play_time 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9fda01e40d6f45ff8a8cd45993ad4607980d8db
-  data.tar.gz: 9873585e4d98abdd9427db9be366bb3927d3b7ba
+  metadata.gz: 52263d955063ada0381b1f92eb4f3eb888e9b09a
+  data.tar.gz: a4a5c66750eeba46e127b1a16813fb3935873559
 SHA512:
-  metadata.gz: 45a538a54f11c912363f9ba6e4fe31be275c99f78aacd5bb61f7821fa58d89594207cdd2c9079b2d37f8904d4481421e1fb4836bb930af157d6f6a8f5468d2d6
-  data.tar.gz: 086f36a90eb5023bfacf2ca3b9f32d5e7960c3543c10ed56744533f764f0cb69d359a0fd14cb7fcef6c642de9118b22c3c8412ec3aac48455e8db236cddefd8e
+  metadata.gz: 416e3bbdbde16698f213f275b444181ca7e5ccbb448bb6f51de1fe026d87acc436da08573ce16df454d001ea2a6bc3ca405e5f4af51f6110f704363cfe28aa73
+  data.tar.gz: c8a5867c0c328306ee31d97a5d2f555e82bc85946d4ba10c3d72e79ebe6046ef13c7e2a125748a49a982af22242a33affd816da19bad15854cd51678b677f736

data/lib/play_time/client.rb

@@ -24,29 +24,33 @@ module PlayTime
 
     private
 
-    attr_reader :edit_id
+    attr_reader :edit_id, :version_code
 
     def create_insert
-      @edit_id = Runner.run!(client, api_method: service.edits.insert, parameters: parameters).data.id
+      @edit_id = run!(api_method: service.edits.insert, parameters: parameters).data.id
     end
 
     def upload_apk
       upload_params = parameters.merge(editId: edit_id, uploadType: 'media')
-      Runner.run! client, api_method: service.edits.apks.upload, parameters: upload_params, media: Apk.load
+      @version_code = run!(api_method: service.edits.apks.upload, parameters: upload_params, media: Apk.load).data.versionCode
     end
 
     def update_track(track)
       update_params = parameters.merge(editId: edit_id, track: track)
-      Runner.run! client, api_method: service.edits.tracks.update, parameters: update_params
+      run! api_method: service.edits.tracks.update, parameters: update_params, body_object: { versionCodes: [version_code] }
     end
 
     def save
       commit_params = parameters.merge(editId: edit_id)
-      Runner.run! client, api_method: service.edits.commit, parameters: commit_params
+      run! api_method: service.edits.commit, parameters: commit_params
+    end
+
+    def run!(options = {})
+      Runner.run! client, options
     end
 
     def parameters
-      {package_name: PlayTime.configuration.package_name}
+      {packageName: PlayTime.configuration.package_name}
     end
 
     def client

data/lib/play_time/configuration.rb

@@ -1,5 +1,7 @@
 module PlayTime
   class Configuration
+    class MissingOption < StandardError; end
+
     DEFAULT_CONFIG = 'config/play_time.yml'.freeze
     OPTIONS = %w(
       apk_path
@@ -17,9 +19,9 @@ module PlayTime
 
     OPTIONS.each do |config_name|
       eval <<-RUBY
-        def #{config_name}         # def config_option
-          config["#{config_name}"] #  config['config_option']
-        end                        # end
+        def #{config_name}
+          config["#{config_name}"] || raise(MissingOption, "Missing #{config_name} in \#{PlayTime.config_path}")
+        end
       RUBY
     end
 

data/lib/play_time/runner.rb

@@ -1,40 +1,17 @@
 module PlayTime
   class Runner
-    class IOError < StandardError; end
     class ResponseError < StandardError; end
 
     class << self
       def run!(client, options = {})
         response = client.execute(options)
 
-        if error?(response)
-          raise error_for(response)
+        if response.data && (error = response.data['error'])
+          raise ResponseError, error
         else
           response
         end
       end
-
-      private
-
-      def has_data?(response)
-        response && response.data 
-      end
-
-      def error?(response)
-        !has_data?(response) || response.data['error']
-      end
-
-      def error_message(response)
-        response.data['error'] if has_data?(response)
-      end
-
-      def error_for(response)
-        if error_message = error_message(response)
-          ResponseError.new(error_message)
-        else
-          IOError
-        end
-      end
     end
   end
 end

data/lib/play_time/version.rb

@@ -1,3 +1,3 @@
 module PlayTime
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/client_spec.rb

@@ -67,7 +67,7 @@ describe PlayTime::Client do
   describe '#commit' do
     let(:track) { 'alpha' }
     let(:service) { double(Google::APIClient::API) }
-    let(:response) { double(:response, data: double(:data, id: 'id')) }
+    let(:response) { double(:response, data: double(:data, id: 'id', versionCode: 'version code')) }
     let(:apk_file) { instance_double(Google::APIClient::UploadIO) }
 
     subject { PlayTime::Client.new.commit(track) }
@@ -94,7 +94,7 @@ describe PlayTime::Client do
       subject
 
       expect(PlayTime::Runner).to have_received(:run!).with(
-        api_client, api_method: 'insert', parameters: { package_name: 'com.package.name' })
+        api_client, api_method: 'insert', parameters: { packageName: 'com.package.name' })
     end
 
     it 'uploads an apk file' do
@@ -103,7 +103,7 @@ describe PlayTime::Client do
       expect(PlayTime::Runner).to have_received(:run!).with(
         api_client,
         api_method: 'upload',
-        parameters: { package_name: 'com.package.name', editId: 'id', uploadType: 'media' },
+        parameters: { packageName: 'com.package.name', editId: 'id', uploadType: 'media' },
         media: apk_file
       )
     end
@@ -114,7 +114,8 @@ describe PlayTime::Client do
       expect(PlayTime::Runner).to have_received(:run!).with(
         api_client,
         api_method: 'track update',
-        parameters: { package_name: 'com.package.name', editId: 'id', track: track }
+        parameters: { packageName: 'com.package.name', editId: 'id', track: track },
+        body_object: { versionCodes: ['version code'] }
       )
     end
 
@@ -124,7 +125,7 @@ describe PlayTime::Client do
       expect(PlayTime::Runner).to have_received(:run!).with(
         api_client,
         api_method: 'commit',
-        parameters: { package_name: 'com.package.name', editId: 'id' }
+        parameters: { packageName: 'com.package.name', editId: 'id' }
       )
     end
   end

data/spec/configuration_spec.rb

@@ -7,6 +7,16 @@ describe PlayTime::Configuration do
     it "fetchings the option from the config" do
       expect(subject).to eq option
     end
+
+    context 'missing options' do
+      let(:configuration) { PlayTime::Configuration.new({'foo' => 'bar'}) }
+
+      it "raises an exception for each missing param" do
+        expect {
+          subject
+        }.to raise_error PlayTime::Configuration::MissingOption, "Missing #{option} in #{PlayTime.config_path}"
+      end
+    end
   end
 
   PlayTime::Configuration::OPTIONS.each do |option|

data/spec/runner_spec.rb

@@ -16,29 +16,17 @@ describe PlayTime::Runner do
       it 'returns a response' do
         expect(subject).to eq response
       end
-    end
-
-    context 'when failure' do
-      context 'when no response' do
-        let(:response) { nil }
-
-        it 'raises an error' do
-          expect {
-            subject
-          }.to raise_error PlayTime::Runner::IOError
-        end
-      end
 
       context 'when data is nil' do
         let(:response) { double(:response, data: nil) }
 
-        it 'raises an error' do
-          expect {
-            subject
-          }.to raise_error PlayTime::Runner::IOError
+        it 'returns the response' do
+          expect(subject).to eq response
         end
       end
+    end
 
+    context 'when failure' do
       context 'when data has an error' do
         let(:response) { double(:response, data: {'error' => 'Something went wrong'}) }
 

data/spec/support/config/default.yml

@@ -1,5 +1,7 @@
 package_name: com.example.app
 secret_path: /path/to/secret/secret.p12
+secret_passphrase: notasecret
 apk_path: /path/to/alpha/app.apk
-client_name: 'Google API Client Name'
-client_version: '1.0.0'
+client_name: Google API Client Name
+client_version: 1.0.0
+issuer: issuer@developer.gserviceaccount.com

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: play_time
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - IS Dev team