plastic 0.2.1 → 0.2.2

data/.gitignore

@@ -1,5 +1,4 @@
 *.gem
-*.gemspec
 *.log
 *.pid
 *.sqlite3

data/README.rdoc

@@ -4,7 +4,7 @@ Credit card “plastic” library for Ruby. Parses track 1, track 2 and individu
 
 == Prerequisites
 
-* Money and a FICA score > 600.
+* Money and a FICO score > 600.
 
 == Testing
 

data/lib/plastic/core.rb

@@ -1,5 +1,5 @@
 class Plastic
-  BRANDS = [:visa, :mastercard, :american_express, :discover]
+  BRANDS = [:visa, :mastercard, :american_express, :discover, :jcb]
 
   attr_accessor :pan, :expiration
   attr_accessor :track_name, :surname, :given_name, :title
@@ -40,12 +40,15 @@ class Plastic
 
   def brand
     case pan
-    when /^4/      then :visa
-    when /^5[1-5]/ then :mastercard
-    when /^677189/ then :mastercard
-    when /^6011/   then :discover
-    when /^65/     then :discover
-    when /^3[47]/  then :american_express
+    when /^4\d{15}$/        then :visa
+    when /^5[1-5]\d{14}$/   then :mastercard
+    when /^677189\d{10}$/   then :mastercard
+    when /^6011\d{12}$/     then :discover
+    when /^64[4-9]\d{13}$/  then :discover
+    when /^65\d{14}$/       then :discover
+    when /^3[47]\d{13}$/    then :american_express
+    when /^352[8-9]\d{12}$/ then :jcb
+    when /^35[3-8]\d{13}$/  then :jcb
     end
   end
 

data/lib/plastic/version.rb

@@ -2,7 +2,7 @@ class Plastic
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 2
-    TINY  = 1
+    TINY  = 2
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/plastic.gemspec

@@ -0,0 +1,62 @@
+# Generated by jeweler
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = %q{plastic}
+  s.version = "0.2.2"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Randy Reddig", "Cameron Walters", "Chris Kampmeier", "Erica Kwan", "Matthew O'Connor", "Damon McCormick", "Brian Jenkins"]
+  s.date = %q{2010-09-01}
+  s.description = %q{Handle credit, debit, bank and other cards.}
+  s.email = %q{github@squareup.com}
+  s.extra_rdoc_files = [
+    "LICENSE.txt",
+     "README.rdoc"
+  ]
+  s.files = [
+    ".gitignore",
+     "HISTORY.rdoc",
+     "LICENSE.txt",
+     "README.rdoc",
+     "Rakefile",
+     "lib/plastic.rb",
+     "lib/plastic/core.rb",
+     "lib/plastic/duck_type.rb",
+     "lib/plastic/track.rb",
+     "lib/plastic/validations.rb",
+     "lib/plastic/version.rb",
+     "plastic.gemspec",
+     "spec/plastic/core_spec.rb",
+     "spec/plastic/duck_type_spec.rb",
+     "spec/plastic/track_spec.rb",
+     "spec/plastic/validations_spec.rb",
+     "spec/spec.opts",
+     "spec/spec_helper.rb"
+  ]
+  s.homepage = %q{http://github.com/square/plastic}
+  s.rdoc_options = ["--charset=UTF-8"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = %q{1.3.7}
+  s.summary = %q{Credit card library for Ruby.}
+  s.test_files = [
+    "spec/plastic/core_spec.rb",
+     "spec/plastic/duck_type_spec.rb",
+     "spec/plastic/track_spec.rb",
+     "spec/plastic/validations_spec.rb",
+     "spec/spec_helper.rb"
+  ]
+
+  if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
+    else
+    end
+  else
+  end
+end
+

data/spec/plastic/core_spec.rb

@@ -155,37 +155,108 @@ describe Plastic do
       Plastic.new(:pan => "4111111111111111").brand.should == :visa
     end
 
+    it "does not recognize pseudo-Visa cards with 13, 14, 15, or 17 digits" do
+      # Visa once used 13-digit PANs, but these accounts have all been migrated
+      # to 16-digit PANs. The old numbers are not valid for new transactions.
+      Plastic.new(:pan => "4111111111111").brand.should_not == :visa
+      Plastic.new(:pan => "41111111111111").brand.should_not == :visa
+      Plastic.new(:pan => "411111111111111").brand.should_not == :visa
+      Plastic.new(:pan => "41111111111111111").brand.should_not == :visa
+    end
+
     it "recognizes MasterCard cards" do
       Plastic.new(:pan => "5100000000000000").brand.should == :mastercard
       Plastic.new(:pan => "5200000000000000").brand.should == :mastercard
       Plastic.new(:pan => "5300000000000000").brand.should == :mastercard
       Plastic.new(:pan => "5400000000000000").brand.should == :mastercard
       Plastic.new(:pan => "5500000000000000").brand.should == :mastercard
-      Plastic.new(:pan => "6771890000000000").brand.should == :mastercard # TODO: confirm that 6771- is really MasterCard
+      # TODO: confirm that 677189- is really MasterCard
+      Plastic.new(:pan => "6771890000000000").brand.should == :mastercard
+    end
+
+    it "does not recognize pseudo-MasterCards with invalid IINs" do
+      Plastic.new(:pan => "5000000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "5600000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "5700000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "5800000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "5900000000000000").brand.should_not == :mastercard
     end
 
-    it "returns nil for bogus pseudo-MasterCard cards" do
-      Plastic.new(:pan => "5000000000000000").brand.should be_nil
-      Plastic.new(:pan => "5600000000000000").brand.should be_nil
-      Plastic.new(:pan => "5700000000000000").brand.should be_nil
-      Plastic.new(:pan => "5800000000000000").brand.should be_nil
-      Plastic.new(:pan => "5900000000000000").brand.should be_nil
+    it "does not recognize pseudo-MasterCards with 15 or 17 digits" do
+      Plastic.new(:pan => "510000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "520000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "53000000000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "54000000000000000").brand.should_not == :mastercard
+      # TODO: confirm that 677189- is really MasterCard
+      Plastic.new(:pan => "677189000000000").brand.should_not == :mastercard
+      Plastic.new(:pan => "67718900000000000").brand.should_not == :mastercard
     end
 
     it "recognizes Discover cards" do
       Plastic.new(:pan => "6011000000000000").brand.should == :discover
+      Plastic.new(:pan => "6440000000000000").brand.should == :discover
+      Plastic.new(:pan => "6450000000000000").brand.should == :discover
+      Plastic.new(:pan => "6460000000000000").brand.should == :discover
+      Plastic.new(:pan => "6470000000000000").brand.should == :discover
+      Plastic.new(:pan => "6480000000000000").brand.should == :discover
+      Plastic.new(:pan => "6490000000000000").brand.should == :discover
       Plastic.new(:pan => "6500000000000000").brand.should == :discover
     end
 
+    it "does not recognize pseudo-Discover cards with 15 digits" do
+      Plastic.new(:pan => "601100000000000").brand.should_not == :discover
+      Plastic.new(:pan => "644000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "645000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "646000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "647000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "648000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "649000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "650000000000000").brand.should_not == :discover
+    end
+
+    it "does not recognize pseudo-Discover cards with 17 digits" do
+      Plastic.new(:pan => "60110000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "64400000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "64500000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "64600000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "64700000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "64800000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "64900000000000000").brand.should_not == :discover
+      Plastic.new(:pan => "65000000000000000").brand.should_not == :discover
+    end
+
     it "recognizes American Express cards" do
       Plastic.new(:pan => "340000000000000").brand.should == :american_express
       Plastic.new(:pan => "370000000000000").brand.should == :american_express
     end
+
+    it "does not recognize pseudo-American Express cards with 14 or 16 digits" do
+      Plastic.new(:pan => "34000000000000").brand.should_not == :american_express
+      Plastic.new(:pan => "37000000000000").brand.should_not == :american_express
+      Plastic.new(:pan => "3400000000000000").brand.should_not == :american_express
+      Plastic.new(:pan => "3700000000000000").brand.should_not == :american_express
+    end
+
+    it "recognizes JCB cards" do
+      Plastic.new(:pan => "3540123456789012").brand.should == :jcb
+      Plastic.new(:pan => "3528000000000000").brand.should == :jcb
+      Plastic.new(:pan => "3589990000000000").brand.should == :jcb
+    end
+
+    it "does not recognize pseudo-JCB cards with 15 or 17 digits" do
+      Plastic.new(:pan => "354012345678901").brand.should_not == :jcb
+      Plastic.new(:pan => "352800000000000").brand.should_not == :jcb
+      Plastic.new(:pan => "358999000000000").brand.should_not == :jcb
+      Plastic.new(:pan => "35401234567890123").brand.should_not == :jcb
+      Plastic.new(:pan => "35280000000000000").brand.should_not == :jcb
+      Plastic.new(:pan => "35899900000000000").brand.should_not == :jcb
+    end
   end
 
   describe "BRANDS constant" do
     it "returns a list of the brands as symbols" do
-      Plastic::BRANDS.should == [:visa, :mastercard, :american_express, :discover]
+      Plastic::BRANDS.should == [:visa, :mastercard, :american_express,
+                                 :discover, :jcb]
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: plastic
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Randy Reddig
@@ -21,7 +21,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-07-18 00:00:00 -07:00
+date: 2010-09-01 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -46,6 +46,7 @@ files:
 - lib/plastic/track.rb
 - lib/plastic/validations.rb
 - lib/plastic/version.rb
+- plastic.gemspec
 - spec/plastic/core_spec.rb
 - spec/plastic/duck_type_spec.rb
 - spec/plastic/track_spec.rb