plaid_rails 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 72d8bf7cf5be435eb044cfbd8c92c163a52be1aa
-  data.tar.gz: e799208fe98d47f8cda6af3d5ae7796715066b27
+  metadata.gz: 61f6da3ef8adaecdfc317658e67984c85e41523b
+  data.tar.gz: 78da897a2aa4f7d77bd1fdb7e5aa7b10e9dabdd6
 SHA512:
-  metadata.gz: 6a8f287bef770e7555d0b5f9bacf1f64298fa6b5a5aaf0215fcc1b8361779d132c0a3b74c3381b2ff65b734b5b0efd7a06418e51d60cfdc187528cdf9107153a
-  data.tar.gz: ca780efbb78ca457855d6faa32e9c406feade50a3e067cc5f79b52af1e93d143c3dfce72f643ff16472debf4841a72cee2582c277f6250e4e70b73861ef4296b
+  metadata.gz: 193ce2a12853307505f295dbfa264baca9e95c8d1a04392e2c89546ed7d55d0173ea409f663bbce241c108a4a86abaa961163e68a120c74123ca03f167b90124
+  data.tar.gz: d4e424a09d944f832db08a3b664021ad25de8de0c690c22629ee3aef064b70ef9b6b752c146cc772f61badcd8b8eae2f7082034dba4e5346a67d8ae8ddf34e47

data/app/assets/javascripts/plaid_rails/link.js

@@ -35,7 +35,8 @@ function getPlaid(plaidData) {
                     name: metadata.institution.name,
                     type: metadata.institution.type,
                     owner_type: plaidData.data('owner-type'),
-                    owner_id: plaidData.data('owner-id')
+                    owner_id: plaidData.data('owner-id'),
+                    number: plaidData.data('number')
                 }
             });
         },

data/app/controllers/plaid_rails/link_controller.rb

@@ -16,27 +16,39 @@ module PlaidRails
       end
     end
     
+    # updates the access token after changing password with institution  
     def update
       begin
         exchange_token = Plaid::User.exchange_token(link_params[:public_token])
-
-        @plaid_accounts =PlaidRails::Account.where(owner_type: link_params[:owner_type],
-        owner_id: link_params[:owner_id])
-        @plaid_accounts.each do |account|
-          account.update(access_token: exchange_token.access_token, 
+        
+        # find old access_token
+        old_access_token = PlaidRails::Account.find_by(owner_type: link_params[:owner_type],
+        owner_id: link_params[:owner_id],number: link_params[:number]).access_token
+        
+        # find all plaid_accounts with old access_token 
+        accounts = PlaidRails::Account.where(owner_type: link_params[:owner_type],
+        owner_id: link_params[:owner_id], access_token: old_access_token)
+      
+        # update found accounts with new token.
+        accounts.update_all(access_token: exchange_token.access_token, 
             transactions_start_date: Date.today)
-        end
+    
+        # get all accounts to display back to user.
+        @plaid_accounts = PlaidRails::Account.where(owner_type: link_params[:owner_type],
+        owner_id: link_params[:owner_id])
+      
         flash[:success]="You have successfully updated your account(s)"
       rescue => e
         Rails.logger.error "Error: #{e}"
-        Rails.logger.error e.backtrace.join("\n")
         render text: e.message, status: 500
       end
     end
+    
     private
     # Never trust parameters from the scary internet, only allow the white list through.
     def link_params
-      params.permit(:access_token, :public_token, :type,:name,:owner_id,:owner_type)
+      params.permit(:access_token, :public_token, :type,:name,:owner_id,
+        :owner_type,:number)
     end
   end
 end

data/app/models/plaid_rails/account.rb

@@ -2,8 +2,8 @@ module PlaidRails
   class Account < ActiveRecord::Base
     belongs_to :owner, polymorphic: true, foreign_key: :owner_id
     
-    before_destroy :delete_connect
-    before_save :delete_connect, if: Proc.new{|a| a.access_token_changed? and !a.new_record?}
+    before_destroy :delete_connect, :unless=> :accounts_with_same_token?
+    before_update :delete_updated_token, :if=> :access_token_changed?
     
     validates :plaid_id, presence: true
     validates :name, presence: true
@@ -13,18 +13,45 @@ module PlaidRails
     private
     
     # delete token from Plaid if there are no more accounts for this token
+    def delete_updated_token
+      # change all matching tokens on update
+      accounts = PlaidRails::Account.where(access_token: my_token)
+      if  accounts.size > 0
+        delete_connect
+      end
+    end
+    
+    # delete Plaid user  
     def delete_connect
-      token = self.access_token
       begin
-        if PlaidRails::Account.where(access_token: token).size == 1
-          user = Plaid::User.load(:connect, token)
-          user.delete
+        Rails.logger.info "Deleting Plaid User with token #{token_last_8}"
+        user = Plaid::User.load(:connect, my_token)
+        # skip delete if there are no transactions
+        if user.transactions.any?
+          user.delete 
+          Rails.logger.info "Deleted Plaid User with token #{token_last_8}"
         end
       rescue  => e
-        message = "Unable to delete token #{token}"
+        message = "Unable to delete user with token #{token_last_8}"
         Rails.logger.error "#{message}: #{e.message}"
-        Rails.logger.error e.backtrace.join("\n")
       end
     end
+      
+    # check if access token changed and use that token 
+    # means the bank password was changed
+    # return token changed token if it was changed
+    def my_token
+      self.access_token_changed? ? self.access_token_was : self.access_token
+    end
+      
+    # hide full token from logs
+    def token_last_8
+      my_token[-8..-1]
+    end
+    
+    # are there more accounts that use the same token
+    def accounts_with_same_token?
+      PlaidRails::Account.where(access_token: my_token).size > 1
+    end
   end
 end

data/app/views/plaid_rails/link/authenticate.js.erb

@@ -1,5 +1,2 @@
 // override this js file with your own in your the own view in 
 // app/views/plaid_rails/link/authenticate.js.erb
-
-console.log('success')
-alert('success')

data/app/views/plaid_rails/link/update.js.erb

@@ -1,5 +1,2 @@
 // override this js file with your own in your the own view in 
 // app/views/plaid_rails/link/authenticate.js.erb
-
-console.log('success')
-alert('success')

data/lib/plaid_rails/version.rb

@@ -1,3 +1,3 @@
 module PlaidRails
-  VERSION = "0.9.0"
+  VERSION = "0.10.0"
 end

data/spec/controllers/plaid_rails/link_controller_spec.rb

@@ -22,7 +22,7 @@ module PlaidRails
     it "update with public token" do
       account = create(:account, transactions_start_date: Date.today - 3)
       xhr :post, :update, public_token: 'test,wells,connected', name:'Wells Fargo', type: 'wells',
-        owner_id: "1", owner_type: "User"
+        owner_id: "1", owner_type: "User", number: 1234
       expect(response).to be_success
       expect(assigns(:plaid_accounts)).to_not be_nil
       expect(assigns(:plaid_accounts).first.transactions_start_date).to eq Date.today