plaid 1.5.2 → 1.5.3

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 368e233ca55b0e688f8d58faaaa9a3316d80d663
-  data.tar.gz: 7034e5662cac8e09fb029719abdbbbcb9ecd1e61
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    MjcyODE1ZDJkZmVhM2EzNDNhNDhmNzU3ZjJhYTkzM2E2NmMzMzY3Nw==
+  data.tar.gz: !binary |-
+    NDdlOWQzNzFhZTFkNmEwYjI1NGFkM2NjZmQ5NDkyOGQxZDYwNzQwNA==
 SHA512:
-  metadata.gz: f22fb8efa56472c28389840bb817d1ad6d6e8180d88f4d960db334404b8f1308b7a39e76f83fc234542e30b03b36ee47d512153ffb25106a88489b359004c306
-  data.tar.gz: 82af4b00d019397e0de3e26feb70797e93eaeff967698571e1b8cd6ffcbf89b18f446fa63f7f598d5240cd283af6a6e844547f43ab6fd8fea09c1dec11fc4b75
+  metadata.gz: !binary |-
+    YjIyODZmMWY4ZmYyMWM0MTc5Yzg5MGVkZThkMzlkZDc3NjEyMzExNmY0NDI1
+    ODE1Y2QwMmExMGY5Yzc1MjNjYzkyYjk5NmZjZjAzMTJhZWM3YWZmYWU1OGIw
+    ZDcwZGMxM2M0YTJkMTNmODMxMjg2ZmFlYjM1MWM5MTBhOWU4YmI=
+  data.tar.gz: !binary |-
+    ZDc3NjExNjFhMGM4NDNkZmY3NGMwMmI4OGI2YjBjOGQ1MGNkYmViYzVkNDE0
+    MjA5Mzc2ZGI0OTQyNDE4NWQwNjVkNzlkMGNhM2E0ZWU3YWFkYjg5MWVlYzdj
+    ZTlhNDM5ZmU1MjFkYTFhYjRlZTZlMThjNzAwMmMyMTZiNTFlNWU=

data/README.md

@@ -6,7 +6,7 @@ Ruby bindings for the Plaid API
 
 This version is a beta version that contains failing tests for the new 'info' endpoint. While these have been tested individually on real accounts the tests here will fail with the test accounts supplied. These will be updated soon with test credentials.
 
-Latest stable version: **1.5.2**
+Latest stable version: **1.5.3**
 
 This version removes the need to use 'type' in each additional call.
 
@@ -71,7 +71,7 @@ user = Plaid.set_user('access_token')
 ```
 
 ```ruby
-user = Plaid.set_user('access_token', 'wells')
+user = Plaid.set_user('access_token', ['connect'])
 ```
 
 ### Exchanging a Link public_token for a Plaid access_token

data/lib/plaid.rb

@@ -1,11 +1,13 @@
 require 'plaid/version'
 require 'plaid/config'
+require 'plaid/errors'
 
 require 'plaid/models/user'
 require 'plaid/models/institution'
 require 'plaid/models/category'
 require 'plaid/models/exchange_token_response'
 
+
 require 'json'
 
 module Plaid

data/lib/plaid/connection.rb

@@ -1,6 +1,7 @@
 require 'net/http'
 require 'json'
 require 'uri'
+
 module Plaid
   class Connection
     class << self
@@ -51,22 +52,6 @@ module Plaid
         Net::HTTP.start(uri.hostname, uri.port, :use_ssl => uri.scheme == 'https') { |http| http.request(req) }
       end
 
-      # API: semi-private
-      # TODO: Refactor these to use symbols instead of strings
-      def error_handler(err, res = nil)
-        case err
-        when 'Bad Request'
-          puts res.body
-          raise 'The request was malformed. Did you check the API docs?'
-        when 'Unauthorized'
-          raise 'Access denied: Try using the correct credentials.'
-        when 'Corrupted token'
-          raise 'It appears that the access token has been corrupted'
-        else
-          raise err
-        end
-      end
-
       protected
 
       # API: semi-private
@@ -82,23 +67,16 @@ module Plaid
         case res.code.delete('.').to_i
         when 200 then body
         when 201 then { msg: 'Requires further authentication', body: body}
-        when 400 then error_handler('Bad Request',res)
+        when 400
+          raise Plaid::BadRequest.new(body['code'], body['message'], body['resolve'])
         when 401
-          case body['code']
-          when 1108 then error_handler('Institution not supported', res)
-          when 1105 then error_handler('Corrupted token', res)
-          when 1106 then error_handler('Corrupted public_token', res)
-          when 1107 then error_handler('Missing public_token', res)
-          when 1501 then error_handler('Not Found', res)
-          else error_handler('Unauthorized',res)
-          end
+          raise Plaid::Unauthorized.new(body['code'], body['message'], body['resolve'])
         when 402
-          return {msg: 'User account is locked', body: body} if body['code'] == 1205
-          error_handler('Request Failed', res)
+          raise Plaid::RequestFailed.new(body['code'], body['message'], body['resolve'])
         when 404
-          error_handler('Not Found',res)
+          raise Plaid::NotFound.new(body['code'], body['message'], body['resolve'])
         else
-          error_handler('Server Error',res)
+          raise Plaid::ServerError.new(body['code'], body['message'], body['resolve'])
         end
       end
 
@@ -110,7 +88,7 @@ module Plaid
         when nil
           body
         when 1301, 1401, 1501, 1601
-          error_handler('Not Found',body)
+          raise Plaid::NotFound.new(body['code'], body['message'], body['resolve'])
         else
           body
         end

data/lib/plaid/errors.rb

@@ -0,0 +1,27 @@
+module Plaid
+  class PlaidError < StandardError
+    attr_reader :code
+    attr_reader :resolve
+    
+    def initialize(code, message, resolve)
+      super(message)
+      @code = code
+      @resolve = resolve
+    end
+  end
+
+  class BadRequest < PlaidError
+  end
+
+  class Unauthorized < PlaidError
+  end
+
+  class RequestFailed < PlaidError
+  end
+
+  class NotFound < PlaidError
+  end
+
+  class ServerError < PlaidError
+  end
+end

data/lib/plaid/version.rb

@@ -1,3 +1,3 @@
 module Plaid
-  VERSION = '1.5.2'
+  VERSION = '1.5.3'
 end

data/plaid.gemspec

@@ -23,5 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~>3.1'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pry-stack_explorer'
+  spec.add_development_dependency 'webmock'
 end
 

data/spec/connection_spec.rb

@@ -0,0 +1,180 @@
+require 'spec_helper'
+
+RSpec.describe Plaid::Connection do
+  
+  let(:stub_url) { "https://tartan.plaid.com/testing" }
+  let(:bad_req_response) {  {"code" => 1005, "message" => "invalid credentials", "resolve" => "The username or password provided is not correct."}.to_json }
+  let(:unauth_response) { {"code" => 1105, "message" => "bad access_token", "resolve" => "This access_token appears to be corrupted."}.to_json }
+  let(:req_fail_response) {  {"code" => 1200, "message" => "invalid credentials", "resolve" => "The username or password provided is not correct."}.to_json }
+  let(:req_not_found) {  {"code" =>  1600, "message" => "product not found", "resolve" => "This product doesn't exist yet, we're actually not sure how you reached this error..."}.to_json }
+
+  describe "#post" do
+    it "should send a post request" do
+      stub = stub_request(:post, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      Plaid::Connection.post("testing")
+      expect(stub).to have_requested(:post, stub_url)
+    end
+
+    it "should return response on 200 response" do
+      stub = stub_request(:post, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      response = Plaid::Connection.post("testing")
+      expect(response).to eq({"response" => "OK"})
+    end
+
+    it "should return message on 201 response" do
+      stub = stub_request(:post, stub_url).to_return(status: 201, body: {"response" => "OK"}.to_json)
+      response = Plaid::Connection.post("testing")
+      expect(response).to eq({:msg => "Requires further authentication", :body => {"response" => "OK"}})
+    end
+
+    it "should throw Plaid::BadRequest on 400 response" do
+      stub = stub_request(:post, stub_url).to_return(status: 400, body: bad_req_response)
+      expect { Plaid::Connection.post("testing") }.to raise_error(Plaid::BadRequest, "invalid credentials")
+    end
+
+    it "should throw Plaid::Unauthorized on 401 response" do 
+      stub = stub_request(:post, stub_url).to_return(status: 401, body: unauth_response)
+      expect { Plaid::Connection.post("testing") }.to raise_error(Plaid::Unauthorized, "bad access_token")
+    end
+
+    it "should throw Plaid::RequestFailed on 402 response" do
+      stub = stub_request(:post, stub_url).to_return(status: 402, body: req_fail_response)
+      expect { Plaid::Connection.post("testing") }.to raise_error(Plaid::RequestFailed, "invalid credentials")
+    end
+
+    it "should throw a Plaid::NotFound on 404 response" do 
+      stub = stub_request(:post, stub_url).to_return(status: 404, body: req_not_found)
+      expect { Plaid::Connection.post("testing") }.to raise_error(Plaid::NotFound, "product not found")
+    end
+  end
+
+  describe "#get" do
+    it "should send a get request" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      Plaid::Connection.get("testing")
+      expect(stub).to have_requested(:get, stub_url)
+    end
+    
+    it "should return response when no code available" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      response = Plaid::Connection.get("testing")
+      expect(response).to eq({"response" => "OK"})
+    end
+    
+    it "should return response when code not [1301, 1401, 1501, 1601]" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"code" => 1502, "response" => "OK"}.to_json})
+      response = Plaid::Connection.get("testing")
+      expect(response).to eq({"code" => 1502, "response" => "OK"})
+    end
+
+    it "should throw 404 for 1301 code" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"code" => 1301, "message" => "Doesn't matter", "resolve" => "Yep."}.to_json})
+      expect { Plaid::Connection.get("testing")}.to raise_error(Plaid::NotFound, "Doesn't matter")
+    end
+    
+    it "should throw 404 for 1401 code" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"code" => 1401, "message" => "Doesn't matter", "resolve" => "Yep."}.to_json})
+      expect { Plaid::Connection.get("testing")}.to raise_error(Plaid::NotFound, "Doesn't matter")
+    end
+    
+    it "should throw 404 for 1501 code" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"code" => 1501, "message" => "Doesn't matter", "resolve" => "Yep."}.to_json})
+      expect { Plaid::Connection.get("testing")}.to raise_error(Plaid::NotFound, "Doesn't matter")
+    end
+    
+    it "should throw 404 for 1601 code" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"code" => 1601, "message" => "Doesn't matter", "resolve" => "Yep."}.to_json})
+      expect { Plaid::Connection.get("testing")}.to raise_error(Plaid::NotFound, "Doesn't matter")
+    end
+
+  end
+
+  describe "#secure_get" do
+    it "should send a secure get request" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      Plaid::Connection.secure_get("testing", "test_wells")
+      expect(stub).to have_requested(:get, stub_url).with(:body => {:access_token => "test_wells"}) 
+    end
+
+    it "should return response on 200 response" do
+      stub = stub_request(:get, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      response = Plaid::Connection.secure_get("testing", "test_wells")
+      expect(response).to eq({"response" => "OK"})
+    end
+
+    it "should return message on 201 response" do
+      stub = stub_request(:get, stub_url).to_return(status: 201, body: {"response" => "OK"}.to_json)
+      response = Plaid::Connection.secure_get("testing", "test_wells")
+      expect(response).to eq({:msg => "Requires further authentication", :body => {"response" => "OK"}})
+    end
+
+    it "should throw Plaid::BadRequest on 400 response" do
+      stub = stub_request(:get, stub_url).to_return(status: 400, body: bad_req_response)
+      expect { Plaid::Connection.secure_get("testing", "test_wells") }.to raise_error(Plaid::BadRequest, "invalid credentials")
+    end
+
+    it "should throw Plaid::Unauthorized on 401 response" do 
+      stub = stub_request(:get, stub_url).to_return(status: 401, body: unauth_response)
+      expect { Plaid::Connection.secure_get("testing", "test_wells") }.to raise_error(Plaid::Unauthorized, "bad access_token")
+    end
+
+    it "should throw Plaid::RequestFailed on 402 response" do
+      stub = stub_request(:get, stub_url).to_return(status: 402, body: req_fail_response)
+      expect { Plaid::Connection.secure_get("testing", "test_wells") }.to raise_error(Plaid::RequestFailed, "invalid credentials")
+    end
+
+    it "should throw a Plaid::NotFound on 404 response" do 
+      stub = stub_request(:get, stub_url).to_return(status: 404, body: req_not_found)
+      expect { Plaid::Connection.secure_get("testing", "test_wells") }.to raise_error(Plaid::NotFound, "product not found")
+    end
+  end
+
+  describe "#patch" do
+    it "should send a patch request" do
+      stub = stub_request(:patch, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      Plaid::Connection.patch("testing")
+      expect(stub).to have_requested(:patch, stub_url)
+    end
+    
+    it "should return response on 200 response" do
+      stub = stub_request(:patch, stub_url).to_return({:body => {"response" => "OK"}.to_json})
+      response = Plaid::Connection.patch("testing")
+      expect(response).to eq({"response" => "OK"})
+    end
+
+    it "should return message on 201 response" do
+      stub = stub_request(:patch, stub_url).to_return(status: 201, body: {"response" => "OK"}.to_json)
+      response = Plaid::Connection.patch("testing")
+      expect(response).to eq({:msg => "Requires further authentication", :body => {"response" => "OK"}})
+    end
+
+    it "should throw Plaid::BadRequest on 400 response" do
+      stub = stub_request(:patch, stub_url).to_return(status: 400, body: bad_req_response)
+      expect { Plaid::Connection.patch("testing") }.to raise_error(Plaid::BadRequest, "invalid credentials")
+    end
+
+    it "should throw Plaid::Unauthorized on 401 response" do 
+      stub = stub_request(:patch, stub_url).to_return(status: 401, body: unauth_response)
+      expect { Plaid::Connection.patch("testing") }.to raise_error(Plaid::Unauthorized, "bad access_token")
+    end
+
+    it "should throw Plaid::RequestFailed on 402 response" do
+      stub = stub_request(:patch, stub_url).to_return(status: 402, body: req_fail_response)
+      expect { Plaid::Connection.patch("testing") }.to raise_error(Plaid::RequestFailed, "invalid credentials")
+    end
+
+    it "should throw a Plaid::NotFound on 404 response" do 
+      stub = stub_request(:patch, stub_url).to_return(status: 404, body: req_not_found)
+      expect { Plaid::Connection.patch("testing") }.to raise_error(Plaid::NotFound, "product not found")
+    end
+  end
+
+  describe "#delete" do
+    it "should send a delete request" do
+      stub = stub_request(:delete, stub_url)
+      Plaid::Connection.delete("testing")
+      expect(stub).to have_requested(:delete, stub_url)
+    end
+  end
+
+end

data/spec/plaid_error_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+RSpec.describe Plaid::PlaidError do
+  describe "#new" do
+    it "should allow code, message and resolution" do
+      error = Plaid::PlaidError.new 1, "testing", "fix it"
+      expect(error.code).to eq(1)
+      expect(error.message).to eq("testing")
+      expect(error.resolve).to eq("fix it")
+    end
+  end
+end

data/spec/plaid_spec.rb

@@ -28,7 +28,13 @@ RSpec.describe Plaid do
 
         context 'when account is locked' do
           let(:password) { 'plaid_locked' }
-          it { expect(user.api_res).to eq 'User account is locked' }
+          it "raises a locked error" do
+            expect { user }.to raise_error { |error|
+              expect(error).to be_a(Plaid::RequestFailed)
+              expect(error.code).to eq(1205)
+            }
+          end
+          
         end
 
         context 'with connection options' do

data/spec/spec_helper.rb

@@ -4,6 +4,9 @@ Bundler.setup
 require 'plaid'
 require 'pry' if ENV['DEBUG']
 
+require 'webmock/rspec'
+WebMock.allow_net_connect!
+
 Plaid.config do |p|
   p.customer_id = 'test_id'
   p.secret = 'test_secret'

metadata

@@ -1,83 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: plaid
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: 1.5.3
 platform: ruby
 authors:
 - Justin Crites
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-19 00:00:00.000000000 Z
+date: 2015-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-stack_explorer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Ruby gem wrapper for the Plaid API. Read more at the homepage, the wiki,
@@ -88,8 +102,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".travis.yml"
+- .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -97,6 +111,7 @@ files:
 - lib/plaid.rb
 - lib/plaid/config.rb
 - lib/plaid/connection.rb
+- lib/plaid/errors.rb
 - lib/plaid/models/account.rb
 - lib/plaid/models/category.rb
 - lib/plaid/models/exchange_token_response.rb
@@ -109,7 +124,9 @@ files:
 - spec/account_spec.rb
 - spec/category_spec.rb
 - spec/config_spec.rb
+- spec/connection_spec.rb
 - spec/institution_spec.rb
+- spec/plaid_error_spec.rb
 - spec/plaid_spec.rb
 - spec/spec_helper.rb
 - spec/transaction_spec.rb
@@ -124,17 +141,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Ruby bindings for Plaid
@@ -142,7 +159,9 @@ test_files:
 - spec/account_spec.rb
 - spec/category_spec.rb
 - spec/config_spec.rb
+- spec/connection_spec.rb
 - spec/institution_spec.rb
+- spec/plaid_error_spec.rb
 - spec/plaid_spec.rb
 - spec/spec_helper.rb
 - spec/transaction_spec.rb