pkwde-has_set 0.0.1 → 0.0.2

data/has_set.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{has_set}
-  s.version = "0.0.1"
+  s.version = "0.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["pkw.de Dev Team"]

data/lib/has_set.rb

@@ -5,7 +5,7 @@ require 'activesupport'
 require 'activerecord'
 
 module HasSet
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
   
   module ClassMethods
     
@@ -18,10 +18,6 @@ module HasSet
       
       set_column = options.has_key?(:column_name) ? options[:column_name].to_s : "#{set_name}_bitfield"
       
-      unless self.columns_hash[set_column.to_s].type == :integer
-        raise ActiveRecord::ActiveRecordError, "The column '#{set_column}' to store the the set must be of type integer, because we store them in a bitfield."
-      end
-      
       begin
         enum_class = options.has_key?(:enum_class) ? options[:enum_class] : Object.const_get(set_name.to_s.camelcase)
       rescue NameError => ne
@@ -32,6 +28,12 @@ module HasSet
         if set_elements.blank?
           self[set_column] = 0
         else
+          if set_elements.kind_of? String
+            set_elements = set_elements.split(",").collect do |element|
+              element.strip!
+              enum_class.const_get(element)
+            end
+          end
           [set_elements].flatten.each do |element|
             unless element.kind_of? enum_class
               raise ArgumentError, "You must provide an element of the #{enum_class} Enumeration. You provided an element of the class #{element.class}."
@@ -68,7 +70,6 @@ module HasSet
           end
         end
       end
-      
     end
   end
 

data/test/has_set_test.rb

@@ -30,7 +30,6 @@ class HasSetTest < Test::Unit::TestCase
   end
   
   def test_should_throw_argument_error_if_there_is_no_enumeratable_class_to_take_the_set_entries_from
-    Person.expects(:columns_hash).returns({"hobbies_bitfield" => stub(:type => :integer)})
     assert_raise(NameError) { Person.has_set :hobbies }
   end
   
@@ -53,15 +52,25 @@ class HasSetTest < Test::Unit::TestCase
     assert !person.interest_dating?, "Person should not be interested in dating."
   end
   
-  def test_should_raise_active_record_error_if_the_type_of_the_bitfiel_column_is_not_integer
-    assert_raise(ActiveRecord::ActiveRecordError) { Punk.has_set :bad_habits }
-  end
-  
   def test_should_get_all_set_elements_of_a_certain_object
     person = Person.new(:fullname => "Jessie Summers", :interests => [Interests::Dating, Interests::Shopping])
     assert_equal [Interests::Dating, Interests::Shopping], person.interests
   end
   
+  def test_should_set_elements_by_string_names
+    person = Person.new(:fullname => "Jessie Summers", :interests => "Dating, Shopping")
+    assert_equal [Interests::Dating, Interests::Shopping], person.interests
+  end
+  
+  def test_should_set_elements_by_string_name
+    person = Person.new(:fullname => "Jessie Summers", :interests => "Dating")
+    assert_equal [Interests::Dating], person.interests
+  end
+  
+  def test_should_raise_exception_if_strings_cannot_be_constantized
+    assert_raise(NameError) { Person.new(:fullname => "Jessie Summers", :interests => "Dadding, Shopping") }
+  end
+  
   def test_should_provide_the_name_of_the_bitfield_column
     party = Party.new(:location => "Beach House", :drinks => [Drinks::Beer, Drinks::CubaLibre])
     assert party.save, "Party should save!"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: pkwde-has_set
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - pkw.de Dev Team