pki_express 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96112f72042a8deaa33c44615735b0cf1583cbf8ff3d9f2063a9c34fae618de6
-  data.tar.gz: 7f154465e01e5159bce9ab4ff6548fcf74564fdb7cc8b57dec8e88958966e1aa
+  metadata.gz: f3fe73f3d18d1dc566b80140f294c5028e0e60787dcb5c56e4112af8f0128e5c
+  data.tar.gz: c5f73243393de32161c70d0ac4933db9b6261cb37e89a2e3e7702c45500240f6
 SHA512:
-  metadata.gz: 80afd152f8767046e2a6a0314a3d05ca4d94039be98a19d14e2b56d8dc2bbdae8ed6485e4fede075a59311a33635665766a64539f423c4023e64bbf6db6da5fa
-  data.tar.gz: 5b4fdc45bea0e0b534b46f291121702d0bca002ed579eb01c10c8836def784ed086f499d9a74c2939c34ab20fe9e134536b0e39359afb26cfd630fcce52c555f
+  metadata.gz: 8ceaea14d93ffbda8c76725e7d178e4530a90d928fb2d6ffdbfb5308534f07793ecc0bd40de485d7fd5415a9f3e2812cf2c70c4c4bb277c6831590cb9fd5616d
+  data.tar.gz: 382bc00219a77605c809fcd3499cca7e1e238faff2896d4ec219533241efc228af99f4697695b309859b519badeff5cdf423751d2ee9b7ce5b473cb949a1c88a

data/.github/workflows/test.yml

@@ -0,0 +1,22 @@
+name: Ruby
+
+on: push
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    
+    strategy:
+      matrix:
+        ruby-version: ['3.1', '2.7']
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+      - name: Install dependencies
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake spec

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.3.1 (2023-03-30)
+* Fix pki express operator finalizer
+* Improve pathname call with exists
+
 ## 1.3.0 (2021-08-04)
 * Adds culture and time zone attributes to PkiExpressOperator
 

data/Gemfile

@@ -1,4 +1,8 @@
 source 'https://rubygems.org'
 
 # Specify the gem's dependencies in pki_express.gemspec
-gemspec
+gemspec
+
+group :development, :test do
+    gem 'rspec'
+end

data/README.md

@@ -7,7 +7,7 @@ This library contains classes that encapsulate the calls to PKI Express.
 The recommended way to install **PKI Expresss lib** is through setting in your Gemfile:
 
 ````ruby
-gem 'pki_express', '~> 1.3.0'
+gem 'pki_express', '~> 1.3.1'
 ````
 
 And with installing via [Bundler](http://bundler.io/) on your project root folder:

data/Rakefile

@@ -1 +1,7 @@
-require 'bundler/gem_tasks'
+require 'rake'
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec) do |t|
+    t.pattern = Dir.glob('spec/**/*_spec.rb')
+end

data/lib/pki_express/pki_express_config.rb

@@ -5,7 +5,7 @@ module PkiExpress
     @@single_temp_folder = nil
 
     def initialize(pki_express_home = nil, temp_folder = nil, transfer_data_folder = nil)
-      if not temp_folder.nil? and Pathname.exist?(temp_folder)
+      if not temp_folder.nil? and Pathname.new(temp_folder).exist?
         @temp_folder = temp_folder
       else
         if @@single_temp_folder.nil?
@@ -14,7 +14,7 @@ module PkiExpress
         @temp_folder = @@single_temp_folder
       end
 
-      if not transfer_data_folder.nil? and Pathname.exist?(transfer_data_folder)
+      if not transfer_data_folder.nil? and Pathname.new(transfer_data_folder).exist?
         @transfer_data_folder = transfer_data_folder
       else
         @transfer_data_folder = @temp_folder
@@ -23,4 +23,4 @@ module PkiExpress
       @pki_express_home = pki_express_home
     end
   end
-end
+end

data/lib/pki_express/pki_express_operator.rb

@@ -1,5 +1,8 @@
 require 'shellwords'
+require 'securerandom'
 require 'open3'
+require 'tmpdir'
+require 'tempfile'
 
 module PkiExpress
 
@@ -21,11 +24,14 @@ module PkiExpress
       @culture = nil
       @time_zone = nil
 
-      ObjectSpace.define_finalizer(self, self.class.method(:finalize))
+      @id = SecureRandom.uuid
+      ObjectSpace.define_finalizer(@id, proc {
+        self.class.finalize(@temp_files)
+      })
     end
 
-    def self.finalize
-      @temp_files.each do |file|
+    def self.finalize(temp_files)
+      temp_files.each do |file|
         File.delete(file) if File.exist?(file)
       end
     end

data/lib/pki_express/version.rb

@@ -1,3 +1,3 @@
 module PkiExpress
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/pki_express.gemspec

@@ -22,6 +22,6 @@ Gem::Specification.new do |spec|
       'source_code_uri'   => 'https://github.com/LacunaSoftware/PkiExpressRuby'
   }
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'bundler', '~> 2.3'
   spec.add_development_dependency 'rake', '~> 13'
 end

data/spec/pki_express/pki_express_operator_spec.rb

@@ -0,0 +1,31 @@
+require_relative '../spec_helper'
+
+module PkiExpress
+    describe PkiExpressOperator do
+        it "should remove files created by child classes when GC remove its instance" do
+            operator = ChildOperator.new
+            temp_files = []
+            (1..3).each { 
+                created_file = operator.create_temp_file
+                temp_files.append(created_file)
+                expect(File.exist?(created_file)).to equal(true)
+            }
+            operator = nil
+            GC.start
+
+            temp_files.each do |file|
+                expect(File.exist?(file)).to equal(false)
+            end
+        end
+    end
+    
+    class ChildOperator < PkiExpressOperator
+        def initialize(config=PkiExpressConfig.new)
+            super(config)
+        end
+
+        def create_temp_file
+            super
+        end
+    end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,13 @@
+require_relative '../lib/pki_express'
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pki_express
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Ismael Medeiros
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-04 00:00:00.000000000 Z
+date: 2023-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -46,7 +46,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitattributes"
+- ".github/workflows/test.yml"
 - ".gitignore"
+- ".rspec"
 - CHANGELOG.md
 - Gemfile
 - README.md
@@ -120,6 +122,8 @@ files:
 - lib/pki_express/version.rb
 - lib/pki_express/version_manager.rb
 - pki_express.gemspec
+- spec/pki_express/pki_express_operator_spec.rb
+- spec/spec_helper.rb
 homepage: http://docs.lacunasoftware.com/en-us/articles/pki-express
 licenses:
 - MIT
@@ -128,7 +132,7 @@ metadata:
   changelog_uri: https://github.com/LacunaSoftware/PkiExpressRuby/blob/develop/CHANGELOG.md
   documentation_uri: http://docs.lacunasoftware.com/en-us/articles/pki-express
   source_code_uri: https://github.com/LacunaSoftware/PkiExpressRuby
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -143,8 +147,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.10
+signing_key:
 specification_version: 4
 summary: Gem for using PKI Express on Ruby
-test_files: []
+test_files:
+- spec/pki_express/pki_express_operator_spec.rb
+- spec/spec_helper.rb