pjdavis-roart 0.1.2 → 0.1.3

data/History.txt

@@ -1,3 +1,6 @@
+==0.1.3 / 2009-08-18
+Can now update tickets with #save. Returns true if saved, raises an error if not.
+
 ==0.1.2 / 2009-08-18
 Added Create ticket functionality. Ticket.new will create a ticket in the RT system and return that ticket.
 

data/lib/roart/core/hash.rb

@@ -1,6 +1,14 @@
 class Hash
   def to_content_format
-    fields = self.map { |key,value| "#{key.to_s.camelize}: #{value}" unless value.nil? }
+    fields = self.map do |key,value| 
+      unless value.nil?
+        if key.to_s.match(/^cf_.+/)
+          "CF-#{key.to_s[3..key.to_s.length].camelize.humanize}: #{value}"
+        else
+          "#{key.to_s.camelize}: #{value}"
+        end
+      end
+    end
     content = fields.compact.join("\n")
   end
   

data/lib/roart/core/string.rb

@@ -15,4 +15,7 @@ class String
     self.gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase }
   end
   
+  def humanize
+    self.gsub(/_id$/, "").gsub(/_/, " ").capitalize
+  end
 end

data/lib/roart/roart.rb

@@ -14,7 +14,10 @@ module Roart
     def add_methods!
       @attributes.each do |key, value|
         (class << self; self; end).send :define_method, key do
-          return value
+          return @attributes[key]
+        end
+        (class << self; self; end).send :define_method, "#{key}=" do |new_val|
+          @attributes[key] = new_val
         end
       end 
     end

data/lib/roart/ticket.rb

@@ -2,7 +2,7 @@ module Roart
   
   module Tickets
     
-    DefaultAttributes = %w(queue owner creator subject status priority initial_priority final_priority requestors cc admin_cc created starts started due resolved told last_updated time_estimated time_worked time_left full logs)
+    DefaultAttributes = %w(queue owner creator subject status priority initial_priority final_priority requestors cc admin_cc created starts started due resolved told last_updated time_estimated time_worked time_left)
     RequiredAttributes = %w(queue subject)
   
   end
@@ -11,6 +11,8 @@ module Roart
     
     include Roart::MethodFunctions
     
+    attr_reader :full, :history
+    
     # Creates a new ticket. Attributes queue and subject are required. Expects a hash with the attributes of the ticket.
     #
     #   ticket = MyTicket.new(:queue => "Some Queue", :subject => "The System is Down.")
@@ -25,6 +27,7 @@ module Roart
       else
         raise ArgumentError, "Expects a hash."
       end
+      @history = false
       add_methods!
     end
     
@@ -47,6 +50,21 @@ module Roart
       @histories ||= Roart::History.default(:ticket => self)
     end
     
+    def save
+      uri = "#{self.class.connection.server}/REST/1.0/ticket/#{self.id}/edit"
+      payload = @attributes.clone
+      payload.delete(:id)
+      payload = payload.to_content_format
+      resp = self.class.connection.post(uri, :content => payload)
+      resp = resp.split("\n")
+      raise "Ticket Update Failed" unless resp.first.include?("200")
+      if resp[2].match(/^# Ticket (\d+) updated./)
+        return true
+      else
+        raise "Ticket Create Failed"
+      end
+    end
+    
     protected
       
       def create
@@ -140,6 +158,7 @@ module Roart
           object.instance_variable_set("@attributes", attrs)
           object.send("add_methods!")
         end
+        object.instance_variable_set("@history", false)
         object
       end
       
@@ -181,8 +200,9 @@ module Roart
         page = page_array(uri)
         page.extend(Roart::TicketPage)
         page = page.to_hash
-        page.update(:full => true)
-        self.instantiate(page)
+        ticket = self.instantiate(page)
+        ticket.instance_variable_set("@full", true)
+        ticket
       end
       
       def get_ticket_by_id(id) #:nodoc:

data/lib/roart/ticket_page.rb

@@ -9,12 +9,16 @@ module Roart
       self.delete_if{|x| !x.include?(":")}
       self.each do |ln|
         ln = ln.split(":")
-        key = ln.delete_at(0).strip.underscore
-        value = ln.join(":").strip
-        hash[key.to_sym] = value
+        if ln[0] && ln[0].match(/^CF-.+/)
+          key = ln.delete_at(0)
+          key = "cf_" + key[3..key.length].gsub(/ /, "_")
+        else
+          key = ln.delete_at(0).strip.underscore
+          value = ln.join(":").strip
+          hash[key.to_sym] = value
+        end
       end
       hash[:id] = hash[:id].split("/").last.to_i
-      hash.update(:history => false)
       hash
     end
     

data/lib/roart.rb

@@ -2,7 +2,7 @@ require 'rubygems'
 module Roart
 
   # :stopdoc:
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
   LIBPATH = ::File.expand_path(::File.dirname(__FILE__)) + ::File::SEPARATOR
   PATH = ::File.dirname(LIBPATH) + ::File::SEPARATOR
   # :startdoc:

data/spec/roart/core/hash_spec.rb

@@ -8,4 +8,9 @@ describe 'hash extentions' do
     payload.to_content_format.include?("Queue: My Queue").should be_true
   end
   
+  it 'should handel custom fields' do
+    payload = {:cf_stuff => 'field'}
+    payload.to_content_format.should == "CF-Stuff: field"
+  end
+  
 end

data/spec/roart/ticket_page_spec.rb

@@ -12,13 +12,6 @@ describe 'ticket page' do
       hash[:id].should == 10
       hash[:subject].should == 'asdf'
     end
-    
-    it 'should not have a history' do
-      array = ["id : 10", "subject : asdf"]
-      array.extend(Roart::TicketPage)
-      hash = array.to_hash
-      hash[:history].should be_false
-    end
   
   end
   
@@ -39,11 +32,6 @@ describe 'ticket page' do
       @array.last[:id].should == 234
     end
     
-    it 'should keep history false' do
-      @array.first[:history].should be_false
-      @array.last[:history].should be_false
-    end
-    
   end
   
   describe 'ticket history hash' do

data/spec/roart/ticket_spec.rb

@@ -284,6 +284,13 @@ describe "Ticket" do
   
   describe 'ticket methods' do
     
+    
+    it 'should change the ticket' do
+      ticket = Roart::Ticket.send(:instantiate,{:subject => 'A New Ticket', :queue => 'My Queue', :id => 1})
+      ticket.subject = 'An Old Ticket'
+      ticket.subject.should == 'An Old Ticket'
+    end
+    
     it 'should be able to load the full ticket' do
       search_array = ['1:subject']
       search_array.extend(Roart::TicketPage)
@@ -303,26 +310,73 @@ describe "Ticket" do
       fields.compact.join("\n")
     end
     
-    before do 
-      post_data = @payload = {:subject => 'A New Ticket', :queue => 'My Queue'}
-      post_data.update(:id => 'ticket/new')
-      post_data = to_content_format(post_data)
-      mock_connection = mock('connection')
-      mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/new', {:content => post_data}).and_return("RT/3.6.6 200 Ok\n\n# Ticket 267783 created.")
-      mock_connection.should_receive(:server).and_return('uri')
-      Roart::Ticket.should_receive(:connection).twice.and_return(mock_connection)
-    end
+    describe 'creating tickets' do
     
-    it 'should be able to create a ticket' do
-      ticket = Roart::Ticket.new(@payload)
-    end
+      before do 
+        post_data = @payload = {:subject => 'A New Ticket', :queue => 'My Queue'}
+        post_data.update(:id => 'ticket/new')
+        post_data = to_content_format(post_data)
+        mock_connection = mock('connection')
+        mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/new', {:content => post_data}).and_return("RT/3.6.6 200 Ok\n\n# Ticket 267783 created.")
+        mock_connection.should_receive(:server).and_return('uri')
+        Roart::Ticket.should_receive(:connection).twice.and_return(mock_connection)
+      end
+    
+      it 'should be able to create a ticket' do
+        ticket = Roart::Ticket.new(@payload)
+      end
+    
+      it 'should return a newly created ticket' do
+        ticket = Roart::Ticket.new(@payload)
+        ticket.class.should == Roart::Ticket
+        ticket.id.should == 267783
+      end
     
-    it 'should return a newly created ticket' do
-      ticket = Roart::Ticket.new(@payload)
-      ticket.class.should == Roart::Ticket
-      ticket.id.should == 267783
     end
     
+    describe 'updating tickets' do
+    
+      before do 
+        @post_data = @payload = {:subject => 'A New Ticket', :queue => 'My Queue'}
+        @post_data[:subject] = 'An Old Ticket'
+        @post_data = to_content_format(@post_data)
+        @mock_connection = mock('connection')
+        @mock_connection.should_receive(:server).and_return('uri')
+        Roart::Ticket.should_receive(:connection).twice.and_return(@mock_connection)
+      end
+      
+      it 'should be able to update a ticket' do
+      @mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/1/edit', {:content => @post_data}).and_return("RT/3.6.6 200 Ok\n\n# Ticket 267783 updated.")
+        ticket = Roart::Ticket.send(:instantiate, @payload.update(:id => 1))
+        ticket.subject = 'An Old Ticket'
+        ticket.save.should == true
+      end
+
+      it 'should keep the same id' do
+      @mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/1/edit', {:content => @post_data}).and_return("RT/3.6.6 200 Ok\n\n# Ticket 267783 updated.")
+        ticket = Roart::Ticket.send(:instantiate, @payload.update(:id => 1))
+        ticket.subject = 'An Old Ticket'
+        ticket.save
+        ticket.id.should == 1
+      end
+      
+      it 'should save the ticket' do
+      @mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/1/edit', {:content => @post_data}).and_return("RT/3.6.6 200 Ok\n\n# Ticket 267783 updated.")
+        ticket = Roart::Ticket.send(:instantiate, @payload.update(:id => 1))
+        ticket.subject = 'An Old Ticket'
+        ticket.save
+        ticket.subject.should == 'An Old Ticket'
+      end
+
+      it 'should raise an error on failed save' do
+        @mock_connection.should_receive(:post).with('uri/REST/1.0/ticket/1/edit', {:content => @post_data}).and_return("RT/3.6.6 400 Not OK\n\n# U's A SUKKA, FOO!.")
+        ticket = Roart::Ticket.send(:instantiate, @payload.update(:id => 1))
+        ticket.subject = 'An Old Ticket'
+        lambda {ticket.save}.should raise_error
+      end
+      
+    end
+  
   end
   
   describe 'histories' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: pjdavis-roart
 version: !ruby/object:Gem::Version 
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - PJ Davis
@@ -57,7 +57,6 @@ files:
 - lib/roart/roart.rb
 - lib/roart/ticket.rb
 - lib/roart/ticket_page.rb
-- roart.gemspec
 - spec/roart/connection_spec.rb
 - spec/roart/core/array_spec.rb
 - spec/roart/core/hash_spec.rb
@@ -70,7 +69,6 @@ files:
 - spec/spec_helper.rb
 - spec/test_data/full_history.txt
 - spec/test_data/single_history.txt
-- test/test_roart.rb
 has_rdoc: true
 homepage: http://github.com/pjdavis/roart
 licenses: 
@@ -99,5 +97,5 @@ rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Interface for working with Request Tracker (RT) tickets inspired by ActiveRecord
-test_files: 
-- test/test_roart.rb
+test_files: []
+

data/roart.gemspec

@@ -1,38 +0,0 @@
-# -*- encoding: utf-8 -*-
-
-Gem::Specification.new do |s|
-  s.name = %q{roart}
-  s.version = "0.1.2"
-
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["PJ Davis"]
-  s.date = %q{2009-08-18}
-  s.description = %q{Interface for working with Request Tracker (RT) tickets inspired by ActiveRecord.}
-  s.email = %q{pj.davis@gmail.com}
-  s.extra_rdoc_files = ["History.txt", "README.rdoc", "spec/test_data/full_history.txt", "spec/test_data/single_history.txt"]
-  s.files = ["History.txt", "README.rdoc", "Rakefile", "lib/roart.rb", "lib/roart/connection.rb", "lib/roart/core/array.rb", "lib/roart/core/hash.rb", "lib/roart/core/string.rb", "lib/roart/errors.rb", "lib/roart/history.rb", "lib/roart/roart.rb", "lib/roart/ticket.rb", "lib/roart/ticket_page.rb", "roart.gemspec", "spec/roart/connection_spec.rb", "spec/roart/core/array_spec.rb", "spec/roart/core/hash_spec.rb", "spec/roart/core/string_spec.rb", "spec/roart/history_spec.rb", "spec/roart/roart_spec.rb", "spec/roart/ticket_page_spec.rb", "spec/roart/ticket_spec.rb", "spec/roart_spec.rb", "spec/spec_helper.rb", "spec/test_data/full_history.txt", "spec/test_data/single_history.txt", "test/test_roart.rb"]
-  s.has_rdoc = true
-  s.homepage = %q{http://github.com/pjdavis/roart}
-  s.rdoc_options = ["--main", "README.rdoc"]
-  s.require_paths = ["lib"]
-  s.rubyforge_project = %q{roart}
-  s.rubygems_version = %q{1.3.2}
-  s.summary = %q{Interface for working with Request Tracker (RT) tickets inspired by ActiveRecord}
-  s.test_files = ["test/test_roart.rb"]
-
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
-
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<mechanize>, [">= 0.9.0"])
-      s.add_development_dependency(%q<bones>, [">= 2.5.1"])
-    else
-      s.add_dependency(%q<mechanize>, [">= 0.9.0"])
-      s.add_dependency(%q<bones>, [">= 2.5.1"])
-    end
-  else
-    s.add_dependency(%q<mechanize>, [">= 0.9.0"])
-    s.add_dependency(%q<bones>, [">= 2.5.1"])
-  end
-end