pippi 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd4bb5e3d9e8a7c1b97def8b8c81a3ebc1bcf6b1
-  data.tar.gz: ba99f8da56b5dcdb9a73989b377e76e9b1f006c0
+  metadata.gz: 0c609506ea54efa1618cc91626c3a1b0d13619ce
+  data.tar.gz: 815ea5e17c5562c9eee9c8cffe7025c759036995
 SHA512:
-  metadata.gz: 5f59f05b8883eae2a0781097494d5a73cb25a25c673d593de4d011605012642763473c7ea7b6b95c592bcfde0d889bd171b7e2da3a78d4de120a82a685bb772e
-  data.tar.gz: e85313fc90ffaddc56a566e6a2016cd85e22ce5f8c506474c3e22cde50b8f0fc2a254b139e9df66a93b9285599a005a1f04107fdae418fd10dedc9a65aff4d30
+  metadata.gz: db93b8205fcfd68ebce496b74701165719364b90d5ffe9f06609e7a1bec19a4fdc5a14766d01dbf8a0138cd42d6a9ec9b2cd69377f15ca5e3cb4c6ea0af7f2fc
+  data.tar.gz: 2cb1d62ca2e910bb583b0cffa1bf67531b4b5bf6393133b93776b3e72787293fd3793b28adff09aff965e4464523c94365c61cb513c70ad0021124e6323ce6c6

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.0.9 (2014-12-04)
+
+* [FIXED] False positives reduced
+
 ## 0.0.8 (2014-12-04)
 
  * [NEW] Added SelectFollowedByAny

data/README.md

@@ -346,7 +346,7 @@ rm -rf pippi_debug.log pippi.log .bundle/gems/pippi-0.0.1/ .bundle/cache/pippi-0
 * Tie off Changelog notes
 * Regenerate docs with `pippi:generate_docs`, copy and paste that into README
 * Commit, push
-* Tag the release
+* Tag the release (e.g., `git tag -a v0.0.8 -m 'v0.0.8' && git push origin v0.0.8`)
 * `bundle exec gem build pippi.gemspec`
 * `gem push pippi-x.gem`
 * Update pippi_demo

data/lib/pippi/problem.rb

@@ -19,5 +19,9 @@ module Pippi
       check_class == other.check_class &&
       line_number == other.line_number
     end
+
+    def to_s
+      "#{file_path},#{check_class.name.split('::').last},#{line_number}"
+    end
   end
 end

data/lib/pippi/report.rb

@@ -1,16 +1,18 @@
 module Pippi
   class Report
-    attr_reader :problems
+    attr_reader :problems, :removed
 
     def initialize
       @problems = []
+      @removed = Set.new
     end
 
     def add(problem)
-      @problems << problem unless duplicate_report?(problem)
+      @problems << problem unless duplicate_report?(problem) || already_removed?(problem)
     end
 
     def remove(lineno, path, clazz)
+      @removed << Pippi::Problem.new(:line_number => lineno, :file_path => path, :check_class => clazz).to_s
       @problems.reject! { |p| p.line_number == lineno && p.file_path == path && p.check_class == clazz }
     end
 
@@ -19,5 +21,10 @@ module Pippi
     def duplicate_report?(candidate)
       !problems.find { |existing| existing.eql?(candidate) }.nil?
     end
+
+    def already_removed?(problem)
+      removed.include?(problem.to_s)
+    end
+
   end
 end

data/lib/pippi/version.rb

@@ -1,3 +1,3 @@
 module Pippi
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pippi
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-04 00:00:00.000000000 Z
+date: 2014-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake