pippi 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5a74d95bf3f5630ef99c31014f3bfcc83043cab
-  data.tar.gz: d3225b55129c7c327fa963cec71a281c17f275c3
+  metadata.gz: 9f1712f4957c4dc681c64b2031b42668a1965c26
+  data.tar.gz: 2e7795a1a90750cb9838dcfa37e6a83a5ea9d5d3
 SHA512:
-  metadata.gz: 367327d170a40465f8df9ff8bd41efb8c673068898dce752958557cf3cdc0c28f14f3fb8f4b0c8d2efe71ac18f321010f7f6814e679c4739010297daa7ab6fe1
-  data.tar.gz: a2900f8d02ca4d99aed0f5180ba87489da2d9ca260434b7bd582d019eed30ec8f502f2c8c142a78f83d06da596d603057fc68425d768cd83530662cc442cd4e0
+  metadata.gz: d8c0198da71b5bc8ae6ce92d432374c74f97249394bfbe75c13862137d47d5864f0c8f7b43ed66084756a4677ac73f0c7dcd660df343455690330eeb5a52b5c1
+  data.tar.gz: 399fd31a5f4cb6938f2368b586902cfe7ded570ec00975d13c76eacdf90f2400a19c5f1d9afabc1efec1f6c1aa49b798a0cfa94bb874b2ded25d6e044325ab69

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+Oct 22, 2014 - 0.0.3:
+Moved AssertWithNil to "buggy" checkset until I can figure out issues.
+
 Oct 22, 2014 - 0.0.2:
 Added AssertWithNil
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pippi (0.0.2)
+    pippi (0.0.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -2,6 +2,23 @@ Pippi is a utility for finding suboptimal Ruby class API usage.
 
 <a href="http://thomasleecopeland.com/2014/10/22/finding-suboptimal-api-usage.html">Here's a project overview</a>.
 
+## Checksets
+
+Pippi has the concept of "checksets" which are, well, sets of checks.  The current checksets are listed below.
+
+Maybe we should have a dedicated "test" checkset?  Let me know what you think at https://twitter.com/tcopeland, thanks!
+
+### Basic
+
+* SelectFollowedByFirst
+* SelectFollowedBySize
+* ReverseFollowedByEach
+
+### Buggy
+
+* AssertWithNil
+* MapFollowedByFlatten
+
 ## Checks
 
 ### AssertWithNil

data/lib/pippi/check_set_mapper.rb

@@ -22,11 +22,11 @@ module Pippi
           "SelectFollowedByFirst",
           "SelectFollowedBySize",
           "ReverseFollowedByEach",
-          "AssertWithNil"
         ],
         "training" => [
         ],
         "buggy" => [
+          "AssertWithNil",
           "MapFollowedByFlatten",
         ]
       }

data/lib/pippi/version.rb

@@ -1,3 +1,3 @@
 module Pippi
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/test/unit/assert_with_nil_test.rb

@@ -10,6 +10,26 @@ class AssertWithNilTest < CheckTest
     assert_no_problems "x = 42 ; assert_equal(42, x)", :include_rails_core_extensions => true, :subclass => "ActiveSupport::TestCase"
   end
 
+  # Seems like there's some way to do this, but maybe not... anyhow, moving this rule to "buggy" for now
+  # pippi> $ echo "foo(nil)" | ruby --dump insns
+  # == disasm: <RubyVM::InstructionSequence:<main>@->=======================
+  # 0000 trace            1                                               (   1)
+  # 0002 putself
+  # 0003 putnil
+  # 0004 opt_send_simple  <callinfo!mid:foo, argc:1, FCALL|ARGS_SKIP>
+  # 0006 leave
+  # pippi> $ echo "foo(x)" | ruby --dump insns
+  # == disasm: <RubyVM::InstructionSequence:<main>@->=======================
+  # 0000 trace            1                                               (   1)
+  # 0002 putself
+  # 0003 putself
+  # 0004 opt_send_simple  <callinfo!mid:x, argc:0, FCALL|VCALL|ARGS_SKIP>
+  # 0006 opt_send_simple  <callinfo!mid:foo, argc:1, FCALL|ARGS_SKIP>
+  # 0008 leave
+  def test_nil_reference_first_arg_doesnt_flag
+    assert_no_problems "x = 42 ; y = nil ; assert_equal(nil, x)", :include_rails_core_extensions => true, :subclass => "ActiveSupport::TestCase"
+  end
+
   def test_three_arg_is_flagged
     assert_problems "x = 42 ; assert_equal(nil, x, 'whatevs')", :include_rails_core_extensions => true, :subclass => "ActiveSupport::TestCase"
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pippi
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-22 00:00:00.000000000 Z
+date: 2014-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake