pipejump 0.4.1 → 0.4.2

data/lib/pipejump/base/resource.rb

@@ -93,7 +93,7 @@ module Pipejump
 
     end
 
-    attr_accessor :attributes
+    attr_accessor :attributes, :errors
     # Constructor for the Resource
     def initialize(attrs)
       @session = attrs.delete(:session)
@@ -132,7 +132,7 @@ module Pipejump
 
     def save
       before_save if respond_to?(:before_save)
-      @errors = {}
+      return false unless valid?
       code, data = id ? update : create # @session.post('/' + self.class.collection_path.to_s + '.json', to_query)
       if data['errors']
         @errors = data['errors']
@@ -143,6 +143,16 @@ module Pipejump
       end
     end
 
+    def validate
+      true
+    end
+
+    def valid?
+      @errors = {}
+      validate
+      @errors.none?
+    end
+
     def inspect
       "#<#{self.class} #{@attributes.collect { |pair| pair[1] = pair[1].inspect; pair.join(': ') }.join(', ')}>"
     end

data/lib/pipejump/resources/contact.rb

@@ -246,6 +246,13 @@ module Pipejump
       @attributes
     end
 
+    def validate
+      if @attributes['name'].to_s.empty? and
+         @attributes['last_name'].to_s.empty?
+        @errors['name'] = "is missing"
+      end
+    end
+
   end
 
 end

data/lib/pipejump/version.rb

@@ -1,3 +1,3 @@
 module Pipejump
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/pipejump/resources/contact_spec.rb

@@ -17,6 +17,7 @@ describe Pipejump::Contact do
     @contact2.destroy
   end
 
+
   describe '@session.contacts' do
 
     it ".all should return all contacts" do
@@ -98,17 +99,4 @@ describe Pipejump::Contact do
 
   end
 
-  describe "#custom_fields" do
-
-    it "returns a hash of custom fields" do
-      @contact1.name = 'AAA TESTING ONE'
-      @contact1.custom_fields['test_field'] = 'yaaay'
-      @contact1.save
-
-      puts @contact1.inspect
-
-      @session.contacts.find(@contact1.id).custom_fields['test_field']['value'].should =='yaaay'
-    end
-  end
-
 end

data/spec/pipejump/resources/contact_validation_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe Pipejump::Contact do
+
+  describe "validation" do
+
+    it "does not save when not valid" do
+      @contact = Pipejump::Contact.new(:name => '')
+      @contact.save.should be_false
+    end
+
+    it "is not valid when name is not set" do
+      @contact = Pipejump::Contact.new(:name => 'foo')
+      @contact.valid?.should be_true
+      @contact.name = ''
+      @contact.valid?.should be_false
+    end
+
+    it "is not valid when last_name is not set" do
+      @contact = Pipejump::Contact.new(:last_name => 'foo')
+      @contact.valid?.should be_true
+      @contact.last_name = ''
+      @contact.valid?.should be_false
+    end
+
+  end
+
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pipejump
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -48,6 +48,7 @@ files:
 - spec/pipejump/resources/contact/reminder_spec.rb
 - spec/pipejump/resources/contact_custom_fields_spec.rb
 - spec/pipejump/resources/contact_spec.rb
+- spec/pipejump/resources/contact_validation_spec.rb
 - spec/pipejump/resources/deal/note_spec.rb
 - spec/pipejump/resources/deal/reminder_spec.rb
 - spec/pipejump/resources/deal_spec.rb
@@ -85,6 +86,7 @@ test_files:
 - spec/pipejump/resources/contact/reminder_spec.rb
 - spec/pipejump/resources/contact_custom_fields_spec.rb
 - spec/pipejump/resources/contact_spec.rb
+- spec/pipejump/resources/contact_validation_spec.rb
 - spec/pipejump/resources/deal/note_spec.rb
 - spec/pipejump/resources/deal/reminder_spec.rb
 - spec/pipejump/resources/deal_spec.rb