pioneer_ruby_sdk 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e909be278c86086ed47667127df968e8b75e1dc639dd718a1344b11e5ba96334
-  data.tar.gz: a88077557732acb48a49354805fe4d08d2f2ea0ba4db82ca8771bd8c465b6672
+  metadata.gz: e95e45596e7e7c90a6e718e412191ea4868cfc700b4481116bcb26470ebb4418
+  data.tar.gz: 1dc70bede8bf710de8acce3400e441cc5da366113f90380296569c4da79a6330
 SHA512:
-  metadata.gz: c31dfe2719112b871537b9b9e9649ce2b22775561bfe98964f123ab2014db724782433362075b7fb67089a730c7c4dc9813d0ef04bc1dda8f9b564b8b57c63bc
-  data.tar.gz: 8347f79aa3645304ebd8f1748787704e833330968e083972fb8541e38d3b8e72361f204d83c805a56f03cb92ea2bfa364c47b841012b9add596d836dc95f1a8d
+  metadata.gz: 6574f8de533d0c54004c0977d233297017a822059f8793c6b9a1560209ea2d519a9ce7102685527c99ff7b665c15b0b876164a6919b4bee38ca4683f73370665
+  data.tar.gz: ea4379f0f47571dcc88dfc4d2dfd1f872882321bcab7f9580d76ddfc2ecd6ad24483f4af409328190b0a82b64395100fdca6709900e57d64b281954cf8a08732

data/lib/client_with_context.rb

@@ -1,4 +1,4 @@
-require_relative 'helper_methods/handle_undefined_feature.rb'
+require_relative 'mod/handle_undefined_feature.rb'
 
 class Client_With_Context
 	def initialize(context_obj)
@@ -10,7 +10,7 @@ class Client_With_Context
 	def get_feature(key, default_value)
 		feature_state = @client.get_feature_state(key)
 		if !feature_state
-			return handle_undefined_feature(key, default_value)
+			return HandleUndefinedFeature.handle(key, default_value)
 		end
 
 		return feature_state.strategy.calculate(@context)

data/lib/event_source_client.rb

@@ -1,7 +1,7 @@
 require 'ld-eventsource'
 require 'json'
 require_relative 'feature_state'
-require_relative 'helper_methods/handle_undefined_feature'
+require_relative 'mod/handle_undefined_feature'
 
 # class for event source client instance
 class Event_Source_Client 
@@ -15,7 +15,8 @@ class Event_Source_Client
       headers: { Authorization: @config[:sdk_key]}
     }
 
-	sse_client = SSE::Client.new("localhost:3030/features", headers: options[:headers])
+	# this needs to make use of the constant based uri, not hardcoded
+	sse_client = SSE::Client.new(@config[:server_address], headers: options[:headers])
 
 	@api_client = sse_client
 	end
@@ -26,20 +27,13 @@ class Event_Source_Client
 	end
 
 	def handle_events
-		event_type = nil
-
 		@api_client.on_event do |event| 
 			data = JSON.parse(event[:data]) 
-			event_type = data[:type]
-			payload = data[:data]
-		end
-
-		puts event_type
-		case event_type
-		when "ALL_FEATURES" 
-			handle_all_features(payload)
-		when "CREATE_CONNECTION"
-			return
+			event_type = data['eventType']
+			if event_type == "ALL_FEATURES"
+				payload = data['payload']
+				handle_all_features(payload)
+			end
 		end
 	end
 
@@ -56,11 +50,11 @@ class Event_Source_Client
 
 		all_features.each do |feature|
 			modified_feature_state_params = {
-				title: feature[:title],
-				value: feature[:is_active],
-				strategy: {percentage: feature[:rollout]}
+				title: feature['title'],
+				value: feature['is_active'],
+				strategy: {percentage: feature['rollout']}
 			}
-			feature_states[feature[:title]] = FeatureState.new(modified_feature_state_params)
+			feature_states[feature['title']] = FeatureState.new(modified_feature_state_params)
 		end
 
 		@features = feature_states
@@ -69,17 +63,16 @@ class Event_Source_Client
 
 	def get_feature(key, default_value) 
 		feature_state = get_feature_state(key)
-		if !feature_state
-			handle_undefined_feature(key, default_value)
+		if feature_state.nil?
+			HandleUndefinedFeature.handle(key, default_value)
 			return
 		end
 
-		value = feature_state[:value]
-		return value
+		feature_state.value
 	end
 
 
 	def get_feature_state(key) 
-		return @features[:key]
+		return @features[key]
 	end
 end

data/lib/feature_state.rb

@@ -1,6 +1,7 @@
 require_relative 'strategy'
 
 class FeatureState
+	attr_reader :value
 	def initialize(feature_state_object)
 		@title = feature_state_object[:title],
 		@value = feature_state_object[:value],

data/lib/mod/handle_undefined_feature.rb

@@ -0,0 +1,9 @@
+module HandleUndefinedFeature
+	def self.handle(key, default_value)
+		unless default_value.nil?
+			puts("Warning: Could not get #{key} from features, using provided default value!")
+			return default_value
+		end
+		raise("Error: #{key} does not exist, cannot get get feature!");
+	end
+end

data/lib/pioneer_ruby_sdk.rb

@@ -13,9 +13,9 @@ class Pioneer_Ruby_Sdk
 	end
 
 	def connect()
-	@client = Event_Source_Client.new(@configs)
-		@client.start()
-		return self
+		@client = Event_Source_Client.new(@configs)
+		@client.start
+		self
 	end
 
 	def with_wait_for_data(time_out = 1, polling_attempts = 5)
@@ -47,4 +47,8 @@ class Pioneer_Ruby_Sdk
 	def get_server_address()
 		return @server_address
 	end
-end
+
+	def get_feature(key, default_value)
+		@client.get_feature(key, default_value)
+	end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pioneer_ruby_sdk
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jimmy Zheng
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-19 00:00:00.000000000 Z
+date: 2021-07-21 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: 
@@ -23,11 +23,12 @@ files:
 - lib/context.rb
 - lib/event_source_client.rb
 - lib/feature_state.rb
-- lib/helper_methods/handle_undefined_feature.rb
+- lib/mod/handle_undefined_feature.rb
 - lib/pioneer_ruby_sdk.rb
 - lib/strategy.rb
 homepage: 
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []

data/lib/helper_methods/handle_undefined_feature.rb

@@ -1,7 +0,0 @@
-def handle_undefined_feature(key, default_value)
-	if !default_value.nil?
-    puts("Warning: Could not get #{key} from features, using provided default value!")
-    return default_value
-	end
-  raise("Error: #{key} does not exist, cannot get get feature!");
-end