pin_up 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 886e0ca286fef6c9bba66913d9316aea2bcf5d77
-  data.tar.gz: ea47fe9051629aa4ad5245f3221d834d5d95da39
+  metadata.gz: c67d8075501e91bd3b435d0e505340c02205a535
+  data.tar.gz: 36267918b46bcc3bbeb595f3e8af798daba499f4
 SHA512:
-  metadata.gz: 4bab9630b52f2d0a3c4331441a9954f79aed82622044d0c0898a65f4c17a22b842b1d62033a6c0dfcdf4fe0a8be318d1b36bb27781f7e1ead5a4e68be021b0ad
-  data.tar.gz: 5681976d8d7e39fc61ac9da509a311823b273d12a9e585aeae2dbfc38101887559a8cbabe00ee45cdf7454dd3b7bae76944114ec44935c5d23c04fbcbb4fd372
+  metadata.gz: b5cc15ec66e259f6e3ef21c22b7fb4e936195ba84c22a2f8521b0ff130ba9e42bfa1a399b0986beafcfaab0c299d20b89c466c8e71d6b5dcd4129452da6f3500
+  data.tar.gz: 1e25012796615fa553563200ca24888d915b06d6c55348f3ac7fdbd6d8696226424593d722add3dda0fcba055f8a36f6a04cff6c3d7f851724b44a880f364ebd

data/VERSION

@@ -1 +1 @@
-1.1.1
+1.2.0

data/lib/pin_up/pin_errors.rb

@@ -1,7 +1,7 @@
 module Pin
   ##
   # Base Pin Error class
-  class PinError < StandardError
+  class PinError
     def initialize(message = nil, http_status = nil)
       @message = message
       @http_status = http_status
@@ -17,17 +17,17 @@ module Pin
       when 400
         case response['error']
         when 'cannot_delete_primary_card'
-          raise(Pin::InvalidResource, response['error_description'])
+          raise Pin::InvalidResource.new(response, response['error_description'])
         else
-          raise(Pin::ChargeError, "#{response['error']}: #{response['error_description']}. Charge token: #{response['charge_token']}")
+          raise Pin::ChargeError.new(response)
         end
       when 402
-        raise(Pin::InsufficientPinBalance, "#{response['error_description']}")
+        raise Pin::InsufficientPinBalance.new(response)
       when 404
-        raise(Pin::ResourceNotFound, "#{response['error_description']}")
+        raise Pin::ResourceNotFound.new response
       when 422
         message = handle_bad_response(response)
-        raise(Pin::InvalidResource, message)
+        raise Pin::InvalidResource.new(response, message)
       end
     end
 
@@ -48,22 +48,43 @@ module Pin
     end
 
     def self.handle_bad_request
-      raise(Pin::ClientError, 'request :method must be one of get, post, put, patch or delete')
+      raise Pin::ClientError, 'request :method must be one of get, post, put, patch or delete'
     end
   end
 
-  class ResourceNotFound < PinError
+  class SimpleError < StandardError
+    attr_accessor :response, :message
+    def initialize(response, message=nil)
+      @response = response
+      @message = message || @response['error_description']
+    end
+
+    def to_s
+      @message
+    end
+  end
+
+  class ResourceNotFound < SimpleError
   end
 
-  class InvalidResource < PinError
+  class InvalidResource < SimpleError
   end
 
-  class ChargeError < PinError
+  class ChargeError < StandardError
+    attr_accessor :response, :message
+    def initialize(response)
+      @response = response
+      @message = "#{@response['error']}: #{@response['error_description']}. Charge token: #{@response['charge_token']}"
+    end
+
+    def to_s
+      @message
+    end
   end
 
-  class InsufficientPinBalance < PinError
+  class InsufficientPinBalance < SimpleError
   end
 
-  class ClientError < PinError
+  class ClientError < StandardError
   end
 end

data/pin_up.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: pin_up 1.1.1 ruby lib
+# stub: pin_up 1.2.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "pin_up"
-  s.version = "1.1.1"
+  s.version = "1.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Daniel Nitsikopoulos"]
-  s.date = "2015-10-30"
+  s.date = "2015-11-14"
   s.description = "A Ruby gem wrapper for the pin-payments (pin.net.au) API"
   s.email = "dnitza@gmail.com"
   s.extra_rdoc_files = [

data/spec/errors_spec.rb

@@ -6,12 +6,20 @@ describe 'Errors', :vcr, class: Pin::PinError do
   end
 
   it 'should raise a 404 error when looking for a customer that doesn\'t exist' do
-    expect { Pin::Customer.find('foo') }.to raise_error(Pin::ResourceNotFound, 'The requested resource could not be found.')
+    expect { Pin::Customer.find('foo') }.to raise_error do |error|
+      expect(error).to be_a Pin::ResourceNotFound
+      expect(error.message).to eq 'The requested resource could not be found.'
+      expect(error.response).to be_a Hash
+    end
   end
 
   it 'should raise a 422 error when trying to update missing a param' do
     options = { email: 'dNitza@gmail.com', card: { address_line1: '12345 Fake Street', expiry_month: '05', expiry_year: '2016', cvc: '123', address_city: 'Melbourne', address_postcode: '1234', address_state: 'VIC', address_country: 'Australia' } }
-    expect { Pin::Customer.update('cus_6XnfOD5bvQ1qkaf3LqmhfQ', options) }.to raise_error(Pin::InvalidResource, "card_number_invalid: Card number can't be blank card_name_invalid: Card name can't be blank ")
+    expect { Pin::Customer.update('cus_6XnfOD5bvQ1qkaf3LqmhfQ', options) }.to raise_error do |error|
+      expect(error).to be_a Pin::InvalidResource
+      expect(error.message).to eq "card_number_invalid: Card number can't be blank card_name_invalid: Card name can't be blank "
+      expect(error.response).to be_a Hash
+    end
   end
 
   it 'should raise a 422 error when trying to make a payment with an expired card' do
@@ -27,7 +35,11 @@ describe 'Errors', :vcr, class: Pin::PinError do
         address_state: 'WA',
         address_country: 'Australia'
       } }
-    expect { Pin::Charges.create(options) }.to raise_error(Pin::InvalidResource, 'card_expiry_month_invalid: Card expiry month is expired card_expiry_year_invalid: Card expiry year is expired ')
+    expect { Pin::Charges.create(options) }.to raise_error do |error|
+      expect(error).to be_a Pin::InvalidResource
+      expect(error.message).to eq 'card_expiry_month_invalid: Card expiry month is expired card_expiry_year_invalid: Card expiry year is expired '
+      expect(error.response).to be_a Hash
+    end
   end
 
   it 'should raise a 400 error when trying to make a payment and a valid card gets declined' do
@@ -59,30 +71,40 @@ describe 'Errors', :vcr, class: Pin::PinError do
         address_state: 'WA',
         address_country: 'Australia'
       } }
-    expect { Pin::Charges.create(options) }.to raise_error(Pin::InvalidResource, 'card_number_invalid: Card number is not valid ')
+    expect { Pin::Charges.create(options) }.to raise_error do |error|
+      expect(error).to be_a Pin::InvalidResource
+      expect(error.message).to eq 'card_number_invalid: Card number is not valid '
+      expect(error.response).to be_a Hash
+    end
   end
 
   it 'Should raise a ResourceNotFound error when can\'t find customer' do
-    expect { Pin::Customer.charges('foo') }.to raise_error(Pin::ResourceNotFound, 'The requested resource could not be found.')
+    expect { Pin::Customer.charges('foo') }.to raise_error do |error|
+      expect(error).to be_a Pin::ResourceNotFound
+      expect(error.message).to eq 'The requested resource could not be found.'
+      expect(error.response).to be_a Hash
+    end
   end
 
   it 'should raise a 422 error if no 2nd argument is given' do
     options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_6XnfOD5bvQ1qkaf3LqmhfQ' }
     @charge = Pin::Charges.create(options)
-    expect { Pin::Refund.create(@charge['token']) }.to raise_error(Pin::InvalidResource, "amount_invalid: Amount can't be blank amount_invalid: Amount is not a number ")
-  end
-
-  it 'should raise a 422 error if a value of less than 100 is given' do
-    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '100', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_6XnfOD5bvQ1qkaf3LqmhfQ' }
-    @charge = Pin::Charges.create(options)
-    # expect { Pin::Refund.create(@charge['token'], 90) }.to raise_error(Pin::InvalidResource, 'amount_invalid: Amount must be more than 100 ($1.00 AUD)')
+    expect { Pin::Refund.create(@charge['token']) }.to raise_error do |error|
+      expect(error).to be_a Pin::InvalidResource
+      expect(error.message).to eq "amount_invalid: Amount can't be blank amount_invalid: Amount is not a number "
+      expect(error.response).to be_a Hash
+    end
   end
 
   it 'should raise a 400 error when attempting to delete customer\'s primary card' do
     customer_token = 'cus_6XnfOD5bvQ1qkaf3LqmhfQ'
     cards = Pin::Customer.cards(customer_token)
     primary_card_token = cards.select{|card| card['primary'] }.first['token']
-    expect { Pin::Customer.delete_card(customer_token, primary_card_token) }.to raise_error(Pin::InvalidResource, 'You cannot delete a customer\'s primary card token')
+    expect { Pin::Customer.delete_card(customer_token, primary_card_token) }.to raise_error do |error|
+      expect(error).to be_a Pin::InvalidResource
+      expect(error.message).to eq 'You cannot delete a customer\'s primary card token'
+      expect(error.response).to be_a Hash
+    end
   end
 
 end

data/spec/spec_helper.rb

@@ -1,4 +1,4 @@
-require "codeclimate-test-reporter"
+require 'codeclimate-test-reporter'
 require 'simplecov'
 
 CodeClimate::TestReporter.start

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pin_up
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Daniel Nitsikopoulos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-30 00:00:00.000000000 Z
+date: 2015-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty