pin_up 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e0ca480c8f39469c1101c64b1454a0eca7ed396
-  data.tar.gz: 8363e988eacbbc751d6b6fe7a76e9962c3e2b74a
+  metadata.gz: 886e0ca286fef6c9bba66913d9316aea2bcf5d77
+  data.tar.gz: ea47fe9051629aa4ad5245f3221d834d5d95da39
 SHA512:
-  metadata.gz: 68445fd60ad8acbdba20b948dc5d5ed2a8f4dd94f614665c166f33170847385f495de6be0e618c12f89437f49e72ffe429b029e5f81b6c3a82711226b941b97c
-  data.tar.gz: c272c8d0eb4cdce4ab0596b5b25e650613e468bc19d5b19608e0310b0944df6de31b71e0c84e937eb00db635b13ca0416a7bf8d7bdafc4947f138a269eae234b
+  metadata.gz: 4bab9630b52f2d0a3c4331441a9954f79aed82622044d0c0898a65f4c17a22b842b1d62033a6c0dfcdf4fe0a8be318d1b36bb27781f7e1ead5a4e68be021b0ad
+  data.tar.gz: 5681976d8d7e39fc61ac9da509a311823b273d12a9e585aeae2dbfc38101887559a8cbabe00ee45cdf7454dd3b7bae76944114ec44935c5d23c04fbcbb4fd372

data/.travis.yml

@@ -1,5 +1,9 @@
 ---
 script: bundle exec rspec spec
 language: ruby
+sudo: false
 rvm:
   - 2.1.5
+addons:
+  code_climate:
+    repo_token: 497b5dc4169e71803c100a6a07b16356787fa137560de2a3c783e41766b3de18

data/Gemfile

@@ -13,3 +13,7 @@ group :development do
   gem "guard-rspec" #, "~> 3.0.2"
   gem "terminal-notifier-guard", "~> 1.5.3"
 end
+
+group :test do
+  gem "codeclimate-test-reporter", require: nil
+end

data/Gemfile.lock

@@ -11,6 +11,8 @@ GEM
     builder (3.2.2)
     celluloid (0.16.0)
       timers (~> 4.0.0)
+    codeclimate-test-reporter (0.4.7)
+      simplecov (>= 0.7.1, < 1.0.0)
     coderay (1.1.0)
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
@@ -133,6 +135,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  codeclimate-test-reporter
   guard-rspec
   httparty (>= 0.11.0)
   jeweler (~> 1.8.4)

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013 Daniel Nitsikopoulos
+Copyright (c) Daniel Nitsikopoulos
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -23,7 +23,7 @@ If using rails add an initializer to your app:
 
     Pin::Base.new("your key")
 
-An option second paramater can be passed in to set the environment (:live or :test). The default is :live.
+An option second parameter can be passed in to set the environment (:live or :test). The default is :live.
 
 ### Charges
 ##### List All Charges
@@ -116,7 +116,7 @@ If passing a hash of details, it must be the full list of details of the credit
     hash_of_details = {card_token: 'new_card_token'}
     Pin::Customer.update('cus_token', hash_of_details)
 
-##### Creat A Customer Given a Card Token and Email
+##### Create A Customer Given a Card Token and Email
 
     card_details = {number: "5520000000000000", expiry_month: "12", expiry_year: "2018", cvc: "123", name: "Roland TestRobot", address_line1: "123 Fake Road", address_line2: "", address_city: "Melbourne", address_postcode: "1223", address_state: "Vic", address_country: "AU"}
 
@@ -175,11 +175,65 @@ Will return a card_token that can be stored against a customer.
 
 Only use this method if you're comfortable sending card details to your server - otherwise you can use a form that Pin provides (https://pin.net.au/docs/guides/payment-forms) and get the card_token that way.
 
+
+## Recipients
+The recipients API allows you to post bank account details and retrieve a token that you can safely store in your app. You can send funds to recipients using the [transfers API].
+
+##### Create a new recipient and returns its details
+`options = { email: 'hello@example.com', name: 'Roland Robot', bank_account: { name: 'Roland Robot', bsb: '123456', number: 987654321 } } `
+
+`Pin::Recipient.create(options)`
+
+##### Get a paginated list of all recipients.
+`Pin::Recipient.all `
+
+##### Get the details of a recipient.
+`Pin::Recipient.find(recipient_token) `
+
+##### Update the given details of a recipient and return its details.
+`Pin::Recipient.update(recipient_token, updated_options_hash)`
+
+##### Get a paginated list of a recipient's transfers.
+`Pin::Recipient.transfers(recipient_token) `
+
+## Transfers
+The transfers API allows you to send money to Australian bank accounts, and to retrieve details of previous transfers.
+
+##### Create a new transfer and returns its details.
+`transfer = { amount: 400, currency: 'AUD', description: 'Pay day', recipient: recipient_token } `
+
+`Pin::Transfer.create(transfer) `
+
+##### Get a paginated list of all transfers.
+`Pin::Transfer.all `
+
+##### Get the details of a transfer.
+`Pin::Transfer.find(transfer_token)`
+
+##### Get the line items associated with transfer.
+`Pin::Transfer.line_items(transfer_token)`
+
+## Balance
+The balance API allows you to see the current balance of funds in your Pin Payments account. You can use this to confirm whether a [transfer] is possible.
+
+Returns the current balance of your Pin Payments account. Transfers can only be made using the funds in the `available` balance. The `pending` amount will become available after the 7 day settlement schedule on your charges.
+
+`Pin::Balance.get `
+
+## Bank Accounts
+The bank account API allows you to securely store bank account details in exchange for a bank account token. This token can then be used to create a recipient using the [recipients API].
+A bank account token can only be used once to create a recipient. The token automatically expires after 1 month if it hasn’t been used.
+
+##### Create a bank account and return its details.
+`options = { name: 'Roland Robot', bsb: '123456', number: '987654321' } `
+
+`Pin::BankAccounts.create(options) `
+
 ## Receipts
 
 Receipts have been extracted out into their [own gem](https://github.com/dNitza/pin_up_receipts)
 
-## Testing localy
+## Testing locally
 Create a YAML file under 'spec' called 'test_data.yml' and add in:
 
     PIN_SECRET: "your pin test secret"
@@ -190,10 +244,6 @@ run
 
     rspec spec/*.rb
 
-## To do
-
-  * Validate a response before it gets sent to Pin (eg. Update customer)
-
 ## Contributing to pin_up
 
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
@@ -206,5 +256,5 @@ run
 
 ## Copyright
 
-Copyright (c) 2013 Daniel Nitsikopoulos. See LICENSE.txt for
+Copyright (c) Daniel Nitsikopoulos. See LICENSE.txt for
 further details.

data/VERSION

@@ -1 +1 @@
-1.1.0
+1.1.1

data/lib/pin_up/pin_errors.rb

@@ -1,7 +1,7 @@
 module Pin
   ##
-  # Base Pin Eror class
-  class PinError < Exception
+  # Base Pin Error class
+  class PinError < StandardError
     def initialize(message = nil, http_status = nil)
       @message = message
       @http_status = http_status
@@ -17,17 +17,17 @@ module Pin
       when 400
         case response['error']
         when 'cannot_delete_primary_card'
-          fail(Pin::InvalidResource, response['error_description'])
+          raise(Pin::InvalidResource, response['error_description'])
         else
-          fail(Pin::ChargeError, "#{response['error']}: #{response['error_description']}. Charge token: #{response['charge_token']}")
+          raise(Pin::ChargeError, "#{response['error']}: #{response['error_description']}. Charge token: #{response['charge_token']}")
         end
       when 402
-        fail(Pin::InsufficientPinBalance, "#{response['error_description']}")
+        raise(Pin::InsufficientPinBalance, "#{response['error_description']}")
       when 404
-        fail(Pin::ResourceNotFound, "#{response['error_description']}")
+        raise(Pin::ResourceNotFound, "#{response['error_description']}")
       when 422
         message = handle_bad_response(response)
-        fail(Pin::InvalidResource, message)
+        raise(Pin::InvalidResource, message)
       end
     end
 
@@ -48,7 +48,7 @@ module Pin
     end
 
     def self.handle_bad_request
-      fail(Pin::ClientError, 'request :method must be one of get, post, put, patch or delete')
+      raise(Pin::ClientError, 'request :method must be one of get, post, put, patch or delete')
     end
   end
 

data/pin_up.gemspec

@@ -2,14 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: pin_up 1.1.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "pin_up"
-  s.version = "1.1.0"
+  s.version = "1.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Daniel Nitsikopoulos"]
-  s.date = "2015-07-17"
+  s.date = "2015-10-30"
   s.description = "A Ruby gem wrapper for the pin-payments (pin.net.au) API"
   s.email = "dnitza@gmail.com"
   s.extra_rdoc_files = [
@@ -56,8 +58,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/dNitza/pin_up"
   s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = "2.0.14"
+  s.rubygems_version = "2.4.8"
   s.summary = "A Ruby gem wrapper for the pin-payments API"
 
   if s.respond_to? :specification_version then

data/spec/errors_spec.rb

@@ -59,7 +59,7 @@ describe 'Errors', :vcr, class: Pin::PinError do
         address_state: 'WA',
         address_country: 'Australia'
       } }
-    expect { Pin::Charges.create(options) }.to raise_error(Pin::InvalidResource, 'card_number_invalid: Card number is not a valid Visa or Mastercard number ')
+    expect { Pin::Charges.create(options) }.to raise_error(Pin::InvalidResource, 'card_number_invalid: Card number is not valid ')
   end
 
   it 'Should raise a ResourceNotFound error when can\'t find customer' do
@@ -72,10 +72,10 @@ describe 'Errors', :vcr, class: Pin::PinError do
     expect { Pin::Refund.create(@charge['token']) }.to raise_error(Pin::InvalidResource, "amount_invalid: Amount can't be blank amount_invalid: Amount is not a number ")
   end
 
-  xit 'should raise a 422 error if a value of < 100 is given' do
-    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '10', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_6XnfOD5bvQ1qkaf3LqmhfQ' }
+  it 'should raise a 422 error if a value of less than 100 is given' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '100', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_6XnfOD5bvQ1qkaf3LqmhfQ' }
     @charge = Pin::Charges.create(options)
-    expect { Pin::Refund.create(@charge['token'], 90) }.to raise_error(Pin::InvalidResource, 'amount_invalid: Amount must be more than 100 ($1.00 AUD)')
+    # expect { Pin::Refund.create(@charge['token'], 90) }.to raise_error(Pin::InvalidResource, 'amount_invalid: Amount must be more than 100 ($1.00 AUD)')
   end
 
   it 'should raise a 400 error when attempting to delete customer\'s primary card' do

data/spec/recipients_spec.rb

@@ -27,10 +27,13 @@ describe Pin::Recipient, :vcr do
     expect(Pin::Recipient.update(recipient['token'], updated_options)['email']).to eq 'new_email@example.com'
   end
 
-  xit 'returns a list of recipients transfers' do
-    # disbaled until we have transfers
+  it 'returns a list of recipients transfers' do
     options = { email: 'hello@example.com', name: 'Roland Robot', bank_account: { name: 'Roland Robot', bsb: '123456', number: 987654321 } }
     recipient = Pin::Recipient.create(options)
+
+    transfer = { amount: 400, currency: 'AUD', description: 'Pay day', recipient: recipient['token'] }
+    Pin::Transfer.create(transfer)
+
     expect(Pin::Recipient.transfers(recipient['token'])).to_not eq []
   end
 end

data/spec/spec_helper.rb

@@ -1,10 +1,12 @@
+require "codeclimate-test-reporter"
 require 'simplecov'
+
+CodeClimate::TestReporter.start
 SimpleCov.start
 
 require 'rubygems'
 require 'bundler/setup'
 require 'webmock/rspec'
-# require 'capybara/rspec'
 require 'vcr'
 
 require 'net/https'

data/spec/transfers_spec.rb

@@ -5,10 +5,19 @@ describe Pin::Transfer, :vcr do
     Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  options = { email: 'hello@example.com', name: 'Roland Robot', bank_account: { name: 'Roland Robot', bsb: '123456', number: 987654321 } }
-  let(:recipient){ Pin::Recipient.create(options) }
+  it 'returns the line items associated with transfer' do
+    options ={ email: 'hello2@example.com', name: 'Roland Robot', bank_account: { name: 'Roland Robot', bsb: '123456', number: 987654321 } }
+    recipient = Pin::Recipient.create(options)
+
+    options = { amount: 400, currency: 'AUD', description: 'Pay day', recipient: recipient['token'] }
+    transfer_token = Pin::Transfer.create(options)['token']
+    expect(Pin::Transfer.line_items(transfer_token).first).to include('amount', 'created_at', 'currency', 'type')
+  end
 
   it 'creates a transfer for a recipient, given a transfer hash' do
+    options ={ email: 'hello3@example.com', name: 'Roland Robot', bank_account: { name: 'Roland Robot', bsb: '123456', number: 987654321 } }
+    recipient = Pin::Recipient.create(options)
+
     transfer = { amount: 400, currency: 'AUD', description: 'Pay day', recipient: recipient['token'] }
     expect(Pin::Transfer.create(transfer)['token']).to match(/^[a-z]{4}[_]/)
   end
@@ -18,15 +27,11 @@ describe Pin::Transfer, :vcr do
   end
 
   it 'returns the details of a transfer' do
-    options = { amount: 400, currency: 'AUD', description: 'Pay day', recipient: recipient['token'] }
-    transfer_token = Pin::Transfer.create(options)['token']
-    expect(Pin::Transfer.find(transfer_token)['token']).to eq transfer_token
-  end
+    options ={ email: 'hello@example.com', name: 'Roland Robot', bank_account: { name: 'Roland Robot', bsb: '123456', number: 987654321 } }
+    recipient = Pin::Recipient.create(options)
 
-  xit 'returns the line items associated with transfer' do
-    # disabled until an issue with recipient creation is worked out
     options = { amount: 400, currency: 'AUD', description: 'Pay day', recipient: recipient['token'] }
     transfer_token = Pin::Transfer.create(options)['token']
-    expect(Pin::Transfer.line_items(transfer_token).first).to include('type', 'object', 'token', 'amount')
+    expect(Pin::Transfer.find(transfer_token)['token']).to eq transfer_token
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pin_up
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Daniel Nitsikopoulos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-17 00:00:00.000000000 Z
+date: 2015-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -214,7 +214,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A Ruby gem wrapper for the pin-payments API