pin_up 0.9.4 → 0.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 391267df12d830f0f10802fe7db17cfaedd16ba8
-  data.tar.gz: 5bb490e4420cd5f985e9cbb37f053013b6217c1e
+  metadata.gz: 569c2387bbe572f2e680d34ccc7319d663fd2941
+  data.tar.gz: 2e4ff4fc878584bf9938d2d7dd0bdd4b20b248e7
 SHA512:
-  metadata.gz: 38c198c75ef69a73fb7901329e67fac7b4196e37177f22b807fc8c157f099f31b16a970eaeeb27a797a62793bd27fafcd4787deae8f62caacda264d18823133b
-  data.tar.gz: 4bed768f5b877730539027b5cb3bae4cc826aa2eacf3577a61da7bb040dd4271c632c35a0208dfe7995fdcc090540367cee8afa677ea01fa3fa4d05fa9cf2898
+  metadata.gz: 429922018edf82e1cd70f9982961a43f2a335937655463af14640c821bfb6cdad01cb51ffcbe5ec34f0201ce0454e19bc12a48c8ba758f5edbeab86f8be9860a
+  data.tar.gz: 1a65fd45399e990c5730c166b91d5f88155323cd66aa9604c3f1ef1d3d75e95eb340c204d398e5cff4b7c96879ce51e73ad50a3b55c883282ae0bf0fcf9c742b

data/.rubocop.yml

@@ -0,0 +1,5 @@
+LineLength:
+  Enabled: false
+
+BlockAlignment:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+2.1.0-preview1

data/Guardfile

@@ -2,7 +2,7 @@
 # More info at https://github.com/guard/guard#readme
 guard :rspec do
   watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }
 
   # Rails example
@@ -24,7 +24,7 @@ end
 
 guard :rspec do
   watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch(%r{^lib/pin_up/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }
 
   # Rails example

data/VERSION

@@ -1 +1 @@
-0.9.4
+0.9.5

data/lib/pin_up/base.rb

@@ -1,41 +1,38 @@
 module Pin
   ##
-  # This class sets up a few things like the base URL and provides a few utility methods to be shared between classes.
+  # This class sets up a few things like the base URL and provides a few
+  # utility methods to be shared between classes.
   class Base
     include HTTParty
 
+    attr_reader :key
     ##
     # Create a new Pin instance
     # Args:
     #  key: Your Pin secret key
-    #  env: The environment you want to use. Leave blank for live and pass in :test for test
+    #  env: The environment you want to use.
+    #    Leave blank for live and pass :test for test
     # An error is raised if an invalid env is passed in.
-    def initialize(key = "", env = :live)
+    def initialize(key = '', env = :live)
       @key = key
       env = env.to_sym
-      @@auth = {username: key, password: ''}
+      @@auth = { username: @key, password: '' }
       @@base_url = if env == :live
-        "https://api.pin.net.au/1/"
+        'https://api.pin.net.au/1/'
       elsif env == :test
-        "https://test-api.pin.net.au/1/"
+        'https://test-api.pin.net.au/1/'
       else
-        raise "'env' option must be :live or :test. Leave blank for live payments"
+        fail "'env' option must be :live or :test. Leave blank for live payments"
       end
     end
 
-    ##
-    # Provides access to your key if needed
-    def key
-      @key
-    end
-
     ##
     # Provides access to the base URL if needed
-    def uri
+    def base_uri
       @@base_url
     end
 
-    protected
+    # protected
 
     ##
     # Sends an authorised GET request to pins server
@@ -67,15 +64,19 @@ module Pin
     end
 
     ##
-    # Builds a response of a collection if the response code is 200 otherwise an empty array is returned
-    def self.build_collection_response(response, pagination=false)
+    # Builds a response of a collection if the response code is 200
+    #  otherwise an empty array is returned
+    def self.build_collection_response(response, pagination = false)
       models = []
       if response.code == 200
         if pagination
           response.parsed_response['response'].each do |model|
             models << model
           end
-          return {response: models, pagination: response.parsed_response['pagination']}
+          return {
+            response: models,
+            pagination: response.parsed_response['pagination']
+          }
         else
           response.parsed_response['response'].each do |model|
             models << model
@@ -87,4 +88,4 @@ module Pin
       # models
     end
   end
-end
+end

data/lib/pin_up/card.rb

@@ -2,7 +2,6 @@ module Pin
   ##
   # This class models Pin's Cards API
   class Card < Base
-
     ##
     # creates a card given a hash of options
     # https://pin.net.au/docs/api/cards
@@ -15,4 +14,4 @@ module Pin
       build_response(auth_post('cards', options))
     end
   end
-end
+end

data/lib/pin_up/charge.rb

@@ -11,8 +11,8 @@ module Pin
     # and the pagination hash with [:pagination]
     #
     # https://pin.net.au/docs/api/charges#get-charges
-    def self.all(page=nil, pagination=false)
-      build_collection_response(auth_get("charges?page=#{page}"),pagination)
+    def self.all(page = nil, pagination = false)
+      build_collection_response(auth_get("charges?page=#{page}"), pagination)
     end
 
     ##
@@ -29,29 +29,28 @@ module Pin
     # returns: a collection of charge objects
     # https://pin.net.au/docs/api/charges#search-charges
     def self.search(options = {})
-      term = ""
+      term = ''
       options.each do |key, option|
-        term += "#{key.to_s}=#{URI::encode(option)}&"
+        term += "#{key.to_s}=#{URI.encode(option)}&"
       end
       build_response(auth_get("charges/search?#{term}"))
     end
 
-    # Create a charge given charge details and a card, a card_token or acustomer_token
+    # Create a charge given charge details and a card,
+    # a card_token or a customer_token
     # args: options (Hash)
     # returns: a charge object
     # https://pin.net.au/docs/api/charges#post-charges
     def self.create(options = {})
-      build_response(auth_post("charges", options))
+      build_response(auth_post('charges', options))
     end
 
     # Captures a previously authorised charge and returns its details.
     # args: charge-token (String)
     # returns: charge object
     # https://pin.net.au/docs/api/charges#put-charges
-
     def self.capture(token)
       build_response(auth_put("/charges/#{token}/capture"))
     end
-
   end
-end
+end

data/lib/pin_up/customer.rb

@@ -2,7 +2,6 @@ module Pin
   ##
   # This class models Pins Customers API
   class Customer < Base
-
     ##
     # Lists all customers for your account
     # args: page (Fixnum), pagination (Boolean)
@@ -12,7 +11,7 @@ module Pin
     # and the pagination hash with [:pagination]
     #
     # https://pin.net.au/docs/api/customers#get-customers
-    def self.all(page=nil, pagination=false)
+    def self.all(page = nil, pagination = false)
       build_collection_response(auth_get("customers?page=#{page}"), pagination)
     end
 
@@ -23,9 +22,9 @@ module Pin
     # https://pin.net.au/docs/api/customers#post-customers
     def self.create(email, card)
       options = if card.respond_to?(:to_hash)
-        {card: card.to_hash}
+        { card: card.to_hash }
       else
-        {card_token: card}
+        { card_token: card }
       end.merge(email: email)
 
       build_response(auth_post('customers', options))
@@ -41,11 +40,13 @@ module Pin
     end
 
     ##
-    # Update a customer for your account given a token and any of: email, card (hash),card_token
+    # Update a customer for your account given a token
+    # and any of: email, card (hash),card_token
     # args: token (String), options (Hash)
     # returns: a customer object
     # https://pin.net.au/docs/api/customers#put-customer
-    # NB: When providing a card (hash), you need to specify the full list of details.
+    # NB: When providing a card (hash), you need to specify
+    # the full list of details.
     def self.update(token, options = {})
       build_response(auth_put("customers/#{token}", options))
     end
@@ -59,8 +60,10 @@ module Pin
     # and the pagination hash with [:pagination]
     #
     # https://pin.net.au/docs/api/customers#get-customers-charges
-    def self.charges(token, page=nil, pagination=false)
-      build_collection_response(auth_get("customers/#{token}/charges?page=#{page}"), pagination)
+    def self.charges(token, page = nil, pagination = false)
+      build_collection_response(
+        auth_get("customers/#{token}/charges?page=#{page}"), pagination
+      )
     end
   end
-end
+end

data/lib/pin_up/pin_errors.rb

@@ -1,40 +1,45 @@
 module Pin
+  ##
+  # Base Pin Eror class
   class PinError < Exception
-
-    def initialize(message=nil, http_status=nil)
+    def initialize(message = nil, http_status = nil)
       @message = message
       @http_status = http_status
     end
 
     def to_s
-      status_string = @http_status.nil? ? "" : "(Status #{@http_status}) "
+      status_string = @http_status.nil? ? '' : "(Status #{@http_status}) "
       "#{status_string}#{@message}"
     end
 
     def self.handle_error(http_status, response)
       case http_status
       when 400
-        raise(Pin::ChargeError, "#{response['error']}: #{response['error_description']}. Charge token: #{response['charge_token']}")
+        fail(Pin::ChargeError, "#{response['error']}: #{response['error_description']}. Charge token: #{response['charge_token']}")
       when 402
-        raise(Pin::InsufficientPinBalance, "#{response['error_description']}")
+        fail(Pin::InsufficientPinBalance, "#{response['error_description']}")
       when 404
-        raise(Pin::ResourceNotFound, "#{response['error_description']}")
+        fail(Pin::ResourceNotFound, "#{response['error_description']}")
       when 422
-        message = ""
-          begin
-            response['messages'].each do |m|
-              message += "#{m['code']}: #{m['message']}"
-            end
-           rescue
-            begin response['messages']['amount'][0]
-              message = "#{response['error']}: #{response['error_description']}. Amount: #{response['messages']['amount'][0]}"
-            rescue
-              message = "#{response['error']}: #{response['error_description']}"
-            end
+        message = handle_bad_response(response)
+        fail(Pin::InvalidResource, message)
+      end
+    end
 
-           end
-        raise(Pin::InvalidResource, message)
+    def self.handle_bad_response(response)
+      message = ''
+      begin
+        response['messages'].each do |m|
+          message += "#{m['code']}: #{m['message']}"
+        end
+      rescue
+        begin response['messages']['amount'][0]
+          message = "#{response['error']}: #{response['error_description']}. Amount: #{response['messages']['amount'][0]}"
+        rescue
+          message = "#{response['error']}: #{response['error_description']}"
+        end
       end
+      message
     end
   end
 
@@ -47,7 +52,6 @@ module Pin
   class ChargeError < PinError
   end
 
-  class InsufficientPinBalance <PinError
+  class InsufficientPinBalance < PinError
   end
-
-end
+end

data/lib/pin_up/refund.rb

@@ -2,7 +2,6 @@ module Pin
   ##
   # This class models Pin's Charges API
   class Refund < Base
-
     ##
     # Find a refund by charge token
     # returns: a collection of refund objects
@@ -23,8 +22,8 @@ module Pin
     # if no amount is passed in, the full amount of the charge will be refunded
     # https://pin.net.au/docs/api/refunds#post-refunds
     def self.create(token, amount = nil)
-      options = {amount: amount}
+      options = { amount: amount }
       build_response(auth_post("charges/#{token}/refunds", options))
     end
   end
-end
+end

data/lib/pin_up.rb

@@ -8,4 +8,4 @@ require 'pin_up/charge'
 require 'pin_up/customer'
 require 'pin_up/refund'
 
-require 'pin_up/pin_errors'
+require 'pin_up/pin_errors'

data/pin_up.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: pin_up 0.9.4 ruby lib
+# stub: pin_up 0.9.5 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "pin_up"
-  s.version = "0.9.4"
+  s.version = "0.9.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
@@ -29,6 +29,8 @@ Gem::Specification.new do |s|
     ".idea/scopes/scope_settings.xml",
     ".idea/vcs.xml",
     ".idea/workspace.xml",
+    ".rubocop.yml",
+    ".ruby-version",
     ".travis.yml",
     "Gemfile",
     "Gemfile.lock",

data/spec/base_spec.rb

@@ -1,29 +1,29 @@
 require 'spec_helper'
 
-describe "Base", :vcr, class: Pin::Base do
+describe 'Base', :vcr, class: Pin::Base do
   before(:each) do
-    @test_pin = Pin::Base.new(ENV["PIN_SECRET"], :test)
+    @test_pin = Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  it "should set key correctly"  do
-    @pin = Pin::Base.new("KEY", :live)
-    expect(@pin.key).to eq "KEY"
+  it 'should set key correctly'  do
+    @pin = Pin::Base.new('KEY', :live)
+    expect(@pin.key).to eq 'KEY'
   end
 
-  it "should set environment to live if no env set" do
-    @pin = Pin::Base.new("KEY", :live)
-    expect(@pin.uri).to eq "https://api.pin.net.au/1/"
+  it 'should set environment to live if no env set' do
+    @pin = Pin::Base.new('KEY', :live)
+    expect(@pin.base_uri).to eq 'https://api.pin.net.au/1/'
   end
 
-  it "should set environment to test when set" do
-    expect(@test_pin.uri).to eq "https://test-api.pin.net.au/1/"
+  it 'should set environment to test when set' do
+    expect(@test_pin.base_uri).to eq 'https://test-api.pin.net.au/1/'
   end
 
-  it "should raise an error if anything other than '' :live or :test is passed to a new instance" do
-    expect{Pin::Base.new("KEY", :foo)}.to raise_error(RuntimeError, "'env' option must be :live or :test. Leave blank for live payments")
+  it 'should raise an error if anything other than '' :live or :test is passed to a new instance' do
+    expect { Pin::Base.new('KEY', :foo) }.to raise_error(RuntimeError, "'env' option must be :live or :test. Leave blank for live payments")
   end
 
-  it "should list succesfully connect to Pin" do
+  it 'should list succesfully connect to Pin' do
     stub_request(:get, "https://#{@test_pin.key}:''@test-api.pin.net.au/1/customers")
     expect(Pin::Base.auth_get('customers').code).to eq 200
   end

data/spec/cards_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
-describe "Card", :vcr, class: Pin::Card do
+describe 'Card', :vcr, class: Pin::Card do
   before(:each) do
-    Pin::Base.new(ENV["PIN_SECRET"], :test)
+    Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  it "should create a card and respond with the card detail from pin" do
-    options = {number: "5520000000000000", expiry_month: "12", expiry_year: "2018", cvc: "123", name: "Roland Robot", address_line1: "123 Fake Road", address_line2: "", address_city: "Melbourne", address_postcode: "1223", address_state: "Vic", address_country: "AU"}
+  it 'should create a card and respond with the card detail from pin' do
+    options = { number: '5520000000000000', expiry_month: '12', expiry_year: '2018', cvc: '123', name: 'Roland Robot', address_line1: '123 Fake Road', address_line2: '', address_city: 'Melbourne', address_postcode: '1223', address_state: 'Vic', address_country: 'AU' }
     Pin::Card.create(options)['token'].should match(/^[a-z]{4}[_]/)
   end
-end
+end

data/spec/charges_spec.rb

@@ -1,47 +1,47 @@
 require 'spec_helper'
 
-describe "Charge", :vcr, class: Pin::Charges do
+describe 'Charge', :vcr, class: Pin::Charges do
   before(:each) do
-    Pin::Base.new(ENV["PIN_SECRET"], :test)
+    Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  it "should list charges in Pin" do
+  it 'should list charges in Pin' do
     Pin::Charges.all.should_not == []
   end
 
-  it "should show a charge given a token" do
-    Pin::Charges.find("ch_0kdOMXP7gG0_W_Vh8qAWdA")["token"].should match(/^[a-z]{2}[_]/)
+  it 'should show a charge given a token' do
+    Pin::Charges.find('ch_0kdOMXP7gG0_W_Vh8qAWdA')['token'].should match(/^[a-z]{2}[_]/)
   end
 
-  it "should show a charge given a search term" do
-    Pin::Charges.search({query: "mid Plan - My Focusbook", end_date: "Mar 25, 2013"}).should_not == []
+  it 'should show a charge given a search term' do
+    Pin::Charges.search(query: 'mid Plan - My Focusbook', end_date: 'Mar 25, 2013').should_not == []
   end
 
-  it "should not show a charge if end_date is out of range" do
-    Pin::Charges.search({end_date: "Mar 25, 2011"}).should == []
+  it 'should not show a charge if end_date is out of range' do
+    Pin::Charges.search(end_date: 'Mar 25, 2011').should == []
   end
 
-  it "should create a charge given details" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", customer_token: "cus_8ImkZdEZ6BXUA6NcJDZg_g"   }
-    Pin::Charges.create(options)["success"].should eq true
+  it 'should create a charge given details' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_8ImkZdEZ6BXUA6NcJDZg_g' }
+    Pin::Charges.create(options)['success'].should eq true
   end
 
-  it "should return pagination if 'pagination' is true" do
-    Pin::Charges.all(3,true)[:pagination]["current"] == 3
+  it 'should return pagination if "pagination" is true' do
+    Pin::Charges.all(3, true)[:pagination]['current'] == 3
   end
 
-  it "should list charges on a page given a page" do
+  it 'should list charges on a page given a page' do
     Pin::Charges.all(1).should_not == []
   end
 
-  it "should create a pre-auth (capture a charge)" do
-    options = {email: "dNitza@gmail.com", description: "A new captured charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", customer_token: "cus_8ImkZdEZ6BXUA6NcJDZg_g", capture: false   }
-    Pin::Charges.create(options)["captured"].should eq false
+  it 'should create a pre-auth (capture a charge)' do
+    options = { email: 'dNitza@gmail.com', description: 'A new captured charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_8ImkZdEZ6BXUA6NcJDZg_g', capture: false }
+    Pin::Charges.create(options)['captured'].should eq false
   end
 
-  it "should capture a charge" do
-    options = {email: "dNitza@gmail.com", description: "A new captured charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", customer_token: "cus_8ImkZdEZ6BXUA6NcJDZg_g", capture: false   }
-    token = Pin::Charges.create(options)["token"]
-    Pin::Charges.capture(token)["success"].should eq true
+  it 'should capture a charge' do
+    options = { email: 'dNitza@gmail.com', description: 'A new captured charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_8ImkZdEZ6BXUA6NcJDZg_g', capture: false }
+    token = Pin::Charges.create(options)['token']
+    Pin::Charges.capture(token)['success'].should eq true
   end
-end
+end

data/spec/customers_spec.rb

@@ -1,63 +1,63 @@
 require 'spec_helper'
 
-describe "Customer", :vcr, class: Pin::Customer do
+describe 'Customer', :vcr, class: Pin::Customer do
   before(:each) do
-    Pin::Base.new(ENV["PIN_SECRET"], :test)
+    Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  it "should list customers" do
+  it 'should list customers' do
     Pin::Customer.all.should_not == []
   end
 
-  it "should go to a specific page when page paramater is passed" do
-    request = Pin::Customer.all(20,true)
-    request[:pagination]["current"].should == 20
+  it 'should go to a specific page when page paramater is passed' do
+    request = Pin::Customer.all(20, true)
+    request[:pagination]['current'].should == 20
   end
 
-  it "should list customers on a page given a page" do
-    request = Pin::Customer.all(1,true)
+  it 'should list customers on a page given a page' do
+    request = Pin::Customer.all(1, true)
     request[:response].should_not == []
   end
 
-  it "should return pagination if true is passed for pagination" do
-    request = Pin::Customer.all(1,true)
-    request[:pagination].keys.include?(["current", "previous", "next", "per_page", "pages", "count"])
+  it 'should return pagination if true is passed for pagination' do
+    request = Pin::Customer.all(1, true)
+    request[:pagination].keys.include?(%W('current previous next per_page pages count))
   end
 
-  it "should not list customers on a page given a page if there are no customers" do
-    request = Pin::Customer.all(25,true)
+  it 'should not list customers on a page given a page if there are no customers' do
+    request = Pin::Customer.all(25, true)
     request[:response].should == []
   end
 
-  it "should show a  customer given a token" do
-    Pin::Customer.find('cus_8ImkZdEZ6BXUA6NcJDZg_g')['token'].should == "cus_8ImkZdEZ6BXUA6NcJDZg_g"
+  it 'should show a  customer given a token' do
+    Pin::Customer.find('cus_8ImkZdEZ6BXUA6NcJDZg_g')['token'].should == 'cus_8ImkZdEZ6BXUA6NcJDZg_g'
   end
 
-  it "should list charges to a customer given a token" do
+  it 'should list charges to a customer given a token' do
     Pin::Customer.charges('cus_8ImkZdEZ6BXUA6NcJDZg_g')[0]['token'].should match(/^[a-z]{2}[_]/)
   end
 
-  it "should show pagination on a page given a token and a page" do
-    Pin::Customer.charges('cus_8ImkZdEZ6BXUA6NcJDZg_g',5,true)[:pagination]["current"] == 5
+  it 'should show pagination on a page given a token and a page' do
+    Pin::Customer.charges('cus_8ImkZdEZ6BXUA6NcJDZg_g', 5, true)[:pagination]['current'] == 5
   end
 
-  it "should list charges to a customer on a page given a token and a page" do
-    Pin::Customer.charges('cus_8ImkZdEZ6BXUA6NcJDZg_g',1,true)[:response][0]['token'].should match(/^[a-z]{2}[_]/)
+  it 'should list charges to a customer on a page given a token and a page' do
+    Pin::Customer.charges('cus_8ImkZdEZ6BXUA6NcJDZg_g', 1, true)[:response][0]['token'].should match(/^[a-z]{2}[_]/)
   end
 
-  it "should create a customer given an email and card details" do
-    Pin::Customer.create('dNitza@gmail.com', {number: '5520000000000000', expiry_month: "12", expiry_year: "2014", cvc: "123", name: 'Roland Robot', address_line1: '123 fake street', address_city: 'Melbourne', address_postcode: '1234', address_state: 'Vic', address_country: 'Australia'})["token"].should match(/^[a-z]{3}[_]/)
+  it 'should create a customer given an email and card details' do
+    Pin::Customer.create('dNitza@gmail.com', number: '5520000000000000', expiry_month: '12', expiry_year: '2014', cvc: '123', name: 'Roland Robot', address_line1: '123 fake street', address_city: 'Melbourne', address_postcode: '1234', address_state: 'Vic', address_country: 'Australia')['token'].should match(/^[a-z]{3}[_]/)
   end
 
-  it "should update a customer given a token and details to update" do
-    options = {email: "dNitza@gmail.com", card: {number: "5520000000000000", address_line1: "12345 Fake Street", expiry_month: "05", expiry_year: "2014", cvc: "123", name: "Daniel Nitsikopoulos", address_city: "Melbourne", address_postcode: "1234", address_state: "VIC", address_country: "Australia"}}
-    Pin::Customer.update('cus_sRtAD2Am-goZoLg1K-HVpA', options)['card']['address_line1'].should == "12345 Fake Street"
+  it 'should update a customer given a token and details to update' do
+    options = { email: 'dNitza@gmail.com', card: { number: '5520000000000000', address_line1: '12345 Fake Street', expiry_month: '05', expiry_year: '2014', cvc: '123', name: 'Daniel Nitsikopoulos', address_city: 'Melbourne', address_postcode: '1234', address_state: 'VIC', address_country: 'Australia' } }
+    Pin::Customer.update('cus_sRtAD2Am-goZoLg1K-HVpA', options)['card']['address_line1'].should == '12345 Fake Street'
   end
 
-  it "should create a customer given a card token customer email" do
-    options = {number: "5520000000000000", expiry_month: "12", expiry_year: "2018", cvc: "123", name: "Roland TestRobot", address_line1: "123 Fake Road", address_line2: "", address_city: "Melbourne", address_postcode: "1223", address_state: "Vic", address_country: "AU"}
+  it 'should create a customer given a card token customer email' do
+    options = { number: '5520000000000000', expiry_month: '12', expiry_year: '2018', cvc: '123', name: 'Roland TestRobot', address_line1: '123 Fake Road', address_line2: '', address_city: 'Melbourne', address_postcode: '1223', address_state: 'Vic', address_country: 'AU' }
     @card = Pin::Card.create(options)
     Pin::Customer.create('nitza98@hotmail.com', @card['token'])['token'].should match(/^[a-z]{3}[_]/)
   end
 
-end
+end

data/spec/errors_spec.rb

@@ -1,82 +1,81 @@
 require 'spec_helper'
 
-describe "Errors", :vcr, class: Pin::PinError do
+describe 'Errors', :vcr, class: Pin::PinError do
   before(:each) do
-    Pin::Base.new(ENV["PIN_SECRET"], :test)
+    Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  it "should raise a 404 error when looking for a customer that doesn't exist" do
-    expect{Pin::Customer.find('foo')}.to raise_error(Pin::ResourceNotFound, "The requested resource could not be found.")
+  it 'should raise a 404 error when looking for a customer that doesn\'t exist' do
+    expect { Pin::Customer.find('foo') }.to raise_error(Pin::ResourceNotFound, 'The requested resource could not be found.')
   end
 
-  it "should raise a 422 error when trying to update missing a param" do
-    options = {email: "dNitza@gmail.com", card: {address_line1: "12345 Fake Street", expiry_month: "05", expiry_year: "2014", cvc: "123", address_city: "Melbourne", address_postcode: "1234", address_state: "VIC", address_country: "Australia"}}
-    expect{Pin::Customer.update('cus_sRtAD2Am-goZoLg1K-HVpA', options)}.to raise_error(Pin::InvalidResource, "invalid_resource: One or more parameters were missing or invalid")
+  it 'should raise a 422 error when trying to update missing a param' do
+    options = { email: 'dNitza@gmail.com', card: { address_line1: '12345 Fake Street', expiry_month: '05', expiry_year: '2014', cvc: '123', address_city: 'Melbourne', address_postcode: '1234', address_state: 'VIC', address_country: 'Australia' } }
+    expect { Pin::Customer.update('cus_sRtAD2Am-goZoLg1K-HVpA', options) }.to raise_error(Pin::InvalidResource, 'invalid_resource: One or more parameters were missing or invalid')
   end
 
-  it "should raise a 422 error when trying to make a payment with an expired card" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", card: {
-        number: "5520000000000000",
-        expiry_month: "05",
-        expiry_year: "2012",
-        cvc: "123",
-        name: "Roland Robot",
-        address_line1: "42 Sevenoaks St",
-        address_city: "Lathlain",
-        address_postcode: "6454",
-        address_state: "WA",
-        address_country: "Australia",
-      }}
-    expect{Pin::Charges.create(options)}.to raise_error(Pin::InvalidResource, "card_expiry_month_invalid: Card expiry month is expiredcard_expiry_year_invalid: Card expiry year is expired")
+  it 'should raise a 422 error when trying to make a payment with an expired card' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', card: {
+        number: '5520000000000000',
+        expiry_month: '05',
+        expiry_year: '2012',
+        cvc: '123',
+        name: 'Roland Robot',
+        address_line1: '42 Sevenoaks St',
+        address_city: 'Lathlain',
+        address_postcode: '6454',
+        address_state: 'WA',
+        address_country: 'Australia'
+      } }
+    expect { Pin::Charges.create(options) }.to raise_error(Pin::InvalidResource, 'card_expiry_month_invalid: Card expiry month is expiredcard_expiry_year_invalid: Card expiry year is expired')
   end
 
-  it "should raise a 400 error when trying to make a payment and a valid card gets declined" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", card: {
-        number: "5560000000000001",
-        expiry_month: "05",
-        expiry_year: "2018",
-        cvc: "123",
-        name: "Roland Robot",
-        address_line1: "42 Sevenoaks St",
-        address_city: "Lathlain",
-        address_postcode: "6454",
-        address_state: "WA",
-        address_country: "Australia",
-      }}
-    expect{Pin::Charges.create(options)}.to raise_error(Pin::ChargeError)
+  it 'should raise a 400 error when trying to make a payment and a valid card gets declined' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', card: {
+        number: '5560000000000001',
+        expiry_month: '05',
+        expiry_year: '2018',
+        cvc: '123',
+        name: 'Roland Robot',
+        address_line1: '42 Sevenoaks St',
+        address_city: 'Lathlain',
+        address_postcode: '6454',
+        address_state: 'WA',
+        address_country: 'Australia'
+      } }
+    expect { Pin::Charges.create(options) }.to raise_error(Pin::ChargeError)
   end
 
-  it "should raise a 422 error when trying to make a payment with an invalid card" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", card: {
-        number: "5520000000000099",
-        expiry_month: "05",
-        expiry_year: "2014",
-        cvc: "123",
-        name: "Roland Robot",
-        address_line1: "42 Sevenoaks St",
-        address_city: "Lathlain",
-        address_postcode: "6454",
-        address_state: "WA",
-        address_country: "Australia",
-      }}
-    expect{Pin::Charges.create(options)}.to raise_error(Pin::InvalidResource, "card_number_invalid: Card number is not a valid Visa or Mastercard number")
+  it 'should raise a 422 error when trying to make a payment with an invalid card' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', card: {
+        number: '5520000000000099',
+        expiry_month: '05',
+        expiry_year: '2014',
+        cvc: '123',
+        name: 'Roland Robot',
+        address_line1: '42 Sevenoaks St',
+        address_city: 'Lathlain',
+        address_postcode: '6454',
+        address_state: 'WA',
+        address_country: 'Australia'
+      } }
+    expect { Pin::Charges.create(options) }.to raise_error(Pin::InvalidResource, 'card_number_invalid: Card number is not a valid Visa or Mastercard number')
   end
 
-  it "Should raise a ResourceNotFound error when can't find customer" do
-    expect{Pin::Customer.charges("foo")}.to raise_error(Pin::ResourceNotFound, "The requested resource could not be found.")
+  it 'Should raise a ResourceNotFound error when can\'t find customer' do
+    expect { Pin::Customer.charges('foo') }.to raise_error(Pin::ResourceNotFound, 'The requested resource could not be found.')
   end
 
-
-  it "should raise a 422 error if no 2nd argument is given" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", customer_token: "cus_8ImkZdEZ6BXUA6NcJDZg_g"   }
+  it 'should raise a 422 error if no 2nd argument is given' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_8ImkZdEZ6BXUA6NcJDZg_g' }
     @charge = Pin::Charges.create(options)
-    expect{Pin::Refund.create(@charge['token'])}.to raise_error(Pin::InvalidResource, "invalid_resource: One or more parameters were missing or invalid. Amount: can't be blank")
+    expect { Pin::Refund.create(@charge['token']) }.to raise_error(Pin::InvalidResource, 'invalid_resource: One or more parameters were missing or invalid. Amount: can\'t be blank')
   end
 
-  xit "should raise a 422 error if a value of < 100 is given" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", customer_token: "cus_8ImkZdEZ6BXUA6NcJDZg_g"   }
+  xit 'should raise a 422 error if a value of < 100 is given' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_8ImkZdEZ6BXUA6NcJDZg_g' }
     @charge = Pin::Charges.create(options)
-    expect{Pin::Refund.create(@charge['token'], 90)}.to raise_error(Pin::InvalidResource, "One or more parameters were missing or invalid")
+    expect { Pin::Refund.create(@charge['token'], 90) }.to raise_error(Pin::InvalidResource, 'One or more parameters were missing or invalid')
   end
 
-end
+end

data/spec/refund_spec.rb

@@ -1,27 +1,26 @@
 require 'spec_helper'
 
-
-describe "Refund", :vcr, class: Pin::Refund do
+describe 'Refund', :vcr, class: Pin::Refund do
   before(:each) do
-    Pin::Base.new(ENV["PIN_SECRET"], :test)
+    Pin::Base.new(ENV['PIN_SECRET'], :test)
   end
 
-  it "should list all refunds made to a charge given a token" do
-    Pin::Refund.find('ch_S_3tP81Q9_sDngSv27gShQ')[0]['token'].should == "rf_O4lHrNzwXYmMmTbBq0ZLPw"
+  it 'should list all refunds made to a charge given a token' do
+    Pin::Refund.find('ch_S_3tP81Q9_sDngSv27gShQ')[0]['token'].should == 'rf_O4lHrNzwXYmMmTbBq0ZLPw'
   end
 
-  it "should return nothing if looking for a charge without a refund" do
+  it 'should return nothing if looking for a charge without a refund' do
     Pin::Refund.find('ch_rqPIWDK71YU46M4MAQHQKg').should == []
   end
 
-  it "should return a page of refunds given a page and token" do
-    Pin::Refund.find('ch_S_3tP81Q9_sDngSv27gShQ',1,true)[:response].should_not == []
+  it 'should return a page of refunds given a page and token' do
+    Pin::Refund.find('ch_S_3tP81Q9_sDngSv27gShQ', 1, true)[:response].should_not == []
   end
 
-  it "should create a refund for a given amount and charge" do
-    options = {email: "dNitza@gmail.com", description: "A new charge from testing Pin gem", amount: "400", currency: "AUD", ip_address: "127.0.0.1", customer_token: "cus_8ImkZdEZ6BXUA6NcJDZg_g"   }
+  it 'should create a refund for a given amount and charge' do
+    options = { email: 'dNitza@gmail.com', description: 'A new charge from testing Pin gem', amount: '400', currency: 'AUD', ip_address: '127.0.0.1', customer_token: 'cus_8ImkZdEZ6BXUA6NcJDZg_g' }
     @charge = Pin::Charges.create(options)
-    Pin::Refund.create(@charge['token'], "400")['amount'].should == 400
+    Pin::Refund.create(@charge['token'], '400')['amount'].should == 400
   end
 
-end
+end

data/spec/spec_helper.rb

@@ -7,11 +7,11 @@ require 'webmock/rspec'
 require 'capybara/rspec'
 require 'vcr'
 
-require "net/https"
-require "uri"
+require 'net/https'
+require 'uri'
 
 ## Uncomment to load in a .yml with your pin key
-# ENV.update YAML.load(File.read(File.expand_path("../test_data.yml", __FILE__)))
+# ENV.update YAML.load(File.read(File.expand_path('../test_data.yml', __FILE__)))
 
 # require pin_up gem
 require 'pin_up'
@@ -20,15 +20,17 @@ RSpec.configure do |config|
   config.include WebMock::API
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.around(:each, :vcr) do |example|
-    name = example.metadata[:full_description].split(/\s+/, 2).join("/").gsub(/[^\w\/]+/, "_")
-    # options = example.metadata.slice(:record, :match_requests_on).except(:example_group)
+    name = example
+          .metadata[:full_description]
+          .split(/\s+/, 2).join('/')
+          .gsub(/[^\w\/]+/, '_')
     VCR.use_cassette(name) { example.call }
   end
 end
 
 VCR.configure do |c|
-  c.cassette_library_dir = "spec/vcr"
+  c.cassette_library_dir = 'spec/vcr'
   c.hook_into :webmock
   c.allow_http_connections_when_no_cassette = true
-  c.filter_sensitive_data('<key>') {ENV["PIN_SECRET"]}
+  c.filter_sensitive_data('<key>') { ENV['PIN_SECRET'] }
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pin_up
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.5
 platform: ruby
 authors:
 - Daniel Nitsikopoulos
@@ -182,6 +182,8 @@ files:
 - ".idea/scopes/scope_settings.xml"
 - ".idea/vcs.xml"
 - ".idea/workspace.xml"
+- ".rubocop.yml"
+- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - Gemfile.lock