pilot 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7149e94a5acfe24a53a3ccc3fcf6a1720f97019
-  data.tar.gz: 6ada87b02c3f1c2d1ad15a5f13e661c8ea6f5601
+  metadata.gz: 083e9daa6e5b462f70042fd311183e9b59b7527b
+  data.tar.gz: 11162757ee19762349eb4a8be814739a80042dcb
 SHA512:
-  metadata.gz: 3a1271238efca13d6919691f26bee1b5c37a637cad4fc3343a28ccb01fd4cc52b7106e413438734e5434f198a4b014aaacd80bc3f2a5363e6c5d963465e523a6
-  data.tar.gz: 28b3a89a6a4f861b1b1186bfa56f9fbeada98de9768749bbe3fd5e52d35d0c18bf7c70c648980a2de32d45989a3841e4997fccc34c4c3ea1f3b520e1f7b8904e
+  metadata.gz: 9c4410c9652ac3870d0da149a9cf3399eed15cb8a8520b9592bb2a0ba6aa43d84c62fa5c7238a730d28197800e66729c994b14c5518be7ae08a7d301a9109811
+  data.tar.gz: 7fc21966e90776ca7e5570c742a20c03fb49f7bbe9bea6629c3a392d8c7bcb16db3c7102a63f84a7c8228b93db9fdc03321d06fb2639629af6995b662cce523c

data/lib/pilot.rb

@@ -5,7 +5,6 @@ require "pilot/build_manager"
 require "pilot/tester_manager"
 require "pilot/tester_importer"
 require "pilot/tester_exporter"
-require "pilot/package_builder"
 
 require "fastlane_core"
 require "spaceship"

data/lib/pilot/build_manager.rb

@@ -7,9 +7,11 @@ module Pilot
 
       Helper.log.info "Ready to upload new build to TestFlight (App: #{app.apple_id})...".green
 
-      package_path = PackageBuilder.new.generate(apple_id: app.apple_id,
-                                                 ipa_path: config[:ipa],
-                                             package_path: "/tmp")
+      plist = FastlaneCore::IpaFileAnalyser.fetch_info_plist_file(config[:ipa]) || {}
+      package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(app_id: app.apple_id,
+                                                                      ipa_path: config[:ipa],
+                                                                  package_path: "/tmp",
+                                                                      platform: plist["DTPlatformName"])
 
       transporter = FastlaneCore::ItunesTransporter.new(options[:username])
       result = transporter.upload(app.apple_id, package_path)
@@ -105,9 +107,19 @@ module Pilot
       # First, set the changelog (if necessary)
       uploaded_build.update_build_information!(whats_new: options[:changelog])
 
-      # Submit for internal beta testing
+      # Submit for review before external testflight is available
+      if options[:distribute_external]
+        uploaded_build.client.submit_testflight_build_for_review!(
+          app_id: uploaded_build.build_train.application.apple_id,
+          train: uploaded_build.build_train.version_string,
+          build_number: uploaded_build.build_version,
+          platform: uploaded_build.platform
+        )
+      end
+
+      # Submit for beta testing
       type = options[:distribute_external] ? 'external' : 'internal'
-      uploaded_build.build_train.update_testing_status!(true, type)
+      uploaded_build.build_train.update_testing_status!(true, type, uploaded_build)
       return true
     end
   end

data/lib/pilot/commands_generator.rb

@@ -1,5 +1,4 @@
 # rubocop:disable Metrics/MethodLength
-# rubocop:disable Metrics/AbcSize
 require "commander"
 require "pilot/options"
 require "fastlane_core"
@@ -25,9 +24,21 @@ module Pilot
       o
     end
 
-    def handle_email(config, args)
-      config[:email] ||= args.first
-      config[:email] ||= ask("Email address of the tester: ".yellow)
+    def handle_multiple(action, args, options)
+      mgr = Pilot::TesterManager.new
+      config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
+      args.push(ask("Email address of the tester: ".yellow)) if args.empty?
+      failures = []
+      args.each do |address|
+        config[:email] = address
+        begin
+          mgr.public_send(action, config)
+        rescue => ex
+          failures.push(address)
+          Helper.log.info "[#{address}]: #{ex}".red
+        end
+      end
+      raise "Some operations failed: #{failures}".red unless failures.empty?
     end
 
     def run
@@ -60,11 +71,9 @@ module Pilot
 
       command :add do |c|
         c.syntax = "pilot add"
-        c.description = "Adds a new external tester to a specific app (if given). This will also add an existing tester to an app."
+        c.description = "Adds new external tester(s) to a specific app (if given). This will also add an existing tester to an app."
         c.action do |args, options|
-          config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
-          handle_email(config, args)
-          Pilot::TesterManager.new.add_tester(config)
+          handle_multiple('add_tester', args, options)
         end
       end
 
@@ -79,21 +88,17 @@ module Pilot
 
       command :find do |c|
         c.syntax = "pilot find"
-        c.description = "Find a tester (internal or external) by their email address"
+        c.description = "Find tester(s) (internal or external) by their email address"
         c.action do |args, options|
-          config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
-          handle_email(config, args)
-          Pilot::TesterManager.new.find_tester(config)
+          handle_multiple('find_tester', args, options)
         end
       end
 
       command :remove do |c|
         c.syntax = "pilot remove"
-        c.description = "Remove an external tester by their email address"
+        c.description = "Remove external tester(s) by their email address"
         c.action do |args, options|
-          config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
-          handle_email(config, args)
-          Pilot::TesterManager.new.remove_tester(config)
+          handle_multiple('remove_tester', args, options)
         end
       end
 

data/lib/pilot/options.rb

@@ -80,7 +80,7 @@ module Pilot
                                      env_name: "PILOT_WAIT_PROCESSING_INTERVAL",
                                      description: "Interval in seconds to wait for iTunes Connect processing",
                                      default_value: 30,
-                                     is_string: false,
+                                     type: Integer,
                                      verify_block: proc do |value|
                                        raise "Please enter a valid positive number of seconds" unless value.to_i > 0
                                      end),

data/lib/pilot/tester_manager.rb

@@ -87,12 +87,12 @@ module Pilot
     def list(all_testers, title)
       rows = []
       all_testers.each do |tester|
-        rows << [tester.first_name, tester.last_name, tester.email, tester.devices.count]
+        rows << [tester.first_name, tester.last_name, tester.email, tester.devices.count, tester.full_version, tester.pretty_install_date]
       end
 
       puts Terminal::Table.new(
         title: title.green,
-        headings: ["First", "Last", "Email", "Devices"],
+        headings: ["First", "Last", "Email", "Devices", "Latest Version", "Latest Install Date"],
         rows: rows
       )
     end

data/lib/pilot/version.rb

@@ -1,4 +1,4 @@
 module Pilot
-  VERSION = "1.3.0"
+  VERSION = "1.4.0"
   DESCRIPTION = "The best way to manage your TestFlight testers and builds from your terminal"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pilot
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-05 00:00:00.000000000 Z
+date: 2016-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.31.0
+        version: 0.36.5
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.31.0
+        version: 0.36.5
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -36,7 +36,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.20.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -46,7 +46,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.20.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -215,13 +215,11 @@ files:
 - LICENSE
 - README.md
 - bin/pilot
-- lib/assets/XMLTemplate.xml.erb
 - lib/pilot.rb
 - lib/pilot/build_manager.rb
 - lib/pilot/commands_generator.rb
 - lib/pilot/manager.rb
 - lib/pilot/options.rb
-- lib/pilot/package_builder.rb
 - lib/pilot/tester_exporter.rb
 - lib/pilot/tester_importer.rb
 - lib/pilot/tester_manager.rb

data/lib/assets/XMLTemplate.xml.erb

@@ -1,12 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<package xmlns="http://apple.com/itunes/importer" version="software4.7">
-  <software_assets apple_id="<%= @data[:apple_id] %>">
-    <asset type="bundle">
-      <data_file>
-        <size><%= @data[:file_size] %></size>
-        <file_name><%= @data[:ipa_path] %></file_name>
-        <checksum type="md5"><%= @data[:md5] %></checksum>
-      </data_file>
-    </asset>
-  </software_assets>
-</package>

data/lib/pilot/package_builder.rb

@@ -1,43 +0,0 @@
-require "digest/md5"
-
-module Pilot
-  class PackageBuilder
-    METADATA_FILE_NAME = "metadata.xml"
-
-    attr_accessor :package_path
-
-    def generate(apple_id: nil, ipa_path: nil, package_path: nil)
-      self.package_path = File.join(package_path, "#{apple_id}.itmsp")
-      FileUtils.rm_rf self.package_path if File.directory?(self.package_path)
-      FileUtils.mkdir_p self.package_path
-
-      lib_path = Helper.gem_path("pilot")
-
-      ipa_path = copy_ipa(ipa_path)
-      @data = {
-        apple_id: apple_id,
-        file_size: File.size(ipa_path),
-        ipa_path: File.basename(ipa_path), # this is only the base name as the ipa is inside the package
-        md5: Digest::MD5.hexdigest(File.read(ipa_path))
-      }
-
-      xml_path = File.join(lib_path, "lib/assets/XMLTemplate.xml.erb")
-      xml = ERB.new(File.read(xml_path)).result(binding) # http://www.rrn.dk/rubys-erb-templating-system
-
-      File.write(File.join(self.package_path, METADATA_FILE_NAME), xml)
-      Helper.log.info "Wrote XML data to '#{self.package_path}'".green if $verbose
-
-      return package_path
-    end
-
-    private
-
-    def copy_ipa(ipa_path)
-      ipa_file_name = Digest::MD5.hexdigest(ipa_path)
-      resulting_path = File.join(self.package_path, "#{ipa_file_name}.ipa")
-      FileUtils.cp(ipa_path, resulting_path)
-
-      return resulting_path
-    end
-  end
-end