pilot 1.12.1 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aaa910e77be068138c6d8f405d62218e5b91bc01
-  data.tar.gz: 3e785fb3c652a2c97476c49eb212b36d0ff45c7f
+  metadata.gz: 804c9d896ba3e463dfaaa31b5fd0c9994eec340a
+  data.tar.gz: ce1afba1c0d21d6a24d1eb80e9f147156af30d35
 SHA512:
-  metadata.gz: aad4add20c950ab720e3436cfd5d292bf3c0bc65234b794d7664e391f51131d863de21bf77be77e086406be46bc104ed2722044b7273be9917b14a8fa87cc120
-  data.tar.gz: a492de6adb9e3a3bb53bc590c23f1176347ec78f62b8be4a97e68ff8b3482aad9e0fd89d86f63ad371c2581ac1b22b20c8a90398ec2feee2383711d8ff113638
+  metadata.gz: 508073bb23adeaaa18bde075010097a549d4c5053afdc9fcffd5bb5cfbd967ae959b70ab1165c43aceafa8da0474ab585f2ce9c6a4d3fda3090a316fc983f7b1
+  data.tar.gz: 924a064ba540ac1983d75b7606d6b6ff71d31be9083022918854057a4c2a424cbeb8a460f7e246d49800cc4e01d3157dc423f49ac358af9007c9a21943f0ac7e

data/README.md

@@ -258,7 +258,7 @@ If you run into any issues you can use the `verbose` mode to get a more detailed
 DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS="-t DAV" pilot ...
 ```
 
-If you are using `pilot` via the [fastlane action](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md#pilot), add the following to your `Fastfile`
+If you are using `pilot` via the [fastlane action](https://docs.fastlane.tools/actions#pilot), add the following to your `Fastfile`
 
 ```
 ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] = "-t DAV"

data/lib/pilot/build_manager.rb

@@ -3,13 +3,13 @@ module Pilot
     def upload(options)
       start(options)
 
+      options[:changelog] = self.class.truncate_changelog(options[:changelog]) if options[:changelog]
+
       UI.user_error!("No ipa file given") unless config[:ipa]
 
       UI.success("Ready to upload new build to TestFlight (App: #{app.apple_id})...")
 
-      plist = FastlaneCore::IpaFileAnalyser.fetch_info_plist_file(config[:ipa]) || {}
-      platform = plist["DTPlatformName"]
-      platform = "ios" if platform == "iphoneos" # via https://github.com/fastlane/spaceship/issues/247
+      platform = fetch_app_platform
       package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(app_id: app.apple_id,
                                                                       ipa_path: config[:ipa],
                                                                   package_path: "/tmp",
@@ -31,7 +31,7 @@ module Pilot
       end
 
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
-      uploaded_build = wait_for_processing_build(options) # this might take a while
+      uploaded_build = wait_for_processing_build(options, platform) # this might take a while
 
       distribute(options, uploaded_build)
     end
@@ -43,7 +43,8 @@ module Pilot
       end
 
       if build.nil?
-        builds = app.all_processing_builds + app.builds
+        platform = fetch_app_platform(required: false)
+        builds = app.all_processing_builds(platform: platform) + app.builds(platform: platform)
         # sort by upload_date
         builds.sort! { |a, b| a.upload_date <=> b.upload_date }
         build = builds.last
@@ -81,7 +82,8 @@ module Pilot
         config[:app_identifier] = UI.input("App Identifier: ")
       end
 
-      builds = app.all_processing_builds + app.builds
+      platform = fetch_app_platform(required: false)
+      builds = app.all_processing_builds(platform: platform) + app.builds(platform: platform)
       # sort by upload_date
       builds.sort! { |a, b| a.upload_date <=> b.upload_date }
       rows = builds.collect { |build| describe_build(build) }
@@ -93,6 +95,17 @@ module Pilot
       )
     end
 
+    def self.truncate_changelog(changelog)
+      max_changelog_length = 4000
+      if changelog && changelog.length > max_changelog_length
+        original_length = changelog.length
+        bottom_message = "..."
+        changelog = "#{changelog[0...max_changelog_length - bottom_message.length]}#{bottom_message}"
+        UI.important "Changelog has been truncated since it exceeds Apple's #{max_changelog_length} character limit. It currently contains #{original_length} characters."
+      end
+      return changelog
+    end
+
     private
 
     def describe_build(build)
@@ -111,7 +124,7 @@ module Pilot
 
     # This method will takes care of checking for the processing builds every few seconds
     # @return [Build] The build that we just uploaded
-    def wait_for_processing_build(options)
+    def wait_for_processing_build(options, platform)
       # the upload date of the new buid
       # we use it to identify the build
       start = Time.now
@@ -127,10 +140,10 @@ module Pilot
         #  build trains right away, and if we don't do this check, we will
         #  get break out of this loop and then generate an error later when we
         #  have a nil build
-        if app.build_trains.count == 0
+        if app.build_trains(platform: platform).count == 0
           UI.message("New application; waiting for build train to appear on iTunes Connect")
         else
-          builds = app.all_processing_builds
+          builds = app.all_processing_builds(platform: platform)
           break if builds.count == 0
           latest_build = builds.last
 
@@ -155,9 +168,7 @@ module Pilot
         # true -> false, where the second true is transient. This causes a spurious failure. Find build by build_version
         # and ensure it's not processing before proceeding - it had to have already been false before, to get out of the
         # previous loop.
-        build_train = app.build_trains[latest_build.train_version]
-        builds = build_train ? build_train.builds : []
-        full_build = builds.find do |b|
+        full_build = app.build_trains(platform: platform)[latest_build.train_version].builds.find do |b|
           b.build_version == latest_build.build_version
         end
 

data/lib/pilot/commands_generator.rb

@@ -42,6 +42,7 @@ module Pilot
     end
 
     def run
+      program :name, 'pilot'
       program :version, Pilot::VERSION
       program :description, Pilot::DESCRIPTION
       program :help, "Author", "Felix Krause <pilot@krausefx.com>"

data/lib/pilot/manager.rb

@@ -56,5 +56,16 @@ module Pilot
       UI.verbose("App identifier (#{result})")
       return result
     end
+
+    def fetch_app_platform(required: true)
+      result = config[:app_platform]
+      result ||= FastlaneCore::IpaFileAnalyser.fetch_app_platform(config[:ipa]) if config[:ipa]
+      if required
+        result ||= ask("Please enter the app's platform (appletvos, ios, osx): ")
+        UI.user_error!("App Platform must be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? result
+        UI.verbose("App Platform (#{result})")
+      end
+      return result
+    end
   end
 end

data/lib/pilot/options.rb

@@ -19,6 +19,14 @@ module Pilot
                                      description: "The bundle identifier of the app to upload or manage testers (optional)",
                                      optional: true,
                                      default_value: ENV["TESTFLIGHT_APP_IDENTITIFER"] || CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)),
+        FastlaneCore::ConfigItem.new(key: :app_platform,
+                                     short_option: "-m",
+                                     env_name: "PILOT_PLATFORM",
+                                     description: "The platform to use (optional)",
+                                     optional: true,
+                                     verify_block: proc do |value|
+                                       UI.user_error!("The platform can only be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? value
+                                     end),
         FastlaneCore::ConfigItem.new(key: :ipa,
                                      short_option: "-i",
                                      optional: true,

data/lib/pilot/version.rb

@@ -1,4 +1,4 @@
 module Pilot
-  VERSION = "1.12.1"
+  VERSION = "1.13.0"
   DESCRIPTION = "The best way to manage your TestFlight testers and builds from your terminal"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pilot
 version: !ruby/object:Gem::Version
-  version: 1.12.1
+  version: 1.13.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-17 00:00:00.000000000 Z
+date: 2016-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.56.0
+        version: 0.60.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.56.0
+        version: 0.60.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -36,7 +36,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.37.0
+        version: 0.39.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -46,7 +46,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.37.0
+        version: 0.39.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -102,16 +102,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement