pilot 0.1.7 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d7bcfccc7f27f53f0b4b1912f7c24df5a307e4f
-  data.tar.gz: 25d9921106e42ba76441e8b39bf8add81054dd86
+  metadata.gz: e2daff1b9410811bcefce3463946c8d5fd431f25
+  data.tar.gz: 2e7ed79218abbb987b039872a30e81df48f5c23b
 SHA512:
-  metadata.gz: 7017f2533d568ac56d8a6c100bcc64ea56f3bf875c2b785cab6e735a405da3395d064a70d6d8146d533e5b39421d103670d83dd6b2da1e6ba1c137ef5662e2f4
-  data.tar.gz: 09e0b6e551ffe3cd0c22870bf7efe38fe4a318694f664192a8853d1ba770d2e4aba36ff62e90cf765cf23d44bf5b1ed379c36335da1ec0dcdc2b1ab960994fdf
+  metadata.gz: 4289b34303f3c9fe3fb00b297b7963a27023bb1266a7fd6fd1a71d18a4acf79617faf8f6f376fbc67264ab0eb3dad882743d628ef794ba175496add1d773f355
+  data.tar.gz: 05acaec2f491065cb17f3a78b7678e3c76569b09a7355c85e3641701c2b85790d38fa59f04340cc7d1b61a2f02ff78e4d486bc964bea22841827e6e438d38b48

data/lib/pilot/build_manager.rb

@@ -5,7 +5,7 @@ module Pilot
 
       Helper.log.info "Ready to upload new build to TestFlight (App: #{app.apple_id})...".green
 
-      package_path = PackageBuilder.new.generate(apple_id: app.apple_id, 
+      package_path = PackageBuilder.new.generate(apple_id: app.apple_id,
                                                  ipa_path: config[:ipa],
                                              package_path: "/tmp")
 
@@ -32,8 +32,10 @@ module Pilot
         config[:app_identifier] = ask("App Identifier: ")
       end
 
-      rows = app.all_processing_builds.collect { |build| describe_build(build) }
-      rows = rows + app.builds.collect { |build| describe_build(build) }
+      builds = app.all_processing_builds + app.builds
+      # sort by upload_date
+      builds.sort! {|a, b| a.upload_date <=> b.upload_date }
+      rows = builds.collect { |build| describe_build(build) }
 
       puts Terminal::Table.new(
         title: "#{app.name} Builds".green,
@@ -43,60 +45,61 @@ module Pilot
     end
 
     private
-      def describe_build(build)
-        row = [build.train_version, 
-               build.build_version,
-               build.testing_status,
-               build.install_count,
-               build.session_count]
-
-        return row
+
+    def describe_build(build)
+      row = [build.train_version,
+             build.build_version,
+             build.testing_status,
+             build.install_count,
+             build.session_count]
+
+      return row
+    end
+
+    # This method will takes care of checking for the processing builds every few seconds
+    # @return [Integer] The upload date
+    def wait_for_processing_build
+      # the upload date of the new buid
+      # we use it to identify the build
+      upload_date = nil
+      loop do
+        Helper.log.info "Waiting for iTunes Connect to process the new build"
+        sleep 5
+        builds = app.all_processing_builds
+        break if builds.count == 0
+        upload_date = builds.last.upload_date
       end
 
-      # This method will takes care of checking for the processing builds every few seconds
-      # @return [Integer] The upload date
-      def wait_for_processing_build
-        # the upload date of the new buid
-        # we use it to identify the build
-        upload_date = nil
-        loop do
-          Helper.log.info "Waiting for iTunes Connect to process the new build"
-          sleep 5
-          builds = app.all_processing_builds
-          break if builds.count == 0
-          upload_date = builds.last.upload_date
+      if upload_date
+        Helper.log.info "Build successfully processed by iTunes Connect".green
+        return upload_date
+      else
+        raise "Error: Seems like iTunes Connect didn't properly pre-process the binary".red
+      end
+    end
+
+    def distribute_build(upload_date)
+      Helper.log.info "Distributing new build to testers"
+
+      # We try this multiple times, as it sometimes takes some time
+      # to process the binary
+      10.times do
+        current_build = app.builds.find do |build|
+          build.upload_date == upload_date
         end
 
-        if upload_date
-          Helper.log.info "Build successfully processed by iTunes Connect".green
-          return upload_date
+        if current_build
+          current_build.build_train.update_testing_status!(true)
+          return true
         else
-          raise "Error: Seems like iTunes Connect didn't properly pre-process the binary".red
+          Helper.log.info "Binary is not yet available online..."
+          sleep 5
         end
       end
 
-      def distribute_build(upload_date)
-        Helper.log.info "Distributing new build to testers"
-        
-        # We try this multiple times, as it sometimes takes some time
-        # to process the binary
-        10.times do
-          current_build = app.builds.find do |build|
-            build.upload_date == upload_date
-          end
-
-          if current_build
-            current_build.build_train.update_testing_status!(true)
-            return true
-          else
-            Helper.log.info "Binary is not yet available online..."
-            sleep 5
-          end
-        end
-
-        Helper.log.error "Build is not visible on iTunes Connect any more - couldn't distribute to testers.".red
-        Helper.log.error "You can run `pilot --skip_submission` to only upload the binary without distributing.".red
-        raise "Error distributing the binary"
-      end
+      Helper.log.error "Build is not visible on iTunes Connect any more - couldn't distribute to testers.".red
+      Helper.log.error "You can run `pilot --skip_submission` to only upload the binary without distributing.".red
+      raise "Error distributing the binary"
+    end
   end
-end
+end

data/lib/pilot/commands_generator.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Metrics/MethodLength
+# rubocop:disable Metrics/AbcSize
 require "commander"
 require "pilot/options"
 require "fastlane_core"
@@ -23,8 +25,8 @@ module Pilot
       o
     end
 
-    def handle_email(config, _args)
-      config[:email] ||= _args.first
+    def handle_email(config, args)
+      config[:email] ||= args.first
       config[:email] ||= ask("Email address of the tester: ".yellow)
     end
 
@@ -41,7 +43,7 @@ module Pilot
       command :upload do |c|
         c.syntax = "pilot upload"
         c.description = "Uploads a new binary to Apple TestFlight"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
           Pilot::BuildManager.new.upload(config)
         end
@@ -50,7 +52,7 @@ module Pilot
       command :builds do |c|
         c.syntax = "pilot builds"
         c.description = "Lists all builds for given application"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
           Pilot::BuildManager.new.list(config)
         end
@@ -59,9 +61,9 @@ module Pilot
       command :add do |c|
         c.syntax = "pilot add"
         c.description = "Adds a new external tester to a specific app (if given). This will also add an existing tester to an app."
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
-          handle_email(config, _args)
+          handle_email(config, args)
           Pilot::TesterManager.new.add_tester(config)
         end
       end
@@ -69,7 +71,7 @@ module Pilot
       command :list do |c|
         c.syntax = "pilot list"
         c.description = "Lists all registered testers, both internal and external"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
           Pilot::TesterManager.new.list_testers(config)
         end
@@ -78,9 +80,9 @@ module Pilot
       command :find do |c|
         c.syntax = "pilot find"
         c.description = "Find a tester (internal or external) by their email address"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
-          handle_email(config, _args)
+          handle_email(config, args)
           Pilot::TesterManager.new.find_tester(config)
         end
       end
@@ -88,9 +90,9 @@ module Pilot
       command :remove do |c|
         c.syntax = "pilot remove"
         c.description = "Remove an external tester by their email address"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
-          handle_email(config, _args)
+          handle_email(config, args)
           Pilot::TesterManager.new.remove_tester(config)
         end
       end
@@ -98,7 +100,7 @@ module Pilot
       command :export do |c|
         c.syntax = "pilot export"
         c.description = "Exports all external testers to a CSV file"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
           Pilot::TesterExporter.new.export_testers(config)
         end
@@ -107,7 +109,7 @@ module Pilot
       command :import do |c|
         c.syntax = "pilot import"
         c.description = "Create external testers from a CSV file"
-        c.action do |_args, options|
+        c.action do |args, options|
           config = FastlaneCore::Configuration.create(Pilot::Options.available_options, convert_options(options))
           Pilot::TesterImporter.new.import_testers(config)
         end
@@ -119,3 +121,5 @@ module Pilot
     end
   end
 end
+# rubocop:enable Metrics/MethodLength
+# rubocop:enable Metrics/AbcSize

data/lib/pilot/manager.rb

@@ -20,16 +20,15 @@ module Pilot
     def app
       @apple_id ||= fetch_app_id
 
-      unless (@app ||= Spaceship::Application.find(@apple_id))
+      @app ||= Spaceship::Application.find(@apple_id)
+      unless @app
         raise "Could not find app with #{(config[:apple_id] || config[:app_identifier])}"
       end
       return @app
     end
 
-    # Access the current configuration 
-    def config
-      @config
-    end
+    # Access the current configuration
+    attr_reader :config
 
     # Config Related
     ################
@@ -56,4 +55,4 @@ module Pilot
       return result
     end
   end
-end
+end

data/lib/pilot/options.rb

@@ -4,7 +4,7 @@ require "credentials_manager"
 module Pilot
   class Options
     def self.available_options
-      @@options ||= [
+      @options ||= [
         FastlaneCore::ConfigItem.new(key: :username,
                                      short_option: "-u",
                                      env_name: "PILOT_USERNAME",
@@ -16,8 +16,8 @@ module Pilot
                                      description: "Path to the ipa file to upload",
                                      default_value: Dir["*.ipa"].first,
                                      verify_block: proc do |value|
-                                       fail "Could not find ipa file at path '#{value}'" unless File.exist? value
-                                       fail "'#{value}' doesn't seem to be an ipa file" unless value.end_with? ".ipa"
+                                       raise "Could not find ipa file at path '#{value}'" unless File.exist? value
+                                       raise "'#{value}' doesn't seem to be an ipa file" unless value.end_with? ".ipa"
                                      end),
         FastlaneCore::ConfigItem.new(key: :skip_submission,
                                      short_option: "-s",
@@ -30,47 +30,37 @@ module Pilot
                                      env_name: "PILOT_APP_IDENTIFIER",
                                      description: "The bundle identifier of the app to upload or manage testers (optional)",
                                      optional: true,
-                                     default_value: ENV["TESTFLIGHT_APP_IDENTITIFER"] || CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier),
-                                     verify_block: proc do |_value|
-                                     end),
+                                     default_value: ENV["TESTFLIGHT_APP_IDENTITIFER"] || CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)),
         FastlaneCore::ConfigItem.new(key: :apple_id,
                                      short_option: "-p",
                                      env_name: "PILOT_APPLE_ID",
                                      description: "The unique App ID provided by iTunes Connect",
                                      optional: true,
-                                     default_value: ENV["TESTFLIGHT_APPLE_ID"],
-                                     verify_block: proc do |_value|
-                                     end),
+                                     default_value: ENV["TESTFLIGHT_APPLE_ID"]),
         FastlaneCore::ConfigItem.new(key: :first_name,
                                      short_option: "-f",
                                      env_name: "PILOT_TESTER_FIRST_NAME",
                                      description: "The tester's first name",
-                                     optional: true,
-                                     verify_block: proc do |_value|
-                                     end),
+                                     optional: true),
         FastlaneCore::ConfigItem.new(key: :last_name,
                                      short_option: "-l",
                                      env_name: "PILOT_TESTER_LAST_NAME",
                                      description: "The tester's last name",
-                                     optional: true,
-                                     verify_block: proc do |_value|
-                                     end),
+                                     optional: true),
         FastlaneCore::ConfigItem.new(key: :email,
                                      short_option: "-e",
                                      env_name: "PILOT_TESTER_EMAIL",
                                      description: "The tester's email",
                                      optional: true,
-                                     verify_block: proc do |_value|
-                                        raise "Please pass a valid email address" unless _value.include?"@"
+                                     verify_block: proc do |value|
+                                       raise "Please pass a valid email address" unless value.include? "@"
                                      end),
         FastlaneCore::ConfigItem.new(key: :testers_file_path,
                                      short_option: "-c",
                                      env_name: "PILOT_TESTERS_FILE",
                                      description: "Path to a CSV file of testers",
                                      default_value: "./testers.csv",
-                                     optional: true,
-                                     verify_block: proc do |_value|
-                                     end)
+                                     optional: true)
 
       ]
     end

data/lib/pilot/package_builder.rb

@@ -8,7 +8,7 @@ module Pilot
 
     def generate(apple_id: nil, ipa_path: nil, package_path: nil)
       self.package_path = File.join(package_path, "#{apple_id}.itmsp")
-      FileUtils.rm_rf self.package_path rescue nil
+      FileUtils.rm_rf self.package_path if File.directory?(self.package_path)
       FileUtils.mkdir_p self.package_path
 
       lib_path = Helper.gem_path("pilot")
@@ -22,8 +22,8 @@ module Pilot
       }
 
       xml_path = File.join(lib_path, "lib/assets/XMLTemplate.xml.erb")
-      xml = ERB.new(File.read(xml_path)).result(binding) # http://www.rrn.dk/rubys-erb-templating-system  
-      
+      xml = ERB.new(File.read(xml_path)).result(binding) # http://www.rrn.dk/rubys-erb-templating-system
+
       File.write(File.join(self.package_path, METADATA_FILE_NAME), xml)
       Helper.log.info "Wrote XML data to '#{self.package_path}'".green if $verbose
 
@@ -31,12 +31,13 @@ module Pilot
     end
 
     private
-      def copy_ipa(ipa_path)
-        ipa_file_name = Digest::MD5.hexdigest(ipa_path)
-        resulting_path = File.join(self.package_path, "#{ipa_file_name}.ipa")
-        FileUtils.cp(ipa_path, resulting_path)
 
-        return resulting_path
-      end
+    def copy_ipa(ipa_path)
+      ipa_file_name = Digest::MD5.hexdigest(ipa_path)
+      resulting_path = File.join(self.package_path, "#{ipa_file_name}.ipa")
+      FileUtils.cp(ipa_path, resulting_path)
+
+      return resulting_path
+    end
   end
-end
+end

data/lib/pilot/tester_exporter.rb

@@ -1,9 +1,9 @@
 require "fastlane_core"
+require "pilot/tester_util"
 
 module Pilot
   class TesterExporter < Manager
     def export_testers(options)
-
       raise "Export file path is required".red unless options[:testers_file_path]
 
       start(options)
@@ -14,11 +14,9 @@ module Pilot
       file = config[:testers_file_path]
 
       CSV.open(file, "w") do |csv|
-
         csv << ['First', 'Last', 'Email', 'Devices', 'Groups', 'Installed Version', 'Install Date']
 
         testers.each do |tester|
-
           groups = tester.raw_data.get("groups")
 
           group_names = ""
@@ -27,12 +25,14 @@ module Pilot
             group_names = names.join(';')
           end
 
-          csv << [tester.first_name, tester.last_name, tester.email, tester.devices.count, group_names]
+          install_version = tester.full_version || ""
+          pretty_date = tester.pretty_install_date || ""
+
+          csv << [tester.first_name, tester.last_name, tester.email, tester.devices.count, group_names, install_version, pretty_date]
         end
 
         Helper.log.info "Successfully exported CSV to #{file}".green
       end
-
     end
   end
 end

data/lib/pilot/tester_importer.rb

@@ -20,7 +20,7 @@ module Pilot
           next
         end
 
-        first_name, last_name, email = row        
+        first_name, last_name, email = row
 
         unless email
           Helper.log.error "No email found in row: #{row}".red
@@ -35,10 +35,9 @@ module Pilot
         begin
           tester_manager.add_tester(config)
           imported_tester_count += 1
-        rescue => ex
+        rescue
           # do nothing, move on to the next row
         end
-
       end
 
       Helper.log.info "Successfully imported #{imported_tester_count} testers from #{file}".green

data/lib/pilot/tester_manager.rb

@@ -1,4 +1,5 @@
 require "fastlane_core"
+require "pilot/tester_util"
 
 module Pilot
   class TesterManager < Manager
@@ -17,7 +18,7 @@ module Pilot
                                                               last_name: config[:last_name])
           Helper.log.info "Successfully invited tester: #{tester.email}".green
         end
-        
+
         app_filter = (config[:apple_id] || config[:app_identifier])
         if app_filter
           begin
@@ -43,14 +44,14 @@ module Pilot
       tester ||= Spaceship::Tunes::Tester::External.find(config[:email])
 
       raise "Tester #{config[:email]} not found".red unless tester
-      
+
       describe_tester(tester)
       return tester
     end
 
     def remove_tester(options)
       start(options)
-      
+
       tester = Spaceship::Tunes::Tester::External.find(config[:email])
       tester ||= Spaceship::Tunes::Tester::Internal.find(config[:email])
 
@@ -73,64 +74,60 @@ module Pilot
 
     private
 
-      def list(all_testers, title)
-        rows = []
-        all_testers.each do |tester|
-          rows << [tester.first_name, tester.last_name, tester.email, tester.devices.count]
-        end
-
-        puts Terminal::Table.new(
-          title: title.green,
-          headings: ["First", "Last", "Email", "Devices"],
-          rows: rows
-        )
+    def list(all_testers, title)
+      rows = []
+      all_testers.each do |tester|
+        rows << [tester.first_name, tester.last_name, tester.email, tester.devices.count]
       end
 
-      # Print out all the details of a specific tester
-      def describe_tester(tester)
-        return unless tester
+      puts Terminal::Table.new(
+        title: title.green,
+        headings: ["First", "Last", "Email", "Devices"],
+        rows: rows
+      )
+    end
 
-        rows = []
+    # Print out all the details of a specific tester
+    def describe_tester(tester)
+      return unless tester
 
-        rows << ["First name", tester.first_name]
-        rows << ["Last name", tester.last_name]
-        rows << ["Email", tester.email]
+      rows = []
 
-        groups = tester.raw_data.get("groups")
+      rows << ["First name", tester.first_name]
+      rows << ["Last name", tester.last_name]
+      rows << ["Email", tester.email]
 
-        if groups && groups.length > 0
-          group_names = groups.map { |group| group["name"]["value"] }
-          rows << ["Groups", group_names.join(', ')]
-        end
+      groups = tester.raw_data.get("groups")
 
-        if tester.latest_install_date
-          latest_installed_version = tester.latest_installed_version_number
-          latest_installed_short_version = tester.latest_installed_build_number
-          pretty_date = Time.at((tester.latest_install_date / 1000)).strftime("%m/%d/%y %H:%M")
+      if groups && groups.length > 0
+        group_names = groups.map { |group| group["name"]["value"] }
+        rows << ["Groups", group_names.join(', ')]
+      end
 
-          rows << ["Latest Version", "#{latest_installed_version} (#{latest_installed_short_version})"]
-          rows << ["Latest Install Date", pretty_date]
-        end
+      if tester.latest_install_date
+        rows << ["Latest Version", tester.full_version]
+        rows << ["Latest Install Date", tester.pretty_install_date]
+      end
 
-        if tester.devices.length == 0
-          rows << ["Devices", "No devices"]
-        else
-          rows << ["#{tester.devices.count} Devices", ""]
-          tester.devices.each do |device|
-            current = "\u2022 #{device['model']}, iOS #{device['osVersion']}"
-
-            if rows.last[1].length == 0
-              rows.last[1] = current
-            else
-              rows << ["", current]
-            end
+      if tester.devices.length == 0
+        rows << ["Devices", "No devices"]
+      else
+        rows << ["#{tester.devices.count} Devices", ""]
+        tester.devices.each do |device|
+          current = "\u2022 #{device['model']}, iOS #{device['osVersion']}"
+
+          if rows.last[1].length == 0
+            rows.last[1] = current
+          else
+            rows << ["", current]
           end
         end
-
-        puts Terminal::Table.new(
-          title: tester.email.green,
-          rows: rows
-        )
       end
+
+      puts Terminal::Table.new(
+        title: tester.email.green,
+        rows: rows
+      )
+    end
   end
 end

data/lib/pilot/tester_util.rb

@@ -0,0 +1,23 @@
+require "spaceship/base"
+require "spaceship/tunes/tunes_base"
+require "spaceship/tunes/tester"
+
+module Spaceship
+  module Tunes
+    # monkey patched
+    # move this to spaceship
+    class Tester < TunesBase
+      def full_version
+        return nil unless latest_install_date
+        latest_installed_version = latest_installed_version_number
+        latest_installed_short_version = latest_installed_build_number
+        "#{latest_installed_version} (#{latest_installed_short_version})"
+      end
+
+      def pretty_install_date
+        return nil unless latest_install_date
+        Time.at((latest_install_date / 1000)).strftime("%m/%d/%y %H:%M")
+      end
+    end
+  end
+end

data/lib/pilot/version.rb

@@ -1,4 +1,4 @@
 module Pilot
-  VERSION = "0.1.7"
+  VERSION = "0.2.0"
   DESCRIPTION = "The best way to manage your TestFlight testers and builds from your terminal"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pilot
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.2.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-07 00:00:00.000000000 Z
+date: 2015-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.16.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: 0.16.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -191,6 +191,7 @@ files:
 - lib/pilot/tester_exporter.rb
 - lib/pilot/tester_importer.rb
 - lib/pilot/tester_manager.rb
+- lib/pilot/tester_util.rb
 - lib/pilot/version.rb
 homepage: https://fastlane.tools
 licenses:
@@ -212,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: The best way to manage your TestFlight testers and builds from your terminal