pil 0.2.0 → 0.3.0

data/README.md

@@ -47,19 +47,23 @@ You can also instantiate PIL:
     pil = Pil.new
     pil.include?( 'areallylongpasswordwithathreeatheend3' )   # => false
     pil.exclude?( 'areallylongpasswordwithathreeatheend3' )   # => true
-    
+
 ## With Rails
 
 In your User model:
 
-    validates_with PasswordInclusionValidator
+    validates :password, uncommon: true
+
+If you prefer your own error message (ie: for localization):
+
+    validates :password, uncommon: { error_message: "Password is too common." }
 
-In /app/validators/ create a new class called PasswordInclusionValidator:
+In /app/validators/ create a new class called UncommonValidator:
 
-    class PasswordInclusionValidator < ActiveModel::Validator
-      def validate(record)
-        if Pil.include?(record.password)
-          record.errors[:password] << "Password is commonly used. Please choose a different password."
+    class UncommonValidator < ActiveModel::EachValidator
+      def validate_each(object, attribute, value)
+        if Pil.include?(value)
+          object.errors[attribute] << (options[:error_message] || "Password is commonly used. Please choose a different password.")
         end
       end
     end

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.3.0

data/lib/pil/password_list.rb

@@ -10,16 +10,10 @@ class Pil::PasswordList
   # ------------------------------ Instance Methods ------------------------------
 
   def_delegator :@passwords, :count, :count
+  def_delegator :@passwords, :include?, :include?
 
   def initialize(datafile = DEFAULT_PASSWORD_FILE)
-    @datafile = datafile
-    @passwords = Set.new
-
-    load_passwords
-  end
-
-  def include?(password)
-    @passwords.include?(password)
+    load_passwords(datafile)
   end
 
   def exclude?(password)
@@ -28,10 +22,8 @@ class Pil::PasswordList
 
   private
 
-    def load_passwords
-      raise "Password list cannot be nil" if @datafile.nil?
-
-      file = File.open(@datafile)
-      file.each_line { |line| @passwords << line.chop }
+    def load_passwords(datafile)
+      raise "Password list cannot be nil" if datafile.nil?
+      File.open(datafile) { |file| @passwords = Set.new(file.readlines.each(&:chop!)) }
     end
 end

data/pil.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "pil"
-  s.version = "0.2.0"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Chris Cummer"]
-  s.date = "2012-12-26"
+  s.date = "2012-12-28"
   s.description = "Checks a given plaintext password against an inclusion list of common passwords. Returns TRUE if the user's password is in the list; FALSE if it isn't."
   s.email = "chriscummer@me.com"
   s.extra_rdoc_files = [

data/test/test_password_list.rb

@@ -13,7 +13,8 @@ class PasswordListTest < Test::Unit::TestCase
   end
 
   def test_passwords
-    assert_instance_of(Set, @instance.passwords)
+    assert_respond_to(@instance.passwords, :count)
+    assert_respond_to(@instance.passwords, :include?)
   end
 
   def test_include?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pil
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-26 00:00:00.000000000 Z
+date: 2012-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: shoulda
@@ -130,7 +130,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2670622847389292681
+      hash: -767269175845970462
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: