piko_transaction 3.0.0 → 3.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fb92d89b2652b73d375601b371f4e455bb288a2
-  data.tar.gz: 2aedbe5d5503fd358d82bc407a8f5f572d14c066
+  metadata.gz: 1576d38fce4625c421d0285b2448092bce7eb73e
+  data.tar.gz: 1501f8f4072e9cf41b562876c70ffbadffc403d3
 SHA512:
-  metadata.gz: d007f9c884d25c6028e8e790239be5d2b2886970963d9df4b91cab56e0927dd4cab49f628d20cfb8675b988a92e457e5aa387b96f9be42ee3976f6745628f6af
-  data.tar.gz: 29a8c4244b32c2e9de4f03b724116bee83472b5bc2630391bd74e82eef1128a2f76f8393d365eecd588983c4cb9500e22cbfc43dd624470fe8ab3636e656a6b4
+  metadata.gz: 66673e9a68a8aea8aaf476b739962622a5aaa835c7fe96f9e67eb343117ab7cca64b5fa64642bea2e4005ddda44c1e18bf636cbfbbd0059af1290df43abf12bc
+  data.tar.gz: b4e7b4296c20c517f707b53c19a9b818216f69911db52e506a139d799207f972d1aad8b11d42b8c7feefc1c708d76e0017a66c52a37fbe91614783d8d599ae05

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 3.0.2 - 3.0.5 (2017.07.04)
+
+* fix travis build
+
+### 3.0.1 (2017.07.04)
+
+* extract Command class to reuse some code
+
 ### 3.0.0 (2017.06.13)
 
 * allow to register success and failure observers in commands

data/lib/piko_transaction/command.rb

@@ -0,0 +1,83 @@
+# frozen_string_literal: true
+
+# Copyright (C) 2017 Szymon Kopciewski
+#
+# This file is part of PikoTransaction.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+require "piko_transaction/logger"
+
+module PikoTransaction
+  class Command
+    include Logger
+
+    def initialize()
+      @name = nil
+      @success_callbacks = []
+      @failure_callbacks = []
+      @done = false
+    end
+
+    def to_s
+      format "[%s]", @name || self.class.name.split("::").last
+    end
+
+    def name(value)
+      @name = value.to_s
+    end
+
+    def add_success_callback(callback)
+      @success_callbacks << callback if callback.respond_to?(:call)
+      logger.debug { format "%s Registered success callbacks: %i", to_s, @success_callbacks.count }
+    end
+
+    def add_failure_callback(callback)
+      @failure_callbacks << callback if callback.respond_to?(:call)
+      logger.debug { format "%s Registered failure callbacks: %i", to_s, @failure_callbacks.count }
+    end
+
+    private
+
+    def terminate(msg)
+      logger.warn { format "%s %s", to_s, msg }
+      false
+    end
+
+    def mark_as_done
+      @done = true
+    end
+
+    def mark_as_undone
+      @done = false
+      true
+    end
+
+    def can_do?
+      !@done
+    end
+
+    def can_undo?
+      @done
+    end
+
+    def call_failure_callbacks
+      @failure_callbacks.each_with_index do |callback, i|
+        logger.debug { format "%s Run %i failure callback", to_s, i + 1 }
+        callback.call
+      end
+      false
+    end
+  end
+end

data/lib/piko_transaction/custom_command.rb

@@ -17,19 +17,14 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-require "piko_transaction/logger"
+require "piko_transaction/command"
 
 module PikoTransaction
-  class CustomCommand
-    include Logger
-
+  class CustomCommand < Command
     def initialize(do_action = nil, undo_action = nil, &alternative_do_action)
-      @name = nil
+      super()
       @do_action = choose_do_action(do_action, alternative_do_action)
       @undo_action = undo_action
-      @success_callbacks = []
-      @failure_callbacks = []
-      @done = false
     end
 
     def do
@@ -40,52 +35,12 @@ module PikoTransaction
       execute_undo_action
     end
 
-    def to_s
-      format "[%s]", @name || "custom_cmd"
-    end
-
-    def name(value)
-      @name = value.to_s
-    end
-
-    def add_success_callback(callback)
-      @success_callbacks << callback if callback.respond_to?(:call)
-      logger.debug { format "%s Registered success callbacks: %i", to_s, @success_callbacks.count }
-    end
-
-    def add_failure_callback(callback)
-      @failure_callbacks << callback if callback.respond_to?(:call)
-      logger.debug { format "%s Registered failure callbacks: %i", to_s, @failure_callbacks.count }
-    end
-
     private
 
     def choose_do_action(action, alternative_action)
       action || alternative_action
     end
 
-    def terminate(msg)
-      logger.warn { format "%s %s", to_s, msg }
-      false
-    end
-
-    def mark_as_done
-      @done = true
-    end
-
-    def mark_as_undone
-      @done = false
-      true
-    end
-
-    def can_do?
-      !@done
-    end
-
-    def can_undo?
-      @done
-    end
-
     def execute_do_action
       return terminate("Command already done") unless can_do?
       return terminate("'Do' action do not responds to :call") unless \
@@ -134,13 +89,5 @@ module PikoTransaction
       end
       true
     end
-
-    def call_failure_callbacks
-      @failure_callbacks.each_with_index do |callback, i|
-        logger.debug { format "%s Run %i failure callback", to_s, i + 1 }
-        callback.call
-      end
-      false
-    end
   end
 end

data/lib/piko_transaction/delete_command.rb

@@ -17,21 +17,16 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-require "piko_transaction/logger"
+require "piko_transaction/command"
 
 module PikoTransaction
-  class DeleteCommand
-    include Logger
-
+  class DeleteCommand < Command
     def initialize(document_id, collection, &success_action)
-      @name = nil
+      super()
       @document_id = document_id
       @collection = collection
       @success_action = success_action
-      @success_callbacks = []
-      @failure_callbacks = []
       @deleted_doc = nil
-      @done = false
     end
 
     def do
@@ -43,48 +38,8 @@ module PikoTransaction
       store_document
     end
 
-    def to_s
-      format "[%s]", @name || "delete_cmd"
-    end
-
-    def name(value)
-      @name = value.to_s
-    end
-
-    def add_success_callback(callback)
-      @success_callbacks << callback if callback.respond_to?(:call)
-      logger.debug { format "%s Registered success callbacks: %s", to_s, @success_callbacks.count }
-    end
-
-    def add_failure_callback(callback)
-      @failure_callbacks << callback if callback.respond_to?(:call)
-      logger.debug { format "%s Registered failure callbacks: %s", to_s, @failure_callbacks.count }
-    end
-
     private
 
-    def terminate(msg)
-      logger.warn { format "%s %s", to_s, msg }
-      false
-    end
-
-    def mark_as_done
-      @done = true
-    end
-
-    def mark_as_undone
-      @done = false
-      true
-    end
-
-    def can_do?
-      !@done
-    end
-
-    def can_undo?
-      @done
-    end
-
     def remove_document
       return terminate("Command already done") unless can_do?
       return terminate("Error during deleting document") unless delete_document_from_collection
@@ -116,13 +71,5 @@ module PikoTransaction
       end
       true
     end
-
-    def call_failure_callbacks
-      @failure_callbacks.each_with_index do |callback, i|
-        logger.debug { format "%s Run %i failure callback", to_s, i + 1 }
-        callback.call
-      end
-      false
-    end
   end
 end

data/lib/piko_transaction/insert_command.rb

@@ -17,21 +17,16 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-require "piko_transaction/logger"
+require "piko_transaction/command"
 
 module PikoTransaction
-  class InsertCommand
-    include Logger
-
+  class InsertCommand < Command
     def initialize(document, collection, &success_action)
-      @name = nil
+      super()
       @document = document
       @collection = collection
       @success_action = success_action
-      @success_callbacks = []
-      @failure_callbacks = []
       @inserted_id = nil
-      @done = false
     end
 
     def do
@@ -43,48 +38,8 @@ module PikoTransaction
       remove_document
     end
 
-    def to_s
-      format "[%s]", @name || "insert_cmd"
-    end
-
-    def name(value)
-      @name = value.to_s
-    end
-
-    def add_success_callback(callback)
-      @success_callbacks << callback if callback.respond_to?(:call)
-      logger.debug { format "%s Registered success callbacks: %i", to_s, @success_callbacks.count }
-    end
-
-    def add_failure_callback(callback)
-      @failure_callbacks << callback if callback.respond_to?(:call)
-      logger.debug { format "%s Registered failure callbacks: %i", to_s, @failure_callbacks.count }
-    end
-
     private
 
-    def terminate(msg)
-      logger.warn { format "%s %s", to_s, msg }
-      false
-    end
-
-    def mark_as_done
-      @done = true
-    end
-
-    def mark_as_undone
-      @done = false
-      true
-    end
-
-    def can_do?
-      !@done
-    end
-
-    def can_undo?
-      @done
-    end
-
     def store_document
       return terminate("Command already done") unless can_do?
       return terminate("Error during inserting document") unless insert_document_into_collection
@@ -116,13 +71,5 @@ module PikoTransaction
       end
       true
     end
-
-    def call_failure_callbacks
-      @failure_callbacks.each_with_index do |callback, i|
-        logger.debug { format "%s Run %i failure callback", to_s, i + 1 }
-        callback.call
-      end
-      false
-    end
   end
 end

data/lib/piko_transaction/version.rb

@@ -18,5 +18,5 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 module PikoTransaction
-  VERSION = "3.0.0"
+  VERSION = "3.0.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: piko_transaction
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.5
 platform: ruby
 authors:
 - Szymon Kopciewski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-13 00:00:00.000000000 Z
+date: 2017-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logger2r
@@ -120,6 +120,7 @@ files:
 - LICENSE
 - README.md
 - lib/piko_transaction.rb
+- lib/piko_transaction/command.rb
 - lib/piko_transaction/custom_command.rb
 - lib/piko_transaction/delete_command.rb
 - lib/piko_transaction/insert_command.rb
@@ -147,7 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Abstraction layer for storage