pii_safe_schema 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a3fe6f6dc02bc520f523874f6111cb00dc9201687f0b7f668dc39e587080bda
-  data.tar.gz: c2f2bf99f36d65c806e9b74af88ab55a8c77291e5bd61883a36bd2b2bf2d6b1b
+  metadata.gz: 37742fbd9ebda37050c8e0b851cbfaba6a8a6eedc70283e46a393bcdc2baf1c0
+  data.tar.gz: 285e70b4e2aabf1a089471044c6495f685fa9b187cbc5514a42e7d3eafbd8b4b
 SHA512:
-  metadata.gz: 539795ee77529477a46a52df234f0474f5d774f2ded25537520f20d023af8539c5643f3c859e3df56e3181591cea9b854b23030be1d5f4c9344dec6b3b7d7f29
-  data.tar.gz: 8ed9a5f69eeeca205128085268198732888632563922be5402129779074f314df3bf18ad54b17a859372fb90c2689a2b140352bd02f9fa9275950b75667deb67
+  metadata.gz: 1528541842d2b5af3a78d06ec7711eccb372f317b8f12fc9850435ce4d326dae796ebcbc43c8b2dd355dd24d737eb60c3d4a8d86a098a5d1a784bb06168e9dc6
+  data.tar.gz: cb2af9ed4ac8019c201394ad2e3a4ec5263ce56ca2c1a631b980c8f4252eb4ce2928f003544bdbb1136cf92dfecf6a9b08e9109c3d1958db23e4aa9dd3f96e60

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.3.1 - 2019-11-06
+### Fixed
+- Passing arguments to `rake pii_safe_schema:generate_migrations` actually works
+
 ## 1.3.0 - 2019-11-04
 ### Added
 - Can pass explicitly annotate PII columns from the command line as arguments when using `rake pii_safe_schema:generate_migrations`.

data/lib/pii_safe_schema/pii_column.rb

@@ -15,11 +15,13 @@ module PiiSafeSchema
       end
 
       def from_column_name(table:, column:, suggestion:)
-        unless connection.columns(table.to_s).find { |c| c.name == column.to_s }
+        activerecord_column = connection.columns(table.to_s).find { |c| c.name == column.to_s }
+
+        unless activerecord_column
           raise InvalidColumnError, "column \"#{column}\" does not exist for table \"#{table}\""
         end
 
-        new(table: table, column: column, suggestion: suggestion)
+        new(table: table, column: activerecord_column, suggestion: suggestion)
       end
 
       private

data/lib/pii_safe_schema/version.rb

@@ -1,3 +1,3 @@
 module PiiSafeSchema
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.3.1'.freeze
 end

data/lib/tasks/pii_safe_schema.rake

@@ -9,6 +9,7 @@ namespace :pii_safe_schema do
       PiiSafeSchema.generate_migrations(additional_columns)
     end
 
+    exit(0) # forces rake to stop after this and not assume args are tasks
   rescue ActiveRecord::StatementInvalid, PiiSafeSchema::InvalidColumnError => e
     raise e if e.class == ActiveRecord::StatementInvalid && e.cause.class != PG::UndefinedTable
 
@@ -19,7 +20,7 @@ namespace :pii_safe_schema do
 
       Please create the table & columns first, running their migrations, before attempting to use the pii_safe_schema generator.
     HEREDOC
-  ensure
-    exit(0) # forces rake to stop after this and not assume args are tasks
+
+    exit(1) # forces rake to stop after this and not assume args are tasks
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pii_safe_schema
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Alexi Garrow
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-06 00:00:00.000000000 Z
+date: 2019-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport