picturehouse_uk 3.0.8 → 3.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f6fb1d47bad9c9222aa24f5782e3dacf9dfdf4f
-  data.tar.gz: 0c4675d6002c48e5a3d060ae77f14286df40dc16
+  metadata.gz: 437ad0e8ebc0d270642be6c4d4da06c33833be3f
+  data.tar.gz: 429a905ad6768ab2428c666dfe3d30c9c6148518
 SHA512:
-  metadata.gz: 724b00074362866f62645fb0ee3cdce265e2ed50566e72a0bbcd9dab474ce247e67ee76a7c4e0dfd9fe4bd20aa7e6e3954e197349f33f48a0a68a3c68156cdd4
-  data.tar.gz: 1880388a8387f29b76d005477195d59aea20c789bd121b3901cbb2e1d083fa83ad2779bf1c52102d68124e4c3d39bf3872be7f6498fcdb5e0109ae2343ff6924
+  metadata.gz: 073b9f66f5e761884c50faceb2a5b2b8aa9d13d451d112a1c9827c2f4c49d09cf53887dcc4716e9a85328e3907b60ff4d2a3245cdd5b1ebbf4286b80b93154c7
+  data.tar.gz: 0349ae4fd13d79da081476a63d02bb1c111d5702039fa862a3f054cf11d294ea9e577a8c9fa5994b0738cef3b6ddc74bcbbe32222016e2c8868ee53b79e2c241

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [3.0.9] - 2015-04-12
+
+### Fixed
+- Date parsing was busted, it's not anymore
+
+### Changed
+- Better use of Struct
+
 ## [3.0.8] - 2015-04-07
 
 ### Fixed

data/lib/picturehouse_uk/internal/parser/screenings.rb

@@ -4,16 +4,16 @@ module PicturehouseUk
     # @api private
     module Parser
       # Parses screenings page into an array of hashes for an individual cinema
-      class Screenings < Struct.new(:cinema_id)
+      Screenings = Struct.new(:cinema_id) do
         # css for a day of films & screenings
-        LISTINGS = '#this-week .listings > li, #further-ahead .listings > li'
+        LISTINGS = '#today .listings > li, #this-week .listings > li, #further-ahead .listings > li'
 
         # parse the cinema page into an array of screenings attributes
         # @return [Array<Hash>]
         def to_a
-          date = nil
+          date = Date.today
           doc.css(LISTINGS).each_with_object([]) do |node, result|
-            if date_parse(node.text)
+            if date?(node.text)
               date = date_parse(node.text)
             else
               result << FilmWithShowtimes.new(node, date).to_a
@@ -33,13 +33,17 @@ module PicturehouseUk
           @doc ||= Nokogiri::HTML(page)
         end
 
+        def date?(text)
+          !!text.match(/(Mon|Tues|Wednes|Thurs|Fri|Satur|Sun)day \d{1,2}(st|nd|th) (Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec)/)
+        end
+
         def page
           @page ||= PicturehouseUk::Internal::Website.new.cinema(cinema_id)
         end
       end
     end
 
-    class FilmWithShowtimes < Struct.new(:node, :date)
+    FilmWithShowtimes = Struct.new(:node, :date) do
       # film name css
       NAME = '.top-mg-sm a'
       # variants css
@@ -76,7 +80,7 @@ module PicturehouseUk
     end
 
     # variants can have multiple screenings
-    class Variant < Struct.new(:node, :date)
+    Variant = Struct.new(:node, :date) do
       SHOWTIMES = '.btn'
       VARIANT   = '.film-type-desc'
 
@@ -94,7 +98,7 @@ module PicturehouseUk
     end
 
     # parse an individual screening node
-    class Showtime < Struct.new(:node, :date)
+    Showtime = Struct.new(:node, :date) do
       # the attributes of a single screening
       # @return [Hash]
       # @example

data/lib/picturehouse_uk/version.rb

@@ -1,6 +1,6 @@
 # Ruby interface for http://www.picturehouses.co.uk
-# @version 3.0.8
+# @version 3.0.9
 module PicturehouseUk
   # Gem version
-  VERSION = '3.0.8'
+  VERSION = '3.0.9'
 end

data/test/lib/picturehouse_uk/screening_test.rb

@@ -19,7 +19,7 @@ describe PicturehouseUk::Screening do
 
     it 'returns correct number of screenings' do
       PicturehouseUk::Internal::Website.stub :new, website do
-        subject.count.must_equal 14
+        subject.count.must_equal 59
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: picturehouse_uk
 version: !ruby/object:Gem::Version
-  version: 3.0.8
+  version: 3.0.9
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-07 00:00:00.000000000 Z
+date: 2015-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler