picture_from 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb7f865aafa5ad8a359f4a3c9cbf3bcdfc9f19b4
-  data.tar.gz: 5d8e3f71b4186d10eaf1ab0c218ba61d2bdb1c32
+  metadata.gz: 23aea69a8712e80042dbc252a4838a8846d2edb4
+  data.tar.gz: ac517c481ac4adf814b04b5462986874bc64a5fe
 SHA512:
-  metadata.gz: d2ae1cc6afd91c116577c9c5ffc4b4c6cba109282258a27a68cca707c3f093dbd6f7f6168e82a5308a5ffe1490dfe1e3cbefe4fe46d241d9b1939acba9b228e9
-  data.tar.gz: 6fa907f00f53441ade90e99257fed809af8964fab8475c696a40cbf57b96d0f20f0d2ec5632fb169d9fb6a872864e4b4d9620e6191e2e30f67078e05a10b9b4f
+  metadata.gz: d6fdbfc7d7bc0411bd56cf49cfc366bc2c3818534114d3c5b2283b558ea2323ccfa8669e3de71c64c003783443c26a7ec4f1d7898219bfeea2b7c3b7f260623a
+  data.tar.gz: faa0aaac0eecffd5b067a26e655e0e3fe4b0e587055ac38519cb612fef50e3318f4c3aae53625b4792b4157bee0089c7ae4900f337ba581ecc4ad8b7c9de67f6

data/lib/picture_from/search_engine.rb

@@ -27,6 +27,7 @@ module PictureFrom
           return image_url if image_url
         end
       end
+      nil
     end
 
     private

data/lib/picture_from/version.rb

@@ -1,3 +1,3 @@
 module PictureFrom
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/lib/picture_from/facebook_picture_spec.rb

@@ -6,12 +6,29 @@ describe PictureFrom::FacebookPicture do
     subject { described_class.new }
 
     it 'returns the image url' do
+      fake('http://graph.facebook.com/karreiro/picture',
+           status: 302,
+           message: 'Found',
+           location: 'https://fbcdn-profile-a.akamaihd.net/image.png')
+
       link = subject.picture_from_username('karreiro')
       expect(link).to eq('http://graph.facebook.com/karreiro/picture')
     end
   end
 
-  describe 'online tests' do
+  describe '#picture_from_user_info' do
+    subject { described_class.new }
+
+    it 'returns the image url' do
+      fake('https://www.facebook.com/search.php?q=karreiro@gmail.com',
+           file: 'facebook_crawler.response')
+
+      link = subject.picture_from_user_info('karreiro@gmail.com')
+      expect(link).to eq('http://graph.facebook.com/karreiro/picture')
+    end
+  end
+
+  describe 'online tests', online: true do
 
     describe '#picture_from_user_info' do
       subject { described_class.new }

data/spec/lib/picture_from/twitter_picture_spec.rb

@@ -2,7 +2,17 @@ require 'spec_helper'
 
 describe PictureFrom::TwitterPicture do
 
-  describe 'online tests' do
+  describe '#picture_from_username' do
+    subject { described_class.new }
+
+    it 'returns the image url' do
+      fake('https://twitter.com/g_carreiro', file: 'twitter_crawler.response')
+      link = subject.picture_from_username('g_carreiro')
+      expect(link).to eq('https://pbs.twimg.com/profile_images/524721838002143233/nNdh6ftm_400x400.jpeg')
+    end
+  end
+
+  describe 'online tests', online: true do
 
     describe '#picture_from_username' do
       subject { described_class.new }
@@ -14,5 +24,4 @@ describe PictureFrom::TwitterPicture do
     end
 
   end
-
 end

data/spec/spec_helper.rb

@@ -6,5 +6,6 @@ require 'fakeweb'
 require 'picture_from'
 
 RSpec.configure do |config|
+  config.filter_run_excluding online: !ENV['RUN_ONLINE_TESTS']
   config.include FakeWebHelper
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: picture_from
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Guilherme Carreiro
@@ -159,7 +159,6 @@ files:
 - spec/lib/picture_from/facebook_picture_spec.rb
 - spec/lib/picture_from/gravatar_picture_spec.rb
 - spec/lib/picture_from/keyword_spec.rb
-- spec/lib/picture_from/search_engine_spec.rb
 - spec/lib/picture_from/twitter_picture_spec.rb
 - spec/lib/picture_from_spec.rb
 - spec/spec_helper.rb
@@ -199,7 +198,6 @@ test_files:
 - spec/lib/picture_from/facebook_picture_spec.rb
 - spec/lib/picture_from/gravatar_picture_spec.rb
 - spec/lib/picture_from/keyword_spec.rb
-- spec/lib/picture_from/search_engine_spec.rb
 - spec/lib/picture_from/twitter_picture_spec.rb
 - spec/lib/picture_from_spec.rb
 - spec/spec_helper.rb

data/spec/lib/picture_from/search_engine_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe PictureFrom::SearchEngine do
-
-  describe '#picture_from_username' do
-
-  end
-
-end