picky 4.31.1 → 4.31.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2b3c54b9a8b3db32d2cfb2ddbc7acd92889ae4bf
-  data.tar.gz: dc1355c15b92450a9b4d5ac2d05cdd1754938e94
+  metadata.gz: 54dcfc7c9200c82d700cbc217d92b95dfdeb7560
+  data.tar.gz: e6bb65cb70e0e35b682461354fc7141196d8250a
 SHA512:
-  metadata.gz: 5c8267d3a6d40cb9170d9f068d296dca257c83651db5848c2e8d43c1e8547bb07a57a5a58bf20b8e9d3c3e1e0c5b64564daefa5a0e7cc434df0b2a7fbded6154
-  data.tar.gz: 4a5e283823b8558e5e030cb583b491f5be88669ca6e6b70904a78a5d92e1aeae10183b96e27deea2c816af677bd4038a8fa7251982c684ea0606fe1b9d55d68d
+  metadata.gz: 0785f11056dc78dbfd52414ab3ff14be8ec1bb429ddcbdb90b6a5d77d9c5250308b64e52ba91e5313a7991b84cb50b9f5f94ccfc8fda05c3716479e3f36a9f4e
+  data.tar.gz: a7a92264369467374a3d7490b7d5f32170d07a923a40e5fe5466888dc0086b339066d153503cd846ab01a535ddf48ef0c300f3e6185573eaef903728fc5e8af1

data/lib/picky/category_realtime.rb

@@ -7,7 +7,9 @@ module Picky
     # Adds and indexes this category of the
     # given object.
     #
-    # TODO Don't do this super-dynamically?
+    # @param object [Object] The thing to index.
+    # @param method [Symbol] The method name to use on the id array.
+    # @param force_update [Boolean] Whether to force update.
     #
     def add object, method: :unshift, force_update: false
       data = if from.respond_to? :call
@@ -21,22 +23,40 @@ module Picky
     # Removes an indexed object with the
     # given id.
     #
+    # @param id [Object] The id of the object.
+    #
     def remove id
       id = id.send key_format if key_format?
       exact.remove id
       partial.remove id
     end
 
-    # Removes the object's id, and then
-    # adds it again.
+    # Replaces an object. Will first check if each category of the object is in
+    # the index it would insert, and if it is, will not insert.
+    # Otherwise will delete and add.
     #
-    # TODO Is this the actual forced update?
+    # @param object [Object] The object to replace.
+    # @param method [Symbol] The method name to use on the id array.
     #
     def replace object, method: :unshift
       remove object.send id
       add object, method: method
     end
 
+    # Always removes the object's id, and then
+    # adds the object again.
+    #
+    # Note: This puts a bit of a strain on Ruby's
+    # memory management.
+    #
+    # @param object [Object] The object to replace.
+    # @param method [Symbol] The method name to use on the id array.
+    #
+    def replace! object, method: :unshift
+      remove object.send id
+      add object, method: method
+    end
+
     # Replaces just part of the indexed data.
     #
     # Note: Takes a hash as opposed to the add/replace method.

data/lib/picky/wrappers/bundle/exact_partial.rb

@@ -18,7 +18,7 @@ module Picky
         def dump; end
         def empty; end
         def index; end
-        def load; end
+        def load(*); end
         
         def to_tree_s indent = 0
           bundle.to_tree_s(indent) { "(reference)" }

data/spec/functional/realtime_spec.rb

@@ -107,6 +107,15 @@ describe "Realtime Indexing" do
 
           books.search('Titl').ids.should == [2,1]
         end
+        it 'will not have duplicate result from adding something twice' do
+          books.search('Titl').ids.should == [1]
+
+          index.add Book.new(2, "Title New", "Author New")
+          index.add Book.new(2, "New Title", "New Author")
+          index.add Book.new(2, "Title New", "Author New")
+
+          books.search('Titl').ids.should == [2,1]
+        end
 
         it 'allows replacing something' do
           index.replace Book.new(1, "Title New", "Author New")
@@ -134,6 +143,17 @@ describe "Realtime Indexing" do
 
           books.search('title:Ne').ids.should == [1]
         end
+        it 'does not unnecessarily change the position if a category already contains it' do
+          books.search('title:Title').ids.should == [1]
+
+          index.add Book.new(2, "Title New", "Author New")
+
+          books.search('title:Title').ids.should == [2,1]
+          
+          index.replace Book.new(1, "Title", "Author")
+          
+          books.search('title:Title').ids.should == [2,1]
+        end
       end
 
       context 'non-partial' do
@@ -258,11 +278,11 @@ describe "Realtime Indexing" do
     end
   end
 
-  context 'special index' do
+  context 'index with key_format :to_sym' do
     let(:index) do
       Picky::Index.new(:books) do
         key_format :to_sym
-        source []
+        
         category :title
         category :author, similarity: Picky::Generators::Similarity::DoubleMetaphone.new(3)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: picky
 version: !ruby/object:Gem::Version
-  version: 4.31.1
+  version: 4.31.2
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-30 00:00:00.000000000 Z
+date: 2015-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -397,7 +397,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: http://rubyforge.org/projects/picky
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: 'Picky: Semantic Search Engine. Clever Interface. Good Tools.'