picky 4.0.9 → 4.1.0

data/lib/picky/results.rb

@@ -41,8 +41,15 @@ module Picky
 
     # Delegates to allocations.
     #
-    def ids amount = 20
-      allocations.ids amount
+    # TODO Remove parameter in 5.0 and just call
+    # the method with amount.
+    #
+    # Note that this is an expensive call and
+    # should not be done repeatedly. Just keep
+    # a reference to the result.
+    #
+    def ids only = nil
+      allocations.ids only || amount
     end
 
     # The total results. Delegates to the allocations.

data/spec/functional/non_specific_ids_larger_than_20_spec.rb

@@ -0,0 +1,28 @@
+# encoding: utf-8
+#
+require 'spec_helper'
+
+describe 'Location search with live updates' do
+
+  it 'works with ids larger than 20 on non-specific search' do
+    data = Picky::Index.new :test do
+      category :titel
+      category :text
+    end
+
+    50.times do |i|
+      data.replace_from id: i, titel: 'japan', text: 'some text on japan' 
+    end
+
+    stuff = Picky::Search.new data
+
+    result = stuff.search 'titel:japan', 10000
+    result.total.should == 50
+    result.ids.size.should == 50
+    
+    result = stuff.search 'japan', 10000
+    result.total.should == 100
+    result.ids.size.should == 100
+  end
+  
+end

data/spec/integration/sinatra_index_actions_spec.rb

@@ -14,6 +14,7 @@ describe 'Sinatra Index Actions' do
       category :name
       category :surname
     end
+    
     people = Picky::Search.new data
     
     get '/people' do

data/spec/lib/extensions/object_spec.rb

@@ -25,7 +25,7 @@ describe Object do
 
     describe 'warn_gem_missing' do
       it 'should warn right' do
-        object.should_receive(:warn).once.with "gnorf gem missing!\nTo use gnarble gnarf, you need to:\n  1. Add the following line to Gemfile:\n     gem 'gnorf'\n     or\n     require 'gnorf'\n     for example at the top of your app.rb file.\n  2. Then, run:\n     bundle update\n"
+        object.should_receive(:warn).once.with "gnorf gem missing!\nTo use gnarble gnarf, you need to:\n  1. Add the following line to Gemfile:\n     gem 'gnorf'\n  2. Then, run:\n     bundle update\n"
 
         object.warn_gem_missing 'gnorf', 'gnarble gnarf'
       end

data/spec/lib/generators/similarity/phonetic_spec.rb

@@ -15,7 +15,7 @@ describe Picky::Generators::Similarity::Phonetic do
 
     instance.should_receive(:require).any_number_of_times.and_raise LoadError
 
-    instance.should_receive(:warn).once.with "text gem missing!\nTo use a phonetic Similarity, you need to:\n  1. Add the following line to Gemfile:\n     gem 'text'\n     or\n     require 'text'\n     for example at the top of your app.rb file.\n  2. Then, run:\n     bundle update\n"
+    instance.should_receive(:warn).once.with "text gem missing!\nTo use a phonetic Similarity, you need to:\n  1. Add the following line to Gemfile:\n     gem 'text'\n  2. Then, run:\n     bundle update\n"
     instance.should_receive(:exit).once.with 1
 
     instance.send :initialize

data/spec/lib/results_spec.rb

@@ -17,13 +17,19 @@ describe Picky::Results do
   describe "ids" do
     before(:each) do
       @allocations = stub :allocations
-      @results = described_class.new :unimportant, :unimportant, :unimportant, @allocations
+      @results = described_class.new :unimportant, :amount, :unimportant, @allocations
     end
     it "delegates" do
       @allocations.should_receive(:ids).once.with :anything
 
       @results.ids :anything
     end
+    it "delegates and uses amount if nothing given" do
+      @allocations.should_receive(:ids).once.with :amount
+
+      @results.ids
+    end
+    
   end
 
   describe 'to_s time format' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: picky
 version: !ruby/object:Gem::Version
-  version: 4.0.9
+  version: 4.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-07 00:00:00.000000000 Z
+date: 2012-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70141079682140 !ruby/object:Gem::Requirement
+  requirement: &70259240903180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,21 +21,21 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70141079682140
+  version_requirements: *70259240903180
 - !ruby/object:Gem::Dependency
   name: picky-client
-  requirement: &70141079681320 !ruby/object:Gem::Requirement
+  requirement: &70259240902680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.9
+        version: 4.1.0
   type: :development
   prerelease: false
-  version_requirements: *70141079681320
+  version_requirements: *70259240902680
 - !ruby/object:Gem::Dependency
   name: text
-  requirement: &70141079680580 !ruby/object:Gem::Requirement
+  requirement: &70259240902260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70141079680580
+  version_requirements: *70259240902260
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70141079679600 !ruby/object:Gem::Requirement
+  requirement: &70259240901800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70141079679600
+  version_requirements: *70259240901800
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70141079694860 !ruby/object:Gem::Requirement
+  requirement: &70259240901300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70141079694860
+  version_requirements: *70259240901300
 - !ruby/object:Gem::Dependency
   name: procrastinate
-  requirement: &70141079691460 !ruby/object:Gem::Requirement
+  requirement: &70259240900800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: '0.4'
   type: :runtime
   prerelease: false
-  version_requirements: *70141079691460
+  version_requirements: *70259240900800
 - !ruby/object:Gem::Dependency
   name: rack_fast_escape
-  requirement: &70141079689280 !ruby/object:Gem::Requirement
+  requirement: &70259240900420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70141079689280
+  version_requirements: *70259240900420
 description: Fast Ruby semantic text search engine with comfortable single field interface.
 email: florian.hanke+picky@gmail.com
 executables:
@@ -248,6 +248,7 @@ files:
 - spec/functional/dynamic_weights_spec.rb
 - spec/functional/exact_first_spec.rb
 - spec/functional/max_allocations_spec.rb
+- spec/functional/non_specific_ids_larger_than_20_spec.rb
 - spec/functional/only_spec.rb
 - spec/functional/realtime_spec.rb
 - spec/functional/regression_spec.rb
@@ -393,6 +394,7 @@ test_files:
 - spec/functional/dynamic_weights_spec.rb
 - spec/functional/exact_first_spec.rb
 - spec/functional/max_allocations_spec.rb
+- spec/functional/non_specific_ids_larger_than_20_spec.rb
 - spec/functional/only_spec.rb
 - spec/functional/realtime_spec.rb
 - spec/functional/regression_spec.rb