pickle 0.3.3 → 0.3.4

data/History.txt

@@ -1,3 +1,10 @@
+== 0.3.4
+
+* 2 minor improvements
+  * Fix problem where email body is not a string, but is string like [#26] [Tom Meier]
+  * Minor code refactoring
+
+
 == 0.3.3
 
 * 1 minor improvement

data/README.rdoc

@@ -328,6 +328,7 @@ To run the features (rails 2.3 only ATM):
 
 The following people have made Pickle better:
 
+* {Tom Meier}[http://github.com/tommeier]
 * {Sean Hussey}[http://github.com/seanhussey]
 * Brian Rose & Kevin Olsen
 * {Christopher Darroch}[http://github.com/chrisdarroch]

data/VERSION

@@ -1 +1 @@
-0.3.3
+0.3.4

data/lib/pickle/config.rb

@@ -1,5 +1,3 @@
-require 'ostruct'
-
 module Pickle
   class Config
     attr_writer :adapters, :factories, :mappings, :predicates
@@ -31,6 +29,9 @@ module Pickle
         k.public_instance_methods.select {|m| m =~ /\?$/} + Pickle::Adapter.column_names(k)
       end.flatten.uniq
     end
+
+    class Mapping < Struct.new(:search, :replacement)
+    end
     
     def mappings
       @mappings ||= []
@@ -41,7 +42,7 @@ module Pickle
       options = args.extract_options!
       raise ArgumentError, "Usage: map 'search' [, 'search2', ...] :to => 'replace'" unless args.any? && options[:to].is_a?(String)
       args.each do |search|
-        self.mappings << OpenStruct.new(:search => search, :replacement => options[:to])
+        self.mappings << Mapping.new(search, options[:to])
       end
     end
   end

data/lib/pickle/email.rb

@@ -70,7 +70,7 @@ module Pickle
     end
 
     def links_in_email(email, protos=['http', 'https'])
-      URI.extract(email.body, protos)
+      URI.extract(email.body.to_s, protos)
     end
 
   end

data/pickle.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{pickle}
-  s.version = "0.3.3"
+  s.version = "0.3.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ian White"]
-  s.date = %q{2010-08-05}
+  s.date = %q{2010-08-06}
   s.description = %q{Easy model creation and reference in your cucumber features}
   s.email = %q{ian.w.white@gmail.com}
   s.extra_rdoc_files = [

data/spec/pickle/config_spec.rb

@@ -80,8 +80,12 @@ describe Pickle::Config do
       @config.map 'foo', :to => 'faz'
     end
 
-    it "should create OpenStruct(search: 'foo', replace: 'faz') mapping" do
-      @config.mappings.first.should == OpenStruct.new(:search => 'foo', :replacement => 'faz')
+    it "should create Mapping('foo', 'faz') mapping" do
+      @config.mappings.first.tap do |mapping|
+        mapping.should be_kind_of Pickle::Config::Mapping
+        mapping.search.should == 'foo'
+        mapping.replacement.should == 'faz'
+      end
     end
   end
 
@@ -91,8 +95,8 @@ describe Pickle::Config do
     end
 
     it "should create 2 mappings" do
-      @config.mappings.first.should == OpenStruct.new(:search => 'foo', :replacement => 'faz')
-      @config.mappings.last.should == OpenStruct.new(:search => 'bar', :replacement => 'faz')
+      @config.mappings.first.should == Pickle::Config::Mapping.new('foo', 'faz')
+      @config.mappings.last.should == Pickle::Config::Mapping.new('bar', 'faz')
     end
   end
 

data/spec/pickle/email_spec.rb

@@ -156,5 +156,11 @@ describe Pickle::Email do
       should_receive(:visit).with('http://example.com/page')
       click_first_link_in_email(@email1)
     end
+    
+    it "should not raise an error when the email body is not a string, but needs to_s [#26]" do
+      stub!(:visit)
+      @email1.stub!(:body).and_return(:a_string_body)
+      lambda { click_first_link_in_email(@email1) }.should_not raise_error
+    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: pickle
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 27
   prerelease: false
   segments: 
   - 0
   - 3
-  - 3
-  version: 0.3.3
+  - 4
+  version: 0.3.4
 platform: ruby
 authors: 
 - Ian White
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-05 00:00:00 +01:00
+date: 2010-08-06 00:00:00 +01:00
 default_executable: 
 dependencies: []