phraseapp-in-context-editor-ruby 2.1.2 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc5405ba5aa6a41f6c21d509eeaa00d6d5f62fb5bfae1578c16695b252931dcc
-  data.tar.gz: 73d0e561de9a0426dfe11b3f0f6f941af7ad1e1dba3de9695add6954eee5af5a
+  metadata.gz: '09476e9967528243584d88b2eab3153a64e77e7c6287bb4044d93f5b8d7535b0'
+  data.tar.gz: cfbdb848d7157a8ca3214db1288c43790548e4bb834c016b9ee5dd8473340810
 SHA512:
-  metadata.gz: ff58eb5b36a68c9b9cc03d495f33dd86d0a831fc90b073ca52dff774a6efffe4e89e21053b25ebf20920dd0696c06148a3028204f4fd6063d53dabd234f3c62d
-  data.tar.gz: e76bc4e76e5733d8d666f9a5c1e63a6f1954a5d636b4a9237a60b9e845269c1d95120f0d1e8ba167ec3e0d455c26846a65be5b975152444d9f66c5f55424e207
+  metadata.gz: fea36910dec30f4b064ebdf5b1d9a0a155db20edd586498606a8c1fc1e925c7360cbf13a152c9b592696658ea6f73997cce5d701eca853497f2f512f3cc88375
+  data.tar.gz: d0d529d0f425c97c992196448ac9c3865f688259b245db12dd7e4be9d1a2d9271f261b97f2e3ecc924402dbe50cd0e37789b97e3a0b8cb3ea938e9771d1c9498

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# [3.0.0](https://github.com/phrase/phraseapp-in-context-editor-ruby/compare/v2.1.2...v3.0.0) (2024-05-21)
+
+
+* BREAKING CHANGE: Use ruby 2.7 'Forward all arguments' syntax: (...) to forward arguments (#78) ([99ae28e](https://github.com/phrase/phraseapp-in-context-editor-ruby/commit/99ae28e2f6fea0ba2ba0eec6eca54a043e21d121)), closes [#78](https://github.com/phrase/phraseapp-in-context-editor-ruby/issues/78)
+
+
+### BREAKING CHANGES
+
+* Hash arguments will throw an error. Keyword arguments must be used instead.
+
 ## [2.1.2](https://github.com/phrase/phraseapp-in-context-editor-ruby/compare/v2.1.1...v2.1.2) (2024-05-21)
 
 

data/lib/phraseapp-in-context-editor-ruby/adapters/i18n.rb

@@ -1,8 +1,8 @@
 if defined?(I18n)
   module I18n
     class << self
-      def translate_with_phraseapp(*args)
-        PhraseApp::InContextEditor.backend.translate(*args)
+      def translate_with_phraseapp(...)
+        PhraseApp::InContextEditor.backend.translate(...)
       end
       alias_method :translate_without_phraseapp, :translate
       alias_method :translate, :translate_with_phraseapp

data/lib/phraseapp-in-context-editor-ruby/backend_service.rb

@@ -9,41 +9,21 @@ module PhraseApp
         self
       end
 
-      def translate(*args)
-        if to_be_translated_without_phraseapp?(args)
-          # *Ruby 2.7+ keyword arguments warning*
-          #
-          # This method uses keyword arguments.
-          # There is a breaking change in ruby that produces warning with ruby 2.7 and won't work as expected with ruby 3.0
-          # The "hash" parameter must be passed as keyword argument.
-          #
-          # Good:
-          #  I18n.t(:salutation, :gender => 'w', :name => 'Smith')
-          #  I18n.t(:salutation, **{ :gender => 'w', :name => 'Smith' })
-          #  I18n.t(:salutation, **any_hash)
-          #
-          # Bad:
-          #  I18n.t(:salutation, { :gender => 'w', :name => 'Smith' })
-          #  I18n.t(:salutation, any_hash)
-          #
-          kw_args = args[1]
-          if kw_args.present?
-            I18n.translate_without_phraseapp(args[0], **kw_args)
-          else
-            I18n.translate_without_phraseapp(args[0])
-          end
+      def translate(...)
+        if to_be_translated_without_phraseapp?(...)
+          I18n.translate_without_phraseapp(...)
         else
-          phraseapp_delegate_for(args)
+          phraseapp_delegate_for(...)
         end
       end
 
       protected
 
-      def to_be_translated_without_phraseapp?(args)
-        PhraseApp::InContextEditor.disabled? || has_been_forced_to_resolve_with_phraseapp?(args)
+      def to_be_translated_without_phraseapp?(...)
+        PhraseApp::InContextEditor.disabled? || has_been_forced_to_resolve_with_phraseapp?(...)
       end
 
-      def has_been_forced_to_resolve_with_phraseapp?(args)
+      def has_been_forced_to_resolve_with_phraseapp?(*args)
         (args.last.is_a?(Hash) && args.last[:resolve] == false)
       end
 
@@ -51,7 +31,7 @@ module PhraseApp
         extract_normalized_key_from_args(args)
       end
 
-      def phraseapp_delegate_for(args)
+      def phraseapp_delegate_for(*args)
         key = given_key_from_args(args)
         return nil unless present?(key)
 

data/lib/phraseapp-in-context-editor-ruby/version.rb

@@ -1,3 +1,3 @@
 module PhraseApp
-  VERSION = "2.1.2"
+  VERSION = "3.0.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phraseapp-in-context-editor-ruby
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 3.0.0
 platform: ruby
 authors:
 - Phrase