phony_rails 0.8.2 → 0.9.0

data/Gemfile.lock

@@ -4,7 +4,7 @@ PATH
     phony_rails (0.8.2)
       activesupport (>= 3.0)
       countries (>= 0.8.2)
-      phony (~> 2.8.3)
+      phony (~> 2.10.1)
 
 GEM
   remote: https://rubygems.org/
@@ -71,7 +71,7 @@ GEM
     nenv (0.1.1)
     optionable (0.2.0)
     origin (2.1.1)
-    phony (2.8.9)
+    phony (2.10.1)
     pry (0.10.1)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)

data/README.md

@@ -87,7 +87,7 @@ so we can use:
     validates_plausible_phone :phone_number, :without => /^\+\d+/
     validates_plausible_phone :phone_number, :presence => true, :with => /^\+\d+/
 
-the i18n key is `:improbable_phone`
+the i18n key is `:improbable_phone`. Languages supported by default: de, en, fr, it, ja, kh and tr.
 
 You can also validate if a number has the correct country number:
 

data/lib/phony_rails.rb

@@ -35,6 +35,18 @@ module PhonyRails
     number # If all goes wrong .. we still return the original input.
   end
 
+  # Wrapper for Phony.plausible?.  Takes the same options as #normalize_number.
+  # NB: This method calls #normalize_number and passes _options_ directly to that method.
+  def self.plausible_number?(number, options = {})
+    return false if number.nil? || number.blank?
+    number = normalize_number(number, options)
+    country_number = options[:country_number] || country_number_for(options[:country_code]) || 
+      default_country_number = options[:default_country_number] || country_number_for(options[:default_country_code])
+    Phony.plausible? number, cc: country_number
+  rescue
+    false
+  end
+
   module Extension
     extend ActiveSupport::Concern
 

data/lib/phony_rails/locales/km.yml

@@ -0,0 +1,4 @@
+km:
+  errors:
+    messages:
+      improbable_phone: "គឺជាលេខមិនត្រឹមត្រូវ"

data/lib/phony_rails/version.rb

@@ -1,3 +1,3 @@
 module PhonyRails
-  VERSION = "0.8.2"
+  VERSION = "0.9.0"
 end

data/phony_rails.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = PhonyRails::VERSION
 
-  gem.add_dependency "phony", "~> 2.8.3"
+  gem.add_dependency "phony", "~> 2.10.1"
   gem.add_dependency "countries", ">= 0.8.2"
   gem.add_dependency "activesupport", ">= 3.0"
   gem.add_development_dependency "activerecord", ">= 3.0"

data/spec/lib/phony_rails_spec.rb

@@ -184,6 +184,47 @@ describe PhonyRails do
     end
   end
 
+  describe 'PhonyRails#plausible_number?' do
+    let(:valid_number) { '1 555 555 5555' }
+    let(:invalid_number) { '123456789 123456789 123456789 123456789' }
+    let(:normalizable_number) { '555 555 5555' }
+    let(:formatted_french_number_with_country_code) { '+33 627899541' }
+    let(:empty_number) { '' }
+    let(:nil_number) { nil }
+
+    it "should return true for a valid number" do
+      PhonyRails.plausible_number?(valid_number, country_code: 'US').should be_true
+    end
+
+    it "should return false for an invalid number" do
+      PhonyRails.plausible_number?(invalid_number, country_code: 'US').should be_false
+    end
+
+    it "should return true for a normalizable number" do
+      PhonyRails.plausible_number?(normalizable_number, country_code: 'US').should be_true
+    end
+
+    it "should return false for a valid number with the wrong country code" do
+      PhonyRails.plausible_number?(valid_number, country_code: 'FR').should be_false
+    end
+
+    it "should return true for a well formatted valid number" do
+      PhonyRails.plausible_number?(formatted_french_number_with_country_code, country_code: 'FR').should be_true
+    end
+
+    it "should return false for an empty number" do
+      PhonyRails.plausible_number?(empty_number, country_code: 'US').should be_false
+    end
+
+    it "should return false for a nil number" do
+      PhonyRails.plausible_number?(nil_number, country_code: 'US').should be_false
+    end
+
+    it "should return false when no country code is supplied" do
+      PhonyRails.plausible_number?(normalizable_number).should be_false
+    end
+  end
+
   shared_examples_for 'model with PhonyRails' do
     describe 'defining model#phony_normalized_method' do
       it "should add a normalized_phone_attribute method" do

data/spec/lib/validators/phony_validator_spec.rb

@@ -170,6 +170,14 @@ describe PhonyPlausibleValidator do
         @home.errors.messages.should include(:phone_number => ["は正し電話番号ではありません"])
       end
     end
+
+    it "should translate the error message in Khmer" do
+      I18n.with_locale(:km) do
+        @home.phone_number = INVALID_NUMBER
+        @home.valid?
+        @home.errors.messages.should include(:phone_number => ["គឺជាលេខមិនត្រឹមត្រូវ"])
+      end
+    end
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phony_rails
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.9.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-18 00:00:00.000000000 Z
+date: 2015-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: phony
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.8.3
+        version: 2.10.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.8.3
+        version: 2.10.1
 - !ruby/object:Gem::Dependency
   name: countries
   requirement: !ruby/object:Gem::Requirement
@@ -113,6 +113,7 @@ files:
 - lib/phony_rails/locales/fr.yml
 - lib/phony_rails/locales/it.yml
 - lib/phony_rails/locales/ja.yml
+- lib/phony_rails/locales/km.yml
 - lib/phony_rails/locales/tr.yml
 - lib/phony_rails/string_extensions.rb
 - lib/phony_rails/version.rb