phony_rails 0.14.12 → 0.14.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f5bc5fd8efabff8b0607fe060f2d27b11ddbd948
-  data.tar.gz: 68add4fb0fc07c768ecafdd390e1ce471940eb07
+SHA256:
+  metadata.gz: c65b83fb1c77dccdf0b125fa2195b997067bc06efa4fff2284ab3542e643a7b3
+  data.tar.gz: '09e7d37472c4c0ccfa050f381506c11f2ec5b939c75199c26e2529b531ccfa90'
 SHA512:
-  metadata.gz: d61d5e02e7e61a8b15088a09d1ae8cc5db8ce5eb38c388ff2845e27a508a2fde4e12e6780042cec5832992610d54908456423a639671c0a6eb128cb45f24a1ce
-  data.tar.gz: 3e61051454973a4ca74a0e863a500f53dfd49bebf26d7e19d311332d8fc701a20dfe55a2ef035cb1184811fcd14809225629023b15e525dce61167a18637456c
+  metadata.gz: 5b35b337390b7c90d8c1a0d9ef972205089f56a04e1d4e51c59ded39acc7bfee6568fbf7d06e7a603d9091e58bfe0ef8f12f974b2170d55b704bc9d375a23846
+  data.tar.gz: a2cb0e49ce1039adb889b4e080cb5418a0c3ea88bd129edc991028e5aa0b5c6620c7fa4ab0a82316655b00d31d06eda7e9a5eb1cd824e0dc422f0e95506ae272

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Change Log
 
+## [v0.14.12](https://github.com/joost/phony_rails/tree/v0.14.12) (2019-06-21)
+[Full Changelog](https://github.com/joost/phony_rails/compare/v0.14.11...v0.14.12)
+
+**Closed issues:**
+
+- Some German numbers not passing plausible\_numbers? without country\_code [\#193](https://github.com/joost/phony_rails/issues/193)
+
+**Merged pull requests:**
+
+- Upgrade Ruby versions and Relax dependancies [\#192](https://github.com/joost/phony_rails/pull/192) ([berkos](https://github.com/berkos))
+- Add possibility to return original phone number when is not valid [\#190](https://github.com/joost/phony_rails/pull/190) ([synion](https://github.com/synion))
+- Add UK country\_code. [\#189](https://github.com/joost/phony_rails/pull/189) ([ayghor](https://github.com/ayghor))
+
 ## [v0.14.11](https://github.com/joost/phony_rails/tree/v0.14.11) (2018-10-11)
 [Full Changelog](https://github.com/joost/phony_rails/compare/v0.14.10...v0.14.11)
 
@@ -172,7 +185,7 @@
 **Merged pull requests:**
 
 - Update readme [\#117](https://github.com/joost/phony_rails/pull/117) ([toydestroyer](https://github.com/toydestroyer))
-- Add uk, ru error message translations [\#114](https://github.com/joost/phony_rails/pull/114) ([sanavy](https://github.com/sanavy))
+- Add uk, ru error message translations [\#114](https://github.com/joost/phony_rails/pull/114) ([shhavel](https://github.com/shhavel))
 - Update phony\_rails.gemspec [\#112](https://github.com/joost/phony_rails/pull/112) ([Agsiegert](https://github.com/Agsiegert))
 - Don't re-parse country codes YAML file every time it's needed. [\#111](https://github.com/joost/phony_rails/pull/111) ([jcoleman](https://github.com/jcoleman))
 - Replace countries dependency with YAML file [\#109](https://github.com/joost/phony_rails/pull/109) ([monfresh](https://github.com/monfresh))

data/lib/phony_rails.rb

@@ -176,8 +176,9 @@ module PhonyRails
     end
 
     def cache_original_attribute(current_instance, attribute)
-      current_instance.define_singleton_method("#{attribute}_original=")  { |value| @original = value }
-      current_instance.define_singleton_method("#{attribute}_original") { @original }
+      attribute_name = "#{attribute}_original"
+      current_instance.define_singleton_method("#{attribute_name}=") { |value| instance_variable_set("@#{attribute_name}", value) }
+      current_instance.define_singleton_method(attribute_name) { instance_variable_get("@#{attribute_name}") }
       current_instance.public_send("#{attribute}_original=", current_instance.public_send(attribute.to_s))
     end
 

data/lib/phony_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PhonyRails
-  VERSION = '0.14.12'
+  VERSION = '0.14.13'
 end

data/spec/lib/validators/phony_validator_spec.rb

@@ -172,9 +172,11 @@ class MessageOptionSameAsModelMethod < HelpfulHome
 end
 #--------------------
 class NormalizabledPhoneHome < ActiveRecord::Base
-  attr_accessor :phone_number, :country_code
+  attr_accessor :phone_number, :phone_number2, :country_code
   validates_plausible_phone :phone_number
+  validates_plausible_phone :phone_number2
   phony_normalize :phone_number, country_code: 'PL', normalize_when_valid: true
+  phony_normalize :phone_number2, country_code: 'PL', normalize_when_valid: true
 end
 
 #-----------------------------------------------------------------------------------------------------------------------
@@ -667,6 +669,23 @@ describe ActiveModel::Validations::HelperMethods do
         expect(@home).to be_valid
         expect(@home.phone_number).to eql('+48799449595')
       end
+
+      it 'does not normalize code after validation with multiple attributes' do
+        @home = NormalizabledPhoneHome.new
+        @home.phone_number = '+44 799 449 595'
+        @home.phone_number2 = '+44 222 111 333'
+        @home.country_code = 'PL'
+
+        expect(@home).to_not be_valid
+        expect(@home.phone_number).to eql('+44 799 449 595')
+        expect(@home.phone_number2).to eql('+44 222 111 333')
+
+        @home.phone_number = '+48 799 449 595'
+        @home.phone_number2 = '+48 222 111 333'
+        expect(@home).to be_valid
+        expect(@home.phone_number).to eql('+48799449595')
+        expect(@home.phone_number2).to eql('+48222111333')
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phony_rails
 version: !ruby/object:Gem::Version
-  version: 0.14.12
+  version: 0.14.13
 platform: ruby
 authors:
 - Joost Hietbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-21 00:00:00.000000000 Z
+date: 2019-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -143,7 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: This Gem adds useful methods to your Rails app to validate, display and save