phony_rails 0.1.0 → 0.1.1

data/Gemfile.lock

@@ -0,0 +1,45 @@
+PATH
+  remote: .
+  specs:
+    phony_rails (0.1.0)
+      activerecord (~> 3.0)
+      phony (~> 1.7.4)
+
+GEM
+  remote: http://rubygems.org/
+  specs:
+    activemodel (3.2.6)
+      activesupport (= 3.2.6)
+      builder (~> 3.0.0)
+    activerecord (3.2.6)
+      activemodel (= 3.2.6)
+      activesupport (= 3.2.6)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activesupport (3.2.6)
+      i18n (~> 0.6)
+      multi_json (~> 1.0)
+    arel (3.0.2)
+    builder (3.0.0)
+    diff-lcs (1.1.3)
+    i18n (0.6.0)
+    multi_json (1.3.6)
+    phony (1.7.4)
+    rspec (2.10.0)
+      rspec-core (~> 2.10.0)
+      rspec-expectations (~> 2.10.0)
+      rspec-mocks (~> 2.10.0)
+    rspec-core (2.10.1)
+    rspec-expectations (2.10.0)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.10.1)
+    sqlite3 (1.3.6)
+    tzinfo (0.3.33)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  phony_rails!
+  rspec
+  sqlite3

data/README.md

@@ -42,6 +42,9 @@ In your views use:
 
 ## Changelog
 
+0.1.0
+* Added specs.
+
 0.0.10
 * Same fix as 0.0.9 but for phony_formatted method.
 

data/lib/phony_rails/version.rb

@@ -1,3 +1,3 @@
 module PhonyRails
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/phony_rails.gemspec

@@ -15,6 +15,6 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = PhonyRails::VERSION
 
-  gem.add_dependency "phony", "~> 1.6.7"
+  gem.add_dependency "phony", "~> 1.7.4"
   gem.add_dependency "activerecord", "~> 3.0"
 end

data/spec/lib/phony_rails_spec.rb

@@ -0,0 +1,126 @@
+require 'spec_helper'
+describe PhonyRails do
+
+  describe 'String extensions' do
+    it "should phony_format a String" do
+      "31101234123".phony_formatted(:format => :international, :spaces => '-').should eql('+31-10-1234123')
+    end
+  end
+
+  describe 'PhonyRails#normalize_number' do
+    it "should normalize a number with a default_country_code" do
+      PhonyRails.normalize_number('010-1234123', :default_country_code => 'NL').should eql('31101234123')
+    end
+
+    it "should normalize a number with a country_code" do
+      PhonyRails.normalize_number('010-1234123', :country_code => 'NL', :default_country_code => 'DE').should eql('31101234123')
+      PhonyRails.normalize_number('010-1234123', :country_code => 'NL').should eql('31101234123')
+    end
+
+    it "should handle different countries" do
+      PhonyRails.normalize_number('(030) 8 61 29 06', :country_code => 'DE').should eql('49308612906')
+      PhonyRails.normalize_number('+43 664 3830412', :country_code => 'AT').should eql('436643830412')
+      PhonyRails.normalize_number('0203 330 8897', :country_code => 'GB').should eql('442033308897')
+    end
+
+    it "should handle some edge cases" do
+      PhonyRails.normalize_number('some nasty stuff in this +31 number 10-1234123 string', :country_code => 'NL').should eql('31101234123')
+      PhonyRails.normalize_number('070-4157134', :country_code => 'NL').should eql('31704157134')
+      PhonyRails.normalize_number('0031-70-4157134', :country_code => 'NL').should eql('31704157134')
+      PhonyRails.normalize_number('+31-70-4157134', :country_code => 'NL').should eql('31704157134')
+      PhonyRails.normalize_number('0323-2269497', :country_code => 'BE').should eql('323232269497')
+    end
+  end
+
+  describe 'defining ActiveRecord#phony_normalized_method' do
+    it "should add a normalized_phone_attribute method" do
+      Home.new.should respond_to(:normalized_phone_attribute)
+    end
+
+    it "should add a normalized_phone_method method" do
+      Home.new.should respond_to(:normalized_phone_method)
+    end
+
+    it "should raise error on existing methods" do
+      lambda {
+        Home.phony_normalized_method(:phone_method)
+      }.should raise_error(StandardError)
+    end
+
+    it "should raise error on not existing attribute" do
+      Home.phony_normalized_method(:phone_non_existing_method)
+      lambda {
+        Home.new.normalized_phone_non_existing_method
+      }.should raise_error(ArgumentError)
+    end
+  end
+
+  describe 'using ActiveRecord#phony_normalized_method' do
+  # Following examples have complete number (with country code!)
+    it "should return a normalized version of an attribute" do
+      home = Home.new(:phone_attribute => "+31-(0)10-1234123")
+      home.normalized_phone_attribute.should eql('31101234123')
+    end
+
+    it "should return a normalized version of a method" do
+      home = Home.new(:phone_method => "+31-(0)10-1234123")
+      home.normalized_phone_method.should eql('31101234123')
+    end
+
+  # Following examples have incomplete number
+    it "should return nil if no country_code is known" do
+      home = Home.new(:phone_attribute => "(0)10-1234123")
+      home.normalized_phone_attribute.should eql('11234123') # This actually is an incorrect number! (FIXME?)
+    end
+
+    it "should use country_code option" do
+      home = Home.new(:phone_attribute => "(0)10-1234123")
+      home.normalized_phone_attribute(:country_code => 'NL').should eql('31101234123')
+    end
+
+    it "should use country_code object method" do
+      home = Home.new(:phone_attribute => "(0)10-1234123", :country_code => 'NL')
+      home.normalized_phone_attribute.should eql('31101234123')
+    end
+
+    it "should fallback to default_country_code option" do
+      home = Home.new(:phone1_method => "(030) 8 61 29 06")
+      home.normalized_phone1_method.should eql('49308612906')
+    end
+
+    it "should overwrite default_country_code option with object method" do
+      home = Home.new(:phone1_method => "(030) 8 61 29 06", :country_code => 'NL')
+      home.normalized_phone1_method.should eql('31308612906')
+    end
+
+    it "should overwrite default_country_code option with option" do
+      home = Home.new(:phone1_method => "(030) 8 61 29 06")
+      home.normalized_phone1_method(:country_code => 'NL').should eql('31308612906')
+    end
+
+    it "should use last passed options" do 
+      home = Home.new(:phone1_method => "(030) 8 61 29 06")
+      home.normalized_phone1_method(:country_code => 'NL').should eql('31308612906')
+      home.normalized_phone1_method(:country_code => 'DE').should eql('49308612906')
+      home.normalized_phone1_method(:country_code => nil).should eql('49308612906')
+    end
+
+    it "should use last object method" do 
+      home = Home.new(:phone1_method => "(030) 8 61 29 06")
+      home.country_code = 'NL'
+      home.normalized_phone1_method.should eql('31308612906')
+      home.country_code = 'DE'
+      home.normalized_phone1_method.should eql('49308612906')
+      home.country_code = nil
+      home.normalized_phone1_method(:country_code => nil).should eql('49308612906')
+    end
+  end
+
+  describe 'using ActiveRecord#phony_normalize' do
+    it "should set a normalized version of an attribute" do
+      home = Home.new(:phone_number => "+31-(0)10-1234123")
+      home.valid?
+      home.phone_number.should eql('31101234123')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,30 @@
+require 'rubygems'
+require 'bundler/setup'
+
+
+require 'active_record'
+require 'phony_rails'
+
+ActiveRecord::Base.establish_connection(
+  :adapter  => "sqlite3",
+  :database => ":memory:"
+)
+
+ActiveRecord::Schema.define do
+create_table :homes do |table|
+  table.column :phone_attribute, :string
+  table.column :phone_number, :string
+end
+end
+
+class Home < ActiveRecord::Base
+  attr_accessor :phone_method, :phone1_method, :country_code
+  phony_normalized_method :phone_attribute # adds normalized_phone_attribute method
+  phony_normalized_method :phone_method # adds normalized_phone_method method
+  phony_normalized_method :phone1_method, :default_country_code => 'DE' # adds normalized_phone_method method
+  phony_normalize :phone_number # normalized on validation
+end
+
+RSpec.configure do |config|
+  # some (optional) config here  
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phony_rails
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-07 00:00:00.000000000 Z
+date: 2012-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: phony
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.7
+        version: 1.7.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.6.7
+        version: 1.7.4
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -60,6 +61,8 @@ files:
 - lib/phony_rails/version.rb
 - lib/validators/phony_validator.rb
 - phony_rails.gemspec
+- spec/lib/phony_rails_spec.rb
+- spec/spec_helper.rb
 homepage: ''
 licenses: []
 post_install_message: 
@@ -85,4 +88,7 @@ signing_key:
 specification_version: 3
 summary: This Gem adds useful methods to your Rails app to validate, display and save
   phone numbers.
-test_files: []
+test_files:
+- spec/lib/phony_rails_spec.rb
+- spec/spec_helper.rb
+has_rdoc: