phony_rails 0.0.12 → 0.1.0

data/Gemfile

@@ -1,4 +1,6 @@
-source 'https://rubygems.org'
+source :rubygems
+gemspec # Specify your gem's dependencies in phony_number.gemspec
 
-# Specify your gem's dependencies in phony_number.gemspec
-gemspec
+# For testing
+gem 'rspec'
+gem 'sqlite3'

data/README.md

@@ -24,7 +24,7 @@ Or install it yourself as:
 In your model add:
 
     class SomeModel < ActiveRecord::Base
-      phony_normalize :phone_number, :default_country_code => 'US' # Normalizes the attribute itself
+      phony_normalize :phone_number, :default_country_code => 'US' # Normalizes the attribute itself on validation
       phony_normalized_method :fax_number # Creates method normalized_fax_number that returns the normalized version of fax_number
     end
 

data/lib/phony_rails.rb

@@ -16,7 +16,10 @@ module PhonyRails
     'IT' => '39',
     'US' => '1',
     'AU' => '61',
-    'LU' => '352'
+    'LU' => '352',
+    'AT' => '43',
+    'CH' => '41',
+    'PL' => '48'
   }
 
   # This method requires a country_code attribute (eg. NL) and phone_number to be set.
@@ -86,13 +89,14 @@ module PhonyRails
       #   phony_normalized_method :fax_number, :default_country_code => 'US'
       # Creates a normalized_fax_number method.
       def phony_normalized_method(*attributes)
-        options = attributes.last.is_a?(Hash) ? attributes.pop : {} 
-        options.assert_valid_keys :country_code, :default_country_code
+        main_options = attributes.last.is_a?(Hash) ? attributes.pop : {} 
+        main_options.assert_valid_keys :country_code, :default_country_code
         attributes.each do |attribute|
-          define_method :"normalized_#{attribute}" do
-            raise ArgumentError, "Attribute #{attribute} was not found on #{self.name} (PhonyRails)" unless self.class.attribute_method?(attribute)
+          raise StandardError, "Instance method normalized_#{attribute} already exists on #{self.name} (PhonyRails)" if self.instance_methods.include?(:"normalized_#{attribute}")
+          define_method :"normalized_#{attribute}" do |options = {}|
+            raise ArgumentError, "No attribute/method #{attribute} found on #{self.class.name} (PhonyRails)" if not self.respond_to?(attribute)
             options[:country_code] ||= self.country_code if self.respond_to?(:country_code)
-            PhonyRails.normalize_number(self[attribute], options)
+            PhonyRails.normalize_number(self.send(attribute), main_options.merge(options))
           end
         end
       end

data/lib/phony_rails/version.rb

@@ -1,3 +1,3 @@
 module PhonyRails
-  VERSION = "0.0.12"
+  VERSION = "0.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phony_rails
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-06 00:00:00.000000000 Z
+date: 2012-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: phony