phony 2.2.13 → 2.2.14

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    M2I1OTQyNDFlNDQxNzc1YWQ2OTJlNzk0MzE5ZGQxZDhiOGUwOGM1Yw==
+    NWUyMTkyYzI5ZGQyMGI3YjczZWQzNDJjY2U1NzZjYWQ2ZWJlNGFkYw==
   data.tar.gz: !binary |-
-    ZjNhNmVlMmQxYWMwNGNmYjg0MTI5MjMxOGViZTM4MjAzMTMzY2RiNQ==
+    OGU1NjMxZDk2OTQzYTM4OWUyNTNmNTUwYmI0NjliMTdhYWZkZDJkYw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NWY1ODk4ZjRlNjI2OGZmNzFmN2U3ODAzNDA5MmE1MThlODc0ZDI0NTdhNTI0
-    MTg2NDIxYmVkODg3MmEzNjJlYmU2MjI4Nzc5ODE0YzE5ZTI2N2E5Mjc3MGMy
-    OTBhMjRmMThhMDI3NTliMjM2YWM0YmYzZjczOGY4MzFlOGMyZmE=
+    OThkNWQ5OWQ1NzAxYjNmZDdlYzUyZTlkZjExN2Q0MDg3N2JhNmRlNzdmY2Y4
+    NjEwYjViMjljMmQ0N2RlZTg5MzM0NWYxMzlmOWNiOTEzYWM2MTM1ODc0MTQw
+    NDg2ZjFjYzA0OTJjZmY0MzM5MmY0MzMzNTg0ZmZhN2NhMjI5YzA=
   data.tar.gz: !binary |-
-    NDEyMTBjNTY4MzEwZDI4ZWU3MTUzYTg1YmEzZmFhMmIyNGQzM2Y3YzMzMWY0
-    NmQ0YjNjNWYwYjU5N2YzMjA1NTc5MGVmOGVkM2M0ZWU0M2QwMmVjN2JmNmY0
-    NDE3ZGUwNzEzM2I0YjI3YWY2NDhmZDc2NWY0NWQ3NWY2OTU2ZjY=
+    NjRjNGQxOWIwYzcyNjk0ZTcwMWFjN2YxZmIyZjRjYjUyMGUyZjZlMjgxNTUw
+    MTMzYTNhMjM5Y2YyYTI1MmNlZTdlMTY5ZTg4NDE4NDM2OWI4MjIyODZjM2Mz
+    YTk5NGFiMmQyMWM4MTY3ZDBhNjc1OGUyY2YzYzRlNjg3ZGE4NTQ=

data/README.textile

@@ -1,6 +1,6 @@
 "!{float:right}https://secure.travis-ci.org/floere/phony.png!":http://travis-ci.org/floere/phony
 "!https://codeclimate.com/github/floere/phony.png!":https://codeclimate.com/github/floere/phony
-!http://inch-pages.github.io/github/floere/phony.png!:http://inch-pages.github.io/github/floere/phony
+!http://inch-ci.org/github/floere/phony.png!:http://inch-ci.org/github/floere/phony
 
 h1. Phony
 

data/lib/phony.rb

@@ -25,6 +25,7 @@ require File.expand_path '../phony/countries/bangladesh', __FILE__
 require File.expand_path '../phony/countries/belarus', __FILE__
 require File.expand_path '../phony/countries/brazil', __FILE__
 require File.expand_path '../phony/countries/cambodia', __FILE__
+require File.expand_path '../phony/countries/croatia', __FILE__
 require File.expand_path '../phony/countries/china', __FILE__
 require File.expand_path '../phony/countries/georgia', __FILE__
 require File.expand_path '../phony/countries/germany', __FILE__

data/lib/phony/countries.rb

@@ -624,10 +624,7 @@ Phony.define do
   country '383', todo # -
   country '384', todo # -
 
-  # Croatia.
-  #
-  country = country '385', one_of('1') >> split(3, 5) | # Zagreb
-                           fixed(2) >> split(3, 5)      # 2-digit NDCs
+  # country '385' # Croatia, see special file.
 
   country '386', fixed(2) >> split(3, 2, 2) # Slovenia
   country '387', fixed(2) >> split(3,2,2) # Bosnia and Herzegovina

data/lib/phony/countries/croatia.rb

@@ -0,0 +1,25 @@
+# Croatia
+#
+# http://en.wikipedia.org/wiki/Telephone_numbers_in_Croatia
+# http://dialcode.org/Europe/Croatia/
+# http://www.howtocallabroad.com/croatia/
+#
+# Landline numbers are composed by a 2 digits area code + 6 fixed digits 
+# Mobile numbers are composed by a 2 digits prefix + 7 fixed digits 
+#
+
+mobile = %w(
+  91
+  92
+  95
+  97
+  977
+  98
+  99
+)
+
+Phony.define do
+  country '385', one_of(mobile) >> split(3, 4) |
+                 one_of('1')    >> split(4, 3) | # Zagreb
+                 fixed(2)       >> split(3, 3)   # 2-digit NDCs
+end

data/spec/functional/plausibility_spec.rb

@@ -259,13 +259,27 @@ describe 'plausibility' do
         Phony.plausible?("+85523123456").should be_false     # Fixed line (NDC + invalid A)
       end
 
-      it "is correct for Danish numbers" do
+      it 'is correct for Croatia' do
+        # Landline
+        expect(Phony.plausible?('+385 21 695900')).to be_true
+        expect(Phony.plausible?('+385 1 4566 666')).to be_true
+
+        expect(Phony.plausible?('+385 21 12345')).to be_false, "too short"
+        expect(Phony.plausible?('+385 21 1234567')).to be_false, "too long"
+
+        # Mobile
+        expect(Phony.plausible?('+385 91 896 7509')).to be_true
+
+        expect(Phony.plausible?('+385 91 123456')).to be_false, "too short"
+      end
+
+      it "is correct for Denmark" do
         Phony.plausible?('+45 44 11 12 23 34').should be_false
         Phony.plausible?('+45 44 11 12 2').should be_false
         Phony.plausible?('+45 44 55 22 33').should be_true
       end
 
-      it 'is correct for Dutch numbers' do
+      it 'is correct for Netherlands' do
         Phony.plausible?('+31 6 12 34 56 78').should be_true
         Phony.plausible?('+31 6 12 34 56 7').should be_false
         Phony.plausible?('+31 20 123 5678').should be_true
@@ -278,7 +292,7 @@ describe 'plausibility' do
         Phony.plausible?('+31 900 001 00').should be_false
       end
 
-      it 'is correct for Egyptian numbers' do
+      it 'is correct for Egypt' do
         Phony.plausible?('+20 800 1234567').should be_true
         Phony.plausible?('+20 800 12345678').should be_false
         Phony.plausible?('+20 2 12345678').should be_true
@@ -287,7 +301,7 @@ describe 'plausibility' do
         Phony.plausible?('+20 40 1234567').should be_false
       end
 
-      it 'is correct for German numbers' do
+      it 'is correct for Germany' do
         Phony.plausible?('+49 209 169 - 0').should be_true # Gelsenkirchen
         Phony.plausible?('+49 209 169 - 3530').should be_true # Gelsenkirchen
         Phony.plausible?('+49 40 123 45678').should be_true
@@ -326,12 +340,12 @@ describe 'plausibility' do
         Phony.plausible?('+49 40 12345678901').should be_true
       end
 
-      it 'is correct for Israelian numbers' do
+      it 'is correct for Israel' do
         Phony.plausible?('+972 2 123 1234').should be_true
         Phony.plausible?('+972 59 123 1234').should be_true
       end
 
-      it 'is correct for Italian numbers' do
+      it 'is correct for Italy' do
         Phony.plausible?('+39 06 1234 4567').should be_true
 
         Phony.plausible?('+39 035 00000').should be_false

data/spec/lib/phony/countries_spec.rb

@@ -147,8 +147,9 @@ describe 'country descriptions' do
       it_splits '573101234567', ['57', '310', '123', '4567'] # mobile
     end
     describe 'Croatia' do
-      it_splits '385112312345', ['385', '1', '123', '12345'] # Zagreb
-      it_splits '385491231234', ['385', '49', '123', '1234'] # Krapina
+      it_splits '38521695900',  %w( 385 21 695 900 )  # Landline
+      it_splits '38514566666',  %w( 385 1 4566 666 )  # Landline (Zagreb)
+      it_splits '385918967509', %w( 385 91 896 7509 ) # Mobile
     end
     describe 'Cuba' do
       it_splits '5351231234', ['53', '5123', '1234'] # Mobile

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 2.2.13
+  version: 2.2.14
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-27 00:00:00.000000000 Z
+date: 2014-08-04 00:00:00.000000000 Z
 dependencies: []
 description: ! 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national
@@ -25,6 +25,7 @@ files:
 - lib/phony/countries/brazil.rb
 - lib/phony/countries/cambodia.rb
 - lib/phony/countries/china.rb
+- lib/phony/countries/croatia.rb
 - lib/phony/countries/georgia.rb
 - lib/phony/countries/germany.rb
 - lib/phony/countries/india.rb