phony 2.12.11 → 2.12.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1162661f981cd2f15b38bb16353bd0b3fe5494c
-  data.tar.gz: 113626e3af2ef2efc0a23354dff6e29805523b02
+  metadata.gz: 0413986973e6c4d3f359a59ae739c43efc8ef2b5
+  data.tar.gz: f0cb839c8fb1f6f718a713b01e8e9c0fbc66538a
 SHA512:
-  metadata.gz: ee0e39389cca7d127e1eb5ffc957d7dd5bc04e5afdff48c9e1308090444e0872f43e1430def823fe98b0fe1be6a766356b59950ed7ff58ee2d0cd5aa2d17ee09
-  data.tar.gz: 956b831f60a63a3b443e9cb6ab6348ba85a574a926f32f523e9cd8f61ea13e65e608b2bd3a6814ee1afe6ac9edab071babe1f5a5bd340a33ab39ea2b19ee4844
+  metadata.gz: e3a65f282d2feb6c846fad5b870c759e99ed60939b649326f96ced72b253e62223624c4f3d202c1466c5e871f4f2346295f1b31ce2f182d11d36d9c978b4e306
+  data.tar.gz: 6ccbb11ac1c8590ffd4a47ef260eda590fe1c5524dfbb9e22b0be8c6a364683864b8cd09d139e5bc6ebb3a3bdc94f909d56dec7442c9e5cf648d25fff4b413ee

data/README.textile

@@ -1,4 +1,5 @@
 "!{float:right}https://secure.travis-ci.org/floere/phony.png!":http://travis-ci.org/floere/phony
+!https://coveralls.io/repos/floere/phony/badge.svg?branch=master(Coverage Status)!:https://coveralls.io/r/floere/phony?branch=master
 "!https://codeclimate.com/github/floere/phony.png!":https://codeclimate.com/github/floere/phony
 !http://inch-ci.org/github/floere/phony.png!:http://inch-ci.org/github/floere/phony
 

data/lib/phony.rb

@@ -59,13 +59,21 @@ require File.expand_path '../phony/countries/ukraine', __FILE__
 require File.expand_path '../phony/countries/united_kingdom', __FILE__
 require File.expand_path '../phony/countries/uruguay', __FILE__
 require File.expand_path '../phony/countries/zimbabwe', __FILE__
-#
+
 # All other countries.
 #
 require File.expand_path '../phony/countries', __FILE__
 
+# Phony is the main module and is generally used to process
+# E164 phone numbers directly.
+#
 module Phony
 
+  # Raised in case Phony can't normalize a given number.
+  #
+  # @example
+  #   Phony.normalize("Fnork!") # Raises a Phony::NormalizationError.
+  #
   class NormalizationError < StandardError
     def initialize
       super %Q{Phony could not normalize the given number. Is it a phone number?}
@@ -80,22 +88,56 @@ module Phony
 
     # Get the Country for the given CC.
     #
-    # Example:
-    #   us = Phony['1']
-    #   normalized_number = us.normalize number
+    # @param [String] cc A valid country code.
+    #
+    # @return [Country] for the given CC.
+    #
+    # @example Country for the NANP (includes the US)
+    #   nanp = Phony['1']
+    #   normalized_number = nanp.normalize number
     #
     def [] cc
       @codes[cc]
     end
 
-    # Normalizes the given number.
+    # Normalizes the given number into a digits-only String.
     #
     # Useful before inserting the number into a database.
     #
+    # @param [String] phone_number An E164 number.
+    # @param [Hash] options An options hash (With :cc as the only used key).
+    #
+    # @return [String] A normalized E164 number.
+    #
+    # @raise [Phony::NormalizationError] If phony can't normalize the given number.
+    #
+    # @example Normalize a Swiss number.
+    #   Phony.normalize("+41 (044) 123 45 67") # => "41441234567"
+    #
+    # @example Normalize a phone number assuming it's a NANP number.
+    #   Phony.normalize("301 555 0100", cc: '1') # => "13015550100"
+    #
     def normalize phone_number, options = {}
       raise ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.normalize(number)." unless phone_number
       normalize! phone_number.dup, options
     end
+    # A destructive version of {#normalize}.
+    #
+    # @see #normalize
+    #
+    # @param [String] phone_number An E164 number.
+    # @param [Hash] options An options hash (With :cc as the only used key).
+    #
+    # @return [String] The normalized E164 number.
+    #
+    # @raise [Phony::NormalizationError] If phony can't normalize the given number.
+    #
+    # @example Normalize a Swiss number.
+    #   Phony.normalize!("+41 (044) 123 45 67") # => "41441234567"
+    #
+    # @example Normalize a phone number assuming it's a NANP number.
+    #   Phony.normalize!("301 555 0100", cc: '1') # => "13015550100"
+    #
     def normalize! phone_number, options = {}
       @codes.normalize phone_number, options
     rescue
@@ -104,22 +146,86 @@ module Phony
 
     # Splits the phone number into pieces according to the country codes.
     #
+    # Useful for manually processing the CC, NDC, and local pieces.
+    #
+    # @param [String] phone_number An E164 number.
+    #
+    # @return [Array<String>] The pieces of a phone number.
+    #
+    # @example Split a Swiss number.
+    #   Phony.split("41441234567") # => ["41", "44", "123", "45", "67"]
+    #
+    # @example Split a NANP number.
+    #   Phony.split("13015550100") # => ["1", "301", "555", "0100"]
+    #
     def split phone_number
       raise ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.split(number)." unless phone_number
       split! phone_number.dup
     end
+    # A destructive version of {#split}.
+    #
+    # @see #split
+    #
+    # @param [String] phone_number An E164 number.
+    #
+    # @return [Array<String>] The pieces of the phone number.
+    #
+    # @example Split a Swiss number.
+    #   Phony.split!("41441234567") # => ["41", "44", "123", "45", "67"]
+    #
+    # @example Split a NANP number.
+    #   Phony.split!("13015550100") # => ["1", "301", "555", "0100"]
+    #
     def split! phone_number
       parts = @codes.split phone_number
       parts.delete_at 1
       parts
     end
 
-    # Formats a E164 number according to local customs.
+    # Formats a normalized E164 number according to a country's formatting scheme.
+    #
+    # Absolutely needs a normalized E164 number.
+    #
+    # @param [String] phone_number A normalized E164 number.
+    # @param [Hash] options See the README for a list of options.
+    #
+    # @return [Array<String>] The pieces of a phone number.
+    #
+    # @example Format a Swiss number.
+    #   Phony.format("41441234567") # => "+41 44 123 45 67"
+    #
+    # @example Format a NANP number.
+    #   Phony.format("13015550100") # => "+1 301 555 0100"
+    #
+    # @example Format a NANP number in local format.
+    #   Phony.format("13015550100", :format => :local) # => "555 0100"
     #
     def format phone_number, options = {}
       raise ArgumentError, "Phone number cannot be nil. Use e.g. number && Phony.format(number)." unless phone_number
       format! phone_number.dup, options
     end
+    # A destructive version of {#format}.
+    #
+    # @see #format
+    #
+    # Formats a normalized E164 number according to a country's formatting scheme.
+    #
+    # Absolutely needs a normalized E164 number.
+    #
+    # @param [String] phone_number A normalized E164 number.
+    # @param [Hash] options See the README for a list of options.
+    #
+    # @return [Array<String>] The pieces of the phone number.
+    #
+    # @example Format a Swiss number.
+    #   Phony.format!("41441234567") # => "+41 44 123 45 67"
+    #
+    # @example Format a NANP number.
+    #   Phony.format!("13015550100") # => "+1 301 555 0100"
+    #
+    # @example Format a NANP number in local format.
+    #   Phony.format!("13015550100", :format => :local) # => "555 0100"
+    #
     def format! phone_number, options = {}
       @codes.format phone_number, options
     end
@@ -146,6 +252,13 @@ module Phony
     # Converts any character in the vanity_number to its numeric representation.
     # Does not check if the passed number is a valid vanity_number, simply does replacement.
     #
+    # @param [String] vanity_number A vanity number.
+    #
+    # @return [String] The de-vanitized phone number.
+    #
+    # @example De-vanitize a number.
+    #   Phony.vanity_to_number("1-800-HELLOTHERE") # => "1-800-4355684373"
+    #
     def vanity_to_number vanity_number
       @codes.vanity_to_number vanity_number.dup
     end

data/lib/phony/countries.rb

@@ -23,6 +23,24 @@
 #
 # Note: The ones that are commented are defined in their special files.
 #
+# @example Switzerland (simplified)
+#   country('41', fixed(2) >> local([3,2,2]))
+#
+# @example Germany. Too big, we use a separate file
+#   Phony.define do
+#     country '49', match(...) >> split([...]) ||
+#                   one_of([...], :max_length => 5) >> split([...])
+#   end
+#
+# @example Denmark
+#   country('45', none >> split([2,2,2,2]))
+#
+# @example Hungary
+#   country('36',
+#           match(/^104|105|107|112/) >> split([3,3]) ||
+#           one_of([1], :max_length => 2) >> split([3,4])
+#   )
+#
 Phony.define do
 
   # Reserved.
@@ -336,6 +354,7 @@ Phony.define do
     none >> matched_split(
         /\A[23]\d+\z/ => [4,4], # LIBTELCO, TEMAS
         /\A[4568]\d+\z/ => [4,3], # mobile Lonestar, Libercell, Comium Liberia Inc.
+        /\A77\d+\z/ => [2,3,4], # http://monrovia.usembassy.gov/contact.html
         /\A7\d+\z/ => [4,4], # mobile Cellcom
         /\A9\d+\z/ => [4,4], # premium rate Telelinks International SAL, Interactive Media Corporation
     )

data/lib/phony/countries/austria.rb

@@ -78,7 +78,7 @@ service = [
  '939'
 ]
 
-# https://www.rtr.at/en/tk/E129/Austrian_Numbering_Plan_2011-03-30.pdf
+# https://www.rtr.at/en/tk/E129/2312_Austrian_Numbering_Plan_2011-03-30.pdf
 #
 # TODO Add more details.
 #
@@ -91,5 +91,5 @@ Phony.define do
                 one_of('663')     >> split(6..6) | # 6 digit mobile.
                 one_of(mobile)    >> split(4,3..9) |
                 one_of(mobile_2digit) >> split(7..7) | # Separate as mobile contains 676 - 67 violates the prefix rule.
-                fixed(4)          >> split(7..7)
-end
+                fixed(4)          >> split(3..9) # Number length is 7..13.
+end

data/lib/phony/country_codes.rb

@@ -121,12 +121,12 @@ module Phony
         format % { :cc => cc, :ndc => ndc, :local => local }
       when nil, :international_absolute, :international, :+
         ndc ?
-          @international_absolute_format % [cc, space, ndc, space, local] :
-          @international_absolute_format % [cc, space, local, nil, nil]
+          format_with_ndc(@international_absolute_format, cc, ndc, local, space) :
+          format_without_ndc(@international_absolute_format, cc, local, space)
       when :international_relative
         ndc ?
-          @international_relative_format % [cc, space, ndc, space, local] :
-          @international_relative_format % [cc, space, local, nil, nil]
+          format_with_ndc(@international_relative_format, cc, ndc, local, space) :
+          format_without_ndc(@international_relative_format, cc, local, space)
       when :national
         # Replaces the %s in the trunk code with a "space".
         trunk = trunk % space if trunk && trunk.size > 1
@@ -141,6 +141,13 @@ module Phony
       parts_ary.compact!
       parts_ary.join local_space.to_s
     end
+    
+    def format_with_ndc format, cc, ndc, local, space
+      format % [cc, space, ndc, space, local]
+    end
+    def format_without_ndc format, cc, local, space
+      format % [cc, space, local, nil, nil]
+    end
 
     #
     #

data/lib/phony/dsl.rb

@@ -1,27 +1,3 @@
-# # Switzerland (simplified):
-# #
-# country('41', fixed(2) >> local([3,2,2]))
-#
-# # Germany. Too big, we use a separate file:
-# #
-# Phony.define do
-#   country '49', match(...) >> split([...]) ||
-#                 one_of([...], :max_length => 5) >> split([...])
-# end
-#
-# # Denmark:
-# #
-# country('45', none >> split([2,2,2,2]))
-#
-# # Hungary:
-# #
-# country('36',
-#         match(/^104|105|107|112/) >> split([3,3]) ||
-#         one_of([1], :max_length => 2) >> split([3,4])
-# )
-#
-# Note: Perhaps the DSL should operate directly on country codes.
-#
 module Phony
 
   # For country definitions.
@@ -42,11 +18,26 @@ module Phony
     dsl
   end
 
+  # Contains a number of DSL methods. Is used e.g. in the countries.rb file.
+  #
+  # Do not use directly, but instead use {Phony.define} to execute a block
+  # in the DSL instance's context.
+  #
+  # @example
+  #   Phony.define { ... }
+  #
   class DSL
 
-    # Start defining a country.
+    # Define a country's rules.
+    #
+    # Use the other DSL methods to define the country's rules.
+    #
+    # @param [String] country_code The country code of the country.
+    # @param [Phony::CountryCodes] definition Rules for this country.
+    #
+    # @return Undefined.
     #
-    # Example:
+    # @example Add a country with country code 27.
     #   country '27', # CC, followed by rules, for example fixed(2) >> ...
     #
     def country country_code, definition, options = {}
@@ -55,12 +46,25 @@ module Phony
     end
     
     # Designates a country code as reserved.
+    # A reserved country will result in an exception when trying to be used.
+    #
+    # @param [String] country_code The country code of the country.
+    #
+    # @return nil
+    #
+    # @example Designate country code 27 as reserved.
+    #   reserved('27')
     #
     def reserved country_code
       # Does nothing, will just fail with an exception.
     end
     
-    # This country still uses a default NDC (and needs to be done, hence the todo).
+    # Define a country to use default rules (and to be done at some point).
+    #
+    # @return Rules for a country.
+    #
+    # @example Define country 27 to use default rules.
+    #   country '27', todo
     #
     def todo
       none >> split(10)
@@ -68,10 +72,19 @@ module Phony
     
     # This country uses a trunk code.
     #
-    # Examples:
-    #  * Hungary uses 06.
-    #  * North America uses 1.
-    #  * Most countries which use a trunk code use 0.
+    # @param [String] code The trunk code.
+    # @param [Hash] options Options hash. Pass :normalize (true/false) to indicate whether it needs to be normalized.
+    #
+    # @return TrunkCode A trunk code handler.
+    #
+    # @example Hungary uses 06.
+    #   country '36', trunk('06', normalize: false) | ...
+    #
+    # @example North America uses 1.
+    #   country '1', trunk('1%s', normalize: true) | ...
+    #
+    # @example Most countries which use a trunk code use 0. E.g. Romania.
+    #   country '40', trunk('0') | ...
     #
     def trunk code, options = {}
       TrunkCode.new code, options
@@ -84,12 +97,12 @@ module Phony
     # uses a zero prefix when formatted
     # with format :national.
     #
-    # Options:
-    #  * length: Length of the fixed length NDC.
-    #  * options: Set :zero to false to not add a zero on format :national.
+    # @param [Fixnum] length The length of the fixed length NDC.
+    # @param [Hash] options An options hash (set zero: false to not add a zero on format :national).
     #
-    # Example:
-    #   # France, uses a fixed NDC of size 1.
+    # @return NationalSplitters::Fixed A fixed length national splitter.
+    #
+    # @example France. Uses a fixed NDC of size 1.
     #   country '33', fixed(1) >> split(2,2,2,2)
     #
     def fixed length, options = {}
@@ -97,13 +110,11 @@ module Phony
       NationalSplitters::Fixed.instance_for length, options
     end
     
-    # This country does not use an NDC. This rule will always match.
+    # Marks the country as not using an NDC. This rule will always match.
+    #
+    # @return NationalSplitters::None A no-ndc national splitter.
     #
-    # Examples:
-    #   * Denmark
-    #   * Norway
-    #   * Iceland
-    #   (and more)
+    # @example Denmark, Norway, Iceland.
     #
     def none
       NationalSplitters::None.instance_for
@@ -112,11 +123,11 @@ module Phony
     # If you have a number of (possibly) variable length NDCs
     # that cannot be well expressed via regexp, use this.
     #
-    # Parameters:
-    #   * ndcs A list of ndcs of variable length.
-    #   * Can contain :max_length => number to denote a maximum NDC length.
+    # @param [Array<String>] ndcs A list of NDCs of variable length. Can contain :max_length => number to denote a maximum NDC length.
+    #
+    # @return NationalSplitters::Variable A variable size national splitter.
     #
-    # Example:
+    # @example With two NDCs
     #   country '51',
     #     # If it's either 103 or 105, then split ...
     #     one_of('103', '105') >> split(3,3)
@@ -134,10 +145,11 @@ module Phony
     # If you have a number of (possibly) variable length NDCs
     # that can be well expressed via regexp, use this.
     #
-    # Parameters:
-    #   * regex A regexp describing the NDCs (First group must contain the NDC, eg. /^(0\d{2})\d+$/) contains all NDCs with 0xx...
+    # @param [Regexp] regex A Regexp describing the NDCs (First group must contain the NDC, eg. /^(0\d{2})\d+$/) contains all NDCs with 0xx...
     #
-    # Example:
+    # @return NationalSplitters::Regex A regexp-based national splitter.
+    #
+    # @example With several NDC matchers.
     #   country '52',
     #     match(/^(0\d{2})\d+$/)   >> split(2,2,2,2) |
     #     match(/^(33|55|81)\d+$/) >> split(2,2,2,2) |
@@ -158,7 +170,11 @@ module Phony
     #
     # Also takes ranges.
     #
-    # Example:
+    # @param [Array<Fixnum>] local The local group sizes to split the local number part into.
+    #
+    # @return LocalSplitters::Fixed A fixed size local splitter.
+    #
+    # @example Splitting in 4 even groups of two digits.
     #   match(/^(0\d{2})\d+$/) >> split(2,2,2,2) # If it matches, split in 4 groups of size 2.
     #
     def split *local
@@ -171,18 +187,18 @@ module Phony
     #
     # Also takes ranges.
     #
-    # Options:
-    #   * fallback A fallback amount of group sizes in case it doesn't match.
+    # @param [Hash] options Can contain option :fallback A fallback amount of group sizes in case it doesn't match.
     #
-    # Example:
-    #   # Norway
+    # @return LocalSplitters::Regex A regexp-based local splitter.
+    #
+    # @example Norway
     #   country '47',
     #     none >> matched_split(/^[1].*$/   => [3],
     #                           /^[489].*$/ => [3,2,3],
     #                           :fallback   => [2,2,2,2])
     #
     def matched_split options = {}
-      Phony::LocalSplitters::Regex.instance_for options
+      LocalSplitters::Regex.instance_for options
     end
     
     # Validators
@@ -190,9 +206,11 @@ module Phony
     
     # Which NDCs are explicitly invalid?
     #
-    # Takes a regexp or a string.
+    # @param [Regexp, String] ndc A regexp or a string of invalid NDCs.
+    #
+    # @return Validators::NDC An NDC validator 
     #
-    # Example:
+    # @example NANP
     #   country '1',
     #     fixed(3, :zero => false) >> split(3,4),
     #     invalid_ndcs('911') # The regexp /911/ would also work.

data/lib/phony/national_splitters/default.rb

@@ -10,10 +10,30 @@ module Phony
         @instance ||= new
       end
 
+      # "Splits" the national part of a phone number into a single piece.
+      #
+      # @param [String] national_number An national part of a number.
+      #
+      # @return [Array<String>] An Array with the given number part as its element.
+      #
+      # @example Split the national part of a Swiss number.
+      #   Phony.split("1234567") # => ["1234567"]
+      #
       def split national_number
         [national_number]
       end
       
+      # By default, the national part of a number is always plausible.
+      #
+      # @param [String] rest An national part of a number (ignored).
+      # @param [Fixnum] size Size (ignored).
+      # @param [Hash] hints Hints (ignored).
+      #
+      # @return [Boolean] Always true.
+      #
+      # @example Split the national part of a Swiss number.
+      #   Phony.plausible?("1234567") # => true
+      #
       def plausible? rest, size, hints = {}
         true
       end

data/lib/phony/national_splitters/dsl.rb

@@ -9,12 +9,7 @@ module Phony
       #
       #
       def >> local_splitter
-        if local_splitter.respond_to? :split
-          country_for local_splitter
-        else
-          local_splitter.national_splitter = self
-          local_splitter
-        end
+        country_for local_splitter
       end
       
       def country_for local_splitter

data/lib/phony/national_splitters/variable.rb

@@ -18,8 +18,10 @@ module Phony
         
         # Extract a starting point.
         #
+        # This if can possibly be removed.
+        #
         presumed_code = if @mapped_ndc_min_length > 0
-          national_number.slice!(0..@mapped_ndc_min_length-1)
+          presumed_code = national_number.slice!(0..@mapped_ndc_min_length-1)
         else
           ''
         end

data/spec/functional/plausibility_spec.rb

@@ -140,6 +140,7 @@ describe 'plausibility' do
         Phony.plausible?('+43 501 1234').should be_false # too short
         Phony.plausible?('+43 501 123456').should be_false # too long
         Phony.plausible?('+43 800 123456789').should be_true
+        Phony.plausible?('+43 3115 3307').should be_true # See issue #246 on Github.
 
         # Mobile
         Phony.plausible?('+43 676 0000000').should be_true
@@ -743,7 +744,11 @@ describe 'plausibility' do
                                                 '+961 90 123 456',
                                                 '+961 81 123 456']
       it_is_correct_for 'Lesotho', :samples => '+266  7612 6866'
-      it_is_correct_for 'Liberia', :samples => [['+231 2 123 4567', '+231 4 123 456']]
+      it 'is correct for Liberia' do
+        Phony.plausible?('+231 2 123 4567').should be_true
+        Phony.plausible?('+231 4 123 456').should be_true
+        Phony.plausible?('+231 77 123 4567').should be_true
+      end
       it_is_correct_for 'Madagascar', :samples => ['+261 20 012 345 678',
                                                    '+261 20 124 3456',
                                                    '+261 512 345 678']

data/spec/lib/phony/countries_spec.rb

@@ -861,6 +861,7 @@ describe 'country descriptions' do
     describe 'Liberia' do
       it_splits '23121234567', ['231', false, '2123', '4567']
       it_splits '2314123456', ['231', false, '4123', '456']
+      it_splits '231771234567', ['231', false, '77', '123', '4567']
     end
     describe 'Libya' do
       it_splits '21820512345', %w(218 205 123 45)

data/spec/lib/phony/national_splitters/default_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe Phony::NationalSplitters::Default do
+  
+  describe 'instance_for' do
+    it 'caches' do
+      described_class.instance_for.should equal(described_class.instance_for)
+    end
+  end
+  
+  context 'with instance' do
+    let(:splitter) { described_class.instance_for }
+    
+    describe 'split' do
+      it 'does not split' do
+        splitter.split(:anything).should == [:anything]
+      end
+    end
+    
+    describe 'plausible?' do
+      it 'is always plausible' do
+        splitter.plausible?(:anything, :anything).should be_true
+      end
+    end
+    
+    describe 'length' do
+      it 'needs to be at least 3' do
+        splitter.length.should == 3
+      end
+    end
+    
+  end
+  
+end

data/spec/lib/phony/national_splitters/fixed_spec.rb

@@ -24,6 +24,9 @@ describe Phony::NationalSplitters::Fixed do
     it 'splits correctly even when the number is too short' do
       @splitter.split('443').should == [nil, '44','3']
     end
+    it 'has a length of 2' do
+      @splitter.length.should == 2
+    end
   end
   describe 'split' do
     before(:each) do
@@ -38,6 +41,9 @@ describe Phony::NationalSplitters::Fixed do
     it 'splits correctly even when the number is too short' do
       @splitter.split('443').should == [nil, '443']
     end
+    it 'has a length of nil' do
+      @splitter.length.should == nil
+    end
   end
   
 end

data/spec/lib/phony/national_splitters/none_spec.rb

@@ -8,11 +8,21 @@ describe Phony::NationalSplitters::None do
     end
   end
   
-  describe 'split' do
+  context 'with instance' do
     let(:splitter) { described_class.instance_for }
-    it 'splits correctly into ndc and rest' do
-      splitter.split('123456789').should == [nil, false, '123456789']
+  
+    describe 'split' do
+      it 'splits correctly into ndc and rest' do
+        splitter.split('123456789').should == [nil, false, '123456789']
+      end
+    end
+    
+    describe 'length' do
+      it 'is always 0' do
+        splitter.length.should be_zero
+      end
     end
+    
   end
   
 end

data/spec/lib/phony/national_splitters/variable_spec.rb

@@ -19,6 +19,9 @@ describe Phony::NationalSplitters::Variable do
       it "handles Rohrau" do
         @splitter.split('2164123456789').should == [nil, '2164', '123456789']
       end
+      it 'has an NDC length of 3' do
+        @splitter.length.should == (1..3)
+      end
     end
     context 'special handling for using the variable size splitter for Swiss service numbers' do
       before(:each) do
@@ -27,6 +30,9 @@ describe Phony::NationalSplitters::Variable do
       it "should handle swiss service numbers" do
         @splitter.split('800223344').should == [nil, '800', '223344']
       end
+      it 'has an NDC length of 3' do
+        @splitter.length.should == (3..3)
+      end
     end
   end
   

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 2.12.11
+  version: 2.12.12
 platform: ruby
 authors:
 - Florian Hanke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-15 00:00:00.000000000 Z
+date: 2015-04-26 00:00:00.000000000 Z
 dependencies: []
 description: 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national
@@ -86,6 +86,7 @@ files:
 - spec/lib/phony/local_splitters/fixed_spec.rb
 - spec/lib/phony/local_splitters/regex_spec.rb
 - spec/lib/phony/national_code_spec.rb
+- spec/lib/phony/national_splitters/default_spec.rb
 - spec/lib/phony/national_splitters/fixed_spec.rb
 - spec/lib/phony/national_splitters/none_spec.rb
 - spec/lib/phony/national_splitters/regex_spec.rb
@@ -129,6 +130,7 @@ test_files:
 - spec/lib/phony/local_splitters/fixed_spec.rb
 - spec/lib/phony/local_splitters/regex_spec.rb
 - spec/lib/phony/national_code_spec.rb
+- spec/lib/phony/national_splitters/default_spec.rb
 - spec/lib/phony/national_splitters/fixed_spec.rb
 - spec/lib/phony/national_splitters/none_spec.rb
 - spec/lib/phony/national_splitters/regex_spec.rb