phony 1.6.2 → 1.6.3

data/lib/phony.rb

@@ -21,6 +21,7 @@ require File.expand_path '../phony/dsl', __FILE__
 require File.expand_path '../phony/countries/austria', __FILE__
 require File.expand_path '../phony/countries/china', __FILE__
 require File.expand_path '../phony/countries/germany', __FILE__
+require File.expand_path '../phony/countries/ireland', __FILE__
 require File.expand_path '../phony/countries/italy', __FILE__
 require File.expand_path '../phony/countries/malaysia', __FILE__
 require File.expand_path '../phony/countries/netherlands', __FILE__

data/lib/phony/countries.rb

@@ -310,7 +310,9 @@ Phony.define do
                  fixed(3)             >> split(3,4)   # 3-digit NDCs
 
   country '352', todo # Luxembourg
-  country '353', todo # Ireland (0-3-4)
+
+  # country '353' # Republic of Ireland, see special file.
+
   country '354', none >> split(3,4) # Iceland
   country '355', todo # Albania
   country '356', todo # Malta

data/lib/phony/countries/ireland.rb

@@ -0,0 +1,76 @@
+# The Republic of Ireland has variable-length NDCs from 2-3 digits in length.  Depending on the NDC, the length of the subscriber number varies from 5-7 characters in length.  There does not appear to be any pattern that relates NDCs to subscriber number length.
+#
+# 7 digit subscriber numbers follow a 3-4 split pattern.
+# 5 and 6 digit subscriber numbers appear split in some examples, and not in others; to be conservative, these are not currently split.  
+#
+# For NDCs that are not recognized, we fall back to not attempting to split out an NDC at all. 
+#
+# References:
+# http://www.comreg.ie/_fileupload/publications/ComReg03147.pdf
+# http://en.wikipedia.org/wiki/Telephone_numbers_in_the_Republic_of_Ireland
+#
+handlers = []
+
+ndcs_with_5_subscriber_digits = [
+  ('22'..'29').to_a, # Mallow, Bandon, Youghal, Fermoy, Macroom, Bantry, Skibbereen, Kanturk
+  '402',  # Arklow
+  '404',  # Wicklow
+  '43',   # Longford, Granard
+  '44',   # Mullingar, Castlepollard, Tyrellspass
+  '47',   # Monaghan, Clones
+  '48',   # Northern Ireland
+  '502',  # Portlaoise, Abbeyleix
+  '504',  # Thurles
+  '505',  # Roscrea
+  '506',  # Tullamore
+  '509',  # Bin-
+  ('52'..'55').to_a, # Killenaule, Wexford, Enniscorthy, Ferns, Gorey
+  '62',   # Tipperary, Cashel
+  '63',   # Charleville
+  '64',   # Killarney, Rathmore
+  '67',   # Nenagh
+  '68',   # Listowel
+  '69',   # Newcastle West
+  '76',   # VoIP
+  '93',   # Tuam
+  ('94'..'99').to_a # Castlebar, Castlerea, Claremorris, Clifden, Ballina, Belmullet, Westport, Kilronan
+].flatten
+
+ndcs_with_6_subscriber_digits = [
+  '45',  # Naas, Kildare, Curragh
+  '51',  # Waterford, Carrick-on-Suir, New Ross, Kilmacthomas
+  '61',  # Limerick, Scariff
+  '91',  # Galway, GOrt, Loughrea
+]
+
+ndcs_with_7_subscriber_digits = [
+  '1',  # Dublin
+  '21', # Cork, Coachford, Kinsale
+  '41', # Ardee
+  '42', # Dundalk, Carrickmacross, Castleblaney
+  '46', # Navan, Kells, Trim, Enfield, Edenderry
+  '49', # Cavan, Cootehill, Oldcastle, Belturbet
+  '56', # Kilkenny, Castlecomer
+  '58', # Dungarvan
+  '59', # Carlow, Muine Bheag, Athy, Baltinglass
+  '65', # Ennistymon, Kilrush
+  '66', # Tralee, Dingle, Killorglin, Cahirciveen
+  '71', # Sligo, Manorhamilton, Carrick-on-Shannon
+  '74', # Donegal, Letterkenny, Dungloe, Buncrana
+  '90', # Athlone, Ballinasloe, Portumna, Roscommon
+  '94'  # Ballinrobe
+]
+
+freefone = [
+  '800'
+]
+
+Phony.define do
+  country '353', one_of(ndcs_with_7_subscriber_digits)   >> split(3,4) |
+                 one_of(ndcs_with_5_subscriber_digits)   >> split(5)   |
+                 one_of(ndcs_with_6_subscriber_digits)   >> split(6)   |
+                 one_of(freefone) >> split(6) |
+                 match(/^(8\d).+$/) >> split(3,4) | # mobile
+                 none >> split(0)
+
+end

data/spec/lib/phony/countries_spec.rb

@@ -111,6 +111,15 @@ describe 'country descriptions' do
       Phony.split('3544621234').should == ['354', '462', '1234'] # Akureyri
       Phony.split('3545511234').should == ['354', '551', '1234'] # Reykjavík
     end
+    it 'handles irish numbers' do
+      Phony.split('35311234567').should == ['353', '1', '123', '4567']   # Dublin, 7 digit subscriber #
+      Phony.split('3532212345').should == ['353', '22', '12345']         # Mallow, 5 digit subscriber #
+      Phony.split('35345123456').should == ['353', '45', '123456']       # Naas, 6 digit subscriber #
+      Phony.split('353801234567').should == ['353', '80', '123', '4567'] # Mobile
+      Phony.split('3537612345').should == ['353', '76', '12345'] # VoIP
+      Phony.split('353800123456').should == ['353', '800', '123456']     # Freefone
+      Phony.split('353000123456').should == ['353', '000123456']         # No NDC/local split for unrecognized
+    end
     it 'handles italian numbers' do
       Phony.split('3934869528').should   == ['39', '3486', '952', '8']   # Mobile
       Phony.split('390612341234').should == ['39', '06', '1234', '1234'] # Roma

data/spec/lib/phony/country_codes_spec.rb

@@ -75,6 +75,9 @@ describe Phony::CountryCodes do
       it "should format american numbers" do
         @countries.formatted('18705551122').should == '+1 870 555 1122'
       end
+      it "should format irish numbers" do
+        @countries.formatted('35311234567').should == '+353 1 123 4567'
+      end
     end
     describe "international" do
       it "should format north american numbers" do
@@ -95,6 +98,9 @@ describe Phony::CountryCodes do
       it 'should format liechtensteiner numbers' do
         @countries.formatted('4233841148', :format => :international_relative).should == '00423 384 11 48'
       end
+      it "should format irish numbers" do
+        @countries.formatted('35311234567', :format => :international).should == '+353 1 123 4567'
+      end
       context 'with no spaces' do
         it "should format north american numbers" do
           Phony.formatted('18091231234', :format => :international, :spaces => '').should == '+18091231234'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phony
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.6.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-25 00:00:00.000000000 Z
+date: 2012-02-27 00:00:00.000000000 Z
 dependencies: []
 description: ! 'Fast international phone number (E164 standard) normalizing, splitting
   and formatting. Lots of formatting options: International (+.., 00..), national
@@ -23,6 +23,7 @@ files:
 - lib/phony/countries/austria.rb
 - lib/phony/countries/china.rb
 - lib/phony/countries/germany.rb
+- lib/phony/countries/ireland.rb
 - lib/phony/countries/italy.rb
 - lib/phony/countries/malaysia.rb
 - lib/phony/countries/netherlands.rb