phony 1.2.4 → 1.2.5

data/README.textile

@@ -5,6 +5,8 @@ h2. Description
 This gem can normalize, format and split E164 numbers.
 "More about E164 numbers in this Wiki":http://en.wikipedia.org/wiki/E.164.
 
+The (admittedly crazy) *goal* of this Gem is to be able to format/split all phone numbers in the world.
+
 Currently handles Afghan, Austrian, Australian, Belgian, Brazilian, Chilean, Chinese, Czech, Danish, Dutch, Egyptian, French, German, Greek, Hungarian, Italian, Malaysian, (The) Netherlands, New Zealand, Norwegian, Peruvian, Polish, Russian, Romanian, South African, South Korean, Spanish, Swedish, Swiss, Turkish, Liechtenstein, US, Venezuelan numbers.
 And to some extend, all others. Just try if it works for you.
 

data/lib/phony.rb

@@ -13,6 +13,7 @@ require File.expand_path '../phony/country', __FILE__
 #
 require File.expand_path '../phony/countries/all_other', __FILE__
 require File.expand_path '../phony/countries/austria', __FILE__
+require File.expand_path '../phony/countries/belgium', __FILE__
 require File.expand_path '../phony/countries/chile', __FILE__
 require File.expand_path '../phony/countries/china', __FILE__
 require File.expand_path '../phony/countries/egypt', __FILE__
@@ -23,6 +24,7 @@ require File.expand_path '../phony/countries/italy', __FILE__
 require File.expand_path '../phony/countries/malaysia', __FILE__
 require File.expand_path '../phony/countries/netherlands', __FILE__
 require File.expand_path '../phony/countries/peru', __FILE__
+require File.expand_path '../phony/countries/portugal', __FILE__
 require File.expand_path '../phony/countries/romania', __FILE__
 require File.expand_path '../phony/countries/south_korea', __FILE__
 require File.expand_path '../phony/countries/sweden', __FILE__

data/lib/phony/countries/all_other.rb

@@ -46,9 +46,7 @@ module Phony
                   
           '30' => Countries::Greece,
           '31' => Countries::Netherlands,
-          '32' => fixed(1,  # Belgium
-                        :local_format => [3, 4]
-                  ),
+          '32' => Countries::Belgium,
           '33' => fixed(1,  # France
                         :local_format         => [2, 2, 2, 2],
                         :service_ndcs         => %w{8}
@@ -82,9 +80,9 @@ module Phony
           '47' => fixed(4,  # Norway
                     :local_format => [4]
                   ),
-          '48' => fixed(2, # Poland (Republic of)
-                        :local_format => [1, 3, 3] # Approximation. Correct would be 48-xxx-xxx-xxx
-                  ),
+          '48' => fixed(3, # Poland (Republic of)
+                        :local_format => [3, 3] # Although the NDCs are 2 digits, the representation is 3 digits.
+                  ), # Note: http://wapedia.mobi/en/Telephone_numbers_in_Poland, mobile not yet correct
           '49' => Countries::Germany,
           
           '51' => Countries::Peru,
@@ -222,7 +220,7 @@ module Phony
           '299' => fixed(2), # Greenland
 
           '350' => fixed(2), # Gibraltar
-          '351' => fixed(2), # Portugal
+          '351' => Countries::Portugal, # Portugal
           '352' => fixed(2), # Luxembourg
           '353' => fixed(2), # Ireland
           '354' => fixed(2), # Iceland

data/lib/phony/countries/belgium.rb

@@ -0,0 +1,60 @@
+# Belgium uses a variable-length ndc code, thus we use a separate file to not let all_other.rb explode.
+#
+# Taken from: http://en.wikipedia.org/wiki/Telephone_numbers_in_Belgium
+#
+Phony::Countries::Belgium = Phony::Country.configured :local_format => [3, 5],
+ :ndc_fallback_length => 2,
+ :ndc_mapping => {
+   :landline => [
+                 '2', # Brussels (Bruxelles/Brussel)
+                 '3', # Antwerpen (Antwerp), Sint-Niklaas
+                 '4', # Liège (Luik), Voeren (Fourons)
+                 '9', # Gent (Ghent/Gand)
+                ],
+   :mobile => [
+                '470', # Mobistar
+                '471', # Mobistar
+                '472', # Mobistar
+                '473', # Mobistar
+                '474', # Mobistar
+                '475', # Mobistar
+                '476', # Mobistar
+                '477', # Mobistar
+                '478', # Mobistar
+                '479', # Mobistar
+                '480', # Base
+                '481', # Base
+                '482', # Base
+                '483', # Base
+                '484', # Base
+                '485', # Base
+                '486', # Base
+                '487', # Base
+                '488', # Base
+                '489', # Base
+                '490', # Proximus
+                '491', # Proximus
+                '492', # Proximus
+                '493', # Proximus
+                '494', # Proximus
+                '495', # Proximus
+                '496', # Proximus
+                '497', # Proximus
+                '498', # Proximus
+                '499', # Proximus
+              ],
+   :service => [
+                 '70', # Specialty numbers, i.e. bus information or bank information
+                '800', # Tollfree
+                '900', # Premium
+                '901', # Premium
+                '902', # Premium
+                '903', # Premium
+                '904', # Premium
+                '905', # Premium
+                '906', # Premium
+                '907', # Premium
+                '908', # Premium
+                '909'  # Premium
+               ]
+ }

data/lib/phony/countries/egypt.rb

@@ -2,6 +2,8 @@
 #
 # http://en.wikipedia.org/wiki/Telephone_numbers_in_Egypt
 #
+# TODO If the fallback length is 2, why do I list length 2 landlines?
+#
 Phony::Countries::Egypt = Phony::Country.configured :local_format => [8],
   :local_special_format => [7],
   :ndc_fallback_length => 2,

data/lib/phony/countries/portugal.rb

@@ -0,0 +1,15 @@
+# Portuguese phone numbers.
+#
+# http://en.wikipedia.org/wiki/Telephone_numbers_in_Portugal
+#
+Phony::Countries::Portugal = Phony::Country.configured :local_format => [3, 4],
+  :local_special_format => [3, 3],
+  :ndc_fallback_length => 3,
+  :ndc_mapping => {
+    :landline => [
+      '21', # Lisboa
+      '22', # Porto
+    ],
+    :mobile => ('90'..'99').to_a,
+    :service => %w{700 800} # Not exhaustive.
+  }

data/spec/lib/phony/countries/belgium_spec.rb

@@ -0,0 +1,32 @@
+# encoding: utf-8
+#
+require 'spec_helper'
+
+describe Phony::Countries::Belgium do
+  
+  before(:each) do
+    @belgium = Phony::Countries::Belgium
+  end
+  
+  describe "split" do
+    it "should handle Antwerpen" do
+      @belgium.split('35551212').should == ['3', '555', '1212']
+    end
+    it "should handle Brugge" do
+      @belgium.split('505551212').should == ['50', '555', '1212']
+    end
+    it "should handle Brussels" do
+      @belgium.split('25551212').should == ['2', '555', '1212']
+    end
+    it "should handle Gent" do
+      @belgium.split('95551914').should == ['9', '555', '1914']
+    end
+    it "should handle Liège" do
+      @belgium.split('45551414').should == ['4', '555', '1414']
+    end
+    it "should handle some mobile services" do
+      @belgium.split('475279584').should == ['475', '279584']
+    end
+
+  end
+end

data/spec/lib/phony/countries/portugal_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Phony::Countries::Portugal do
+  
+  before(:each) do
+    @portugal = Phony::Countries::Portugal
+  end
+  
+  describe "split" do
+    it "works with Lisboa" do
+      @portugal.split('211231234').should == ['21', '123', '1234']
+    end
+    it "works with Abrantes" do
+      @portugal.split('241123123').should == ['241', '123', '123']
+    end
+    it 'works with a mobile' do
+      @portugal.split('931231234').should == ['93', '123', '1234']
+    end
+  end
+  
+end

data/spec/lib/phony_spec.rb

@@ -8,9 +8,17 @@ describe Phony do
     it 'handles afghan numbers' do
       Phony.split('93201234567').should == ['93', '20', '1234567'] # Kabul
     end
-    it "should handle austrian numbers" do
+    it "handles austrian numbers" do
       Phony.split('43198110').should == ['43', '1', '98110']
     end
+    it 'handles belgian numbers' do
+      Phony.split('3235551212').should == ['32', '3', '555', '1212']   # Antwerpen
+      Phony.split('32505551212').should == ['32', '50', '555', '1212'] # Brugge
+      Phony.split('3225551212').should == ['32', '2', '555', '1212']   # Brussels
+      Phony.split('3295551914').should == ['32', '9', '555', '1914']   # Gent
+      Phony.split('3245551414').should == ['32', '4', '555', '1414']   # Liège
+      Phony.split('32475279584').should == ['32', '475', '279584']     # mobile
+    end
     it 'handles brazilian numbers' do
       Phony.split('551112341234').should == ['55', '11', '1234', '1234']
     end
@@ -31,14 +39,14 @@ describe Phony do
       Phony.split('31201234567').should == ['31', '20', '1234567']
       Phony.split('31222123456').should == ['31', '222', '123456']
     end
-    it "should handle egyptian numbers" do
+    it "handles egyptian numbers" do
       Phony.split('20212345678').should == ['20', '2', '12345678']
       Phony.split('20951234567').should == ['20', '95', '1234567']
     end
-    it "should handle french numbers" do
+    it "handles french numbers" do
       Phony.split('33112345678').should == ['33', '1', '12','34','56','78']
     end
-    it "should handle german numbers" do
+    it "handles german numbers" do
       Phony.split('4930123456').should ==   ['49', '30', '123', '456']
       Phony.split('4976112345').should ==   ['49', '761', '123', '45']
       Phony.split('492041123456').should == ['49', '2041', '123', '456']
@@ -56,6 +64,7 @@ describe Phony do
     it 'handles malay numbers' do
       Phony.split('6082123456').should == ['60', '82', '123456'] # Kuching
       Phony.split('60312345678').should == ['60', '3', '12345678'] # Kuala Lumpur
+      Phony.split('60212345678').should == ['60', '2', '12345678'] # Singapore
     end
     it 'handles peruvian numbers' do
       Phony.split('51112341234').should == ['51', '1', '1234', '1234'] # Lima
@@ -63,7 +72,12 @@ describe Phony do
       Phony.split('51841234123').should == ['51', '84', '1234', '123'] # Cuzco, best effort
     end
     it "should handle polish numbers" do
-      Phony.split('48121123123').should == ['48', '12', '1', '123', '123']
+      Phony.split('48123123123').should == ['48', '123', '123', '123']
+    end
+    it 'handles portuguese numbers' do
+      Phony.split('351211231234').should == ['351', '21', '123', '1234'] # Lisboa
+      Phony.split('351241123123').should == ['351', '241', '123', '123'] # Abrantes
+      Phony.split('351931231234').should == ['351', '93', '123', '1234'] # mobile
     end
     it 'handles romanian numbers' do
       Phony.split('40211231234').should == ['40', '21', '123', '1234'] # Bucureşti
@@ -300,7 +314,7 @@ describe Phony do
         performance_of { Phony.normalize(number) }.should < 0.0001
       end
       it 'is fast' do
-        performance_of { @phone_numbers.each { |number| Phony.normalize(number) } }.should < 0.00015
+        performance_of { @phone_numbers.each { |number| Phony.normalize(number) } }.should < 0.00016
       end
     end
     describe 'formatted' do
@@ -309,7 +323,7 @@ describe Phony do
         performance_of { Phony.formatted(number) }.should < 0.000075
       end
       it 'is fast' do
-        performance_of { @phone_numbers.each { |number| Phony.formatted(number) } }.should < 0.00015
+        performance_of { @phone_numbers.each { |number| Phony.formatted(number) } }.should < 0.00016
       end
     end
   end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 2
-  - 4
-  version: 1.2.4
+  - 5
+  version: 1.2.5
 platform: ruby
 authors: 
 - Florian Hanke
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-01 00:00:00 +01:00
+date: 2011-01-21 00:00:00 +01:00
 default_executable: 
 dependencies: []
 
@@ -29,6 +29,7 @@ extra_rdoc_files:
 files: 
 - lib/phony/countries/all_other.rb
 - lib/phony/countries/austria.rb
+- lib/phony/countries/belgium.rb
 - lib/phony/countries/chile.rb
 - lib/phony/countries/china.rb
 - lib/phony/countries/egypt.rb
@@ -39,6 +40,7 @@ files:
 - lib/phony/countries/malaysia.rb
 - lib/phony/countries/netherlands.rb
 - lib/phony/countries/peru.rb
+- lib/phony/countries/portugal.rb
 - lib/phony/countries/romania.rb
 - lib/phony/countries/south_korea.rb
 - lib/phony/countries/sweden.rb
@@ -52,10 +54,12 @@ files:
 - lib/phony.rb
 - README.textile
 - spec/lib/phony/countries/austria_spec.rb
+- spec/lib/phony/countries/belgium_spec.rb
 - spec/lib/phony/countries/egypt_spec.rb
 - spec/lib/phony/countries/germany_spec.rb
 - spec/lib/phony/countries/greece_spec.rb
 - spec/lib/phony/countries/hungary_spec.rb
+- spec/lib/phony/countries/portugal_spec.rb
 - spec/lib/phony/countries/switzerland_spec.rb
 - spec/lib/phony/country_codes_spec.rb
 - spec/lib/phony/country_spec.rb
@@ -99,10 +103,12 @@ specification_version: 3
 summary: Fast international phone number (E164 standard) normalizing, splitting and formatting.
 test_files: 
 - spec/lib/phony/countries/austria_spec.rb
+- spec/lib/phony/countries/belgium_spec.rb
 - spec/lib/phony/countries/egypt_spec.rb
 - spec/lib/phony/countries/germany_spec.rb
 - spec/lib/phony/countries/greece_spec.rb
 - spec/lib/phony/countries/hungary_spec.rb
+- spec/lib/phony/countries/portugal_spec.rb
 - spec/lib/phony/countries/switzerland_spec.rb
 - spec/lib/phony/country_codes_spec.rb
 - spec/lib/phony/country_spec.rb