phonelib 0.1.1 → 0.1.2

data/README.rdoc

@@ -66,8 +66,9 @@ Additional methods:
 
 There is also option to check if provided phone is valid for specified country.
 Country should be specified as two letters country code (like "US" for United States).
+Country can be specified as String <tt>'US'</tt> or <tt>'us'</tt> as well as symbol <tt>:us</tt>.
 
-  Phonelib.valid_for_country? '123456789', 'XX'   # checks if passed value is valid number for specified country
+  Phonelib.valid_for_country? '123456789', 'XX'   # checks if passed value is valid number for specified country 
   Phonelib.invalid_for_country? '123456789', 'XX' # checks if passed value is invalid number for specified country
 
 Additionally you can run:

data/lib/phonelib/core.rb

@@ -123,11 +123,13 @@ module Phonelib
 
     # method checks if passed phone number is valid for provided country
     def valid_for_country?(phone_number, country)
+      country = country.to_s.upcase
       parse(phone_number, country).valid_for_country?(country)
     end
 
     # method checks if passed phone number is invalid for provided country
     def invalid_for_country?(phone_number, country)
+      country = country.to_s.upcase
       parse(phone_number, country).invalid_for_country?(country)
     end
 

data/lib/phonelib/phone.rb

@@ -96,9 +96,10 @@ module Phonelib
     #
     # ==== Attributes
     #
-    # * +country+ - ISO code of country (2 letters) like 'US' for United States
+    # * +country+ - ISO code of country (2 letters) like 'US', 'us' or :us for United States
     #
     def valid_for_country?(country)
+      country = country.to_s.upcase
       @analyzed_data.select {|iso2, data| country == iso2 &&
           data[:valid].any? }.any?
     end
@@ -108,9 +109,10 @@ module Phonelib
     #
     # ==== Attributes
     #
-    # * +country+ - ISO code of country (2 letters) like 'US' for United States
+    # * +country+ - ISO code of country (2 letters) like 'US', 'us' or :us for United States
     #
     def invalid_for_country?(country)
+      country = country.to_s.upcase
       @analyzed_data.select {|iso2, data| country == iso2 &&
           data[:valid].any? }.empty?
     end

data/lib/phonelib/version.rb

@@ -1,4 +1,4 @@
 module Phonelib
   # :nodoc:
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/test/dummy/log/test.log

@@ -501,3 +501,213 @@ Processing by PhonesController#update as HTML
 Redirected to http://test.host/phones/450723037
 Completed 302 Found in 3ms (ActiveRecord: 0.1ms)
    (0.0ms)  rollback transaction
+Connecting to database specified by database.yml
+   (0.3ms)  begin transaction
+  Fixture Delete (0.1ms)  DELETE FROM "phones"
+  Fixture Insert (0.1ms)  INSERT INTO "phones" ("number", "possible_number", "created_at", "updated_at", "id") VALUES ('972541234567', '972541234567', '2013-06-04 11:25:00', '2013-06-04 11:25:00', 450723037)
+  Fixture Insert (0.0ms)  INSERT INTO "phones" ("number", "created_at", "updated_at", "id") VALUES ('wrong', '2013-06-04 11:25:00', '2013-06-04 11:25:00', 667262234)
+  Fixture Insert (0.1ms)  INSERT INTO "phones" ("number", "created_at", "updated_at", "id") VALUES ('972541234567', '2013-06-04 11:25:00', '2013-06-04 11:25:00', 512636273)
+  Fixture Insert (0.1ms)  INSERT INTO "phones" ("possible_number", "created_at", "updated_at", "id") VALUES ('972541234567', '2013-06-04 11:25:00', '2013-06-04 11:25:00', 23760034)
+  Fixture Insert (0.0ms)  INSERT INTO "phones" ("number", "possible_number", "created_at", "updated_at", "id") VALUES ('972541234567', 'wrong', '2013-06-04 11:25:00', '2013-06-04 11:25:00', 703612349)
+   (8.0ms)  commit transaction
+   (0.1ms)  begin transaction
+  Phone Load (1.5ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 512636273]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.1ms)  RELEASE SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (1.3ms)  INSERT INTO "phones" ("created_at", "number", "possible_number", "updated_at") VALUES (?, ?, ?, ?)  [["created_at", Tue, 04 Jun 2013 11:25:00 UTC +00:00], ["number", "972541234567"], ["possible_number", nil], ["updated_at", Tue, 04 Jun 2013 11:25:00 UTC +00:00]]
+   (0.1ms)  RELEASE SAVEPOINT active_record_1
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.1ms)  RELEASE SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 23760034]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 667262234]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 703612349]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+   (0.1ms)  SELECT COUNT(*) FROM "phones" 
+Processing by PhonesController#create as HTML
+  Parameters: {"phone"=>{"number"=>"972541234567"}}
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (0.2ms)  INSERT INTO "phones" ("created_at", "number", "possible_number", "updated_at") VALUES (?, ?, ?, ?)  [["created_at", Tue, 04 Jun 2013 11:25:00 UTC +00:00], ["number", "972541234567"], ["possible_number", nil], ["updated_at", Tue, 04 Jun 2013 11:25:00 UTC +00:00]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+Redirected to http://test.host/phones/703612350
+Completed 302 Found in 3ms (ActiveRecord: 0.2ms)
+   (0.0ms)  SELECT COUNT(*) FROM "phones" 
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+   (0.0ms)  SELECT COUNT(*) FROM "phones" 
+Processing by PhonesController#destroy as HTML
+  Parameters: {"id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (0.1ms)  DELETE FROM "phones" WHERE "phones"."id" = ?  [["id", 450723037]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+Redirected to http://test.host/phones
+Completed 302 Found in 1ms (ActiveRecord: 0.2ms)
+   (0.0ms)  SELECT COUNT(*) FROM "phones" 
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#edit as HTML
+  Parameters: {"id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+  Rendered phones/_form.html.erb (5.4ms)
+Completed 200 OK in 50ms (Views: 49.2ms | ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#index as HTML
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" 
+Completed 200 OK in 4ms (Views: 3.5ms | ActiveRecord: 0.1ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#new as HTML
+  Rendered phones/_form.html.erb (1.2ms)
+Completed 200 OK in 3ms (Views: 2.5ms | ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#show as HTML
+  Parameters: {"id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+Completed 200 OK in 2ms (Views: 1.4ms | ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#update as HTML
+  Parameters: {"phone"=>{"number"=>"972541234567"}, "id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+Redirected to http://test.host/phones/450723037
+Completed 302 Found in 3ms (ActiveRecord: 0.1ms)
+   (0.0ms)  rollback transaction
+Connecting to database specified by database.yml
+   (0.2ms)  begin transaction
+  Fixture Delete (0.1ms)  DELETE FROM "phones"
+  Fixture Insert (0.1ms)  INSERT INTO "phones" ("number", "possible_number", "created_at", "updated_at", "id") VALUES ('972541234567', '972541234567', '2013-06-04 11:25:09', '2013-06-04 11:25:09', 450723037)
+  Fixture Insert (0.0ms)  INSERT INTO "phones" ("number", "created_at", "updated_at", "id") VALUES ('wrong', '2013-06-04 11:25:09', '2013-06-04 11:25:09', 667262234)
+  Fixture Insert (0.0ms)  INSERT INTO "phones" ("number", "created_at", "updated_at", "id") VALUES ('972541234567', '2013-06-04 11:25:09', '2013-06-04 11:25:09', 512636273)
+  Fixture Insert (0.0ms)  INSERT INTO "phones" ("possible_number", "created_at", "updated_at", "id") VALUES ('972541234567', '2013-06-04 11:25:09', '2013-06-04 11:25:09', 23760034)
+  Fixture Insert (0.0ms)  INSERT INTO "phones" ("number", "possible_number", "created_at", "updated_at", "id") VALUES ('972541234567', 'wrong', '2013-06-04 11:25:09', '2013-06-04 11:25:09', 703612349)
+   (3.2ms)  commit transaction
+   (0.1ms)  begin transaction
+  Phone Load (1.4ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 512636273]]
+   (0.1ms)  SAVEPOINT active_record_1
+   (0.1ms)  RELEASE SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (0.7ms)  INSERT INTO "phones" ("created_at", "number", "possible_number", "updated_at") VALUES (?, ?, ?, ?)  [["created_at", Tue, 04 Jun 2013 11:25:09 UTC +00:00], ["number", "972541234567"], ["possible_number", nil], ["updated_at", Tue, 04 Jun 2013 11:25:09 UTC +00:00]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 23760034]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 667262234]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 703612349]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  ROLLBACK TO SAVEPOINT active_record_1
+   (0.0ms)  rollback transaction
+   (0.1ms)  begin transaction
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+   (0.1ms)  SELECT COUNT(*) FROM "phones" 
+Processing by PhonesController#create as HTML
+  Parameters: {"phone"=>{"number"=>"972541234567"}}
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (0.2ms)  INSERT INTO "phones" ("created_at", "number", "possible_number", "updated_at") VALUES (?, ?, ?, ?)  [["created_at", Tue, 04 Jun 2013 11:25:09 UTC +00:00], ["number", "972541234567"], ["possible_number", nil], ["updated_at", Tue, 04 Jun 2013 11:25:09 UTC +00:00]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+Redirected to http://test.host/phones/703612350
+Completed 302 Found in 3ms (ActiveRecord: 0.3ms)
+   (0.0ms)  SELECT COUNT(*) FROM "phones" 
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+   (0.0ms)  SELECT COUNT(*) FROM "phones" 
+Processing by PhonesController#destroy as HTML
+  Parameters: {"id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+   (0.0ms)  SAVEPOINT active_record_1
+  SQL (0.1ms)  DELETE FROM "phones" WHERE "phones"."id" = ?  [["id", 450723037]]
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+Redirected to http://test.host/phones
+Completed 302 Found in 1ms (ActiveRecord: 0.2ms)
+   (0.0ms)  SELECT COUNT(*) FROM "phones" 
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#edit as HTML
+  Parameters: {"id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+  Rendered phones/_form.html.erb (20.1ms)
+Completed 200 OK in 47ms (Views: 46.1ms | ActiveRecord: 0.0ms)
+   (0.1ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#index as HTML
+  Phone Load (0.1ms)  SELECT "phones".* FROM "phones" 
+Completed 200 OK in 4ms (Views: 3.4ms | ActiveRecord: 0.1ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#new as HTML
+  Rendered phones/_form.html.erb (1.2ms)
+Completed 200 OK in 3ms (Views: 2.4ms | ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#show as HTML
+  Parameters: {"id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+Completed 200 OK in 2ms (Views: 1.3ms | ActiveRecord: 0.0ms)
+   (0.0ms)  rollback transaction
+   (0.0ms)  begin transaction
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", 450723037]]
+Processing by PhonesController#update as HTML
+  Parameters: {"phone"=>{"number"=>"972541234567"}, "id"=>"450723037"}
+  Phone Load (0.0ms)  SELECT "phones".* FROM "phones" WHERE "phones"."id" = ? LIMIT 1  [["id", "450723037"]]
+   (0.0ms)  SAVEPOINT active_record_1
+   (0.0ms)  RELEASE SAVEPOINT active_record_1
+Redirected to http://test.host/phones/450723037
+Completed 302 Found in 3ms (ActiveRecord: 0.1ms)
+   (0.0ms)  rollback transaction

data/test/phonelib_test.rb

@@ -1,105 +1,175 @@
 require 'test_helper'
 
-class PhonelibTest < ActiveSupport::TestCase
-  test "truth" do
-    assert_kind_of Module, Phonelib
-  end
-
-  test "returns phone object" do
-    assert Phonelib.parse('972541234567').is_a? Phonelib::Phone
-  end
-
-  test "valid? with malformed phone number" do
-    assert !Phonelib.valid?('sdffsd')
-  end
-
-  test "invalid? with malformed phone number" do
-    assert Phonelib.invalid?('sdffsd')
-  end
-
-  test "valid? with valid phone number" do
-    assert Phonelib.valid? '972541234567'
-  end
-
-  test "invalid? with valid phone number" do
-    assert !Phonelib.invalid?('972541234567')
-  end
-
-  test "possible? with valid phone number" do
-    assert Phonelib.possible? '972541234567'
-  end
-
-  test "impossible? with valid phone number" do
-    assert !Phonelib.impossible?('972541234567')
-  end
-
-  test "valid? with invalid phone number" do
-    assert !Phonelib.valid?('97254123')
-  end
-
-  test "invalid? with invalid phone number" do
-    assert Phonelib.invalid?('97254123')
-  end
-
-  test "possible? with invalid phone number" do
-    assert !Phonelib.possible?('97254123')
-  end
-
-  test "impossible? with invalid phone number" do
-    assert Phonelib.impossible?('97254123')
-  end
+class PhonelibTest < Test::Unit::TestCase
 
-  test "possible but not valid phone number" do
-    phone = Phonelib.parse('9721234567')
-    assert !phone.valid?
-    assert phone.possible?
-  end
-
-  test "valid_for_country? with correct data" do
-    assert Phonelib.valid_for_country?('972541234567', 'IL')
-  end
-  
-  test "valid_for_country? with correct data and national number" do
-    assert Phonelib.valid_for_country?('0541234567', 'IL')
-  end
-  
-  test "valid_for_country? with correct data and without prefix" do
-    assert Phonelib.valid_for_country?('541234567', 'IL')
-  end
-  
-  test "valid_for_country? with fake data and without prefix" do
-    assert !Phonelib.valid_for_country?('541234567', 'US')
-  end
-
-  test "invalid_for_country? with correct data" do
-    assert !Phonelib.invalid_for_country?('972541234567', 'IL')
-  end
-
-  test "invalid_for_country? with incorrect data" do
-    assert Phonelib.invalid_for_country?('972541234567', 'US')
-  end
-
-  test "valid_for_country? with incorrect data" do
-    assert !Phonelib.valid_for_country?('972541234567', 'US')
-  end
-
-  test "international method returns with right formatting" do
-    phone = Phonelib.parse('972541234567')
-    assert phone.international == '+972 54-123-4567'
-  end
-
-  test "national method returns right formatting" do
-    phone = Phonelib.parse('972541234567')
-    assert phone.national == '054-123-4567'
-  end
-
-  test "international method returns sanitized when number invalid but possible" do
-    phone = Phonelib.parse('9721234567')
-    assert phone.international == '+9721234567'
+  should 'be a Module' do
+    assert_kind_of Module, Phonelib
   end
 
-  test "national method returns sanitized national when number invalid but possible" do
-    phone = Phonelib.parse('9721234567')
-    assert phone.national == '1234567'
+  context '.parse' do
+    setup { @phone = Phonelib.parse '9721234567' }
+
+    should 'return a Phone object' do
+      assert @phone.is_a? Phonelib::Phone #instance_of?
+    end
+
+    should 'be possible but not valid phone number' do
+      assert !@phone.valid?
+      assert @phone.possible?
+    end
+  end
+
+  context '.valid?' do
+    context 'with malformed phone number' do
+      should 'not be valid' do
+        assert !Phonelib.valid?('sdffsd')
+      end
+    end
+
+    context 'with valid phone number' do
+      should 'be valid' do
+        assert Phonelib.valid?('972541234567')
+      end
+    end
+
+    context 'with invalid phone number' do
+      should 'not be valid' do
+        assert !Phonelib.valid?('97254123')
+      end
+    end
+  end
+
+  context '.invalid?' do
+    context 'with malformed phone number' do
+      should 'be valid' do
+        assert Phonelib.invalid?('sdffsd')
+      end
+    end
+
+    context 'with valid phone number' do
+      should 'not be valid' do
+        assert !Phonelib.invalid?('972541234567')
+      end
+    end
+
+    context 'with invalid phone number' do
+      should 'be valid' do
+        assert Phonelib.invalid?('97254123')
+      end
+    end
+  end
+
+  context '.possible?' do
+    context 'with valid phone number' do
+      should 'be valid' do
+        assert Phonelib.possible? '972541234567'
+      end
+    end
+
+    context 'with invalid phone number' do
+      should 'not be valid' do
+        assert !Phonelib.possible?('97254123')
+      end
+    end
+  end
+
+  context '.impossible?' do
+    context 'with valid phone number' do
+      should 'not be valid' do
+        assert !Phonelib.impossible?('972541234567')
+      end
+    end
+
+    context 'with invalid phone number' do
+      should 'be valid' do
+        assert Phonelib.impossible?('97254123')
+      end
+    end
+  end
+
+  context 'valid_for_country?' do
+    context 'with correct data' do
+      ['IL', :il].each do |country|
+        context "with #{country} as country" do
+          should 'be valid' do
+            assert Phonelib.valid_for_country?('972541234567', country)
+          end
+
+          context 'and national number' do
+            should 'be valid' do
+              assert Phonelib.valid_for_country?('0541234567', country)
+            end
+          end
+
+          context 'and without prefix' do
+            should 'be valid' do
+              assert Phonelib.valid_for_country?('541234567', country)
+            end
+          end
+        end
+      end
+    end
+
+    ['US', :us].each do |country|
+      context "with #{country} as country" do
+        context 'with incorrect data' do
+          should 'not be valid' do
+            assert !Phonelib.valid_for_country?('972541234567', country)
+          end
+
+          context 'and without prefix' do
+            should 'not be valid' do
+              assert !Phonelib.valid_for_country?('541234567', country)
+            end
+          end
+        end
+      end
+    end
+  end
+
+  context '.invalid_for_country?' do
+    context 'with correct data' do
+      ['IL', :il].each do |country|
+        context "with #{country} as country" do
+          should 'not be invalid' do
+            assert !Phonelib.invalid_for_country?('972541234567', country)
+          end
+        end
+      end
+    end
+
+    context 'with incorrect data' do
+      ['US', :us].each do |country|
+        context "with #{country} as country" do
+          should 'be invalid' do
+            assert Phonelib.invalid_for_country?('972541234567', country)
+          end
+        end
+      end
+    end
+  end
+
+  context '#international' do
+    should 'return right formatting' do
+      phone = Phonelib.parse('972541234567')
+      assert_equal '+972 54-123-4567', phone.international
+    end
+
+    should 'return sanitized when number invalid but possible' do
+      phone = Phonelib.parse('9721234567')
+      assert_equal '+9721234567', phone.international
+    end
+  end
+
+  context '#national' do
+    should 'return right formatting' do
+      phone = Phonelib.parse('972541234567')
+      assert_equal '054-123-4567', phone.national
+    end
+
+    should 'return sanitized national when number invalid but possible' do
+      phone = Phonelib.parse('9721234567')
+      assert_equal '1234567', phone.national
+    end
   end
 end

data/test/test_helper.rb

@@ -1,6 +1,7 @@
 # Configure Rails Environment
 ENV["RAILS_ENV"] = "test"
 
+require 'shoulda-context'
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require "rails/test_help"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phonelib
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-30 00:00:00.000000000 Z
+date: 2013-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &17731760 !ruby/object:Gem::Requirement
+  requirement: &16799660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 3.1.0
   type: :development
   prerelease: false
-  version_requirements: *17731760
+  version_requirements: *16799660
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &17730980 !ruby/object:Gem::Requirement
+  requirement: &16798880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17730980
+  version_requirements: *16798880
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &17730140 !ruby/object:Gem::Requirement
+  requirement: &16798100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17730140
+  version_requirements: *16798100
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &17729360 !ruby/object:Gem::Requirement
+  requirement: &16797520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,18 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17729360
+  version_requirements: *16797520
+- !ruby/object:Gem::Dependency
+  name: shoulda-context
+  requirement: &16812780 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *16812780
 description: Google libphonenumber library was taken as a basis for this gem. Gem
   uses its data file for validations and number formatting.
 email:
@@ -140,7 +151,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3858765468631295667
+      hash: -3279311756524952589
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -149,7 +160,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3858765468631295667
+      hash: -3279311756524952589
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.17