phone_gap-build 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6a3bfa7b5f905953982154c7819b908426a7c20
-  data.tar.gz: eed8c96e1abdbe2fd72271ee5dd1f748563b22ae
+  metadata.gz: 8e834b89c2ec819e1fd0c2b884aadd4ed469a61d
+  data.tar.gz: a1660bada277a57f7693419ca0cc06eabc7383db
 SHA512:
-  metadata.gz: f42ab955ad35a889ad6d04dab15d986cc52ad4ef228d397c3e606bd443c06c7769e16eb8bbed2f4e7fd14cd604bfbd2f6b229847886c6a2d678eb01b2b57f679
-  data.tar.gz: dbaadd0913db4e23f8ae394251770620ef7c436873209d874d57fc446d5914bd29bbf4eb23d04314a4142272edf4b659dbec07457a3a383aa6281311460f83e3
+  metadata.gz: 219404a7e7d4cedeb7868d667ece7e80ac39ec2ae91cf0b2431cbf0d9ed2bc5eb04440ee77ac34db1272cd0c4c23f2eb8dda32bea81cbf7694c8494580de906a
+  data.tar.gz: bf67eac9281fe2fa4ef18e329bcc750a2d101d39cdc1dc89eca9753375be80c0cc443fc49706c7086fe27991bf26461f1874d35dac3be5b3d6f2e51bdd7bb7d7

data/README.md

@@ -56,6 +56,9 @@ Or install it yourself as:
     # check if the build is complete
     app.build_complete?
 
+    # download all build platform's packages
+    app.download
+
     # delete it!
     app.destroy
 

data/lib/phone_gap/build/app.rb

@@ -49,20 +49,10 @@ module PhoneGap
         complete
       end
 
-      #@TODO another hacky method. Come on Seb :-)
       def download(params = {})
         platforms_to_download = params[:platforms] ? params[:platforms] : built_platforms
         platforms_to_download.each do |platform|
-          response =  ApiRequest.new.get("#{PATH}/#{id}/#{platform}")
-          if response.success?
-            file_name = file_name_from_uri(response.request.instance_variable_get(:@last_uri).request_uri)
-            dir = File.join((params[:save_to] ? params[:save_to] : '/tmp'), platform.to_s)
-            file_path =  File.join(dir, file_name)
-            FileUtils.mkdir_p(dir)
-            puts "Saving to #{file_path}"
-            File.open(file_path, 'w+') { |f| f.write(response.body) }
-            puts 'Download complete'
-          end
+          PhoneGap::Build::PackageDownloader.new.download(id, platform, params[:save_to])
         end
       end
 
@@ -72,9 +62,6 @@ module PhoneGap
         status.delete_if { |package, build_status| build_status != 'complete' }.keys
       end
 
-      def file_name_from_uri(uri)
-        uri.match(/\/([^\/]*)$/)[0]
-      end
     end
 
     class BuildError < Exception ; end

data/lib/phone_gap/build/package_downloader.rb

@@ -0,0 +1,39 @@
+module PhoneGap
+  module Build
+    class PackageDownloader
+
+      attr_reader :id, :platform, :target_dir, :http_response
+
+      def download(id, platform, target_dir = '/tmp')
+        @id, @platform, @target_dir = id, platform, target_dir
+        @http_response = PhoneGap::Build::ApiRequest.new.get("/apps/#{id}/#{platform}")
+        save_file if http_response.success?
+      end
+
+      private
+
+      def save_file
+        FileUtils.mkdir_p(platform_output_dir)
+        puts "Saving to #{file_path}"
+        File.open(file_path, 'w+') { |f| f.write(http_response.body) }
+        puts 'Download complete'
+      end
+
+      def platform_output_dir
+        File.join(target_dir, platform.to_s)
+      end
+
+      def file_path
+        File.join(platform_output_dir, file_name)
+      end
+
+      def file_name
+        file_name_from_uri(http_response.request.instance_variable_get(:@last_uri).request_uri)
+      end
+
+      def file_name_from_uri(uri)
+        uri.match(/\/([^\/]*)$/)[0]
+      end
+    end
+  end
+end

data/lib/phone_gap/build/version.rb

@@ -1,5 +1,5 @@
 module PhoneGap
   module Build
-    VERSION = '0.6.0'
+    VERSION = '0.6.1'
   end
 end

data/lib/phone_gap/build.rb

@@ -7,6 +7,7 @@ require 'phone_gap/build/api_request'
 require 'phone_gap/build/rest_resource'
 require 'phone_gap/build/creatable'
 require 'phone_gap/build/error'
+require 'phone_gap/build/package_downloader'
 
 require 'httparty'
 

data/spec/phone_gap/build/app_spec.rb

@@ -176,9 +176,11 @@ describe PhoneGap::Build::App do
     describe '#download' do
 
       let(:http_response) { double('http response', success?: false) }
+      let(:package_downloader) { double('PhoneGap::Build::PackageDownloader') }
 
       before do
         api_request.stub(:get).and_return http_response
+        PhoneGap::Build::PackageDownloader.stub(:new).and_return package_downloader
       end
 
       context 'when there are builds that are complete' do
@@ -187,68 +189,35 @@ describe PhoneGap::Build::App do
           subject.instance_variable_set('@status', { android: 'complete', ios: 'complete', winphone: 'complete' })
         end
 
-        context 'when no specific platforms are specified' do
+        context 'and no specific platforms are specified' do
 
-          let(:platforms) { %w(android ios winphone) }
+          let(:platforms) { %i(android ios winphone) }
 
           it 'downloads each platform\'s package' do
             platforms.each do |platform|
-              expect(api_request).to receive(:get).with("/apps/#{id}/#{platform}")
+              expect(package_downloader).to receive(:download).with(id, platform, anything)
             end
             subject.download
           end
-        end
-
-        context 'when specific packages are specified' do
 
-          let(:platforms) { %w(ios android) }
+          context 'and the package is to be saved in a specific directory' do
 
-          it 'downloads the specific packages' do
-            platforms.each do |platform|
-              expect(api_request).to receive(:get).with("/apps/#{id}/#{platform}")
+            it 'passes on the target directory to the package downloader' do
+              expect(package_downloader).to receive(:download).with(id, anything, 'my special directory').exactly(3).times
+              subject.download(save_to: 'my special directory')
             end
-            subject.download(platforms: platforms)
           end
         end
 
-        context 'when the download response is successful' do
+        context 'and specific packages are set to be downloaded' do
 
-          let(:file_name) { 'Something.ipa' }
-          let(:uri) { double('uri', request_uri: "/ios.phonegap/slicehost-production/apps/894786/#{file_name}" ) }
-          let(:request) { double('request') }
-          let(:http_response) { double('http response', success?: true, request: request, body: 'file content') }
-
-          before do
-            api_request.stub(:get).and_return http_response
-            request.stub(:instance_variable_get).with(:@last_uri).and_return uri
-            FileUtils.stub(:mkdir_p)
-          end
-
-          it 'creates a directory to store the file' do
-            expect(FileUtils).to receive(:mkdir_p)
-            subject.download
-          end
-
-          context 'and given a directory to save to' do
-
-            let(:target_dir) { '/save/me/here' }
-
-            it 'saves each package to the given folder' do
-              expect(File).to receive(:open).with("#{target_dir}/ios/#{file_name}", anything)
-              expect(File).to receive(:open).with("#{target_dir}/android/#{file_name}", anything)
-              expect(File).to receive(:open).with("#{target_dir}/winphone/#{file_name}", anything)
-              subject.download(save_to: target_dir)
-            end
-          end
-
-          context 'and not given a directory to save to' do
+          let(:platforms) { %w(ios android) }
 
-            it 'saves the package to the tmp folder' do
-              expect(File).to receive(:open).with("/tmp/ios/#{file_name}", anything)
-              expect(File).to receive(:open).with("/tmp/android/#{file_name}", anything)
-              expect(File).to receive(:open).with("/tmp/winphone/#{file_name}", anything)
-              subject.download
+          it 'downloads the specific packages' do
+            platforms.each do |platform|
+              expect(package_downloader).to receive(:download).with(id, platform, anything)
             end
+            subject.download(platforms: platforms)
           end
         end
       end

data/spec/phone_gap/build/package_downloader_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+describe PhoneGap::Build::PackageDownloader do
+
+  let(:api_request) { double('PhoneGap::Build::ApiRequest') }
+
+  before do
+    PhoneGap::Build::ApiRequest.stub(:new).and_return api_request
+  end
+
+  context 'when given a package' do
+
+    let(:platform) { 'some platform' }
+
+    context 'and an app id' do
+
+      let(:id) { 'id' }
+      let(:http_response) { double('response', :success? => false, body: '{"key":"value"}') }
+
+      it 'makes an api call to download the package' do
+        expect(api_request).to receive(:get).with("/apps/#{id}/#{platform}").and_return http_response
+        subject.download(id, platform)
+      end
+
+      context 'when the api call is successful' do
+
+        let(:file_name) { 'Something.ipa' }
+        let(:uri) { double('uri', request_uri: "/ios.phonegap/slicehost-production/apps/894786/#{file_name}" ) }
+        let(:request) { double('request') }
+        let(:http_response) { double('http response', success?: true, request: request, body: 'file content') }
+
+        before do
+          api_request.stub(:get).and_return http_response
+          request.stub(:instance_variable_get).with(:@last_uri).and_return uri
+          FileUtils.stub(:mkdir_p)
+          File.stub(:open)
+        end
+
+        it 'creates a directory to store the file' do
+          expect(FileUtils).to receive(:mkdir_p)
+          subject.download(id, platform)
+        end
+
+        context 'and given a directory to save to' do
+
+          let(:target_dir) { '/save/me/here' }
+
+          it 'saves each package to the given folder' do
+            expect(File).to receive(:open).with("#{target_dir}/#{platform}/#{file_name}", anything)
+            subject.download(id, platform, target_dir)
+          end
+        end
+
+        context 'and not given a directory to save to' do
+
+          it 'saves the package to the tmp folder' do
+            expect(File).to receive(:open).with("/tmp/#{platform}/#{file_name}", anything)
+            subject.download(id, platform)
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phone_gap-build
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Seb Glazebrook
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-29 00:00:00.000000000 Z
+date: 2014-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httmultiparty
@@ -112,6 +112,7 @@ files:
 - spec/phone_gap/build/api_request_spec.rb
 - spec/phone_gap/build/app_spec.rb
 - spec/phone_gap/build/credentials_spec.rb
+- spec/phone_gap/build/package_downloader_spec.rb
 - spec/phone_gap/build/rest_resource_spec.rb
 - spec/phone_gap/build_spec.rb
 - spec/spec_helper.rb
@@ -148,6 +149,7 @@ test_files:
 - spec/phone_gap/build/api_request_spec.rb
 - spec/phone_gap/build/app_spec.rb
 - spec/phone_gap/build/credentials_spec.rb
+- spec/phone_gap/build/package_downloader_spec.rb
 - spec/phone_gap/build/rest_resource_spec.rb
 - spec/phone_gap/build_spec.rb
 - spec/spec_helper.rb