phone_classifier 0.0.1 → 0.0.2

data/README.md

@@ -3,6 +3,8 @@ Phone Classifier
 
 Used to quickly classifiy a phone number into :landline, :mobile or :forbidden
 
+Current Travis Build Status: [![Build Status](https://secure.travis-ci.org/mobino/phone_classifier.png?branch=master)](https://travis-ci.org/mobino/phone_classifier)
+
 Installation
 ------------
 
@@ -20,8 +22,6 @@ Supported Countries
 -------------------
 
 * +1, USA (will only reject service numbers, all other numbers considered mobile). Blame the US numbering systems
-* +6, Greece
-* +31, Netherlands
 * +30, Greece
 * +31, Netherlands
 * +32, Belgium
@@ -38,6 +38,8 @@ Supported Countries
 * +47, Norway
 * +48, Poland
 * +49, Germany
+* +60, Malaysia
+* +65, Singapore
 * +212, Morocco
 * +213, Algeria
 * +233, Ghana
@@ -63,12 +65,12 @@ Supported Countries
 Where is it used
 ----------------
 
-Used in Mobino[http://mobino.com], a mobile payment service, to classifiy client phone numbers
+Used in [Mobino](http://mobino.com), a mobile payment service, to classifiy client phone numbers
 
 Related
 -------
 
-PhoneClassifier uses the fantastic 'Phony'[http://github.com/floere/phony.git] library to normalize numbers. Phony is
+PhoneClassifier uses the fantastic [Phony](http://github.com/floere/phony.git) library to normalize numbers. Phony is
 the tool of choice if you need to work with phone numbers in Ruby.
 
 Contributing

data/lib/phone_classifier/forbidden.rb

@@ -0,0 +1,49 @@
+
+
+module Forbidden
+
+  def self.data
+    @@forbidden ||= {
+        '1' => %w{ 1.. }, # USA
+        '30' => %w{ 8.. 9.. }, # Greece
+        '31' => %w{84 85 87 88 91 112 676 800 900 906 909}, # Netherlands
+        '32' => %w{70 800 90[0-9]}, # Belgium
+        '33' => %w{8}, # France
+        '34' => %w{10 11 80 90}, # Spain
+        '36' => %w{ 40 41 50 55 60 71 80 90 91 }, # Hungary
+        '39' => %w{1 7 8}, # Italy
+        '40' => %w{ 8. 9. }, # Romania
+        '41' => %w{ 74 800 840 842 844 848 860 868 900 901 906 }, # Switzerland
+        '43' => %w{ 718 720 780 8.. 9.. }, # Austria
+        '44' => %w{800 808 842 843 844 845 870 871 872 873 900 908 909 982}, # UK
+        '45' => %w{10 11 18 70 80 90}, # Denmark
+        '46' => %w{ 900 939 944 99. },
+        '47' => %w{ 8.. }, # Norway
+        '48' => %w{70., 80.}, # Poland
+        '49' => %w{ 1. 164 168 169 180 181 19[0-4] 800 900 }, # Germany
+        '60' => %w{ 100 101 102 103 104 108 112 991 994 995 999 }, # Malaysia
+        '65' => %w{ 3... 800 1800 1900 }, # Singapore
+        '212' => %w{ 8. }, # Morocco
+        '213' => %w{ 8.. 9.. }, # Algeria
+        '233' => %w{ 1 4 6 7 8 9 }, # Ghana
+        '234' => %w{ 8.. 9.. }, # Nigeria
+        '249' => %w{ }, # Sudan
+        '350' => %w{ 8... }, # Gibraltar
+        '351' => %w{ 800 80. }, # Portugal
+        '352' => %w{ 118 12 13 800 801 900 901 905 }, # Luxembourg
+        '353' => %w{ 76 80 81 800 }, # Ireland
+        '354' => %w{ 8.. 9.. }, # Iceland
+        '356' => %w{ }, # Malta
+        '357' => %w{ 80 90 }, # Cyprus
+        '358' => %w{ 6.. 7.. 8.. }, # Finland
+        '359' => %w{ 800 900 }, # Bulgaria
+        '370' => %w{ 800 9.. }, # Lithuania
+        '372' => %w{ 1.. 800 }, # Estonia
+        '377' => %w{  }, # Monaco
+        '386' => %w{ 80 89 90 }, # Slovenia
+        '420' => %w{ 8.. 9.. }, # Czech republic
+        '421' => %w{ }, # Slovakia
+    }
+  end
+end
+

data/lib/phone_classifier/mobile.rb

@@ -0,0 +1,49 @@
+
+
+  module Mobile
+
+    def self.data
+      @@mobile ||= {
+          '1' => %w{ [2-9].. }, # USA
+          '30' => %w{ 6.. }, # Greece
+          '31' => %w{6}, # Netherlands
+          '32' => %w{4..}, # Belgium
+          '33' => %w{6 7}, # France
+          '34' => %w{6. 7.}, # Spain
+          '36' => %w{ 20 30 31 70 }, # Hungary
+          '39' => %w{3...}, # Italy
+          '40' => %w{ 7. }, # Romania
+          '41' => %w{ 7[6-9] }, # Switerzland
+          '43' => %w{ 67 68 644 65. 66. }, # Austria
+          '44' => %w{ 7[4-9].. }, # UK
+          '45' => %w{ 2[0-9] 30 31 40 41 42 5[0-3] 60 61 71 81 9[1-3] }, # Denmark
+          '46' => %w{ 70 72 73 76 }, # Sweden
+          '47' => %w{ 9.. 4.. 58. 59. }, # Norway
+          '48' => %w{50. 51. 53. 60. 66. 69. 72. 78. 79. 88.}, # Poland
+          '49' => %w{ 151 152 157 159 160 162 163 17[0-9] }, # Germany
+          '60' => %w{ 10 11 12 13 14 153 154 156 158 16 17 18 19 }, # Malaysia
+          '65' => %w{ 8... 9... }, # Singapore
+          '212' => %w{ 6.  }, # Morocco
+          '213' => %w{ 55 66 697 699 77 790 796 }, # Algeria
+          '233' => %w{ 20 23 24 26 27 28 50 54 57 }, # Ghana
+          '234' => %w{ 702[1-9] 70[3-9] 8[01][2-9] }, # Nigeria
+          '249' => %w{ 9.  }, # Sudan
+          '350' => %w{ 5. 6. }, # Gibraltar
+          '351' => %w{ 9. }, # Portugal
+          '352' => %w{ 621 628 661 668 691 698 }, # Luxembourg
+          '353' => %w{ 8[2-9] }, # Ireland
+          '354' => %w{ 6.. 7.. 8..}, # Iceland
+          '356' => %w{ 77 79 98 99 }, # Malta
+          '357' => %w{ 95 96 97 99 }, # Cyprus
+          '358' => %w{ 4. 50 }, # Finland
+          '359' => %w{ 430 87. 88. 89. 98. }, # Bulgaria
+          '370' => %w{ 6.. }, # Lithuania
+          '372' => %w{ 5.. 81. 82.}, # Estonia
+          '377' => %w{ 4. 6 }, # Monaco
+          '386' => %w{ 30 40 31 41 51 71 70 64}, # Slovenia
+          '420' => %w{ 60[1-8] 72. 73. 77. 79. 91 }, # Czech Republic
+          '421' => %w{ 9.. }, # Slovakia
+      }
+    end
+  end
+

data/lib/phone_classifier.rb

@@ -1,89 +1,14 @@
 require 'phony'
 
+
+require 'phone_classifier/mobile'
+require 'phone_classifier/forbidden'
+
 class PhoneClassifier
 
   # authorative info: http://www.itu.int/oth/T0202.aspx?parent=T0202
   # Numbering schemes for mobile numbers
   #
-  @@mobile = {
-      '1' => %w{ [2-9].. }, # USA
-      '30' => %w{ 6.. }, # Greece
-      '31' => %w{6}, # Netherlands
-      '32' => %w{4..}, # Belgium
-      '33' => %w{6 7}, # France
-      '34' => %w{6. 7.}, # Spain
-      '36' => %w{ 20 30 31 70 }, # Hungary
-      '39' => %w{3...}, # Italy
-      '40' => %w{ 7. }, # Romania
-      '41' => %w{ 7[6-9] }, # Switerzland
-      '43' => %w{ 67 68 644 65. 66. }, # Austria
-      '44' => %w{ 7[4-9].. }, # UK
-      '45' => %w{ 2[0-9] 30 31 40 41 42 5[0-3] 60 61 71 81 9[1-3] }, # Denmark
-      '46' => %w{ 70 72 73 76 }, # Sweden
-      '47' => %w{ 9.. 4.. 58. 59. }, # Norway
-      '48' => %w{50. 51. 53. 60. 66. 69. 72. 78. 79. 88.}, # Poland
-      '49' => %w{ 151 152 157 159 160 162 163 17[0-9] }, # Germany
-      '212' => %w{ 6.  }, # Morocco
-      '213' => %w{ 55 66 697 699 77 790 796 }, # Algeria
-      '233' => %w{ 20 23 24 26 27 28 50 54 57 },
-      '234' => %w{ 702[1-9] 70[3-9] 8[01][2-9] },
-      '249' => %w{ 9.  }, # Sudan
-      '350' => %w{ 5. 6. }, # Gibraltar
-      '351' => %w{ 9. }, # Portugal
-      '352' => %w{ 621 628 661 668 691 698 }, # Luxembourg
-      '353' => %w{ 8[2-9] }, # Ireland
-      '354' => %w{ 6.. 7.. 8..}, # Iceland
-      '356' => %w{ 77 79 98 99 }, # Malta
-      '357' => %w{ 95 96 97 99 }, # Cyprus
-      '358' => %w{ 4. 50 }, # Finland
-      '359' => %w{ 430 87. 88. 89. 98. }, # Bulgaria
-      '370' => %w{ 6.. }, # Lithuania
-      '372' => %w{ 5.. 81. 82.}, # Estonia
-      '377' => %w{ 4. 6 }, # Monaco
-      '386' => %w{ 30 40 31 41 51 71 70 64}, # Slovenia
-      '420' => %w{ 60[1-8] 72. 73. 77. 79. 91 }, # Czech Republic
-      '421' => %w{ 9.. }, # Slovakia
-  }
-
-  @@forbidden = {
-      '1' => %w{ 1.. }, # USA
-      '30' => %w{ 8.. 9.. }, # Greece
-      '31' => %w{84 85 87 88 91 112 676 800 900 906 909}, # Netherlands
-      '32' => %w{70 800 90[0-9]}, # Belgium
-      '33' => %w{8}, # France
-      '34' => %w{10 11 80 90}, # Spain
-      '36' => %w{ 40 41 50 55 60 71 80 90 91 }, # Hungary
-      '39' => %w{1 7 8}, # Italy
-      '40' => %w{ 8. 9. }, # Romania
-      '41' => %w{ 74 800 840 842 844 848 860 868 900 901 906 }, # Switzerland
-      '43' => %w{ 718 720 780 8.. 9.. }, # Austria
-      '44' => %w{800 808 842 843 844 845 870 871 872 873 900 908 909 982}, # UK
-      '45' => %w{10 11 18 70 80 90}, # Denmark
-      '46' => %w{ 900 939 944 99. },
-      '47' => %w{ 8.. }, # Norway
-      '48' => %w{70., 80.}, # Poland
-      '49' => %w{ 1. 164 168 169 180 181 19[0-4] 800 900 }, # Germany
-      '212' => %w{ 8. }, # Morocco
-      '213' => %w{ 8.. 9.. }, # Algeria
-      '233' => %w{ 1 4 6 7 8 9 },
-      '234' => %w{ 8.. 9.. },
-      '249' => %w{ }, # Sudan
-      '350' => %w{ 8... }, # Gibraltar
-      '351' => %w{ 800 80. }, # Portugal
-      '352' => %w{ 118 12 13 800 801 900 901 905 }, # Luxembourg
-      '353' => %w{ 76 80 81 800 }, # Ireland
-      '354' => %w{ 8.. 9.. }, # Iceland
-      '356' => %w{ }, # Malta
-      '357' => %w{ 80 90 }, # Cyprus
-      '358' => %w{ 6.. 7.. 8.. }, # Finland
-      '359' => %w{ 800 900 }, # Bulgaria
-      '370' => %w{ 800 9.. }, # Lithuania
-      '372' => %w{ 1.. 800 }, # Estonia
-      '377' => %w{  }, # Monaco
-      '386' => %w{ 80 89 90 }, # Slovenia
-      '420' => %w{ 8.. 9.. }, # Czech republic
-      '421' => %w{ }, # Slovakia
-  }
 
   def initialize number
     @number = number
@@ -101,12 +26,12 @@ class PhoneClassifier
   end
 
   def mobile?
-    return is_number_of_type @@mobile
+    return is_number_of_type Mobile.data
   end
 
 
   def forbidden?
-    return is_number_of_type @@forbidden
+    return is_number_of_type Forbidden.data
   end
 
   def is_number_of_type numbers

data/spec/phone_classifier/forbidden_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Forbidden do
+
+  it 'has a data method' do
+    Forbidden.data.should be_instance_of(Hash)
+  end
+
+
+  it 'has data for country with ndc 1' do
+    Forbidden.data['1'].should be_instance_of(Array)
+  end
+
+end

data/spec/phone_classifier/mobile_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Mobile do
+
+  it 'has a data method' do
+    Mobile.data.should be_instance_of(Hash)
+  end
+
+
+  it 'has data for country with ndc 1' do
+    Mobile.data['1'].should be_instance_of(Array)
+  end
+
+end

data/spec/phone_classifier_spec.rb

@@ -294,4 +294,34 @@ describe PhoneClassifier do
 
   end
 
+  context "Malaysian Numbers" do
+
+    it "should set Malaysian mobile numbers" do
+      phone_number = "60 11 1234 5678"
+      PhoneClassifier.new(phone_number).kind.should == :mobile
+    end
+
+    it "should set Malaysian service numbers " do
+      phone_number = "60 999 123 123"
+      PhoneClassifier.new(phone_number).kind.should == :forbidden
+    end
+
+
+  end
+
+  context "Singapore Numbers" do
+
+     it "should set mobile numbers" do
+       phone_number = "65 8123 1234"
+       PhoneClassifier.new(phone_number).kind.should == :mobile
+     end
+
+     it "should set service numbers " do
+       phone_number = "65 3123 1234"
+       PhoneClassifier.new(phone_number).kind.should == :forbidden
+     end
+
+
+   end
+
 end

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: phone_classifier
 version: !ruby/object:Gem::Version
-  version: 0.0.1
   prerelease: 
+  version: 0.0.2
 platform: ruby
 authors:
 - Jens-Christian Fischer
@@ -12,21 +12,21 @@ cert_chain: []
 date: 2012-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: phony
-  requirement: !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.8'
+    none: false
+  name: phony
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.8'
+    none: false
 description: Classifies some countries phone numbers into :mobile, :forbidden and
   :landline
 email: jcf+phone_classifier@mobino.com
@@ -35,8 +35,12 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
+- lib/phone_classifier/forbidden.rb
+- lib/phone_classifier/mobile.rb
 - lib/phone_classifier.rb
 - README.md
+- spec/phone_classifier/forbidden_spec.rb
+- spec/phone_classifier/mobile_spec.rb
 - spec/phone_classifier_spec.rb
 homepage: http://github.com/mobino/phone_classifier
 licenses: []
@@ -45,17 +49,17 @@ rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
+required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+  none: false
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -63,4 +67,6 @@ signing_key:
 specification_version: 3
 summary: Classification of phone numbers
 test_files:
+- spec/phone_classifier/forbidden_spec.rb
+- spec/phone_classifier/mobile_spec.rb
 - spec/phone_classifier_spec.rb