phlex 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 959fa6b3416f8a2ad94a64379a8b23a1e2693f5990864584694dd8a83e25c03d
-  data.tar.gz: 9d7f1f895a8f814c502d8e3b39dc1634710accbcaa7652489186c64b4544d19f
+  metadata.gz: 8eeaf45425023ac13320c99f80956f12ec994395b3d349fc6a443334a6715b6d
+  data.tar.gz: 34672ca973f3bec7ade7cccae08e65fff009b122c5319345dadabf779877269e
 SHA512:
-  metadata.gz: 2aa7a0cc26cee6e3fa2fab8c6fb5072bcb55b8afb3e394491a039dc9243821fc60ebe4d479f2edd00f44d411da8227e4b2d7c3d231ebf08f05cd1fa3bd2c871d
-  data.tar.gz: 11ee27a58f2f9a1d5b19b8124648642db6162dd159c060fb6025274a24da28e6fcfb43d2e0e8e889713e658651ea795b07c4835fd9ada80933b1780431555205
+  metadata.gz: 51d8f8bea886016a71b67a6b29b1b584dc1a95b29c4ac9cc24263a3e94be534e1ddfa89f800c10caf00618f27508828f9fc1b233b2829d0c1016aa484b0db6fc
+  data.tar.gz: 3cf6631189545652f860ec393fb63cf392bedd326271ee0863238a32f213a4704a7505442d4bbd06c7473e036c0dfb31c1f25584615189d801dc2515a25e4799

data/README.md

@@ -14,6 +14,12 @@ If you run into any trouble, please [start a discussion](https://github.com/joel
 
 Everyone interacting in Phlex codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/joeldrapper/phlex/blob/main/CODE_OF_CONDUCT.md).
 
+### Who uses Phlex?
+
+- [Clearscope](https://www.clearscope.io)
+
+*If you can share that your company uses Phlex in production, please open a PR to list it here.*
+
 ### Sponsorship 💖
 
 Maintaining a library is a lot of work. If your company benefits from this work or is likely to benefit from it in the future, please consider [sponsorship](https://github.com/sponsors/joeldrapper). Phlex is actively developed and maintained by **[Joel Drapper](https://github.com/sponsors/joeldrapper)**.
@@ -25,3 +31,14 @@ If you’ve found a potential security issue, please email [security@phlex.fun](
 ### Thanks 🙏
 
 Thanks [Logology](https://www.logology.co) for sponsoring our logo.
+
+### Prior Art 🎨
+
+- [markaby](https://github.com/markaby/markaby)
+- [erector](https://github.com/erector/erector)
+- [papercraft](https://github.com/digital-fabric/papercraft)
+- [matestack](https://github.com/matestack/matestack-ui-core)
+- [arbre](https://github.com/activeadmin/arbre)
+- [tubby](https://github.com/judofyr/tubby)
+- [hoshi](https://github.com/pete/hoshi)
+- [hyperstack](https://github.com/hyperstack-org/hyperstack)

data/lib/phlex/html.rb

@@ -134,12 +134,12 @@ module Phlex
 		end
 
 		def call(buffer = +"", view_context: nil, parent: nil, &block)
-			return buffer unless render?
-
 			@_target = buffer
 			@_view_context = view_context
 			@_parent = parent
 
+			return buffer unless render?
+
 			around_template do
 				if block_given?
 					template do |*args|
@@ -154,7 +154,7 @@ module Phlex
 				end
 			end
 
-			self.class.rendered_at_least_once ||= true
+			self.class.rendered_at_least_once = true
 
 			buffer
 		end
@@ -224,8 +224,9 @@ module Phlex
 		end
 
 		def unsafe_raw(content = nil, &block)
-			@_target << (content || instance_exec(&block))
-			nil
+			return nil unless content
+
+			@_target << content
 		end
 
 		def capture(&block)
@@ -316,6 +317,10 @@ module Phlex
 		end
 
 		private def _attributes(**attributes)
+			if attributes[:href]&.start_with?(/\s*javascript/)
+				attributes[:href] = attributes[:href].sub(/^\s*(javascript:)+/, "")
+			end
+
 			buffer = +""
 			_build_attributes(attributes, buffer: buffer)
 
@@ -336,11 +341,8 @@ module Phlex
 					else k.to_s
 				end
 
-				lower_name = name.downcase
-				next if lower_name == "href" && v.start_with?(/\s*javascript:/i)
-
 				# Detect unsafe attribute names. Attribute names are considered unsafe if they match an event attribute or include unsafe characters.
-				if HTML::EVENT_ATTRIBUTES[lower_name] || name.match?(/[<>&"']/)
+				if HTML::EVENT_ATTRIBUTES[name] || name.match?(/[<>&"']/)
 					raise ArgumentError, "Unsafe attribute name detected: #{k}."
 				end
 
@@ -352,7 +354,14 @@ module Phlex
 				when Symbol
 					buffer << " " << name << '="' << ERB::Util.html_escape(v.name) << '"'
 				when Hash
-					_build_attributes(v.transform_keys { "#{k}-#{_1.name.tr('_', '-')}" }, buffer: buffer)
+					_build_attributes(
+						v.transform_keys { |subkey|
+							case subkey
+								when Symbol then"#{k}-#{subkey.name.tr('_', '-')}"
+								else "#{k}-#{subkey}"
+							end
+						}, buffer: buffer
+					)
 				else
 					buffer << " " << name << '="' << ERB::Util.html_escape(v.to_s) << '"'
 				end

data/lib/phlex/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Phlex
-	VERSION = "1.0.1"
+	VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phlex
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Joel Drapper
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-11 00:00:00.000000000 Z
+date: 2023-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zeitwerk
@@ -33,7 +33,6 @@ extra_rdoc_files: []
 files:
 - ".editorconfig"
 - ".rubocop.yml"
-- ".ruby-version"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
@@ -86,7 +85,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
+rubygems_version: 3.3.25
 signing_key:
 specification_version: 4
 summary: A framework for building views in Ruby.

data/.ruby-version

@@ -1 +0,0 @@
-3.3.0