phlex-reactive 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 458474fb8c8cdba105626b01860a196a32ebd144cbc79fd9140dc5fce937924f
-  data.tar.gz: 214a174853a11f054ed246a9cd5fa16c96133aaaf65c1eaa07716f9c61db1eb3
+  metadata.gz: 11c82575cc72017be4f81341c0c2f999d626fe88ed8b81a20cfde246a412fe12
+  data.tar.gz: '0996ececdc33cd2220a7a6517d49d1a59c5c583af891b937f1df32f433189a65'
 SHA512:
-  metadata.gz: d4d6d052aa218e41555dc1d94ff4966e93dff8420dda1402974b470bff49050d4864c1d003c7ef6a2e27d33bbf1ef69bf3e384a8e9ac554d163ab59bdfa2a6e8
-  data.tar.gz: 713f21d6a6155e6dd11923ac756428868aac85074e82c969a1133863f68328a83547a5177d27b1b656a162d2363b352d7aaeaf5af79cdd5768ac86c043fe97d9
+  metadata.gz: 24b3704443cd08380e30bb2bd4340d266a75a39beb80247a4ba26327a4c6f6429b0017fc94618b4063dc4f00a7a86f49ab88074c008d9be1c2ead0b266b5c8cd
+  data.tar.gz: 4f858ded4f109ce0350603140572b4d9c694acd981785ac1913c0cf4c48630e6927d223073cd89fbb1f6a72e16bf7cea0603079661fff7b80740a4389ccbe732

data/CHANGELOG.md

@@ -6,6 +6,22 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Fixed
+
+- **Record-backed component built with a different init keyword by the action
+  endpoint vs the broadcast path.** The click path (`Component.from_identity`)
+  builds with `reactive_record_key` (the `reactive_record :name`), but the
+  broadcast path (`Streamable.build` → `model_param_name`) built with the
+  demodulized, underscored class name. They only agreed when the class name
+  happened to equal the record name — otherwise one path worked and the other
+  raised `ArgumentError: missing keyword`. The README's own `Todos::Item`
+  (`reactive_record :todo`, `Item` ≠ `todo`) hit this on broadcast.
+  `model_param_name` now prefers `reactive_record_key` when set, so a single
+  `initialize(<record>:)` satisfies both clicks and broadcasts. `Streamable`-only
+  components (no `reactive_record`) keep the demodulized-class-name default, and
+  an explicit `def self.model_param_name` override still wins. No API changes.
+  Closes #4.
+
 ## [0.2.1]
 
 ### Fixed

data/lib/phlex/reactive/streamable.rb

@@ -27,11 +27,19 @@ module Phlex
       extend ActiveSupport::Concern
 
       class_methods do
-        # The keyword the positional model maps to in `initialize`. Convention:
-        # demodulized, underscored class name (Invoice -> :invoice,
-        # InvoiceItem -> :invoice_item). Override when it differs.
+        # The keyword the positional model maps to in `initialize`. For a
+        # record-backed component (Component#reactive_record), this is the SAME
+        # keyword the action endpoint uses in `from_identity` — so one
+        # `initialize(<record>:)` satisfies BOTH the click path and the
+        # broadcast path. Otherwise it falls back to the demodulized, underscored
+        # class name (Invoice -> :invoice, InvoiceItem -> :invoice_item).
+        # Override when it differs.
         def model_param_name
-          name.demodulize.underscore.to_sym
+          if respond_to?(:reactive_record_key) && reactive_record_key
+            reactive_record_key
+          else
+            name.demodulize.underscore.to_sym
+          end
         end
 
         def component_args(model, options)

data/lib/phlex/reactive/version.rb

@@ -2,6 +2,6 @@
 
 module Phlex
   module Reactive
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-reactive
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Mikael Henriksson