phlex-forms 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd321ccbe2bec3d9b8966d0eda0e1036e4143af38b4aa55dec702ce8c6d23137
-  data.tar.gz: 2abe25e3c63dd5d689a6c6d762df3ed6204c0dca0ef6b7d569f6e8c3da4ee1d7
+  metadata.gz: d963c5c0eb08c6027d236da0489af8e2b7fd5ef258092c91cc280c8fe4711c5e
+  data.tar.gz: d1a686ce5b6b249c3860584c8b7a9447e4198efe7d0b6c9aed86441a3d7ee915
 SHA512:
-  metadata.gz: fb8b8768817fef4b18e0dacadbfb966cf7356339badfce5e96ea04ccc7e0d5bcc60686e65288413376bbe7873e17993746b35dceefb917a58132505ef88f9094
-  data.tar.gz: e7f775c0c15db6e595f9ac5c93449fb49b12d032f1a615f231b5e23f1aa2ac188fb2eb21a6afccf073758227a3e100a69def8f24185baadd63ddc19e923a48e0
+  metadata.gz: 4563f81fac25d23e76303ee2c96f2734add870c5b5707b8d45683a62479fccc30d0cd36464492627bb7bbabba209f41df8d657514d37a7fd748715d1af3150ab
+  data.tar.gz: 39961525f504962d9345cb6e9ab6215c624717d710db5e801b6fad872a8b60dc792233f66f653711c17aa694aa961263d720a8c75084e54d6832c55315c57f65

data/lib/forms/live.rb

@@ -168,10 +168,16 @@ module Forms
       # widget (rendered in the block) is driven by this root, which then DOM-owns
       # its hidden field. Name/id derived through field_name/field_id — the same
       # path the rootless render uses, so the [name=…]/#…_query selectors match.
+      # This form IS a reactive component, so it has reactive_tags/reactive_filter
+      # itself — the same 0.12.2 escape-hatch sugar Forms::TagField uses, emitting
+      # both filter selectors the client needs (issue #6 Caveats 1 & 2).
       tag = self.class.live_tags_declaration
       return attrs unless tag
 
-      mix(attrs, Forms::TagField.root_tag_attributes(name: field_name(tag[:name]), id: field_id(tag[:name])))
+      query_id = Forms::TagField.query_id(field_id(tag[:name]))
+      mix(attrs,
+        reactive_tags(name: field_name(tag[:name])),
+        reactive_filter(input: "##{query_id}"))
     end
 
     # Untouched fields get no error set, so nothing flashes before the user

data/lib/forms/tag_field.rb

@@ -18,11 +18,13 @@ module Forms
   # The reactive_tags_* client helpers require phlex-reactive >= 0.11.4.
   #
   # It uses the reactive_tags_add/option/remove helpers for the chip/query/option
-  # behavior, but emits the ROOT's `data-reactive-tags-field` raw rather than via
-  # reactive_tags(:tags): that helper compiles a SYMBOL through the class-level
-  # reactive_scope, but a form builder's wire name is per-instance ("user[tags]").
-  # The data attribute IS the public contract; any CSS selector works (issue #6
-  # Caveats 1 & 2). Likewise the query input targets by #id so it never submits.
+  # behavior, and the ROOT's wire attrs come from the 0.12.2 escape-hatch sugar:
+  # reactive_tags(name: @name) takes the per-instance wire name verbatim ("user[tags]")
+  # — the class-level reactive_scope compile can't express it — validated at render;
+  # reactive_filter(input: "#…_query") targets the query input by id so it never
+  # submits, and (unlike the old raw -input-only attr) also emits
+  # data-reactive-filter-option so the 0.12.x client type-ahead actually runs
+  # (issue #6 Caveats 1 & 2).
   class TagField < Phlex::HTML
     include Phlex::Reactive::ClientBindings
 
@@ -48,21 +50,26 @@ module Forms
       end
     end
 
-    # The root's tag wire attrs. Raw, not reactive_tags(:tags)/reactive_filter(:q)
-    # (Caveats 1 & 2): target the hidden field by [name=…] and the query input by
-    # #id (an id selector means the query input never submits a stray param).
-    # Public so Forms::Live can hoist these onto the <form> root when the widget
-    # is lifted rootless.
-    def self.root_tag_attributes(name:, id:)
-      { data: {
-        reactive_tags_field: %([name="#{name}"]),
-        reactive_filter_input: "##{id}_query"
-      } }
-    end
+    # The query input's id — the reactive_filter(input:) target and the id the
+    # search input itself carries. Public so Forms::Live can derive the same id
+    # when it hoists the tag wire attrs onto the <form> root (rootless widget).
+    def self.query_id(id) = "#{id}_query"
 
     private
 
-    def root_tag_attributes = self.class.root_tag_attributes(name: @name, id: @id)
+    # The root's tag wire attrs, via the 0.12.2 escape-hatch sugar (Caveats 1 & 2):
+    # reactive_tags(name:) takes the instance-dynamic wire name verbatim and
+    # validates it at render; reactive_filter(input:) targets the query input by
+    # #id (so it never submits a stray param) and emits both filter selectors the
+    # 0.12.x client needs to run the type-ahead. Both are private helpers from
+    # ClientBindings — Forms::Live has its own copies (it's a reactive component)
+    # and calls them directly when hoisting these onto the <form> root.
+    def root_tag_attributes
+      mix(
+        reactive_tags(name: @name),
+        reactive_filter(input: "##{self.class.query_id(@id)}")
+      )
+    end
 
     # The widget body WITHOUT its root wrapper — shared with the rootless variant
     # so chip/template/suggestion markup never drifts between the two.
@@ -93,7 +100,7 @@ module Forms
 
     def query_attributes
       {
-        id: "#{@id}_query", type: "search", autocomplete: "off",
+        id: self.class.query_id(@id), type: "search", autocomplete: "off",
         placeholder: @placeholder, class: input_classes,
         "aria-invalid": @error || nil
       }.compact

data/lib/phlex_forms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PhlexForms
-  VERSION = "0.2.6"
+  VERSION = "0.2.7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: phlex-forms
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Mikael Henriksson