pheme 4.1.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff68537e797de06e1b5ee79eeaa3b6f64c4783c571febadbb19779511b0eb426
-  data.tar.gz: 9e49021b2cc77aa556de089c21b23397d9a6b03b98f03a5838310db04fac8b43
+  metadata.gz: 77aa7f2b7491323470cd9f9703b253281144ef680a474bd41dbc0b502f4f34cb
+  data.tar.gz: fa195a4334ea0b05e9a366411ae404802783423b12997af34d31d1438b8785e8
 SHA512:
-  metadata.gz: 3e31aa40b21e8aff4d26c2869baae883b14c62aff3c7dc9073ff3ab2020b80a74093b731056a552d4148e1bc463a49073b9d715193373f401eb34f7593241605
-  data.tar.gz: bd46da56fef237e5f952c428fd80247f77d7df3470da501195aa4712d1597ac2eb021a999d10002f20e3a505d0d549519213eb9ae519e3a6fa194430fb52a9dd
+  metadata.gz: 417c01bd6811da7e393508c7b1fbb98dbdff0ab415854e3f08074dd63ae896a54c53d6c970b0f7b42eceb150e13eec4d099fc7688abb4c60136ef9155f765ae5
+  data.tar.gz: e7ad5f758ee7f699c45c2f7abd0fe4d18a1ff5bd4d6472d5fed4d6c8a25c92c5758720853f7191307ffd4a23c76eaad67820eba2363f547e4105000e015a7b7e

data/.github/workflows/main.yml

@@ -38,7 +38,8 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 0
-      - uses: ruby/setup-ruby@v1
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
         with:
           bundler-cache: true
       - name: Release the gem

data/.github/workflows/stale.yml

@@ -0,0 +1,20 @@
+name: 'Close stale PRs'
+on:
+  schedule:
+    - cron: '30 6 * * *' # 6:30 am UTC: 1:30 am EST
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v4
+        with:
+          days-before-stale: 30
+          days-before-close: 60
+          stale-pr-message: >
+            This issue has been automatically marked as stale because it has not had
+            recent activity. It will be closed if no further activity occurs.
+          close-pr-message: >
+            This issue has been automatically closed because it has had no activity
+            for over 90 days. Please re-open if you feel this was done in error.
+          exempt-pr-labels: 'dependabot,depfu,dependencies,security'

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 5.0.0 - 2022-01-04
+### Changed
+- Remove RecusiveOpenStruct in favor of ResourceStruct::FlexStruct
+
 ## 4.1.1 - 2022-01-04
 ### Changed
 - Updated dependencies

data/Gemfile.lock

@@ -1,25 +1,25 @@
 PATH
   remote: .
   specs:
-    pheme (4.1.1)
+    pheme (5.0.0)
       activesupport (>= 4)
       aws-sdk-sns (~> 1.1)
       aws-sdk-sqs (~> 1.3)
-      recursive-open-struct (~> 1)
+      resource-struct (~> 0.4)
       smarter_csv (~> 1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.0)
+    activesupport (7.0.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     ast (2.4.2)
     aws-eventstream (1.2.0)
-    aws-partitions (1.544.0)
-    aws-sdk-core (3.125.0)
+    aws-partitions (1.547.0)
+    aws-sdk-core (3.125.1)
       aws-eventstream (~> 1, >= 1.0.2)
       aws-partitions (~> 1, >= 1.525.0)
       aws-sigv4 (~> 1.1)
@@ -38,7 +38,7 @@ GEM
     concurrent-ruby (1.1.9)
     diff-lcs (1.5.0)
     docile (1.4.0)
-    git (1.10.1)
+    git (1.10.2)
       rchardet (~> 1.8)
     i18n (1.8.11)
       concurrent-ruby (~> 1.0)
@@ -51,8 +51,8 @@ GEM
     rainbow (3.0.0)
     rake (13.0.6)
     rchardet (1.8.0)
-    recursive-open-struct (1.1.3)
     regexp_parser (2.2.0)
+    resource-struct (0.4.0)
     rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
@@ -72,7 +72,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.3)
-    rspec_junit_formatter (0.5.0)
+    rspec_junit_formatter (0.5.1)
       rspec-core (>= 2, < 4, != 2.12.0)
     rubocop (1.24.1)
       parallel (~> 1.10)
@@ -88,7 +88,7 @@ GEM
     rubocop-performance (1.13.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.13.0)
+    rubocop-rails (2.13.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
@@ -104,11 +104,11 @@ GEM
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.3)
     smarter_csv (1.2.9)
-    thor (1.1.0)
+    thor (1.2.1)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
-    ws-style (6.12.3)
+    ws-style (6.13.1)
       rubocop (>= 1.23)
       rubocop-performance (>= 1.10.2)
       rubocop-rails (>= 2.9.1)
@@ -132,4 +132,4 @@ DEPENDENCIES
   ws-style
 
 BUNDLED WITH
-   2.2.32
+   2.2.33

data/Rakefile

@@ -6,7 +6,9 @@ end
 
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new
 
-task default: :spec
+task default: %i[spec rubocop]

data/lib/pheme/message_type/aws_event.rb

@@ -19,9 +19,7 @@ module Pheme
       end
 
       def parse_aws_event(message_contents)
-        # rubocop:disable Vendor/RecursiveOpenStructUse
-        RecursiveOpenStruct.new({ wrapper: message_contents }, recurse_over_arrays: true).wrapper
-        # rubocop:enable Vendor/RecursiveOpenStructUse
+        ResourceStruct::FlexStruct.new({ wrapper: message_contents }).wrapper
       end
     end
   end

data/lib/pheme/queue_poller.rb

@@ -127,16 +127,12 @@ module Pheme
 
     def parse_csv(message_contents)
       parsed_body = SmarterCSV.process(StringIO.new(message_contents))
-      # rubocop:disable Vendor/RecursiveOpenStructUse
-      parsed_body.map { |item| RecursiveOpenStruct.new(item, recurse_over_arrays: true) }
-      # rubocop:enable Vendor/RecursiveOpenStructUse
+      parsed_body.map { |item| ResourceStruct::FlexStruct.new(item) }
     end
 
     def parse_json(message_contents)
       parsed_body = JSON.parse(message_contents)
-      # rubocop:disable Vendor/RecursiveOpenStructUse
-      RecursiveOpenStruct.new({ wrapper: parsed_body }, recurse_over_arrays: true).wrapper
-      # rubocop:enable Vendor/RecursiveOpenStructUse
+      ResourceStruct::FlexStruct.new({ wrapper: parsed_body }).wrapper
     end
 
     def handle(message, metadata, message_attributes)

data/lib/pheme/version.rb

@@ -1,3 +1,3 @@
 module Pheme
-  VERSION = '4.1.1'.freeze
+  VERSION = '5.0.0'.freeze
 end

data/lib/pheme.rb

@@ -1,5 +1,5 @@
 require 'active_support/all'
-require 'recursive-open-struct'
+require 'resource-struct'
 require 'aws-sdk-sns'
 require 'aws-sdk-sqs'
 require 'securerandom'

data/pheme.gemspec

@@ -1,32 +1,32 @@
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
-require "pheme/version"
+require 'pheme/version'
 
 Gem::Specification.new do |s|
   raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.' unless s.respond_to?(:metadata)
 
-  s.name          = "pheme"
+  s.name          = 'pheme'
   s.version       = Pheme::VERSION
-  s.authors       = ["Peter Graham"]
-  s.email         = ["peter@wealthsimple.com"]
+  s.authors       = ['Peter Graham']
+  s.email         = ['peter@wealthsimple.com']
   s.description   = 'Ruby AWS SNS publisher + SQS poller & message handler'
   s.summary       = 'Ruby SNS publisher + SQS poller & message handler'
-  s.homepage      = "https://github.com/wealthsimple/pheme"
+  s.homepage      = 'https://github.com/wealthsimple/pheme'
 
   s.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   s.executables   = s.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
-  s.require_paths = ["lib"]
-  s.license       = "MIT"
+  s.require_paths = ['lib']
+  s.license       = 'MIT'
 
   s.required_ruby_version = '>= 2.7.3'
 
-  s.add_dependency "activesupport", ">= 4"
-  s.add_dependency "aws-sdk-sns", "~> 1.1"
-  s.add_dependency "aws-sdk-sqs", "~> 1.3"
-  s.add_dependency "recursive-open-struct", "~> 1"
-  s.add_dependency "smarter_csv", "~> 1"
+  s.add_dependency 'activesupport', '>= 4'
+  s.add_dependency 'aws-sdk-sns', '~> 1.1'
+  s.add_dependency 'aws-sdk-sqs', '~> 1.3'
+  s.add_dependency 'resource-struct', '~> 0.4'
+  s.add_dependency 'smarter_csv', '~> 1'
 
   s.add_development_dependency 'bundler'
   s.add_development_dependency 'git'

data/spec/message_handler_spec.rb

@@ -3,9 +3,7 @@ describe Pheme::MessageHandler do
 
   before { use_default_configuration! }
 
-  # rubocop:disable RSpec/VerifiedDoubles
-  let(:message) { double(status: status) }
-  # rubocop:enable RSpec/VerifiedDoubles
+  let(:message) { ResourceStruct::FlexStruct.new(status: status) }
   let(:timestamp) { '2018-04-17T21:45:05.915Z' }
 
   describe "#handle" do

data/spec/message_type/aws_event_spec.rb

@@ -3,7 +3,8 @@ describe Pheme::MessageType::AwsEvent do
   let(:message_id) { SecureRandom.uuid }
   let(:queue_url) { 'http://queue_url' }
   let(:queue_message) do
-    OpenStruct.new(
+    instance_double(
+      Aws::SQS::Message,
       message_id: message_id,
       body: { 'Records' => records }.to_json,
       queue_url: queue_url,

data/spec/message_type/sns_message_spec.rb

@@ -22,7 +22,7 @@ describe Pheme::MessageType::SnsMessage do
 
   describe "#parse_message" do
     context "with JSON message" do
-      let!(:message) { OpenStruct.new({ body: '{"Message":"{\"test\":\"test\"}"}' }) }
+      let!(:message) { ResourceStruct::FlexStruct.new({ body: '{"Message":"{\"test\":\"test\"}"}' }) }
 
       it 'parses the message correctly' do
         expect(subject.parse_body(message).test).to eq("test")

data/spec/queue_poller_spec.rb

@@ -5,7 +5,7 @@ describe Pheme::QueuePoller do
   let(:topic_arn) { 'arn:topic:test' }
 
   let!(:queue_message) do
-    OpenStruct.new(
+    ResourceStruct::FlexStruct.new(
       body: { Message: message }.to_json,
       message_id: message_id,
     )
@@ -57,7 +57,7 @@ describe Pheme::QueuePoller do
 
       before do
         allow(Aws::SQS::QueuePoller).to receive(:new).and_return(aws_poller)
-        allow(aws_poller).to receive(:before_request).and_yield(OpenStruct.new(received_message_count: max_messages))
+        allow(aws_poller).to receive(:before_request).and_yield(ResourceStruct::FlexStruct.new(received_message_count: max_messages))
       end
 
       it 'throws error' do
@@ -145,7 +145,7 @@ describe Pheme::QueuePoller do
 
     context 'when message attributes' do
       let(:queue_message) do
-        OpenStruct.new(
+        ResourceStruct::FlexStruct.new(
           body: {
             Message: message,
             MessageAttributes: {
@@ -222,9 +222,7 @@ describe Pheme::QueuePoller do
       end
 
       it { is_expected.to have(2).items }
-      # rubocop:disable Vendor/RecursiveOpenStructUse
-      it { is_expected.to eq(RecursiveOpenStruct.new({ wrapper: expected_message }, recurse_over_arrays: true).wrapper) }
-      # rubocop:enable Vendor/RecursiveOpenStructUse
+      it { is_expected.to eq(ResourceStruct::FlexStruct.new({ wrapper: expected_message }).wrapper) }
     end
 
     context "with unknown message format" do
@@ -242,9 +240,7 @@ describe Pheme::QueuePoller do
 
       it { is_expected.to be_a(Array) }
       its(:first) { is_expected.to be_a(Array) }
-      # rubocop:disable Vendor/RecursiveOpenStructUse
-      its('first.first') { is_expected.to be_a(RecursiveOpenStruct) }
-      # rubocop:enable Vendor/RecursiveOpenStructUse
+      its('first.first') { is_expected.to be_a(ResourceStruct::FlexStruct) }
 
       it "parses the nested object" do
         expect(subject.first.first.test).to eq('test')
@@ -288,7 +284,7 @@ describe Pheme::QueuePoller do
         }
       }
       let!(:queue_message) do
-        OpenStruct.new(
+        ResourceStruct::FlexStruct.new(
           body: notification.to_json,
           message_id: message_id,
         )
@@ -321,7 +317,7 @@ describe Pheme::QueuePoller do
         }
       }
       let!(:queue_message) do
-        OpenStruct.new(
+        ResourceStruct::FlexStruct.new(
           body: notification.to_json,
           message_id: message_id,
         )
@@ -352,7 +348,7 @@ describe Pheme::QueuePoller do
         }
       end
       let!(:queue_message) do
-        OpenStruct.new(
+        ResourceStruct::FlexStruct.new(
           body: notification.to_json,
           message_id: message_id,
         )
@@ -365,9 +361,7 @@ describe Pheme::QueuePoller do
 
       it "handles the message" do
         expect(ExampleMessageHandler).to receive(:new).with(
-          # rubocop:disable Vendor/RecursiveOpenStructUse
-          message: RecursiveOpenStruct.new(message),
-          # rubocop:enable Vendor/RecursiveOpenStructUse
+          message: ResourceStruct::FlexStruct.new(message),
           metadata: { timestamp: timestamp, topic_arn: topic_arn },
           message_attributes: {},
         )
@@ -393,7 +387,7 @@ describe Pheme::QueuePoller do
         }
       end
       let!(:queue_message) do
-        OpenStruct.new(
+        ResourceStruct::FlexStruct.new(
           body: notification.to_json,
           message_id: message_id,
         )
@@ -422,7 +416,7 @@ describe Pheme::QueuePoller do
     context "AWS-event message" do
       subject { ExampleAwsEventQueuePoller.new(queue_url: queue_url) }
 
-      let(:queue_message) { OpenStruct.new(body: { 'Records' => records }.to_json) }
+      let(:queue_message) { ResourceStruct::FlexStruct.new(body: { 'Records' => records }.to_json) }
       let(:records) do
         [{ 'eventVersion' => '2.0', eventSource: 'aws:s3' }]
       end
@@ -443,7 +437,7 @@ describe Pheme::QueuePoller do
       let(:message) { { status: 'complete' } }
       let(:notification) { { 'MessageId' => SecureRandom.uuid, 'Message' => message.to_json, 'Type' => 'Notification', 'Timestamp' => timestamp } }
       let!(:queue_message) do
-        OpenStruct.new(
+        ResourceStruct::FlexStruct.new(
           body: notification.to_json,
           message_id: message_id,
         )

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pheme
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 5.0.0
 platform: ruby
 authors:
 - Peter Graham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-04 00:00:00.000000000 Z
+date: 2022-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -53,19 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
-  name: recursive-open-struct
+  name: resource-struct
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: smarter_csv
   requirement: !ruby/object:Gem::Requirement
@@ -216,6 +216,7 @@ files:
 - ".github/CODEOWNERS"
 - ".github/PULL_REQUEST_TEMPLATE.md"
 - ".github/workflows/main.yml"
+- ".github/workflows/stale.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"