pheme 4.0.1 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0657fbd0490ab265656d91778ee29ee63f48af6544bb15766602afa3c3ff178e
-  data.tar.gz: 0dc1b438ca602e23c522856e93af5563b7186d24f8d638ff20ffddd7d9866a51
+  metadata.gz: 38d24eb669b4e507e93aca15a084c375d9dd5d9d6a734d6e7c0ca3336d216f2e
+  data.tar.gz: f3e87e1c473b1f8ec4b7adfc4c94891026f29ad4fc4d192d982d207233993601
 SHA512:
-  metadata.gz: f77b6d79b12c32e1648510bfe44fb8455c06132d759c77b83d69e57e023bd531e99c858a03fbb0680e9e4923b274a07eef44914b5d99619911546df7fe09c95b
-  data.tar.gz: 75c1691f0b7b0d98e5024db118f663731edf9a08a7ba9528aaa9df3ce1626fdce7abfb0f111c1ecea599b2a1bda94a3553376711e5b1605a2d9a0a73e76e4b49
+  metadata.gz: ccdd560c4cb055cd877804f57b73bbab6a2d95d7a8e4140d3b38e4d6e6c9d5cee6dbd8d632a9c8d4e6651d295317d55ffdb3e4cbbd689f65344f6dcf21d2fbd4
+  data.tar.gz: 4069eea7b5d377d3e245d4e4596abd18d7fe9534112967eadb1597eb225f048f97d9324b1de1a20683c9f1991ef508ae06786d63893cbdf78796d8091f01468b

data/.circleci/config.yml

@@ -2,17 +2,17 @@ version: 2
 
 references:
   defaults:
-    2_4_5: &defaults_2_4_5
+    2_4_10: &defaults_2_4_10
       working_directory: ~/wealthsimple
       docker:
-        - image: circleci/ruby:2.4.5
+        - image: circleci/ruby:2.4.10
           environment:
             RAILS_ENV: test
 
-    2_5_3: &defaults
+    2_5_8: &defaults
       working_directory: ~/wealthsimple
       docker:
-        - image: circleci/ruby:2.5.3
+        - image: circleci/ruby:2.5.8
           environment:
             RAILS_ENV: test
 
@@ -46,8 +46,8 @@ references:
           --format documentation
 
 jobs:
-  checkout_and_bundle_2_4_5:
-    <<: *defaults_2_4_5
+  checkout_and_bundle_2_4_10:
+    <<: *defaults_2_4_10
     environment:
       COVERALLS_REPO_TOKEN: ''
     steps:
@@ -109,17 +109,20 @@ workflows:
   version: 2
   build:
     jobs:
-      - checkout_and_bundle_2_4_5:
+      - checkout_and_bundle_2_4_10:
           context: wealthsimple
       - checkout_and_bundle:
           context: wealthsimple
       - rspec:
+          context: wealthsimple
           requires:
             - checkout_and_bundle
       - lint_check:
+          context: wealthsimple
           requires:
             - checkout_and_bundle
       - vulnerability_check:
+          context: wealthsimple
           requires:
             - checkout_and_bundle
       - release:
@@ -128,10 +131,10 @@ workflows:
             branches:
               only: master
           requires:
-          - checkout_and_bundle_2_4_5
-          - rspec
-          - lint_check
-          - vulnerability_check
+            - checkout_and_bundle_2_4_10
+            - rspec
+            - lint_check
+            - vulnerability_check
 
   security-audit:
     triggers:
@@ -145,5 +148,6 @@ workflows:
       - checkout_and_bundle:
           context: wealthsimple
       - vulnerability_check:
+          context: wealthsimple
           requires:
             - checkout_and_bundle

data/.rubocop.yml

@@ -6,4 +6,4 @@ inherit_gem:
 
 AllCops:
   # Specify your target Ruby version here (only major/minor versions):
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.4

data/.rubocop_todo.yml

@@ -1,42 +1,42 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-07-09 13:48:32 -0400 using RuboCop version 0.72.0.
+# on 2021-01-07 16:23:09 UTC using RuboCop version 1.6.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 19
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 147
+
 # Offense count: 2
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 22
 
 # Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 164
-
-# Offense count: 1
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 10
 
-# Offense count: 17
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 147
-
 # Offense count: 3
-# Configuration parameters: CountComments, ExcludedMethods.
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended, extended
 Metrics/MethodLength:
   Max: 28
 
 # Offense count: 1
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 11
 
-# Offense count: 5
-# Configuration parameters: CustomTransform, IgnoreMethods.
+# Offense count: 9
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Exclude:
     - 'spec/configuration_spec.rb'
@@ -45,8 +45,8 @@ RSpec/FilePath:
     - 'spec/message_type/aws_event_spec.rb'
     - 'spec/message_type/sns_message_spec.rb'
     - 'spec/queue_poller_spec.rb'
-    - 'spec/topic_publisher_spec.rb'
     - 'spec/rollbar_spec.rb'
+    - 'spec/topic_publisher_spec.rb'
     - 'spec/version_spec.rb'
 
 # Offense count: 14
@@ -70,3 +70,10 @@ RSpec/VerifiedDoubles:
 Style/GuardClause:
   Exclude:
     - 'lib/pheme/queue_poller.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/pheme/queue_poller.rb'
+    - 'pheme.gemspec'

data/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 4.0.2 - 2020-12-17
+- Bump local dev version, rubocop fixes, add backstage catalog file + sonarqube project settings
+
 ## 4.0.1 - 2020-03-23
 ### Fixes
 - Fixes 4.0.0. Instead of expecting message attributes in the message from `poll`, retrieves them from the right place.

data/catalog-info.yaml

@@ -0,0 +1,12 @@
+---
+apiVersion: backstage.io/v1alpha1
+kind: Component
+metadata:
+  name: pheme
+  description: Ruby SNS publisher + SQS message handler
+  tags:
+    - ruby
+    - open-source
+spec:
+  type: library
+  lifecycle: production

data/lib/pheme/configuration.rb

@@ -19,8 +19,7 @@ module Pheme
     ATTRIBUTES = %i[sns_client sqs_client logger].freeze
     OPTIONAL_ATTRIBUTES = %i[rollbar].freeze
 
-    attr_accessor(*ATTRIBUTES)
-    attr_accessor(*OPTIONAL_ATTRIBUTES)
+    attr_accessor(*ATTRIBUTES, *OPTIONAL_ATTRIBUTES)
 
     def initialize
       @logger ||= Logger.new(STDOUT) # rubocop:disable Lint/DisjunctiveAssignmentInConstructor

data/lib/pheme/queue_poller.rb

@@ -165,9 +165,9 @@ module Pheme
       end
     end
 
-    def with_optional_connection_pool_block
+    def with_optional_connection_pool_block(&block)
       if connection_pool_block
-        ActiveRecord::Base.connection_pool.with_connection { yield }
+        ActiveRecord::Base.connection_pool.with_connection(&block)
       else
         yield
       end

data/lib/pheme/version.rb

@@ -1,3 +1,3 @@
 module Pheme
-  VERSION = '4.0.1'.freeze
+  VERSION = '4.0.2'.freeze
 end

data/sonar-project.properties

@@ -0,0 +1,4 @@
+sonar.projectKey=pheme
+sonar.ruby.coverage.reportPaths=coverage/.resultset.json
+sonar.sources=lib
+sonar.tests=spec

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pheme
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.2
 platform: ruby
 authors:
 - Peter Graham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-23 00:00:00.000000000 Z
+date: 2021-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -240,6 +240,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- catalog-info.yaml
 - lib/pheme.rb
 - lib/pheme/compression.rb
 - lib/pheme/configuration.rb
@@ -252,6 +253,7 @@ files:
 - lib/pheme/topic_publisher.rb
 - lib/pheme/version.rb
 - pheme.gemspec
+- sonar-project.properties
 - spec/configuration_spec.rb
 - spec/logger_spec.rb
 - spec/message_handler_spec.rb