pheme 3.0.1 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 621deceb5241868a873295d67e9e45bf76b5af4a526fdd25eb9cb039eea9cbdc
-  data.tar.gz: d34dec58d517aa4b8a45c804653869bc101f09d794b427d2f9f3443ebcc4d513
+  metadata.gz: a6759a6fc2cc14d4547c6ebaac443eaf8f575348b942d16d8d45bb42dcd7661f
+  data.tar.gz: 27a6583b5aba5af59f26334e7ef9c474c119133829ac203bc5c4837142ffa9a8
 SHA512:
-  metadata.gz: f9427136ba54d55649638d7038e34c5d756a186c6122a43ab1161db3b8e4a48eec2cdcc9f042387d38e88219b946e3520e6e8111e242923722a333b4052b65a3
-  data.tar.gz: db937f03dc966f977fce8e2a589fffd7aa93213c42e0b94f615f73b0325552c90945fb8ba1932a7452d83ccd3a09d6f78cf5cabb826e30a0f9608113aaa14d85
+  metadata.gz: d027e95e34039911f18b14a2af5c75b70a7d22becb4b66ee200a00abd6ea1cfe767758783ecb70edff1959123a1b7abb1c26ec4801fadcd1db1e1324d36143bc
+  data.tar.gz: '0917063c837f62ad082aa5bb8f0f9e8f6a1496d6de08f3d35eee90f4e8c59d9a7e256b4d1d53495c4e18340e0ba9e08705f0f6699adcc775af03f817a9fd7144'

data/.circleci/config.yml

@@ -39,6 +39,7 @@ references:
     run:
       name: Run rspec
       command: |
+        COVERALLS_REPO_TOKEN=${COVERALLS_REPO_TOKEN} \
         bundle exec rspec --require spec_helper \
                           --format RspecJunitFormatter \
                           --out test_results/rspec.xml \

data/.rubocop.yml

@@ -10,3 +10,32 @@ AllCops:
     - 'examples/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
+
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-02-14 09:34:30 -0500 using RuboCop version 0.64.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 22
+
+# Offense count: 8
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 147
+
+# Offense count: 4
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 22
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/pheme/queue_poller.rb'

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 3.1.0 - 2019-02-14
+### Added
+- Code coverage tracker integration (coveralls.io).
+
 ## 3.0.1 - 2019-02-07
 ### Changed
 - Minimum Ruby version required to be 2.4.

data/README.md

@@ -1,4 +1,4 @@
-# pheme [![CircleCI](https://circleci.com/gh/wealthsimple/pheme.svg?style=svg&circle-token=76942be0b1712ac066627be264886ee18039ad11)](https://circleci.com/gh/wealthsimple/pheme)
+# pheme [![CircleCI](https://circleci.com/gh/wealthsimple/pheme.svg?style=svg&circle-token=76942be0b1712ac066627be264886ee18039ad11)](https://circleci.com/gh/wealthsimple/pheme) [![Coverage Status](https://coveralls.io/repos/github/wealthsimple/pheme/badge.svg?branch=3.1.0-rc)](https://coveralls.io/github/wealthsimple/pheme?branch=3.1.0-rc)
 
 Ruby SNS publisher + SQS poller & message handler
 

data/lib/pheme/configuration.rb

@@ -16,8 +16,11 @@ module Pheme
   end
 
   class Configuration
-    ATTRIBUTES = %i[sns_client sqs_client logger rollbar].freeze
+    ATTRIBUTES = %i[sns_client sqs_client logger].freeze
+    OPTIONAL_ATTRIBUTES = %i[rollbar].freeze
+
     attr_accessor(*ATTRIBUTES)
+    attr_accessor(*OPTIONAL_ATTRIBUTES)
 
     def initialize
       @logger ||= Logger.new(STDOUT) # rubocop:disable Lint/DisjunctiveAssignmentInConstructor
@@ -26,7 +29,7 @@ module Pheme
 
     def validate!
       ATTRIBUTES.each do |attribute|
-        raise "Invalid or missing configuration for #{attribute}"  unless send(attribute).present?
+        raise "Invalid or missing configuration for #{attribute}" if send(attribute).blank?
       end
       raise "sns_client must be a Aws::SNS::Client"  unless sns_client.is_a?(Aws::SNS::Client)
       raise "sns_client must be a Aws::SQS::Client"  unless sqs_client.is_a?(Aws::SQS::Client)

data/lib/pheme/queue_poller.rb

@@ -7,7 +7,7 @@ module Pheme
     attr_accessor :queue_url, :queue_poller, :connection_pool_block, :format, :max_messages, :poller_configuration
 
     def initialize(queue_url:, connection_pool_block: false, max_messages: nil, format: :json, poller_configuration: {}, sqs_client: nil)
-      raise ArgumentError, "must specify non-nil queue_url" unless queue_url.present?
+      raise ArgumentError, "must specify non-nil queue_url" if queue_url.blank?
 
       @queue_url = queue_url
       @queue_poller = Aws::SQS::QueuePoller.new(queue_url, client: sqs_client)
@@ -95,7 +95,7 @@ module Pheme
 
     def parse_csv(message_contents)
       parsed_body = SmarterCSV.process(StringIO.new(message_contents))
-      parsed_body.map{ |item| RecursiveOpenStruct.new(item, recurse_over_arrays: true) }
+      parsed_body.map { |item| RecursiveOpenStruct.new(item, recurse_over_arrays: true) }
     end
 
     def parse_json(message_contents)

data/lib/pheme/rollbar.rb

@@ -1,6 +1,6 @@
 module Pheme
   def self.rollbar(exception, message, data = {})
-    return  if configuration.rollbar.nil?
+    return if configuration.rollbar.nil?
 
     configuration.rollbar.error(exception, message, data)
   end

data/lib/pheme/topic_publisher.rb

@@ -24,7 +24,7 @@ module Pheme
     end
 
     def initialize(topic_arn: self.class._topic_arn)
-      raise ArgumentError, "must specify non-nil topic_arn" unless topic_arn.present?
+      raise ArgumentError, "must specify non-nil topic_arn" if topic_arn.blank?
 
       @topic_arn = topic_arn
     end

data/lib/pheme/version.rb

@@ -1,3 +1,3 @@
 module Pheme
-  VERSION = '3.0.1'.freeze
+  VERSION = '3.1.0'.freeze
 end

data/pheme.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.homepage      = "https://github.com/wealthsimple/pheme"
 
   s.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  s.executables   = s.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  s.executables   = s.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
   s.license       = "MIT"
@@ -29,6 +29,7 @@ Gem::Specification.new do |s|
   s.add_dependency "smarter_csv", "~> 1"
 
   s.add_development_dependency 'bundler'
+  s.add_development_dependency 'coveralls'
   s.add_development_dependency 'git'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'

data/spec/configuration_spec.rb

@@ -19,4 +19,35 @@ describe Pheme do
       expect(described_class.configuration.logger).to eq(custom_logger)
     end
   end
+
+  describe Pheme::Configuration do
+    describe '.validate!' do
+      subject { configuration.validate! }
+
+      let(:configuration) { Pheme::Configuration.new }
+
+      context 'empty configuration' do
+        it 'is invalid when empty' do
+          expect { subject }.to raise_error(StandardError)
+        end
+      end
+
+      context 'all mandatory attributes provided' do
+        let(:sns_client) { instance_double('Aws::SNS::Client') }
+        let(:sqs_client) { instance_double('Aws::SQS::Client') }
+
+        before do
+          allow(sns_client).to receive(:is_a?).with(Aws::SNS::Client).and_return(true)
+          allow(sqs_client).to receive(:is_a?).with(Aws::SQS::Client).and_return(true)
+
+          configuration.sns_client = sns_client
+          configuration.sqs_client = sqs_client
+        end
+
+        it 'is valid' do
+          expect { subject }.not_to raise_error
+        end
+      end
+    end
+  end
 end

data/spec/queue_poller_spec.rb

@@ -75,7 +75,7 @@ describe Pheme::QueuePoller do
       let(:message) { 'unkonwn' }
 
       it "should raise error" do
-        expect{ subject }.to raise_error(ArgumentError)
+        expect { subject }.to raise_error(ArgumentError)
       end
     end
 

data/spec/rollbar_spec.rb

@@ -0,0 +1,22 @@
+RSpec.describe Pheme do
+  let(:rollbar) { double }
+
+  describe '.rollbar' do
+    let(:exception) { StandardError }
+    let(:message) { 'Unable to poll for messages' }
+    let(:data) { { sqs_url: 'arn::foo::bar' } }
+
+    before do
+      Pheme.configure do |config|
+        config.rollbar = rollbar
+      end
+    end
+
+    subject { Pheme.rollbar(exception, message, data) }
+
+    it 'sends error message to rollbar' do
+      expect(rollbar).to receive(:error).with(exception, message, data)
+      subject
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require 'coveralls'
+Coveralls.wear!
+
 require 'rspec'
 require 'rspec/its'
 require 'rspec/collection_matchers'

data/spec/version_spec.rb

@@ -2,11 +2,11 @@ require 'git'
 
 describe Pheme do
   def get_version(git, branch = 'HEAD')
-    git.grep('VERSION = ', 'lib/*/version.rb', { object: branch })
-        .map { |_sha, matches| matches.first[1] }
-        .map(&method(:parse_version))
-        .reject(&:nil?)
-        .first
+    git.grep('VERSION = ', 'lib/*/version.rb', { object: branch }).
+      map { |_sha, matches| matches.first[1] }.
+      map(&method(:parse_version)).
+      reject(&:nil?).
+      first
   end
 
   def parse_version(string)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pheme
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Peter Graham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-07 00:00:00.000000000 Z
+date: 2019-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
@@ -228,6 +242,7 @@ files:
 - spec/message_type/aws_event_spec.rb
 - spec/message_type/sns_message_spec.rb
 - spec/queue_poller_spec.rb
+- spec/rollbar_spec.rb
 - spec/spec_helper.rb
 - spec/support/example_aws_event_queue_poller.rb
 - spec/support/example_message_handler.rb
@@ -265,6 +280,7 @@ test_files:
 - spec/message_type/aws_event_spec.rb
 - spec/message_type/sns_message_spec.rb
 - spec/queue_poller_spec.rb
+- spec/rollbar_spec.rb
 - spec/spec_helper.rb
 - spec/support/example_aws_event_queue_poller.rb
 - spec/support/example_message_handler.rb