pheme 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9149116da3709141b203cf65a869497adba3797f
-  data.tar.gz: 7b0cb4ede93115e51b86869bc916624e552e47f5
+  metadata.gz: 46433ad750c6060d267dc7124847580d107274c9
+  data.tar.gz: 11cf1262b1da8a5e590eef8ef023a88734f1874f
 SHA512:
-  metadata.gz: 9c3bd9a644a326a977785430dc10af03f00d93666e6356954f8803383b822b18430ed8bac3cd515d8bf20b718960b07d69d505074e254f9918807b0b8e518de2
-  data.tar.gz: a1d735abbdab60b3527ad9f2a561c34a986b550c541f3bf9038f5f8b5d9d508ab926c3ae6831ef462f04ff4021bd8fcb8fb08e4ea807c96cb4b081e790d0627b
+  metadata.gz: b309d7c66b7ed47901c4748476e5ac428513dfb89b531c64f1936f0f48e1dfc555acc3fbc586372c25592015d9998f6e6bfd6c236a21d8504bc26e11afa8b919
+  data.tar.gz: f9c7870ba06f05d0d01dbc35f09e6d392cb5d4ebd272d0ef7fc7ef938516d52862517875322aafe03390441d02829148160f7ddc8315b7136f5924cfcfe742c9

data/lib/pheme/queue_poller.rb

@@ -3,15 +3,15 @@ module Pheme
     attr_accessor :queue_url, :queue_poller, :connection_pool_block, :poller_configuration
 
     def initialize(queue_url:, connection_pool_block: false, poller_configuration: {})
+      raise ArgumentError, "must specify non-nil queue_url" unless queue_url.present?
       @queue_url = queue_url
       @queue_poller = Aws::SQS::QueuePoller.new(queue_url)
       @connection_pool_block = connection_pool_block
-      @poller_configuration = poller_configuration.merge({
+      @poller_configuration = {
         wait_time_seconds: 10, # amount of time a long polling receive call can wait for a mesage before receiving a empty response (which will trigger another polling request)
         idle_timeout: 20, # disconnects poller after 20 seconds of idle time
-        visibility_timeout: 30, # length of time in seconds that this message will not be visible to other receiving components
         skip_delete: true, # manually delete messages
-      })
+      }.merge(poller_configuration || {})
     end
 
     def poll

data/lib/pheme/topic_publisher.rb

@@ -3,6 +3,7 @@ module Pheme
     attr_accessor :topic_arn
 
     def initialize(topic_arn:)
+      raise ArgumentError, "must specify non-nil topic_arn" unless topic_arn.present?
       @topic_arn = topic_arn
     end
 

data/lib/pheme/version.rb

@@ -1,3 +1,3 @@
 module Pheme
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/queue_poller_spec.rb

@@ -10,6 +10,20 @@ describe Pheme::QueuePoller do
     allow(Aws::SQS::QueuePoller).to receive(:new) { poller }
   end
 
+  describe ".new" do
+    context "when initialized with valid params" do
+      it "does not raise an error" do
+        expect { ExampleQueuePoller.new(queue_url: "queue_url") }.not_to raise_error
+      end
+    end
+
+    context "when initialized with a nil queue_url" do
+      it "raises an ArgumentError" do
+        expect { ExampleQueuePoller.new(queue_url: nil) }.to raise_error(ArgumentError)
+      end
+    end
+  end
+
   describe "#poll" do
     before(:each) do
       module ActiveRecord

data/spec/topic_publisher_spec.rb

@@ -1,8 +1,23 @@
 describe Pheme::TopicPublisher do
   before(:each) { use_default_configuration! }
-  subject { ExamplePublisher.new(topic_arn: "arn:aws:sns:whatever") }
+
+  describe ".new" do
+    context "when initialized with valid params" do
+      it "does not raise an error" do
+        expect { ExamplePublisher.new(topic_arn: "arn:aws:sns:whatever") }.not_to raise_error
+      end
+    end
+
+    context "when initialized with a nil topic_arn" do
+      it "raises an ArgumentError" do
+        expect { ExamplePublisher.new(topic_arn: nil) }.to raise_error(ArgumentError)
+      end
+    end
+  end
 
   describe "#publish_events" do
+    subject { ExamplePublisher.new(topic_arn: "arn:aws:sns:whatever") }
+
     it "publishes the correct events" do
       expect(Pheme.configuration.sns_client).to receive(:publish).with({
         topic_arn: "arn:aws:sns:whatever",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pheme
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Peter Graham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-23 00:00:00.000000000 Z
+date: 2016-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk
@@ -144,3 +144,4 @@ test_files:
 - spec/support/example_queue_poller.rb
 - spec/topic_publisher_spec.rb
 - spec/version_spec.rb
+has_rdoc: