phaxio 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 508fcbe635de23974bfdefe06aec6811fd7f91bd03377dd4a90b971cd1b6a44f
-  data.tar.gz: e33347de232350332fe604ecae8c0f511a3774fb9ef7c863f6a269bb53bad787
+  metadata.gz: 414f3c2357ed3a6ea5afec63b0f365640fac3ac2cd3409554e36f579582b4931
+  data.tar.gz: b1409dd06f09a01afec33edded877041e682cfefad226bfa54fa86b77efef9b3
 SHA512:
-  metadata.gz: 6a041ed3d71f144ae2c2776a69be5d947982f1eb76c2a2e748f07b245d48ac8714c9199702b71a9b8c0cd404ea6318518834cb9da9365f569cc6b35633c66e83
-  data.tar.gz: d50baaa1fc873a3a20268fb0c56d1b902d0b922d8fcdb731d40e23d89c74bd9c6fea3e35aa66e8c7472502b5af7ac1ad060b5cec22d3fe244e816d98d9be10d5
+  metadata.gz: e79bb9271d141517d2d3cd640caf37dbd8a73a7783ee900ff27f51c12e485579b3bd2ae3f17fa0cf0c13b47cb621829d4c13b9b13ecc57fef083c791a1bdf0b7
+  data.tar.gz: 85199d1532aa1c29df9e1a1fae05b394f22af825bf9f23d35508b7267fdb8182337e554bf27024bda0b41f59988f8213f40a4606bd7d3aec810c0f036fc573d6

data/lib/phaxio/client.rb

@@ -52,13 +52,17 @@ module Phaxio
       def handle_response response
         content_type = response.headers[:content_type]
 
-        if content_type.start_with? 'application/json'
-          body = JSON.parse(response.body).with_indifferent_access
+        if content_type
+          if content_type.start_with? 'application/json'
+            body = JSON.parse(response.body).with_indifferent_access
+          else
+            extension = MimeTypeHelper.extension_for_mimetype content_type
+            filename = File.join Dir.tmpdir, tmpname(extension)
+            File.open(filename, 'wb') { |file| file.write response.body }
+            body = {'success' => response.success?, 'data' => File.open(filename, 'rb')}
+          end
         else
-          extension = MimeTypeHelper.extension_for_mimetype content_type
-          filename = File.join Dir.tmpdir, tmpname(extension)
-          File.open(filename, 'wb') { |file| file.write response.body }
-          body = {'success' => response.success?, 'data' => File.open(filename, 'rb')}
+          body = {}
         end
 
         if response.success?
@@ -85,6 +89,8 @@ module Phaxio
             raise Error::InvalidRequestError, "#{status}: #{message}"
           when 429
             raise Error::RateLimitExceededError, "#{status}: #{message}"
+          when 503
+            raise Error::ServiceUnavailableError, "#{status}: #{message}"
           else
             raise Error::GeneralError, "#{status}: #{message}"
           end

data/lib/phaxio/error.rb

@@ -6,6 +6,7 @@ module Phaxio
       NotFoundError
       InvalidRequestError
       RateLimitExceededError
+      ServiceUnavailableError
       GeneralError
       ApiConnectionError
     ].each { |error_klass_name| const_set error_klass_name, Class.new(PhaxioError) }

data/lib/phaxio/version.rb

@@ -1,3 +1,3 @@
 module Phaxio
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/client_spec.rb

@@ -19,6 +19,16 @@ RSpec.describe Phaxio::Client do
     )
   end
 
+  def test_response_503
+    instance_double(
+      Faraday::Response,
+      status: 503,
+      success?: false,
+      headers: {},
+      body: nil
+    )
+  end
+
   describe 'making a request' do
     it 'sends the request to Phaxio' do
       endpoint = 'public/countries/'
@@ -118,6 +128,13 @@ RSpec.describe Phaxio::Client do
       }.to raise_error(Phaxio::Error::RateLimitExceededError, '429: This is a test.')
     end
 
+    it 'raises a service unavailable error if the response status is 503' do
+      expect(test_connection).to receive(:get) { test_response_503 }
+      expect {
+        client.request :get, 'test'
+      }.to raise_error(Phaxio::Error::ServiceUnavailableError, '503: ')
+    end
+
     it 'raises a general error for if the response status is 5XX' do
       expect(test_connection).to receive(:get) { test_response 500 }
       expect {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phaxio
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Julien Negrotto
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-27 00:00:00.000000000 Z
+date: 2022-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday