phaxio 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a10449404bdb1df029a52a878f49202589e727d
-  data.tar.gz: f500188f94760b8300dc2f63b17eb4ad31edc5fa
+  metadata.gz: 12ce42728923c83667571c73e2c0320f41a3f579
+  data.tar.gz: f6840ec8c126853273bd76f68d3399b3f5a24989
 SHA512:
-  metadata.gz: df06285d6e87fbc048f0ebcad0cd5ee608ccfb0b45c6813926f272c4302aa5dc60421445df11bacc6fae2e26a32951912ca201376a56c77bcd2e5fa71e0e5976
-  data.tar.gz: 9d5bcfa978e6e92317d17d4bb0a31e4cd2f33f57d96f8241721bc581be34c768623704d951d4a177f5634dc0eb6a7f2cff4c8db7588e6e286a61ba2aa5020dd3
+  metadata.gz: 3f805c26607a691b2af4e692cd5c8c6cf4b24a624b711527f72e85ee49287071369087e261d41eb292a7a9747cf32e26cd7ac67f3b15018d906cf1c9a8a4ceeb
+  data.tar.gz: a1bc1b11cfa3244f1361a526c0439bfc9dab5c82efe45e80ee888c5d01920af8e190dc5336b232980d0c57ee3162f3ffa6c5220ecba65b5fc98c577a92275526

data/lib/phaxio/client.rb

@@ -55,10 +55,7 @@ module Phaxio
           body = JSON.parse(response.body).with_indifferent_access
         else
           extension = MimeTypeHelper.extension_for_mimetype content_type
-          filename = File.join(
-            Dir.tmpdir,
-            Dir::Tmpname.make_tmpname('phaxio-', "download.#{extension}")
-          )
+          filename = File.join Dir.tmpdir, tmpname(extension)
           File.open(filename, 'wb') { |file| file.write response.body }
           body = {'success' => response.success?, 'data' => File.open(filename, 'rb')}
         end
@@ -93,12 +90,23 @@ module Phaxio
         end
       end
 
+      def tmpname(extension)
+        t = Time.now.strftime("%Y%m%d")
+        "phaxio-#{t}-#{$$}-#{rand(0x100000000).to_s(36)}-download.#{extension}"
+      end
+
       def post endpoint, params = {}
         # Handle file params
         params.each do |k, v|
           next unless k.to_s == 'file'
-          mime_type = MimeTypeHelper.mimetype_for_file v.path
-          params[k] = Faraday::UploadIO.new v, mime_type
+
+          if v.is_a? Array
+            file_param = v.map { |file| file_to_param file }
+          else
+            file_param = file_to_param v
+          end
+
+          params[k] = file_param
         end
 
         conn.post endpoint, params
@@ -130,6 +138,11 @@ module Phaxio
           api_secret: Phaxio.api_secret
         }
       end
+
+      def file_to_param file
+        mime_type = MimeTypeHelper.mimetype_for_file file.path
+        Faraday::UploadIO.new file, mime_type
+      end
     end
   end
 end

data/lib/phaxio/version.rb

@@ -1,3 +1,3 @@
 module Phaxio
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/phaxio.gemspec

@@ -14,6 +14,7 @@ Gem::Specification.new do |gem|
   gem.name          = "phaxio"
   gem.require_paths = ["lib"]
   gem.version       = Phaxio::VERSION
+  gem.licenses      = ['MIT']
 
   gem.required_ruby_version = '>= 2.0'
   gem.add_dependency 'faraday', '~> 0.10'

data/spec/client_spec.rb

@@ -32,6 +32,38 @@ RSpec.describe Phaxio::Client do
       client.request :get, endpoint, params
     end
 
+    it 'handles a single file param' do
+      file_path = File.expand_path File.join('..', 'support', 'files', 'test.pdf'), __FILE__
+      params = {to: '+12258888888', file: File.open(file_path)}
+      expect(test_connection).to receive(:post) do |request_endpoint, request_params|
+        expect(request_params[:file]).to be_a(Faraday::UploadIO)
+        expect(request_params[:file].original_filename).to eq(File.basename(file_path))
+        test_response 200
+      end
+
+      client.request :post, 'faxes', params
+    end
+
+    it 'handles multiple file params' do
+      file_names = ['test.pdf', 'test.txt']
+      file_paths = file_names.map do |file_name|
+        File.expand_path File.join('..', 'support', 'files', file_name), __FILE__
+      end
+      params = {to: '+12258888888', file: file_paths.map { |file_path| File.open(file_path) }}
+
+      expect(test_connection).to receive(:post) do |request_endpoint, request_params|
+        expect(request_params[:file]).to be_a(Array)
+        correct_file_params = request_params[:file].all? do |file_param|
+          file_param.is_a? Faraday::UploadIO
+        end
+        expect(correct_file_params).to eq(true)
+        expect(request_params[:file].map(&:original_filename)).to eq(file_names)
+        test_response 200
+      end
+
+      client.request :post, 'faxes', params
+    end
+
     it 'uses the configured API key and secret by default' do
       expect(test_connection).to receive(:get) do |_endpoint, request_params|
         expect(request_params[:api_key]).to eq(Phaxio.api_key)

data/spec/support/files/test.txt

@@ -0,0 +1 @@
+OK

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: phaxio
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Julien Negrotto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-11 00:00:00.000000000 Z
+date: 2018-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -97,6 +97,7 @@ files:
 - spec/support/credentials.rb
 - spec/support/expectations.rb
 - spec/support/files/test.pdf
+- spec/support/files/test.txt
 - spec/support/vcr.rb
 - spec/support/vcr_cassettes/resources/account/status.yml
 - spec/support/vcr_cassettes/resources/fax/cancel.yml
@@ -117,7 +118,8 @@ files:
 - spec/support/vcr_cassettes/resources/public/area_codes/list.yml
 - spec/support/vcr_cassettes/resources/public/country/list.yml
 homepage: https://github.com/phaxio/phaxio-ruby
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -135,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2.2
 signing_key: 
 specification_version: 4
 summary: Official ruby gem for interacting with Phaxio's API.