pgtk 0.31.7 → 0.31.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9620e5581d667750f82a36568c6b64fcb27c2c588b93fc433869f1a430159128
-  data.tar.gz: 281908df6408d31c7ae69ff9ea4a4122881b7ae54c7906e87d10abf885d625d4
+  metadata.gz: 10ac49e5f5fa5ac3792edf7e62961f8d37f8937a645a878de4e15b3ced01e575
+  data.tar.gz: 51b1c1927f57ea50b181cda95dc6f0471237c4873a7e99482b35f980fd8294dd
 SHA512:
-  metadata.gz: f633a5925cbf6f8ad61247c898a7d58a59d8a64dcf7e23597f625ddfad816e856ae00b6b4960839abec9d763b931a4c519bce49c3bd2724fef38854e7c316c7e
-  data.tar.gz: a70e63d0772e40632333d382d4c8598a6a1ab60d72b3ce7bc8675ed12aced75acdc6117fbfccfc6fd9094e927136f7b9f983ba99491b673a392fd7fdb645597a
+  metadata.gz: 9d1f4a4d1247426d01caea364c9082e6dc9b81eb7428fb2da3f11764d9542ad7c99b35b1f0a1ed25c033e203d9ef253b48b061ce29eee07ca2048f9f82aa8f50
+  data.tar.gz: f713deaf5f0b8c2ba45a0d6fd8d6c46fb88f8ba153b1f1096aa69c351655cd7ce1daefb7d6e0e730609eb96b713c90ad5b3a50ccb08914a10ee4011b4ba3ef2b

data/Gemfile.lock

@@ -42,7 +42,7 @@ GEM
     loog (0.8.0)
       ellipsized
       logger (~> 1.0)
-    minitest (6.0.5)
+    minitest (6.0.6)
       drb (~> 2.0)
       prism (~> 1.5)
     minitest-mock (5.27.0)

data/README.md

@@ -284,7 +284,9 @@ retry_pool.exec('INSERT INTO logs (message) VALUES ($1)', ['User logged in'])
 Key features:
 
 1. Only `SELECT` queries are retried (to prevent duplicate data modifications)
-2. Retries happen immediately without delay
+2. Retries happen immediately, except on `PG::ConnectionBad`,
+   where an exponential backoff (50ms, 200ms, 1s) is applied
+   between attempts to avoid amplifying upstream login storms
 3. The original error is raised after all retry attempts are exhausted
 4. Works seamlessly with other decorators like `Pgtk::Spy` and `Pgtk::Impatient`
 

data/lib/pgtk/liquicheck_task.rb

@@ -7,7 +7,7 @@ require 'nokogiri'
 require 'rake/tasklib'
 require_relative '../pgtk'
 
-# Liquicheck rake task for check Liquibase XML files.
+# Liquicheck rake task to check Liquibase XML files.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
 # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
 # License:: MIT
@@ -63,7 +63,7 @@ class Pgtk::LiquicheckTask < Rake::TaskLib
     context = node.attr('context')&.to_s
     on(errors, file) do
       demand(id, 'ID is empty')
-      confirm(id, /[-a-z]+/, "ID #{id.inspect} has not suffix in #{context} context") if context
+      confirm(id, /[-a-z]+/, "ID #{id.inspect} has no suffix in #{context} context") if context
     end
     on(errors, file) do
       demand(author, 'author is empty')

data/lib/pgtk/pool.rb

@@ -114,7 +114,7 @@ class Pgtk::Pool
   #    puts 'Title: ' + row['title']
   #  end
   #
-  # All values in the retrieved hash are strings. No matter what types of
+  # All values in the retrieved hash are strings. No matter what types
   # of data you have in the database, you get strings here. It's your job
   # to convert them to the type you need.
   #
@@ -322,6 +322,7 @@ class Pgtk::Pool
           conn = renew(conn, reason)
         rescue StandardError => e
           @log.warn("Failed to renew dead connection (#{reason}): #{e.message}")
+          raise(e)
         end
       end
       begin

data/lib/pgtk/retry.rb

@@ -54,6 +54,8 @@ class Pgtk::Retry
   # so its message and stack trace are preserved for debugging.
   class Exhausted < StandardError; end
 
+  BACKOFFS = [0.05, 0.2, 1.0].freeze
+
   # Constructor.
   #
   # @param [Pgtk::Pool] pool The pool to decorate
@@ -86,13 +88,15 @@ class Pgtk::Retry
   end
 
   # Execute a SQL query with automatic retry on transient failures.
-  # SELECT queries are retried on any error, since reads are idempotent.
-  # Non-SELECT queries are retried only on PG::ConnectionBad, since by
-  # definition the query never reached the server, so retrying cannot
-  # duplicate a write. Other errors on writes propagate immediately,
-  # because a failure may occur after the server received the query but
-  # before the acknowledgement reached the client, and retrying a
-  # non-idempotent write could duplicate it.
+  # Only SELECT queries are retried, since reads are idempotent.
+  # Non-SELECT queries propagate the original error immediately, even
+  # on PG::ConnectionBad, because that error can be raised after the
+  # server already received the query but before the acknowledgement
+  # reached the client, and retrying a non-idempotent write could
+  # duplicate it. When the underlying error is PG::ConnectionBad, an
+  # exponential backoff (see BACKOFFS) is applied between attempts, so
+  # that a SELECT failing against an upstream pool that is in its
+  # login-failure cache window does not amplify the storm.
   #
   # @param [String] sql The SQL query with params inside (possibly)
   # @return [Array] Result rows
@@ -101,14 +105,11 @@ class Pgtk::Retry
     attempt = 0
     begin
       @pool.exec(sql, *)
-    rescue PG::ConnectionBad => e
-      attempt += 1
-      raise(Exhausted, "Retry gave up after #{@attempts} attempts: #{e.message}") if attempt >= @attempts
-      retry
     rescue StandardError, Pgtk::Impatient::TooSlow => e
       raise(e) unless query.strip.upcase.start_with?('SELECT')
       attempt += 1
       raise(Exhausted, "Retry gave up after #{@attempts} attempts: #{e.message}") if attempt >= @attempts
+      sleep(BACKOFFS[attempt - 1] || BACKOFFS.last) if e.is_a?(PG::ConnectionBad)
       retry
     end
   end

data/lib/pgtk/version.rb

@@ -10,5 +10,5 @@ require_relative '../pgtk'
 # Copyright:: Copyright (c) 2019-2026 Yegor Bugayenko
 # License:: MIT
 module Pgtk
-  VERSION = '0.31.7' unless defined?(VERSION)
+  VERSION = '0.31.8' unless defined?(VERSION)
 end

data/resources/pom.xml

@@ -10,7 +10,7 @@
   <version>0.0.0</version>
   <packaging>pom</packaging>
   <properties>
-    <postgresql.version>42.7.10</postgresql.version>
+    <postgresql.version>42.7.11</postgresql.version>
     <liquibase.version>5.0.2</liquibase.version>
   </properties>
   <dependencies>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pgtk
 version: !ruby/object:Gem::Version
-  version: 0.31.7
+  version: 0.31.8
 platform: ruby
 authors:
 - Yegor Bugayenko