pghero 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d77eb8abd5e212bfd047e51833fb060f70db7025
-  data.tar.gz: 37615f251c48027095056c84e3d14654fb2a9b57
+  metadata.gz: 88bdee267422f250773f1764fb7b7afea03344b1
+  data.tar.gz: 378e02b5b0c4e3f59646bada6899a203b22ff111
 SHA512:
-  metadata.gz: 773cb04370074357513902e3a707d292e3c67efe2e4b0d2df30cd93d828d1ac104e34f1695cc4a4b63015f9dd8d01c4d0e1264fd32e3f1ebbd3a307e1b900ab9
-  data.tar.gz: fb72f6b6ccc15dce99eee4a68200ad4b0d7a17dbc470362d1ab0aa2c570a7ec574ad22f8c300b0be251137154274ac0fbe900fee3e453753fcfca108b1834e94
+  metadata.gz: 3cac1afe8db164aa87aaa614a2210b7f38b5e6746ab58e3b9931510b1481e579ff03438f1471ac5037379e8123342fc47e526eeb308f94dba9ea6901e7fa53f6
+  data.tar.gz: 1675887b2ea3d5ca45dfa5c5964c35c3e30de771171387fd379efc4cf92d1379e7013281274477d5c8717a0549f560857b27e22284d4558d2449083e08bd1217

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.6.2
+
+- Suggest GiST over GIN for `LIKE` queries again (seeing better performance)
+
 ## 1.6.1
 
 - Suggest GIN over GiST for `LIKE` queries

data/app/views/pg_hero/home/index.html.erb

@@ -267,8 +267,7 @@ remove_index <%= query["unneeded_index"]["table"].to_sym.inspect %>, name: <%= q
       <pre style="overflow: scroll; white-space: pre; word-break: normal;">commit_db_transaction
 <% @suggested_indexes.each do |index| %>
 <% if index[:using] && index[:using] != "btree" %>
-# run directly on production database - Rails has trouble with GIN indexes
-# connection.execute("CREATE INDEX CONCURRENTLY ON <%= index[:table] %><% if index[:using] %> USING <%= index[:using] %><% end %> (<%= index[:columns].join(", ") %>)")
+connection.execute("CREATE INDEX CONCURRENTLY ON <%= index[:table] %><% if index[:using] %> USING <%= index[:using] %><% end %> (<%= index[:columns].join(", ") %>)")
 <% else %>
 add_index <%= index[:table].to_sym.inspect %>, [<%= index[:columns].map(&:to_sym).map(&:inspect).join(", ") %>], algorithm: :concurrently<% end %>
 <% end %></pre>

data/lib/pghero/methods/suggested_indexes.rb

@@ -134,7 +134,7 @@ module PgHero
                   if ["~~", "~~*"].include?(where.first[:op])
                     index[:found] = true
                     index[:row_progression] = [total_rows, index[:row_estimates].values.first]
-                    index[:index] = {table: table, columns: ["#{where.first[:column]} gin_trgm_ops"], using: "gin"}
+                    index[:index] = {table: table, columns: ["#{where.first[:column]} gist_trgm_ops"], using: "gist"}
                   else
                     # if most values are unique, no need to index others
                     rows_left = total_rows

data/lib/pghero/version.rb

@@ -1,3 +1,3 @@
 module PgHero
-  VERSION = "1.6.1"
+  VERSION = "1.6.2"
 end

data/test/best_index_test.rb

@@ -59,7 +59,7 @@ class BestIndexTest < Minitest::Test
   end
 
   def test_like
-    assert_best_index ({table: "users", columns: ["email gin_trgm_ops"], using: "gin"}), "SELECT * FROM users WHERE email LIKE ?"
+    assert_best_index ({table: "users", columns: ["email gist_trgm_ops"], using: "gist"}), "SELECT * FROM users WHERE email LIKE ?"
   end
 
   def test_like_where
@@ -67,11 +67,11 @@ class BestIndexTest < Minitest::Test
   end
 
   def test_like_where2
-    assert_best_index ({table: "users", columns: ["email gin_trgm_ops"], using: "gin"}), "SELECT * FROM users WHERE email LIKE ? AND active = ?"
+    assert_best_index ({table: "users", columns: ["email gist_trgm_ops"], using: "gist"}), "SELECT * FROM users WHERE email LIKE ? AND active = ?"
   end
 
   def test_ilike
-    assert_best_index ({table: "users", columns: ["email gin_trgm_ops"], using: "gin"}), "SELECT * FROM users WHERE email ILIKE ?"
+    assert_best_index ({table: "users", columns: ["email gist_trgm_ops"], using: "gist"}), "SELECT * FROM users WHERE email ILIKE ?"
   end
 
   def test_not_equals

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pghero
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-25 00:00:00.000000000 Z
+date: 2016-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord