pghero 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b86a04757fce4dfc91177eb7794c20ae289ec2d5
-  data.tar.gz: ba8f9f333064208ea84fd6a4c222cd531f18637b
+  metadata.gz: d77eb8abd5e212bfd047e51833fb060f70db7025
+  data.tar.gz: 37615f251c48027095056c84e3d14654fb2a9b57
 SHA512:
-  metadata.gz: d97627eb0174decf527ea8ca4554fcb8d45bc95c28eeb4fc250b7921c544f685af741ec85c5cfd1815a7749af36b4f75a4e90ef2b261adae873a9718ded34de3
-  data.tar.gz: e8fedfa37a433af1d4c2b647242b06bc6cc8ba1697f45e564123d3d77a8db599e722322a047d7c51b4c528805324df5db1f5f08b7bda5ae62ffda093d7f4a718
+  metadata.gz: 773cb04370074357513902e3a707d292e3c67efe2e4b0d2df30cd93d828d1ac104e34f1695cc4a4b63015f9dd8d01c4d0e1264fd32e3f1ebbd3a307e1b900ab9
+  data.tar.gz: fb72f6b6ccc15dce99eee4a68200ad4b0d7a17dbc470362d1ab0aa2c570a7ec574ad22f8c300b0be251137154274ac0fbe900fee3e453753fcfca108b1834e94

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.6.1
+
+- Suggest GIN over GiST for `LIKE` queries
+
 ## 1.6.0
 
 - Removed mostly inactionable items (cache hit rate and index usage)

data/app/views/pg_hero/home/index.html.erb

@@ -266,8 +266,9 @@ remove_index <%= query["unneeded_index"]["table"].to_sym.inspect %>, name: <%= q
       <p>And paste</p>
       <pre style="overflow: scroll; white-space: pre; word-break: normal;">commit_db_transaction
 <% @suggested_indexes.each do |index| %>
-<% if index[:using] == "gist" %>
-connection.execute("CREATE INDEX CONCURRENTLY ON <%= index[:table] %><% if index[:using] %> USING <%= index[:using] %><% end %> (<%= index[:columns].join(", ") %>)")
+<% if index[:using] && index[:using] != "btree" %>
+# run directly on production database - Rails has trouble with GIN indexes
+# connection.execute("CREATE INDEX CONCURRENTLY ON <%= index[:table] %><% if index[:using] %> USING <%= index[:using] %><% end %> (<%= index[:columns].join(", ") %>)")
 <% else %>
 add_index <%= index[:table].to_sym.inspect %>, [<%= index[:columns].map(&:to_sym).map(&:inspect).join(", ") %>], algorithm: :concurrently<% end %>
 <% end %></pre>

data/lib/pghero.rb

@@ -41,7 +41,7 @@ module PgHero
   class << self
     extend Forwardable
     def_delegators :current_database, :access_key_id, :autoindex, :autoindex_all, :autovacuum_danger,
-      :best_index, :blocked_queries, :capture_query_stats, :connection_sources, :connection_stats,
+      :best_index, :blocked_queries, :connection_sources, :connection_stats,
       :cpu_usage, :create_user, :database_size, :db_instance_identifier, :disable_query_stats, :drop_user,
       :duplicate_indexes, :enable_query_stats, :explain, :historical_query_stats_enabled?, :index_caching,
       :index_hit_rate, :index_usage, :indexes, :invalid_indexes, :kill, :kill_all, :kill_long_running_queries,

data/lib/pghero/methods/query_stats.rb

@@ -165,7 +165,7 @@ module PgHero
               SELECT
                 LEFT(query, 10000) AS query,
                 #{supports_query_hash? ? "queryid" : "md5(query)"} AS query_hash,
-                #{supports_query_stats_user? ? "rolname" : "NULL"} AS user,
+                #{supports_query_stats_user? ? "rolname" : "NULL::text"} AS user,
                 (total_time / 1000 / 60) AS total_minutes,
                 (total_time / calls) AS average_time,
                 calls
@@ -205,7 +205,7 @@ module PgHero
             WITH query_stats AS (
               SELECT
                 #{supports_query_hash? ? "query_hash" : "md5(query)"} AS query_hash,
-                #{supports_query_stats_user? ? "pghero_query_stats.user" : "NULL"} AS user,
+                #{supports_query_stats_user? ? "pghero_query_stats.user" : "NULL::text"} AS user,
                 array_agg(LEFT(query, 10000)) AS query,
                 (SUM(total_time) / 1000 / 60) AS total_minutes,
                 (SUM(total_time) / SUM(calls)) AS average_time,

data/lib/pghero/methods/suggested_indexes.rb

@@ -134,7 +134,7 @@ module PgHero
                   if ["~~", "~~*"].include?(where.first[:op])
                     index[:found] = true
                     index[:row_progression] = [total_rows, index[:row_estimates].values.first]
-                    index[:index] = {table: table, columns: ["#{where.first[:column]} gist_trgm_ops"], using: "gist"}
+                    index[:index] = {table: table, columns: ["#{where.first[:column]} gin_trgm_ops"], using: "gin"}
                   else
                     # if most values are unique, no need to index others
                     rows_left = total_rows

data/lib/pghero/version.rb

@@ -1,3 +1,3 @@
 module PgHero
-  VERSION = "1.6.0"
+  VERSION = "1.6.1"
 end

data/test/best_index_test.rb

@@ -59,7 +59,7 @@ class BestIndexTest < Minitest::Test
   end
 
   def test_like
-    assert_best_index ({table: "users", columns: ["email gist_trgm_ops"], using: "gist"}), "SELECT * FROM users WHERE email LIKE ?"
+    assert_best_index ({table: "users", columns: ["email gin_trgm_ops"], using: "gin"}), "SELECT * FROM users WHERE email LIKE ?"
   end
 
   def test_like_where
@@ -67,11 +67,11 @@ class BestIndexTest < Minitest::Test
   end
 
   def test_like_where2
-    assert_best_index ({table: "users", columns: ["email gist_trgm_ops"], using: "gist"}), "SELECT * FROM users WHERE email LIKE ? AND active = ?"
+    assert_best_index ({table: "users", columns: ["email gin_trgm_ops"], using: "gin"}), "SELECT * FROM users WHERE email LIKE ? AND active = ?"
   end
 
   def test_ilike
-    assert_best_index ({table: "users", columns: ["email gist_trgm_ops"], using: "gist"}), "SELECT * FROM users WHERE email ILIKE ?"
+    assert_best_index ({table: "users", columns: ["email gin_trgm_ops"], using: "gin"}), "SELECT * FROM users WHERE email ILIKE ?"
   end
 
   def test_not_equals

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pghero
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-21 00:00:00.000000000 Z
+date: 2016-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord