pgchief 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 613ce14b91c64d69a6fa16449f8ea8aa2a3dfcab054684efaefe978eaae0f564
-  data.tar.gz: 7116499bc9a4ea6e30b850bbe07e953e7068b7c2b8c03b32daef87dde6fe0061
+  metadata.gz: 8c695989f5431e21f2c33b016b34a7197fb5cca9ea62592391fab10fcdbfe385
+  data.tar.gz: 195ab95c85943e54d41455ae25b1458aa538d6bc4b6319685b609de7549504f9
 SHA512:
-  metadata.gz: 3725ab140a34f5e8c41fb13e9c737835a96ca440d2519ee377991921af672109321984e8d089813be6042af732642a4c94127da2d8873d1214f32c0073583299
-  data.tar.gz: f560244827039f3258151f2e8e573b5d4584847cd5ddccf84e085b00104f21b45fa77af1c6a85df54d8ee2ace45a5915d4240ef06ee24ae5714625072eb5ec46
+  metadata.gz: 352d1edab7569b64483b3abf178297cf2a213ff1c24dfdc40f39ecd8548a06acfffd650ae30a7284fba34368c15e7d58c09e9f3153e9cfc8657613fa01fe4da0
+  data.tar.gz: e6e5f42192398383a2b8bc481c6a2b5f37722eef72111a04e2250a84bd1ac4125a9e783123ea1b3d4d64d2c3721a177482b3c83fd1bc656cc4d9b564ac2af4fc

data/CHANGELOG.md

@@ -13,6 +13,24 @@ and this project will try its best to adhere to [Semantic Versioning](https://se
 
 ### Fixes
 
+## [0.5.3]
+
+### Additions
+
+* Add spec for database backup command class.
+* Add check on the resulting db dump file. Make sure it's > 0 bytes.
+
+### Changes
+
+* Allow created users the proper permissions to add PG extensions to a database.
+
+### Fixes
+
+* Fix typo in backup command class description.
+* Fix backup command to use full database connection string to the database when
+  executing the pg_dump command.
+* Reset s3 config in db backup spec to prevent config leaks from other test runs.
+
 ## [0.5.2]
 
 ### Changes
@@ -119,7 +137,8 @@ and this project will try its best to adhere to [Semantic Versioning](https://se
 - Drop user ✅
 - List databases ✅
 
-[Unreleased]: https://github.com/jayroh/pgchief/compare/v0.5.2...HEAD
+[Unreleased]: https://github.com/jayroh/pgchief/compare/v0.5.3...HEAD
+[0.5.3]: https://github.com/jayroh/pgchief/releases/tag/v0.5.3
 [0.5.2]: https://github.com/jayroh/pgchief/releases/tag/v0.5.2
 [0.5.1]: https://github.com/jayroh/pgchief/releases/tag/v0.5.1
 [0.5.0]: https://github.com/jayroh/pgchief/releases/tag/v0.5.0

data/lib/pgchief/command/database_backup.rb

@@ -4,7 +4,7 @@ require "forwardable"
 
 module Pgchief
   module Command
-    # Command object to drop a database
+    # Command object to back up a database
     class DatabaseBackup < Base
       extend Forwardable
 
@@ -12,12 +12,17 @@ module Pgchief
 
       attr_reader :database
 
-      def call
+      def initialize(*params)
+        super
         @database = params.first
         @uploader = Pgchief::Command::S3Upload.new(local_location)
+      end
+
+      def call
         raise Pgchief::Errors::DatabaseMissingError unless db_exists?
 
         backup!
+        check_backup!
         upload! if configured?
 
         "Database '#{database}' backed up to #{location}"
@@ -30,7 +35,11 @@ module Pgchief
       private
 
       def backup!
-        `pg_dump -Fc #{database} -f #{local_location}`
+        `pg_dump -Fc #{Pgchief::Config.pgurl}/#{database} -f #{local_location}`
+      end
+
+      def check_backup!
+        raise Pgchief::Errors::BackupError, "Backup file has 0 bytes" unless File.size?(local_location)
       end
 
       def db_exists?

data/lib/pgchief/command/database_privileges_grant.rb

@@ -27,6 +27,9 @@ module Pgchief
       def grant_privs! # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
         conn = PG.connect("#{Pgchief::Config.pgurl}/#{database}")
         conn.exec("GRANT CONNECT ON DATABASE #{database} TO #{username};")
+        conn.exec("GRANT CREATE ON DATABASE #{database} TO #{username};")
+        conn.exec("GRANT USAGE ON SCHEMA pg_catalog TO #{username};")
+        conn.exec("GRANT CREATE ON SCHEMA pg_catalog TO #{username};")
         conn.exec("GRANT CREATE ON SCHEMA public TO #{username};")
         conn.exec("GRANT SELECT, INSERT, UPDATE, DELETE ON ALL TABLES IN SCHEMA public TO #{username};")
         conn.exec("GRANT USAGE ON SCHEMA public TO #{username};")

data/lib/pgchief/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pgchief
-  VERSION = "0.5.2"
+  VERSION = "0.5.3"
 end

data/lib/pgchief.rb

@@ -50,5 +50,6 @@ module Pgchief
     class UserExistsError < Error; end
     class DatabaseExistsError < Error; end
     class DatabaseMissingError < Error; end
+    class BackupError < Error; end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pgchief
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Joel Oliveira
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-12-17 00:00:00.000000000 Z
+date: 2024-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3